[INFO] fetching crate clean-rs 0.1.18... [INFO] checking clean-rs-0.1.18 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate clean-rs 0.1.18 into /workspace/builds/worker-2-tc2/source [INFO] validating manifest of crates.io crate clean-rs 0.1.18 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] removed /workspace/builds/worker-2-tc2/source/.cargo/config.toml [INFO] started tweaking crates.io crate clean-rs 0.1.18 [INFO] finished tweaking crates.io crate clean-rs 0.1.18 [INFO] tweaked toml for crates.io crate clean-rs 0.1.18 written to /workspace/builds/worker-2-tc2/source/Cargo.toml [INFO] crate crates.io crate clean-rs 0.1.18 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] a9c77db7a76b2895d28b32c647a84f857fe92743b2138450585ff3d06e6b2ce4 [INFO] running `Command { std: "docker" "start" "-a" "a9c77db7a76b2895d28b32c647a84f857fe92743b2138450585ff3d06e6b2ce4", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "a9c77db7a76b2895d28b32c647a84f857fe92743b2138450585ff3d06e6b2ce4", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "a9c77db7a76b2895d28b32c647a84f857fe92743b2138450585ff3d06e6b2ce4", kill_on_drop: false }` [INFO] [stdout] a9c77db7a76b2895d28b32c647a84f857fe92743b2138450585ff3d06e6b2ce4 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 7ac95c475ec16366079625a9932a9f4c31b42e9848a8c9eaef5220f22e9c167d [INFO] running `Command { std: "docker" "start" "-a" "7ac95c475ec16366079625a9932a9f4c31b42e9848a8c9eaef5220f22e9c167d", kill_on_drop: false }` [INFO] [stderr] Compiling libc v0.2.148 [INFO] [stderr] Compiling crossbeam-utils v0.7.2 [INFO] [stderr] Compiling slab v0.4.9 [INFO] [stderr] Compiling maybe-uninit v2.0.0 [INFO] [stderr] Checking futures v0.1.31 [INFO] [stderr] Compiling semver-parser v0.7.0 [INFO] [stderr] Checking log v0.4.20 [INFO] [stderr] Compiling proc-macro2 v1.0.67 [INFO] [stderr] Compiling memoffset v0.5.6 [INFO] [stderr] Compiling semver v0.9.0 [INFO] [stderr] Checking smallvec v0.6.14 [INFO] [stderr] Checking lock_api v0.3.4 [INFO] [stderr] Compiling memoffset v0.9.0 [INFO] [stderr] Compiling rustc_version v0.2.3 [INFO] [stderr] Compiling crossbeam-epoch v0.8.2 [INFO] [stderr] Compiling crossbeam-utils v0.8.16 [INFO] [stderr] Compiling quote v1.0.33 [INFO] [stderr] Compiling parking_lot_core v0.6.3 [INFO] [stderr] Compiling syn v2.0.36 [INFO] [stderr] Compiling parking_lot v0.9.0 [INFO] [stderr] Compiling crossbeam-epoch v0.9.15 [INFO] [stderr] Checking memchr v2.6.3 [INFO] [stderr] Compiling futures-task v0.3.28 [INFO] [stderr] Compiling futures-channel v0.3.28 [INFO] [stderr] Checking crossbeam-deque v0.7.4 [INFO] [stderr] Checking crossbeam-queue v0.2.3 [INFO] [stderr] Compiling rayon-core v1.12.0 [INFO] [stderr] Checking tokio-executor v0.1.10 [INFO] [stderr] Checking tokio-sync v0.1.8 [INFO] [stderr] Checking futures-sink v0.3.28 [INFO] [stderr] Compiling futures-util v0.3.28 [INFO] [stderr] Checking crossbeam-deque v0.8.3 [INFO] [stderr] Checking gimli v0.28.0 [INFO] [stderr] Checking futures-io v0.3.28 [INFO] [stderr] Checking iovec v0.1.4 [INFO] [stderr] Checking num_cpus v1.16.0 [INFO] [stderr] Checking bytes v0.4.12 [INFO] [stderr] Checking net2 v0.2.39 [INFO] [stderr] Compiling cc v1.0.83 [INFO] [stderr] Checking nix v0.26.4 [INFO] [stderr] Checking tokio-threadpool v0.1.18 [INFO] [stderr] Checking mio v0.6.23 [INFO] [stderr] Checking tokio-io v0.1.13 [INFO] [stderr] Checking miniz_oxide v0.7.1 [INFO] [stderr] Checking mio v0.8.8 [INFO] [stderr] Checking signal-hook-registry v1.4.1 [INFO] [stderr] Checking tokio-codec v0.1.2 [INFO] [stderr] Checking tokio-fs v0.1.7 [INFO] [stderr] Checking tokio-current-thread v0.1.7 [INFO] [stderr] Checking tokio-timer v0.2.13 [INFO] [stderr] Checking object v0.32.1 [INFO] [stderr] Checking tokio-reactor v0.1.12 [INFO] [stderr] Checking mio-uds v0.6.8 [INFO] [stderr] Checking cvt v0.1.2 [INFO] [stderr] Checking once_cell v1.18.0 [INFO] [stderr] Checking bytes v1.5.0 [INFO] [stderr] Checking either v1.9.0 [INFO] [stderr] Checking tokio-udp v0.1.6 [INFO] [stderr] Checking tokio-tcp v0.1.4 [INFO] [stderr] Checking tokio-uds v0.2.7 [INFO] [stderr] Compiling anyhow v1.0.75 [INFO] [stderr] Checking rustc-demangle v0.1.23 [INFO] [stderr] Compiling backtrace v0.3.69 [INFO] [stderr] Checking tokio v0.1.22 [INFO] [stderr] Checking rayon v1.8.0 [INFO] [stderr] Checking path-dedot v3.1.1 [INFO] [stderr] Checking fs_at v0.1.10 [INFO] [stderr] Checking log v0.3.9 [INFO] [stderr] Checking normpath v1.1.1 [INFO] [stderr] Checking unwrap v1.2.1 [INFO] [stderr] Checking void v1.0.2 [INFO] [stderr] Checking path-absolutize v3.1.1 [INFO] [stderr] Checking home v0.5.5 [INFO] [stderr] Checking termcolor v1.3.0 [INFO] [stderr] Checking future-utils v0.12.1 [INFO] [stderr] Checking addr2line v0.21.0 [INFO] [stderr] Compiling futures-macro v0.3.28 [INFO] [stderr] Compiling tokio-macros v2.1.0 [INFO] [stderr] Compiling async-recursion v1.0.5 [INFO] [stderr] Checking tokio v1.32.0 [INFO] [stderr] Checking remove_dir_all v0.8.2 [INFO] [stderr] Checking futures-executor v0.3.28 [INFO] [stderr] Checking futures v0.3.28 [INFO] [stderr] Checking tokio-stream v0.1.14 [INFO] [stderr] Checking clean-rs v0.1.18 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:55:22 [INFO] [stdout] | [INFO] [stdout] 54 | fn spawn(n: usize, rx: ExecutionRecv) -> TryJoinAll>> { [INFO] [stdout] | ----------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 55 | try_join_all((0..n).map(move |_| { [INFO] [stdout] | ______________________^ [INFO] [stdout] 56 | | let rx = rx.clone(); [INFO] [stdout] 57 | | tokio::spawn(async move { [INFO] [stdout] 58 | | let mut clean = false; [INFO] [stdout] ... | [INFO] [stdout] 63 | | }) [INFO] [stdout] 64 | | })) [INFO] [stdout] | |__________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:57:26 [INFO] [stdout] | [INFO] [stdout] 54 | fn spawn(n: usize, rx: ExecutionRecv) -> TryJoinAll>> { [INFO] [stdout] | -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 55 | try_join_all((0..n).map(move |_| { [INFO] [stdout] 56 | let rx = rx.clone(); [INFO] [stdout] | -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 57 | tokio::spawn(async move { [INFO] [stdout] | __________________________^ [INFO] [stdout] 58 | | let mut clean = false; [INFO] [stdout] 59 | | while let Some(execution) = rx.lock().await.recv().await { [INFO] [stdout] 60 | | clean = execution.run().await? || clean; [INFO] [stdout] 61 | | } [INFO] [stdout] 62 | | Result::Ok(clean) [INFO] [stdout] 63 | | }) [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/cmd.rs:22:19 [INFO] [stdout] | [INFO] [stdout] 14 | pub fn new(command: T, args: A) -> Self [INFO] [stdout] | ---------- ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 22 | args: args.into_iter().map(Cow::from).collect(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/error.rs:31:19 [INFO] [stdout] | [INFO] [stdout] 30 | fn from(err: T) -> Self { [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 31 | Error::IO(From::from(err)) [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:55:22 [INFO] [stdout] | [INFO] [stdout] 54 | fn spawn(n: usize, rx: ExecutionRecv) -> TryJoinAll>> { [INFO] [stdout] | ----------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 55 | try_join_all((0..n).map(move |_| { [INFO] [stdout] | ______________________^ [INFO] [stdout] 56 | | let rx = rx.clone(); [INFO] [stdout] 57 | | tokio::spawn(async move { [INFO] [stdout] 58 | | let mut clean = false; [INFO] [stdout] ... | [INFO] [stdout] 63 | | }) [INFO] [stdout] 64 | | })) [INFO] [stdout] | |__________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:57:26 [INFO] [stdout] | [INFO] [stdout] 54 | fn spawn(n: usize, rx: ExecutionRecv) -> TryJoinAll>> { [INFO] [stdout] | -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 55 | try_join_all((0..n).map(move |_| { [INFO] [stdout] 56 | let rx = rx.clone(); [INFO] [stdout] | -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 57 | tokio::spawn(async move { [INFO] [stdout] | __________________________^ [INFO] [stdout] 58 | | let mut clean = false; [INFO] [stdout] 59 | | while let Some(execution) = rx.lock().await.recv().await { [INFO] [stdout] 60 | | clean = execution.run().await? || clean; [INFO] [stdout] 61 | | } [INFO] [stdout] 62 | | Result::Ok(clean) [INFO] [stdout] 63 | | }) [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/cmd.rs:22:19 [INFO] [stdout] | [INFO] [stdout] 14 | pub fn new(command: T, args: A) -> Self [INFO] [stdout] | ---------- ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 22 | args: args.into_iter().map(Cow::from).collect(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/error.rs:31:19 [INFO] [stdout] | [INFO] [stdout] 30 | fn from(err: T) -> Self { [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 31 | Error::IO(From::from(err)) [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 4 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 4 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `clean-rs` (lib) due to 5 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] error: could not compile `clean-rs` (lib test) due to 5 previous errors [INFO] running `Command { std: "docker" "inspect" "7ac95c475ec16366079625a9932a9f4c31b42e9848a8c9eaef5220f22e9c167d", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "7ac95c475ec16366079625a9932a9f4c31b42e9848a8c9eaef5220f22e9c167d", kill_on_drop: false }` [INFO] [stdout] 7ac95c475ec16366079625a9932a9f4c31b42e9848a8c9eaef5220f22e9c167d