[INFO] fetching crate clacks_tl_codegen 0.0.5... [INFO] checking clacks_tl_codegen-0.0.5 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate clacks_tl_codegen 0.0.5 into /workspace/builds/worker-0-tc2/source [INFO] validating manifest of crates.io crate clacks_tl_codegen 0.0.5 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate clacks_tl_codegen 0.0.5 [INFO] finished tweaking crates.io crate clacks_tl_codegen 0.0.5 [INFO] tweaked toml for crates.io crate clacks_tl_codegen 0.0.5 written to /workspace/builds/worker-0-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 70 packages to latest compatible versions [INFO] [stderr] Adding aho-corasick v0.6.10 (latest: v1.1.3) [INFO] [stderr] Adding autocfg v0.1.8 (latest: v1.3.0) [INFO] [stderr] Adding bitflags v0.9.1 (latest: v2.6.0) [INFO] [stderr] Adding bitflags v1.3.2 (latest: v2.6.0) [INFO] [stderr] Adding cloudabi v0.0.3 (latest: v0.1.0) [INFO] [stderr] Adding derivative v1.0.4 (latest: v2.2.0) [INFO] [stderr] Adding env_logger v0.4.3 (latest: v0.11.5) [INFO] [stderr] Adding log v0.3.9 (latest: v0.4.22) [INFO] [stderr] Adding pom v1.1.0 (latest: v3.4.0) [INFO] [stderr] Adding proc-macro2 v0.3.8 (latest: v1.0.86) [INFO] [stderr] Adding proc-macro2 v0.4.30 (latest: v1.0.86) [INFO] [stderr] Adding quote v0.5.2 (latest: v1.0.37) [INFO] [stderr] Adding quote v0.6.13 (latest: v1.0.37) [INFO] [stderr] Adding rand v0.6.5 (latest: v0.8.5) [INFO] [stderr] Adding rand_chacha v0.1.1 (latest: v0.3.1) [INFO] [stderr] Adding rand_core v0.3.1 (latest: v0.6.4) [INFO] [stderr] Adding rand_core v0.4.2 (latest: v0.6.4) [INFO] [stderr] Adding rand_hc v0.1.0 (latest: v0.3.2) [INFO] [stderr] Adding rand_isaac v0.1.1 (latest: v0.3.0) [INFO] [stderr] Adding rand_jitter v0.1.4 (latest: v0.4.0) [INFO] [stderr] Adding rand_os v0.1.3 (latest: v0.2.2) [INFO] [stderr] Adding rand_pcg v0.1.2 (latest: v0.3.1) [INFO] [stderr] Adding rand_xorshift v0.1.1 (latest: v0.3.0) [INFO] [stderr] Adding rdrand v0.4.0 (latest: v0.8.3) [INFO] [stderr] Adding regex v0.2.11 (latest: v1.10.6) [INFO] [stderr] Adding regex-syntax v0.5.6 (latest: v0.8.4) [INFO] [stderr] Adding rustc_version v0.2.3 (latest: v0.4.1) [INFO] [stderr] Adding semver v0.9.0 (latest: v1.0.23) [INFO] [stderr] Adding semver-parser v0.7.0 (latest: v0.10.2) [INFO] [stderr] Adding syn v0.13.11 (latest: v2.0.77) [INFO] [stderr] Adding syn v0.15.44 (latest: v2.0.77) [INFO] [stderr] Adding term v0.4.6 (latest: v1.0.0) [INFO] [stderr] Adding thread_local v0.3.6 (latest: v1.1.8) [INFO] [stderr] Adding toml v0.4.10 (latest: v0.8.19) [INFO] [stderr] Adding ucd-util v0.1.10 (latest: v0.2.1) [INFO] [stderr] Adding unicode-xid v0.1.0 (latest: v0.2.5) [INFO] [stderr] Adding winapi v0.2.8 (latest: v0.3.9) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] warning: no edition set: defaulting to the 2015 edition while the latest is 2021 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 7d8c6dfb2cfa2f88e8727756aff700379f507b3fbc7c85f59b4036792f10f5b3 [INFO] running `Command { std: "docker" "start" "-a" "7d8c6dfb2cfa2f88e8727756aff700379f507b3fbc7c85f59b4036792f10f5b3", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "7d8c6dfb2cfa2f88e8727756aff700379f507b3fbc7c85f59b4036792f10f5b3", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "7d8c6dfb2cfa2f88e8727756aff700379f507b3fbc7c85f59b4036792f10f5b3", kill_on_drop: false }` [INFO] [stdout] 7d8c6dfb2cfa2f88e8727756aff700379f507b3fbc7c85f59b4036792f10f5b3 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 4c7894218bc0cf86a4c6bfa1c98b6aab4b3b485f951cd581259e27de22e301d3 [INFO] running `Command { std: "docker" "start" "-a" "4c7894218bc0cf86a4c6bfa1c98b6aab4b3b485f951cd581259e27de22e301d3", kill_on_drop: false }` [INFO] [stderr] warning: no edition set: defaulting to the 2015 edition while the latest is 2021 [INFO] [stderr] Checking unicode-xid v0.1.0 [INFO] [stderr] Compiling syn v0.15.44 [INFO] [stderr] Checking pom v1.1.0 [INFO] [stderr] Checking proc-macro2 v0.3.8 [INFO] [stderr] Checking quote v0.5.2 [INFO] [stderr] Checking syn v0.13.11 [INFO] [stderr] Compiling derivative v1.0.4 [INFO] [stderr] Checking clacks_tl_codegen v0.0.5 (/opt/rustwide/workdir) [INFO] [stdout] warning: unnecessary parentheses around block return value [INFO] [stdout] --> src/lib.rs:153:9 [INFO] [stdout] | [INFO] [stdout] 153 | ( sym(b'#').map(|_| Type::Int) | [INFO] [stdout] | ^^ [INFO] [stdout] ... [INFO] [stdout] 157 | dotted_ident().map(Type::Named) [INFO] [stdout] | __________________________________________^ [INFO] [stdout] 158 | | ) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_parens)]` on by default [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 153 ~ sym(b'#').map(|_| Type::Int) | [INFO] [stdout] 154 | sym(b'!') * ident().map(Type::TypeParameter) | [INFO] [stdout] 155 | ty_flag() | [INFO] [stdout] 156 | ty_generic() | [INFO] [stdout] 157 ~ dotted_ident().map(Type::Named) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around block return value [INFO] [stdout] --> src/lib.rs:163:9 [INFO] [stdout] | [INFO] [stdout] 163 | (space_generic.map(|(name, ty)| Type::Generic(name, Box::new(ty))) | [INFO] [stdout] | ^ [INFO] [stdout] 164 | ty()) [INFO] [stdout] | ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 163 ~ space_generic.map(|(name, ty)| Type::Generic(name, Box::new(ty))) | [INFO] [stdout] 164 ~ ty() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around block return value [INFO] [stdout] --> src/lib.rs:180:9 [INFO] [stdout] | [INFO] [stdout] 180 | ( repeated_field() | [INFO] [stdout] | ^^ [INFO] [stdout] 181 | base_field() | [INFO] [stdout] 182 | ty().map(|ty| Field { name: None, ty: ty })) [INFO] [stdout] | ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 180 ~ repeated_field() | [INFO] [stdout] 181 | base_field() | [INFO] [stdout] 182 ~ ty().map(|ty| Field { name: None, ty: ty }) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around block return value [INFO] [stdout] --> src/lib.rs:220:9 [INFO] [stdout] | [INFO] [stdout] 220 | ( seq(b"---types---").map(|_| Delimiter::Types) | [INFO] [stdout] | ^^ [INFO] [stdout] 221 | seq(b"---functions---").map(|_| Delimiter::Functions) [INFO] [stdout] | ________________________________________________________________^ [INFO] [stdout] 222 | | ) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 220 ~ seq(b"---types---").map(|_| Delimiter::Types) | [INFO] [stdout] 221 ~ seq(b"---functions---").map(|_| Delimiter::Functions) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around block return value [INFO] [stdout] --> src/lib.rs:153:9 [INFO] [stdout] | [INFO] [stdout] 153 | ( sym(b'#').map(|_| Type::Int) | [INFO] [stdout] | ^^ [INFO] [stdout] ... [INFO] [stdout] 157 | dotted_ident().map(Type::Named) [INFO] [stdout] | __________________________________________^ [INFO] [stdout] 158 | | ) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_parens)]` on by default [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 153 ~ sym(b'#').map(|_| Type::Int) | [INFO] [stdout] 154 | sym(b'!') * ident().map(Type::TypeParameter) | [INFO] [stdout] 155 | ty_flag() | [INFO] [stdout] 156 | ty_generic() | [INFO] [stdout] 157 ~ dotted_ident().map(Type::Named) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around block return value [INFO] [stdout] --> src/lib.rs:163:9 [INFO] [stdout] | [INFO] [stdout] 163 | (space_generic.map(|(name, ty)| Type::Generic(name, Box::new(ty))) | [INFO] [stdout] | ^ [INFO] [stdout] 164 | ty()) [INFO] [stdout] | ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 163 ~ space_generic.map(|(name, ty)| Type::Generic(name, Box::new(ty))) | [INFO] [stdout] 164 ~ ty() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around block return value [INFO] [stdout] --> src/lib.rs:180:9 [INFO] [stdout] | [INFO] [stdout] 180 | ( repeated_field() | [INFO] [stdout] | ^^ [INFO] [stdout] 181 | base_field() | [INFO] [stdout] 182 | ty().map(|ty| Field { name: None, ty: ty })) [INFO] [stdout] | ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 180 ~ repeated_field() | [INFO] [stdout] 181 | base_field() | [INFO] [stdout] 182 ~ ty().map(|ty| Field { name: None, ty: ty }) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around block return value [INFO] [stdout] --> src/lib.rs:220:9 [INFO] [stdout] | [INFO] [stdout] 220 | ( seq(b"---types---").map(|_| Delimiter::Types) | [INFO] [stdout] | ^^ [INFO] [stdout] 221 | seq(b"---functions---").map(|_| Delimiter::Functions) [INFO] [stdout] | ________________________________________________________________^ [INFO] [stdout] 222 | | ) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 220 ~ seq(b"---types---").map(|_| Delimiter::Types) | [INFO] [stdout] 221 ~ seq(b"---functions---").map(|_| Delimiter::Functions) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> src/lib.rs:1548:59 [INFO] [stdout] | [INFO] [stdout] 1548 | fn constructors_and_tl_ids<'this>(&'this self) -> Box<'this + Iterator)>> { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2015) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] = note: `#[warn(bare_trait_objects)]` on by default [INFO] [stdout] help: if this is an object-safe trait, use `dyn` [INFO] [stdout] | [INFO] [stdout] 1548 | fn constructors_and_tl_ids<'this>(&'this self) -> Box)>> { [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> src/lib.rs:1548:59 [INFO] [stdout] | [INFO] [stdout] 1548 | fn constructors_and_tl_ids<'this>(&'this self) -> Box<'this + Iterator)>> { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2015) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] = note: `#[warn(bare_trait_objects)]` on by default [INFO] [stdout] help: if this is an object-safe trait, use `dyn` [INFO] [stdout] | [INFO] [stdout] 1548 | fn constructors_and_tl_ids<'this>(&'this self) -> Box)>> { [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/lib.rs:440:35 [INFO] [stdout] | [INFO] [stdout] 440 | Item::Constructor(mut c) => { [INFO] [stdout] | ----^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_mut)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/lib.rs:465:17 [INFO] [stdout] | [INFO] [stdout] 465 | let mut cs = cs.resolve(&resolve_map); [INFO] [stdout] | ----^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/lib.rs:440:35 [INFO] [stdout] | [INFO] [stdout] 440 | Item::Constructor(mut c) => { [INFO] [stdout] | ----^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_mut)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/lib.rs:465:17 [INFO] [stdout] | [INFO] [stdout] 465 | let mut cs = cs.resolve(&resolve_map); [INFO] [stdout] | ----^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:1395:22 [INFO] [stdout] | [INFO] [stdout] 1395 | .map(|n| NameChunks::from_name(n).unwrap()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:144:63 [INFO] [stdout] | [INFO] [stdout] 144 | .map(|((name, bit), ty)| Type::Flagged(name, bit, Box::new(ty))) [INFO] [stdout] | ----------------- ^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:149:51 [INFO] [stdout] | [INFO] [stdout] 149 | .map(|(name, ty)| Type::Generic(name, Box::new(ty))) [INFO] [stdout] | ---------- ^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:163:10 [INFO] [stdout] | [INFO] [stdout] 162 | let space_generic = dotted_ident() - sym(b' ') + ty(); [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 163 | (space_generic.map(|(name, ty)| Type::Generic(name, Box::new(ty))) | [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:164:10 [INFO] [stdout] | [INFO] [stdout] 162 | let space_generic = dotted_ident() - sym(b' ') + ty(); [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 163 | (space_generic.map(|(name, ty)| Type::Generic(name, Box::new(ty))) | [INFO] [stdout] 164 | ty()) [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:163:61 [INFO] [stdout] | [INFO] [stdout] 163 | (space_generic.map(|(name, ty)| Type::Generic(name, Box::new(ty))) | [INFO] [stdout] | ---------- ^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:175:66 [INFO] [stdout] | [INFO] [stdout] 175 | * call(base_fields).map(|fv| Field { name: None, ty: Type::Repeated(fv) }) [INFO] [stdout] | -- ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:199:21 [INFO] [stdout] | [INFO] [stdout] 198 | fn output_and_matched(inner: Parser) -> Parser> { [INFO] [stdout] | -------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 199 | Parser::new(move |input| { [INFO] [stdout] | _____________________^ [INFO] [stdout] 200 | | let start = input.position(); [INFO] [stdout] 201 | | let output = inner.parse(input)?; [INFO] [stdout] 202 | | let end = input.position(); [INFO] [stdout] 203 | | Ok(Matched(output, utf8(input.segment(start, end)))) [INFO] [stdout] 204 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:203:16 [INFO] [stdout] | [INFO] [stdout] 198 | fn output_and_matched(inner: Parser) -> Parser> { [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 201 | let output = inner.parse(input)?; [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 202 | let end = input.position(); [INFO] [stdout] 203 | Ok(Matched(output, utf8(input.segment(start, end)))) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:212:26 [INFO] [stdout] | [INFO] [stdout] 209 | .map(|(((variant, tl_id), (type_parameters, fields)), output)| Constructor { [INFO] [stdout] | ------------------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 212 | variant: Type::Named(variant.0), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused borrow that must be used [INFO] [stdout] --> src/lib.rs:297:21 [INFO] [stdout] | [INFO] [stdout] 297 | &mut s[..1].make_ascii_uppercase(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ the borrow produces a value [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_must_use)]` on by default [INFO] [stdout] help: use `let _ = ...` to ignore the resulting value [INFO] [stdout] | [INFO] [stdout] 297 | let _ = &mut s[..1].make_ascii_uppercase(); [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 10 previous errors; 8 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `clacks_tl_codegen` (lib test) due to 11 previous errors; 8 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:1395:22 [INFO] [stdout] | [INFO] [stdout] 1395 | .map(|n| NameChunks::from_name(n).unwrap()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:144:63 [INFO] [stdout] | [INFO] [stdout] 144 | .map(|((name, bit), ty)| Type::Flagged(name, bit, Box::new(ty))) [INFO] [stdout] | ----------------- ^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:149:51 [INFO] [stdout] | [INFO] [stdout] 149 | .map(|(name, ty)| Type::Generic(name, Box::new(ty))) [INFO] [stdout] | ---------- ^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:163:10 [INFO] [stdout] | [INFO] [stdout] 162 | let space_generic = dotted_ident() - sym(b' ') + ty(); [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 163 | (space_generic.map(|(name, ty)| Type::Generic(name, Box::new(ty))) | [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:164:10 [INFO] [stdout] | [INFO] [stdout] 162 | let space_generic = dotted_ident() - sym(b' ') + ty(); [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 163 | (space_generic.map(|(name, ty)| Type::Generic(name, Box::new(ty))) | [INFO] [stdout] 164 | ty()) [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:163:61 [INFO] [stdout] | [INFO] [stdout] 163 | (space_generic.map(|(name, ty)| Type::Generic(name, Box::new(ty))) | [INFO] [stdout] | ---------- ^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:175:66 [INFO] [stdout] | [INFO] [stdout] 175 | * call(base_fields).map(|fv| Field { name: None, ty: Type::Repeated(fv) }) [INFO] [stdout] | -- ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:199:21 [INFO] [stdout] | [INFO] [stdout] 198 | fn output_and_matched(inner: Parser) -> Parser> { [INFO] [stdout] | -------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 199 | Parser::new(move |input| { [INFO] [stdout] | _____________________^ [INFO] [stdout] 200 | | let start = input.position(); [INFO] [stdout] 201 | | let output = inner.parse(input)?; [INFO] [stdout] 202 | | let end = input.position(); [INFO] [stdout] 203 | | Ok(Matched(output, utf8(input.segment(start, end)))) [INFO] [stdout] 204 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:203:16 [INFO] [stdout] | [INFO] [stdout] 198 | fn output_and_matched(inner: Parser) -> Parser> { [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 201 | let output = inner.parse(input)?; [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 202 | let end = input.position(); [INFO] [stdout] 203 | Ok(Matched(output, utf8(input.segment(start, end)))) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:212:26 [INFO] [stdout] | [INFO] [stdout] 209 | .map(|(((variant, tl_id), (type_parameters, fields)), output)| Constructor { [INFO] [stdout] | ------------------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 212 | variant: Type::Named(variant.0), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused borrow that must be used [INFO] [stdout] --> src/lib.rs:297:21 [INFO] [stdout] | [INFO] [stdout] 297 | &mut s[..1].make_ascii_uppercase(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ the borrow produces a value [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_must_use)]` on by default [INFO] [stdout] help: use `let _ = ...` to ignore the resulting value [INFO] [stdout] | [INFO] [stdout] 297 | let _ = &mut s[..1].make_ascii_uppercase(); [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 10 previous errors; 8 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `clacks_tl_codegen` (lib) due to 11 previous errors; 8 warnings emitted [INFO] running `Command { std: "docker" "inspect" "4c7894218bc0cf86a4c6bfa1c98b6aab4b3b485f951cd581259e27de22e301d3", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "4c7894218bc0cf86a4c6bfa1c98b6aab4b3b485f951cd581259e27de22e301d3", kill_on_drop: false }` [INFO] [stdout] 4c7894218bc0cf86a4c6bfa1c98b6aab4b3b485f951cd581259e27de22e301d3