[INFO] fetching crate ckydb 0.0.5... [INFO] checking ckydb-0.0.5 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate ckydb 0.0.5 into /workspace/builds/worker-7-tc2/source [INFO] validating manifest of crates.io crate ckydb 0.0.5 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate ckydb 0.0.5 [INFO] finished tweaking crates.io crate ckydb 0.0.5 [INFO] tweaked toml for crates.io crate ckydb 0.0.5 written to /workspace/builds/worker-7-tc2/source/Cargo.toml [INFO] crate crates.io crate ckydb 0.0.5 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] fd782ac22c317a914f2895b0c7b342ee91b8696389861deddfc7fddd8628b6a5 [INFO] running `Command { std: "docker" "start" "-a" "fd782ac22c317a914f2895b0c7b342ee91b8696389861deddfc7fddd8628b6a5", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "fd782ac22c317a914f2895b0c7b342ee91b8696389861deddfc7fddd8628b6a5", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "fd782ac22c317a914f2895b0c7b342ee91b8696389861deddfc7fddd8628b6a5", kill_on_drop: false }` [INFO] [stdout] fd782ac22c317a914f2895b0c7b342ee91b8696389861deddfc7fddd8628b6a5 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] df6138213b9c5dfd0653b362cccdcfb5eef066186c3065cad685c7c1d8dc8320 [INFO] running `Command { std: "docker" "start" "-a" "df6138213b9c5dfd0653b362cccdcfb5eef066186c3065cad685c7c1d8dc8320", kill_on_drop: false }` [INFO] [stderr] Compiling proc-macro2 v1.0.40 [INFO] [stderr] Compiling futures-core v0.3.21 [INFO] [stderr] Compiling unicode-ident v1.0.1 [INFO] [stderr] Compiling quote v1.0.20 [INFO] [stderr] Compiling futures-task v0.3.21 [INFO] [stderr] Compiling futures-channel v0.3.21 [INFO] [stderr] Checking futures-sink v0.3.21 [INFO] [stderr] Compiling syn v1.0.98 [INFO] [stderr] Compiling futures-util v0.3.21 [INFO] [stderr] Compiling rustversion v1.0.7 [INFO] [stderr] Checking futures-io v0.3.21 [INFO] [stderr] Compiling log v0.4.17 [INFO] [stderr] Checking smallvec v1.9.0 [INFO] [stderr] Checking ckydb v0.0.5 (/opt/rustwide/workdir) [INFO] [stdout] warning: constant `DUMMY_FILE_DATA` is never used [INFO] [stdout] --> src/utils.rs:11:7 [INFO] [stdout] | [INFO] [stdout] 11 | const DUMMY_FILE_DATA: [(&str, &str); 5] = [ [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `clear_dummy_file_data_in_db` is never used [INFO] [stdout] --> src/utils.rs:24:15 [INFO] [stdout] | [INFO] [stdout] 24 | pub(crate) fn clear_dummy_file_data_in_db>(db_path: P) -> io::Result<()> { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `add_dummy_file_data_in_db` is never used [INFO] [stdout] --> src/utils.rs:36:15 [INFO] [stdout] | [INFO] [stdout] 36 | pub(crate) fn add_dummy_file_data_in_db(db_path: &str) -> io::Result<()> { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `read_files_with_extension` is never used [INFO] [stdout] --> src/utils.rs:55:15 [INFO] [stdout] | [INFO] [stdout] 55 | pub(crate) fn read_files_with_extension>( [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/controller.rs:100:9 [INFO] [stdout] | [INFO] [stdout] 98 | let (tx, rv) = mpsc::channel(); [INFO] [stdout] | -- -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 99 | [INFO] [stdout] 100 | store.load().and(Ok(Ckydb { [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/controller.rs:100:26 [INFO] [stdout] | [INFO] [stdout] 98 | let (tx, rv) = mpsc::channel(); [INFO] [stdout] | -- -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 99 | [INFO] [stdout] 100 | store.load().and(Ok(Ckydb { [INFO] [stdout] | __________________________^ [INFO] [stdout] 101 | | tasks: Some(vec![]), [INFO] [stdout] 102 | | store: Arc::new(Mutex::new(store)), [INFO] [stdout] 103 | | vacuum_interval_sec, [INFO] [stdout] ... | [INFO] [stdout] 106 | | rv: Arc::new(Mutex::new(rv)), [INFO] [stdout] 107 | | })) [INFO] [stdout] | |__________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/controller.rs:167:40 [INFO] [stdout] | [INFO] [stdout] 167 | .or_else(|err| Err(io::Error::new(ErrorKind::Other, err)))?; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/controller.rs:203:38 [INFO] [stdout] | [INFO] [stdout] 203 | .and_then(|mut store| Ok(store.clear())) [INFO] [stdout] | --------- ^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/controller.rs:230:5 [INFO] [stdout] | [INFO] [stdout] 229 | let mut db = Ckydb::new(db_path, max_file_size_kb, vacuum_interval_sec)?; [INFO] [stdout] | -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 230 | db.open().and(Ok(db)) [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/controller.rs:230:19 [INFO] [stdout] | [INFO] [stdout] 229 | let mut db = Ckydb::new(db_path, max_file_size_kb, vacuum_interval_sec)?; [INFO] [stdout] | -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 230 | db.open().and(Ok(db)) [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/utils.rs:25:5 [INFO] [stdout] | [INFO] [stdout] 24 | pub(crate) fn clear_dummy_file_data_in_db>(db_path: P) -> io::Result<()> { [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 25 | fs::remove_dir_all(db_path).or_else(|err| match err.kind() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/utils.rs:104:5 [INFO] [stdout] | [INFO] [stdout] 103 | pub(crate) fn get_file_names_in_folder>(path: P) -> io::Result> { [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 104 | / fs::read_dir(path)? [INFO] [stdout] 105 | | .map(|res| res.map(|e| e.file_name().into_string().unwrap_or("".to_string()))) [INFO] [stdout] | |______________________________________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/utils.rs:115:5 [INFO] [stdout] | [INFO] [stdout] 114 | pub(crate) fn create_file_if_not_exist>(path: P) -> io::Result<()> { [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 115 | / OpenOptions::new() [INFO] [stdout] 116 | | .write(true) [INFO] [stdout] 117 | | .create_new(true) [INFO] [stdout] 118 | | .open(path) [INFO] [stdout] 119 | | .and(Ok(())) [INFO] [stdout] | |____________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/utils.rs:148:28 [INFO] [stdout] | [INFO] [stdout] 148 | .or_else(|err| Err(io::Error::new(ErrorKind::Other, err))) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 10 previous errors; 4 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `ckydb` (lib) due to 11 previous errors; 4 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] running `Command { std: "docker" "inspect" "df6138213b9c5dfd0653b362cccdcfb5eef066186c3065cad685c7c1d8dc8320", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "df6138213b9c5dfd0653b362cccdcfb5eef066186c3065cad685c7c1d8dc8320", kill_on_drop: false }` [INFO] [stdout] df6138213b9c5dfd0653b362cccdcfb5eef066186c3065cad685c7c1d8dc8320