[INFO] fetching crate citp 0.2.1... [INFO] checking citp-0.2.1 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate citp 0.2.1 into /workspace/builds/worker-2-tc2/source [INFO] validating manifest of crates.io crate citp 0.2.1 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate citp 0.2.1 [INFO] removed 0 missing examples [INFO] finished tweaking crates.io crate citp 0.2.1 [INFO] tweaked toml for crates.io crate citp 0.2.1 written to /workspace/builds/worker-2-tc2/source/Cargo.toml [INFO] crate crates.io crate citp 0.2.1 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] f2f0b5d24da8778c862faee8a7f9fba7b0598524eab83bf80e285323a5ab0ca0 [INFO] running `Command { std: "docker" "start" "-a" "f2f0b5d24da8778c862faee8a7f9fba7b0598524eab83bf80e285323a5ab0ca0", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "f2f0b5d24da8778c862faee8a7f9fba7b0598524eab83bf80e285323a5ab0ca0", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "f2f0b5d24da8778c862faee8a7f9fba7b0598524eab83bf80e285323a5ab0ca0", kill_on_drop: false }` [INFO] [stdout] f2f0b5d24da8778c862faee8a7f9fba7b0598524eab83bf80e285323a5ab0ca0 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 5ee704c154c3332201d191b9745548620f9e449c243fe23c9f5647bb5fde8eb2 [INFO] running `Command { std: "docker" "start" "-a" "5ee704c154c3332201d191b9745548620f9e449c243fe23c9f5647bb5fde8eb2", kill_on_drop: false }` [INFO] [stderr] Compiling libc v0.2.149 [INFO] [stderr] Checking bit_field v0.10.2 [INFO] [stderr] Checking ppv-lite86 v0.2.17 [INFO] [stderr] Checking byteorder v1.2.3 [INFO] [stderr] Checking ucs2 v0.3.2 [INFO] [stderr] Checking citp v0.2.1 (/opt/rustwide/workdir) [INFO] [stdout] warning: call to `.clone()` on a reference in this situation does nothing [INFO] [stdout] --> src/protocol/mod.rs:465:59 [INFO] [stdout] | [INFO] [stdout] 465 | let name = std::str::from_utf8(&utf8_buf).unwrap().clone().to_string(); [INFO] [stdout] | ^^^^^^^^ help: remove this redundant call [INFO] [stdout] | [INFO] [stdout] = note: the type `str` does not implement `Clone`, so calling `clone` on `&str` copies the reference, which does not do anything and can be removed [INFO] [stdout] = note: `#[warn(noop_method_call)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: 1 warning emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Checking getrandom v0.2.10 [INFO] [stderr] Checking socket2 v0.5.4 [INFO] [stderr] Checking rand_core v0.6.4 [INFO] [stderr] Checking rand_chacha v0.3.1 [INFO] [stderr] Checking rand v0.8.5 [INFO] [stdout] warning: value assigned to `received` is never read [INFO] [stdout] --> examples/demo/citp_tcp.rs:122:13 [INFO] [stdout] | [INFO] [stdout] 122 | received = received.drain(header.message_size as usize..).collect(); [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: maybe it is overwritten before being read? [INFO] [stdout] = note: `#[warn(unused_assignments)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `send_message` is never used [INFO] [stdout] --> examples/demo/citp_tcp.rs:38:12 [INFO] [stdout] | [INFO] [stdout] 29 | impl CitpTcp { [INFO] [stdout] | ------------ method in this implementation [INFO] [stdout] ... [INFO] [stdout] 38 | pub fn send_message(&mut self, message: &str) -> io::Result<()> { [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> examples/demo/demo.rs:195:11 [INFO] [stdout] | [INFO] [stdout] 193 | let ploc = peer_location(); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 194 | let mut ploc_buf = [0u8; 65535]; [INFO] [stdout] 195 | match ploc.write_to_bytes(&mut ploc_buf[..]) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> examples/demo/citp_tcp.rs:34:12 [INFO] [stdout] | [INFO] [stdout] 31 | pub fn new(stream: TcpStream) -> io::Result { [INFO] [stdout] | ----------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 32 | let writer = io::LineWriter::new(stream.try_clone()?); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 33 | let reader = io::BufReader::new(stream); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 34 | Ok(Self { reader, writer }) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 2 previous errors; 2 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `citp` (example "demo") due to 3 previous errors; 2 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] warning: call to `.clone()` on a reference in this situation does nothing [INFO] [stdout] --> src/protocol/mod.rs:465:59 [INFO] [stdout] | [INFO] [stdout] 465 | let name = std::str::from_utf8(&utf8_buf).unwrap().clone().to_string(); [INFO] [stdout] | ^^^^^^^^ help: remove this redundant call [INFO] [stdout] | [INFO] [stdout] = note: the type `str` does not implement `Clone`, so calling `clone` on `&str` copies the reference, which does not do anything and can be removed [INFO] [stdout] = note: `#[warn(noop_method_call)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: 1 warning emitted [INFO] [stdout] [INFO] [stdout] [INFO] running `Command { std: "docker" "inspect" "5ee704c154c3332201d191b9745548620f9e449c243fe23c9f5647bb5fde8eb2", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "5ee704c154c3332201d191b9745548620f9e449c243fe23c9f5647bb5fde8eb2", kill_on_drop: false }` [INFO] [stdout] 5ee704c154c3332201d191b9745548620f9e449c243fe23c9f5647bb5fde8eb2