[INFO] fetching crate cisat 0.2.2... [INFO] checking cisat-0.2.2 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate cisat 0.2.2 into /workspace/builds/worker-6-tc2/source [INFO] validating manifest of crates.io crate cisat 0.2.2 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate cisat 0.2.2 [INFO] finished tweaking crates.io crate cisat 0.2.2 [INFO] tweaked toml for crates.io crate cisat 0.2.2 written to /workspace/builds/worker-6-tc2/source/Cargo.toml [INFO] crate crates.io crate cisat 0.2.2 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 39b84d8c47a1bb16f9cec1d90627eb168f98c6a76ad767f13b46980df3690d9f [INFO] running `Command { std: "docker" "start" "-a" "39b84d8c47a1bb16f9cec1d90627eb168f98c6a76ad767f13b46980df3690d9f", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "39b84d8c47a1bb16f9cec1d90627eb168f98c6a76ad767f13b46980df3690d9f", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "39b84d8c47a1bb16f9cec1d90627eb168f98c6a76ad767f13b46980df3690d9f", kill_on_drop: false }` [INFO] [stdout] 39b84d8c47a1bb16f9cec1d90627eb168f98c6a76ad767f13b46980df3690d9f [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] cc4f9d121dd2767aab32e5f44d67623bc268b30cb991ce8891add622e86d9302 [INFO] running `Command { std: "docker" "start" "-a" "cc4f9d121dd2767aab32e5f44d67623bc268b30cb991ce8891add622e86d9302", kill_on_drop: false }` [INFO] [stderr] Compiling libc v0.2.84 [INFO] [stderr] Compiling crossbeam-utils v0.8.1 [INFO] [stderr] Compiling getrandom v0.2.2 [INFO] [stderr] Compiling const_fn v0.4.5 [INFO] [stderr] Compiling syn v1.0.60 [INFO] [stderr] Compiling indexmap v1.6.1 [INFO] [stderr] Compiling libm v0.2.1 [INFO] [stderr] Compiling proc-macro-error-attr v1.0.4 [INFO] [stderr] Compiling proc-macro-error v1.0.4 [INFO] [stderr] Compiling num-traits v0.2.14 [INFO] [stderr] Checking ppv-lite86 v0.2.10 [INFO] [stderr] Compiling unicode-segmentation v1.7.1 [INFO] [stderr] Checking hashbrown v0.9.1 [INFO] [stderr] Compiling quote v1.0.8 [INFO] [stderr] Checking vec_map v0.8.2 [INFO] [stderr] Checking ansi_term v0.11.0 [INFO] [stderr] Checking strsim v0.8.0 [INFO] [stderr] Checking fixedbitset v0.2.0 [INFO] [stderr] Checking number_prefix v0.3.0 [INFO] [stderr] Checking structural-shapes v0.1.5 [INFO] [stderr] Compiling heck v0.3.2 [INFO] [stderr] Checking crossbeam-epoch v0.9.1 [INFO] [stderr] Checking crossbeam-channel v0.5.0 [INFO] [stderr] Checking crossbeam-deque v0.8.0 [INFO] [stderr] Checking petgraph v0.5.1 [INFO] [stderr] Checking atty v0.2.14 [INFO] [stderr] Checking terminal_size v0.1.16 [INFO] [stderr] Checking num_cpus v1.13.0 [INFO] [stderr] Checking clap v2.33.3 [INFO] [stderr] Checking console v0.14.0 [INFO] [stderr] Checking rand_core v0.6.1 [INFO] [stderr] Checking rayon-core v1.9.0 [INFO] [stderr] Checking rand_chacha v0.3.0 [INFO] [stderr] Checking rand v0.8.3 [INFO] [stderr] Checking indicatif v0.15.0 [INFO] [stderr] Checking rayon v1.5.0 [INFO] [stderr] Checking rand_distr v0.4.0 [INFO] [stderr] Checking trussx v0.1.3 [INFO] [stderr] Compiling structopt-derive v0.4.14 [INFO] [stderr] Checking structopt v0.3.21 [INFO] [stderr] Checking cisat v0.2.2 (/opt/rustwide/workdir) [INFO] [stdout] warning: unused import: `random_gaussian_vector` [INFO] [stdout] --> src/problems/ackley.rs:4:29 [INFO] [stdout] | [INFO] [stdout] 4 | utilities::randomness::{random_gaussian_vector, random_uniform_vector}, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `random_gaussian_vector` [INFO] [stdout] --> src/problems/ackley.rs:4:29 [INFO] [stdout] | [INFO] [stdout] 4 | utilities::randomness::{random_gaussian_vector, random_uniform_vector}, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `file_name` [INFO] [stdout] --> src/utilities/parameters.rs:109:38 [INFO] [stdout] | [INFO] [stdout] 109 | pub fn load_from_file(&mut self, file_name: String) { [INFO] [stdout] | ^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_file_name` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `initial_learning_matrix` [INFO] [stdout] --> src/utilities/parameters.rs:187:17 [INFO] [stdout] | [INFO] [stdout] 187 | initial_learning_matrix, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try ignoring the field: `initial_learning_matrix: _` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `initial_learning_matrix` [INFO] [stdout] --> src/utilities/parameters.rs:194:17 [INFO] [stdout] | [INFO] [stdout] 194 | initial_learning_matrix, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try ignoring the field: `initial_learning_matrix: _` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `file_name` [INFO] [stdout] --> src/utilities/parameters.rs:109:38 [INFO] [stdout] | [INFO] [stdout] 109 | pub fn load_from_file(&mut self, file_name: String) { [INFO] [stdout] | ^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_file_name` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `delta` [INFO] [stdout] --> src/abm/agent.rs:144:17 [INFO] [stdout] | [INFO] [stdout] 144 | delta, [INFO] [stdout] | ^^^^^ help: try ignoring the field: `delta: _` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `initial_learning_matrix` [INFO] [stdout] --> src/utilities/parameters.rs:187:17 [INFO] [stdout] | [INFO] [stdout] 187 | initial_learning_matrix, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try ignoring the field: `initial_learning_matrix: _` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `initial_learning_matrix` [INFO] [stdout] --> src/utilities/parameters.rs:194:17 [INFO] [stdout] | [INFO] [stdout] 194 | initial_learning_matrix, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try ignoring the field: `initial_learning_matrix: _` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `move_index` [INFO] [stdout] --> src/problems/structure.rs:28:39 [INFO] [stdout] | [INFO] [stdout] 28 | fn apply_move_operator(&mut self, move_index: usize, temperature: f64) { [INFO] [stdout] | ^^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_move_index` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `x` [INFO] [stdout] --> src/utilities/randomness.rs:67:13 [INFO] [stdout] | [INFO] [stdout] 67 | let x = random_gaussian_vector(5, 0.0, 1.0); [INFO] [stdout] | ^ help: if this is intentional, prefix it with an underscore: `_x` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `temperature` [INFO] [stdout] --> src/problems/structure.rs:28:58 [INFO] [stdout] | [INFO] [stdout] 28 | fn apply_move_operator(&mut self, move_index: usize, temperature: f64) { [INFO] [stdout] | ^^^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_temperature` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `x` [INFO] [stdout] --> src/utilities/randomness.rs:72:13 [INFO] [stdout] | [INFO] [stdout] 72 | let x = multinomial_draw(vec![1.0, 2.3, 10.1, 3.1]); [INFO] [stdout] | ^ help: if this is intentional, prefix it with an underscore: `_x` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `delta` [INFO] [stdout] --> src/abm/agent.rs:144:17 [INFO] [stdout] | [INFO] [stdout] 144 | delta, [INFO] [stdout] | ^^^^^ help: try ignoring the field: `delta: _` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `random_gaussian_vector` is never used [INFO] [stdout] --> src/utilities/randomness.rs:7:15 [INFO] [stdout] | [INFO] [stdout] 7 | pub(crate) fn random_gaussian_vector( [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: fields `last_operation` and `current_solution_quality` are never read [INFO] [stdout] --> src/abm/agent.rs:19:5 [INFO] [stdout] | [INFO] [stdout] 13 | pub struct Agent { [INFO] [stdout] | ----- fields in this struct [INFO] [stdout] ... [INFO] [stdout] 19 | last_operation: u64, [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 23 | current_solution_quality: f64, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `Agent` has derived impls for the traits `Debug` and `Clone`, but these are intentionally ignored during dead code analysis [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: fields `truss` and `objective_function_value` are never read [INFO] [stdout] --> src/problems/structure.rs:10:5 [INFO] [stdout] | [INFO] [stdout] 8 | pub struct Structure { [INFO] [stdout] | --------- fields in this struct [INFO] [stdout] 9 | /// Thie contains the fundamental truss information [INFO] [stdout] 10 | truss: Truss, [INFO] [stdout] | ^^^^^ [INFO] [stdout] ... [INFO] [stdout] 14 | objective_function_value: Vec, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `Structure` has derived impls for the traits `Debug` and `Clone`, but these are intentionally ignored during dead code analysis [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/abm/agent.rs:58:35 [INFO] [stdout] | [INFO] [stdout] 50 | let solution = S::new(); [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 58 | best_solution_so_far: solution.clone(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/abm/agent.rs:59:31 [INFO] [stdout] | [INFO] [stdout] 50 | let solution = S::new(); [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 59 | current_solution: solution.clone(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/abm/team.rs:98:41 [INFO] [stdout] | [INFO] [stdout] 98 | .for_each(|x| x.communicate(solutions.clone())); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 3 previous errors; 10 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `move_index` [INFO] [stdout] --> src/problems/structure.rs:28:39 [INFO] [stdout] | [INFO] [stdout] 28 | fn apply_move_operator(&mut self, move_index: usize, temperature: f64) { [INFO] [stdout] | ^^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_move_index` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `temperature` [INFO] [stdout] --> src/problems/structure.rs:28:58 [INFO] [stdout] | [INFO] [stdout] 28 | fn apply_move_operator(&mut self, move_index: usize, temperature: f64) { [INFO] [stdout] | ^^^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_temperature` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: fields `last_operation` and `current_solution_quality` are never read [INFO] [stdout] --> src/abm/agent.rs:19:5 [INFO] [stdout] | [INFO] [stdout] 13 | pub struct Agent { [INFO] [stdout] | ----- fields in this struct [INFO] [stdout] ... [INFO] [stdout] 19 | last_operation: u64, [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 23 | current_solution_quality: f64, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `Agent` has derived impls for the traits `Debug` and `Clone`, but these are intentionally ignored during dead code analysis [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: fields `truss` and `objective_function_value` are never read [INFO] [stdout] --> src/problems/structure.rs:10:5 [INFO] [stdout] | [INFO] [stdout] 8 | pub struct Structure { [INFO] [stdout] | --------- fields in this struct [INFO] [stdout] 9 | /// Thie contains the fundamental truss information [INFO] [stdout] 10 | truss: Truss, [INFO] [stdout] | ^^^^^ [INFO] [stdout] ... [INFO] [stdout] 14 | objective_function_value: Vec, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `Structure` has derived impls for the traits `Debug` and `Clone`, but these are intentionally ignored during dead code analysis [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/abm/agent.rs:58:35 [INFO] [stdout] | [INFO] [stdout] 50 | let solution = S::new(); [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 58 | best_solution_so_far: solution.clone(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/abm/agent.rs:59:31 [INFO] [stdout] | [INFO] [stdout] 50 | let solution = S::new(); [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 59 | current_solution: solution.clone(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/abm/team.rs:98:41 [INFO] [stdout] | [INFO] [stdout] 98 | .for_each(|x| x.communicate(solutions.clone())); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 3 previous errors; 11 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `cisat` (lib test) due to 4 previous errors; 11 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] error: could not compile `cisat` (lib) due to 4 previous errors; 10 warnings emitted [INFO] running `Command { std: "docker" "inspect" "cc4f9d121dd2767aab32e5f44d67623bc268b30cb991ce8891add622e86d9302", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "cc4f9d121dd2767aab32e5f44d67623bc268b30cb991ce8891add622e86d9302", kill_on_drop: false }` [INFO] [stdout] cc4f9d121dd2767aab32e5f44d67623bc268b30cb991ce8891add622e86d9302