[INFO] fetching crate ciff 0.3.1... [INFO] checking ciff-0.3.1 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate ciff 0.3.1 into /workspace/builds/worker-2-tc2/source [INFO] validating manifest of crates.io crate ciff 0.3.1 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate ciff 0.3.1 [INFO] finished tweaking crates.io crate ciff 0.3.1 [INFO] tweaked toml for crates.io crate ciff 0.3.1 written to /workspace/builds/worker-2-tc2/source/Cargo.toml [INFO] crate crates.io crate ciff 0.3.1 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 79a8b615cc95b10b8ce6c6115a08eda1d60bc51a5ca4054b090b48a1181ac79f [INFO] running `Command { std: "docker" "start" "-a" "79a8b615cc95b10b8ce6c6115a08eda1d60bc51a5ca4054b090b48a1181ac79f", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "79a8b615cc95b10b8ce6c6115a08eda1d60bc51a5ca4054b090b48a1181ac79f", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "79a8b615cc95b10b8ce6c6115a08eda1d60bc51a5ca4054b090b48a1181ac79f", kill_on_drop: false }` [INFO] [stdout] 79a8b615cc95b10b8ce6c6115a08eda1d60bc51a5ca4054b090b48a1181ac79f [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 504ab1f9fc33b1ded52a214d5b0a04cdfd8490747a957eba54a791f552de344b [INFO] running `Command { std: "docker" "start" "-a" "504ab1f9fc33b1ded52a214d5b0a04cdfd8490747a957eba54a791f552de344b", kill_on_drop: false }` [INFO] [stderr] Compiling libc v0.2.92 [INFO] [stderr] Compiling proc-macro2 v1.0.26 [INFO] [stderr] Compiling memchr v2.5.0 [INFO] [stderr] Compiling unicode-xid v0.2.1 [INFO] [stderr] Compiling getrandom v0.2.2 [INFO] [stderr] Compiling protobuf v2.27.1 [INFO] [stderr] Compiling syn v1.0.68 [INFO] [stderr] Checking unicode-width v0.1.8 [INFO] [stderr] Checking regex-syntax v0.6.27 [INFO] [stderr] Checking ppv-lite86 v0.2.10 [INFO] [stderr] Compiling autocfg v1.0.1 [INFO] [stderr] Compiling unicode-segmentation v1.7.1 [INFO] [stderr] Compiling anyhow v1.0.40 [INFO] [stderr] Checking remove_dir_all v0.5.3 [INFO] [stderr] Checking number_prefix v0.3.0 [INFO] [stderr] Checking textwrap v0.11.0 [INFO] [stderr] Compiling num-traits v0.2.14 [INFO] [stderr] Compiling heck v0.3.2 [INFO] [stderr] Compiling quote v1.0.9 [INFO] [stderr] Checking aho-corasick v0.7.18 [INFO] [stderr] Checking terminal_size v0.1.16 [INFO] [stderr] Checking atty v0.2.14 [INFO] [stderr] Checking memmap v0.7.0 [INFO] [stderr] Compiling proc-macro-error-attr v1.0.4 [INFO] [stderr] Checking clap v2.33.3 [INFO] [stderr] Checking rand_core v0.6.2 [INFO] [stderr] Checking rand_chacha v0.3.0 [INFO] [stderr] Checking regex v1.6.0 [INFO] [stderr] Checking rand v0.8.3 [INFO] [stderr] Checking tempfile v3.2.0 [INFO] [stderr] Checking console v0.14.1 [INFO] [stderr] Checking env_logger v0.8.3 [INFO] [stderr] Checking quickcheck v1.0.3 [INFO] [stderr] Checking indicatif v0.15.0 [INFO] [stderr] Compiling proc-macro-error v1.0.4 [INFO] [stderr] Compiling protobuf-codegen v2.27.1 [INFO] [stderr] Compiling structopt-derive v0.4.14 [INFO] [stderr] Compiling quickcheck_macros v1.0.0 [INFO] [stderr] Compiling protobuf-codegen-pure v2.27.1 [INFO] [stderr] Checking structopt v0.3.21 [INFO] [stderr] Compiling ciff v0.3.1 (/opt/rustwide/workdir) [INFO] [stdout] warning: lint `box_pointers` has been removed: it does not detect other kinds of allocations, and existed only for historical reasons [INFO] [stdout] --> src/proto/common_index_format_v1.rs:4:10 [INFO] [stdout] | [INFO] [stdout] 4 | #![allow(box_pointers)] [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(renamed_and_removed_lints)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary qualification [INFO] [stdout] --> src/binary_collection.rs:7:29 [INFO] [stdout] | [INFO] [stdout] 7 | const ELEMENT_SIZE: usize = std::mem::size_of::(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] note: the lint level is defined here [INFO] [stdout] --> src/lib.rs:42:5 [INFO] [stdout] | [INFO] [stdout] 42 | unused_qualifications [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] help: remove the unnecessary path segments [INFO] [stdout] | [INFO] [stdout] 7 - const ELEMENT_SIZE: usize = std::mem::size_of::(); [INFO] [stdout] 7 + const ELEMENT_SIZE: usize = size_of::(); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary qualification [INFO] [stdout] --> src/binary_collection.rs:80:26 [INFO] [stdout] | [INFO] [stdout] 80 | if bytes.len() % std::mem::size_of::() == 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] help: remove the unnecessary path segments [INFO] [stdout] | [INFO] [stdout] 80 - if bytes.len() % std::mem::size_of::() == 0 { [INFO] [stdout] 80 + if bytes.len() % size_of::() == 0 { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary qualification [INFO] [stdout] --> src/binary_collection.rs:302:26 [INFO] [stdout] | [INFO] [stdout] 302 | if bytes.len() % std::mem::size_of::() == 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] help: remove the unnecessary path segments [INFO] [stdout] | [INFO] [stdout] 302 - if bytes.len() % std::mem::size_of::() == 0 { [INFO] [stdout] 302 + if bytes.len() % size_of::() == 0 { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary qualification [INFO] [stdout] --> src/binary_collection.rs:303:40 [INFO] [stdout] | [INFO] [stdout] 303 | let length = bytes.len() / std::mem::size_of::(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] help: remove the unnecessary path segments [INFO] [stdout] | [INFO] [stdout] 303 - let length = bytes.len() / std::mem::size_of::(); [INFO] [stdout] 303 + let length = bytes.len() / size_of::(); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary qualification [INFO] [stdout] --> src/binary_collection.rs:339:34 [INFO] [stdout] | [INFO] [stdout] 339 | let offset = index * std::mem::size_of::(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] help: remove the unnecessary path segments [INFO] [stdout] | [INFO] [stdout] 339 - let offset = index * std::mem::size_of::(); [INFO] [stdout] 339 + let offset = index * size_of::(); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary qualification [INFO] [stdout] --> src/payload_vector.rs:57:16 [INFO] [stdout] | [INFO] [stdout] 57 | data[..std::mem::size_of::()].copy_from_slice(&length.to_le_bytes()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] help: remove the unnecessary path segments [INFO] [stdout] | [INFO] [stdout] 57 - data[..std::mem::size_of::()].copy_from_slice(&length.to_le_bytes()); [INFO] [stdout] 57 + data[..size_of::()].copy_from_slice(&length.to_le_bytes()); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: lint `box_pointers` has been removed: it does not detect other kinds of allocations, and existed only for historical reasons [INFO] [stdout] --> src/proto/common_index_format_v1.rs:4:10 [INFO] [stdout] | [INFO] [stdout] 4 | #![allow(box_pointers)] [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(renamed_and_removed_lints)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary qualification [INFO] [stdout] --> src/binary_collection.rs:7:29 [INFO] [stdout] | [INFO] [stdout] 7 | const ELEMENT_SIZE: usize = std::mem::size_of::(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] note: the lint level is defined here [INFO] [stdout] --> src/lib.rs:42:5 [INFO] [stdout] | [INFO] [stdout] 42 | unused_qualifications [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] help: remove the unnecessary path segments [INFO] [stdout] | [INFO] [stdout] 7 - const ELEMENT_SIZE: usize = std::mem::size_of::(); [INFO] [stdout] 7 + const ELEMENT_SIZE: usize = size_of::(); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary qualification [INFO] [stdout] --> src/binary_collection.rs:80:26 [INFO] [stdout] | [INFO] [stdout] 80 | if bytes.len() % std::mem::size_of::() == 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] help: remove the unnecessary path segments [INFO] [stdout] | [INFO] [stdout] 80 - if bytes.len() % std::mem::size_of::() == 0 { [INFO] [stdout] 80 + if bytes.len() % size_of::() == 0 { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary qualification [INFO] [stdout] --> src/binary_collection.rs:302:26 [INFO] [stdout] | [INFO] [stdout] 302 | if bytes.len() % std::mem::size_of::() == 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] help: remove the unnecessary path segments [INFO] [stdout] | [INFO] [stdout] 302 - if bytes.len() % std::mem::size_of::() == 0 { [INFO] [stdout] 302 + if bytes.len() % size_of::() == 0 { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary qualification [INFO] [stdout] --> src/binary_collection.rs:303:40 [INFO] [stdout] | [INFO] [stdout] 303 | let length = bytes.len() / std::mem::size_of::(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] help: remove the unnecessary path segments [INFO] [stdout] | [INFO] [stdout] 303 - let length = bytes.len() / std::mem::size_of::(); [INFO] [stdout] 303 + let length = bytes.len() / size_of::(); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary qualification [INFO] [stdout] --> src/binary_collection.rs:339:34 [INFO] [stdout] | [INFO] [stdout] 339 | let offset = index * std::mem::size_of::(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] help: remove the unnecessary path segments [INFO] [stdout] | [INFO] [stdout] 339 - let offset = index * std::mem::size_of::(); [INFO] [stdout] 339 + let offset = index * size_of::(); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary qualification [INFO] [stdout] --> src/payload_vector.rs:57:16 [INFO] [stdout] | [INFO] [stdout] 57 | data[..std::mem::size_of::()].copy_from_slice(&length.to_le_bytes()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] help: remove the unnecessary path segments [INFO] [stdout] | [INFO] [stdout] 57 - data[..std::mem::size_of::()].copy_from_slice(&length.to_le_bytes()); [INFO] [stdout] 57 + data[..size_of::()].copy_from_slice(&length.to_le_bytes()); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:107:12 [INFO] [stdout] | [INFO] [stdout] 102 | let header = input.read_message::()?; [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 107 | Ok(Self { [INFO] [stdout] | ____________^ [INFO] [stdout] 108 | | protobuf_header: header, [INFO] [stdout] 109 | | num_documents, [INFO] [stdout] 110 | | num_postings_lists, [INFO] [stdout] 111 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 1 previous error; 7 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `ciff` (lib) due to 2 previous errors; 7 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:107:12 [INFO] [stdout] | [INFO] [stdout] 102 | let header = input.read_message::()?; [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 107 | Ok(Self { [INFO] [stdout] | ____________^ [INFO] [stdout] 108 | | protobuf_header: header, [INFO] [stdout] 109 | | num_documents, [INFO] [stdout] 110 | | num_postings_lists, [INFO] [stdout] 111 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 1 previous error; 7 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `ciff` (lib test) due to 2 previous errors; 7 warnings emitted [INFO] running `Command { std: "docker" "inspect" "504ab1f9fc33b1ded52a214d5b0a04cdfd8490747a957eba54a791f552de344b", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "504ab1f9fc33b1ded52a214d5b0a04cdfd8490747a957eba54a791f552de344b", kill_on_drop: false }` [INFO] [stdout] 504ab1f9fc33b1ded52a214d5b0a04cdfd8490747a957eba54a791f552de344b