[INFO] fetching crate chudnovsky 0.0.1... [INFO] checking chudnovsky-0.0.1 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate chudnovsky 0.0.1 into /workspace/builds/worker-1-tc2/source [INFO] validating manifest of crates.io crate chudnovsky 0.0.1 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate chudnovsky 0.0.1 [INFO] finished tweaking crates.io crate chudnovsky 0.0.1 [INFO] tweaked toml for crates.io crate chudnovsky 0.0.1 written to /workspace/builds/worker-1-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 25 packages to latest compatible versions [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 569f79df3c80cdad919c5e5815ea1908c71bb7e12e29d7dfb16224fa0f3030cb [INFO] running `Command { std: "docker" "start" "-a" "569f79df3c80cdad919c5e5815ea1908c71bb7e12e29d7dfb16224fa0f3030cb", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "569f79df3c80cdad919c5e5815ea1908c71bb7e12e29d7dfb16224fa0f3030cb", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "569f79df3c80cdad919c5e5815ea1908c71bb7e12e29d7dfb16224fa0f3030cb", kill_on_drop: false }` [INFO] [stdout] 569f79df3c80cdad919c5e5815ea1908c71bb7e12e29d7dfb16224fa0f3030cb [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 85bba9f8427f2e23a59040930ef3e4f5a3ae9fa5fd53c783fea206a0add1905c [INFO] running `Command { std: "docker" "start" "-a" "85bba9f8427f2e23a59040930ef3e4f5a3ae9fa5fd53c783fea206a0add1905c", kill_on_drop: false }` [INFO] [stderr] Compiling rustversion v1.0.17 [INFO] [stderr] Checking num-modular v0.6.1 [INFO] [stderr] Compiling static_assertions v1.1.0 [INFO] [stderr] Compiling dashu-base v0.4.1 [INFO] [stderr] Checking num-integer v0.1.46 [INFO] [stderr] Checking num-complex v0.4.6 [INFO] [stderr] Checking latexify v0.1.0 [INFO] [stderr] Checking num-bigint v0.4.6 [INFO] [stderr] Checking num-iter v0.1.45 [INFO] [stderr] Compiling dashu-int v0.4.1 [INFO] [stderr] Checking num-order v1.2.0 [INFO] [stderr] Checking num-rational v0.4.2 [INFO] [stderr] Checking num v0.4.3 [INFO] [stderr] Checking dashu-float v0.4.3 [INFO] [stderr] Compiling dashu-ratio v0.4.1 [INFO] [stderr] Compiling dashu-macros v0.4.1 [INFO] [stderr] Checking dashu v0.4.2 [INFO] [stderr] Checking chudnovsky v0.0.1 (/opt/rustwide/workdir) [INFO] [stdout] warning: unused imports: `Display`, `LowerHex`, and `UpperHex` [INFO] [stdout] --> src/order_2/mod.rs:1:17 [INFO] [stdout] | [INFO] [stdout] 1 | use core::fmt::{Display, LowerHex, UpperHex}; [INFO] [stdout] | ^^^^^^^ ^^^^^^^^ ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `super::*` [INFO] [stdout] --> src/order_2/display.rs:1:5 [INFO] [stdout] | [INFO] [stdout] 1 | use super::*; [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused imports: `Display`, `LowerHex`, and `UpperHex` [INFO] [stdout] --> src/order_2/mod.rs:1:17 [INFO] [stdout] | [INFO] [stdout] 1 | use core::fmt::{Display, LowerHex, UpperHex}; [INFO] [stdout] | ^^^^^^^ ^^^^^^^^ ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `super::*` [INFO] [stdout] --> src/order_2/display.rs:1:5 [INFO] [stdout] | [INFO] [stdout] 1 | use super::*; [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `iterators` [INFO] [stdout] --> src/order_2/mod.rs:17:23 [INFO] [stdout] | [INFO] [stdout] 17 | pub fn run(&self, iterators: usize) -> DBig { [INFO] [stdout] | ^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_iterators` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `a` is never read [INFO] [stdout] --> src/order_2/mod.rs:9:5 [INFO] [stdout] | [INFO] [stdout] 8 | pub struct RamanujanL2 { [INFO] [stdout] | ----------- field in this struct [INFO] [stdout] 9 | a: usize, [INFO] [stdout] | ^ [INFO] [stdout] | [INFO] [stdout] = note: `RamanujanL2` has derived impls for the traits `Debug` and `Clone`, but these are intentionally ignored during dead code analysis [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: struct `DecViewer` is never constructed [INFO] [stdout] --> src/helpers/mod.rs:33:19 [INFO] [stdout] | [INFO] [stdout] 33 | pub(crate) struct DecViewer<'i, T> { [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: struct `HexViewer8` is never constructed [INFO] [stdout] --> src/helpers/mod.rs:38:19 [INFO] [stdout] | [INFO] [stdout] 38 | pub(crate) struct HexViewer8<'i> { [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: missing documentation for a method [INFO] [stdout] --> src/order_1/mod.rs:59:5 [INFO] [stdout] | [INFO] [stdout] 59 | pub fn run(&self, iterators: usize) -> DBig { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] note: the lint level is defined here [INFO] [stdout] --> src/lib.rs:2:9 [INFO] [stdout] | [INFO] [stdout] 2 | #![warn(missing_docs, rustdoc::missing_crate_level_docs)] [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/order_1/mod.rs:66:9 [INFO] [stdout] | [INFO] [stdout] 62 | let (_, q1n, r1n) = self.binary_split(1, iterators as i64); [INFO] [stdout] | --- --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 63 | let d = DBig::from(self.c).mul(&q1n).add(r1n).with_precision(RELAXATION * iterators).value(); [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 64 | let n = DBig::from(q1n.mul(self.a)).with_precision(RELAXATION * iterators).value(); [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 65 | let sqrt = DBig::from(self.b).with_precision(RELAXATION * iterators).value().sqrt(); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 66 | n.mul(sqrt).div(d) [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: missing documentation for an associated constant [INFO] [stdout] --> src/order_2/mod.rs:13:5 [INFO] [stdout] | [INFO] [stdout] 13 | pub const J58: Self = Self { a: 0 }; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: missing documentation for a method [INFO] [stdout] --> src/order_2/mod.rs:17:5 [INFO] [stdout] | [INFO] [stdout] 17 | pub fn run(&self, iterators: usize) -> DBig { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: missing documentation for a function [INFO] [stdout] --> src/order_2/mod.rs:22:1 [INFO] [stdout] | [INFO] [stdout] 22 | pub fn ramanujan(iterators: usize) -> DBig { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 1 previous error; 10 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `chudnovsky` (lib) due to 2 previous errors; 10 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] warning: unused variable: `iterators` [INFO] [stdout] --> src/order_2/mod.rs:17:23 [INFO] [stdout] | [INFO] [stdout] 17 | pub fn run(&self, iterators: usize) -> DBig { [INFO] [stdout] | ^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_iterators` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `a` is never read [INFO] [stdout] --> src/order_2/mod.rs:9:5 [INFO] [stdout] | [INFO] [stdout] 8 | pub struct RamanujanL2 { [INFO] [stdout] | ----------- field in this struct [INFO] [stdout] 9 | a: usize, [INFO] [stdout] | ^ [INFO] [stdout] | [INFO] [stdout] = note: `RamanujanL2` has derived impls for the traits `Debug` and `Clone`, but these are intentionally ignored during dead code analysis [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: struct `DecViewer` is never constructed [INFO] [stdout] --> src/helpers/mod.rs:33:19 [INFO] [stdout] | [INFO] [stdout] 33 | pub(crate) struct DecViewer<'i, T> { [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: struct `HexViewer8` is never constructed [INFO] [stdout] --> src/helpers/mod.rs:38:19 [INFO] [stdout] | [INFO] [stdout] 38 | pub(crate) struct HexViewer8<'i> { [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/order_1/mod.rs:66:9 [INFO] [stdout] | [INFO] [stdout] 62 | let (_, q1n, r1n) = self.binary_split(1, iterators as i64); [INFO] [stdout] | --- --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 63 | let d = DBig::from(self.c).mul(&q1n).add(r1n).with_precision(RELAXATION * iterators).value(); [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 64 | let n = DBig::from(q1n.mul(self.a)).with_precision(RELAXATION * iterators).value(); [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 65 | let sqrt = DBig::from(self.b).with_precision(RELAXATION * iterators).value().sqrt(); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 66 | n.mul(sqrt).div(d) [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 1 previous error; 6 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `chudnovsky` (lib test) due to 2 previous errors; 6 warnings emitted [INFO] running `Command { std: "docker" "inspect" "85bba9f8427f2e23a59040930ef3e4f5a3ae9fa5fd53c783fea206a0add1905c", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "85bba9f8427f2e23a59040930ef3e4f5a3ae9fa5fd53c783fea206a0add1905c", kill_on_drop: false }` [INFO] [stdout] 85bba9f8427f2e23a59040930ef3e4f5a3ae9fa5fd53c783fea206a0add1905c