[INFO] fetching crate choose 1.3.4... [INFO] checking choose-1.3.4 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate choose 1.3.4 into /workspace/builds/worker-4-tc2/source [INFO] validating manifest of crates.io crate choose 1.3.4 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate choose 1.3.4 [INFO] finished tweaking crates.io crate choose 1.3.4 [INFO] tweaked toml for crates.io crate choose 1.3.4 written to /workspace/builds/worker-4-tc2/source/Cargo.toml [INFO] crate crates.io crate choose 1.3.4 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 960693d209b76402c92994c7965ebc4a1db615b6730def475240efbf9b417aae [INFO] running `Command { std: "docker" "start" "-a" "960693d209b76402c92994c7965ebc4a1db615b6730def475240efbf9b417aae", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "960693d209b76402c92994c7965ebc4a1db615b6730def475240efbf9b417aae", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "960693d209b76402c92994c7965ebc4a1db615b6730def475240efbf9b417aae", kill_on_drop: false }` [INFO] [stdout] 960693d209b76402c92994c7965ebc4a1db615b6730def475240efbf9b417aae [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 2798a9160f415e4ab1062edbc3a355a054cf6a5d6820dfc616d4771d6cbfb4a3 [INFO] running `Command { std: "docker" "start" "-a" "2798a9160f415e4ab1062edbc3a355a054cf6a5d6820dfc616d4771d6cbfb4a3", kill_on_drop: false }` [INFO] [stderr] Compiling proc-macro2 v1.0.18 [INFO] [stderr] Compiling unicode-xid v0.2.1 [INFO] [stderr] Compiling version_check v0.9.2 [INFO] [stderr] Compiling syn v1.0.33 [INFO] [stderr] Compiling libc v0.2.71 [INFO] [stderr] Compiling memchr v2.3.3 [INFO] [stderr] Compiling bitflags v1.2.1 [INFO] [stderr] Compiling unicode-segmentation v1.6.0 [INFO] [stderr] Checking unicode-width v0.1.7 [INFO] [stderr] Checking regex-syntax v0.6.18 [INFO] [stderr] Checking backslash v0.1.0 [INFO] [stderr] Checking thread_local v1.0.1 [INFO] [stderr] Checking textwrap v0.11.0 [INFO] [stderr] Compiling proc-macro-error-attr v1.0.3 [INFO] [stderr] Compiling proc-macro-error v1.0.3 [INFO] [stderr] Compiling heck v0.3.1 [INFO] [stderr] Checking aho-corasick v0.7.13 [INFO] [stderr] Compiling quote v1.0.7 [INFO] [stderr] Checking atty v0.2.14 [INFO] [stderr] Checking clap v2.33.1 [INFO] [stderr] Checking regex v1.3.9 [INFO] [stderr] Compiling syn-mid v0.5.0 [INFO] [stderr] Compiling structopt-derive v0.4.8 [INFO] [stderr] Checking structopt v0.3.15 [INFO] [stderr] Checking choose v1.3.4 (/opt/rustwide/workdir) [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/config.rs:15:13 [INFO] [stdout] | [INFO] [stdout] 15 | for mut choice in &mut opt.choices { [INFO] [stdout] | ----^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_mut)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `debug` is never read [INFO] [stdout] --> src/opt.rs:17:9 [INFO] [stdout] | [INFO] [stdout] 10 | pub struct Opt { [INFO] [stdout] | --- field in this struct [INFO] [stdout] ... [INFO] [stdout] 17 | pub debug: bool, [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `Opt` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/reader.rs:10:21 [INFO] [stdout] | [INFO] [stdout] 8 | pub fn new(f: R) -> Self { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 9 | Self { [INFO] [stdout] 10 | reader: io::BufReader::new(f), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 1 previous error; 2 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `choose` (bin "choose") due to 2 previous errors; 2 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/config.rs:15:13 [INFO] [stdout] | [INFO] [stdout] 15 | for mut choice in &mut opt.choices { [INFO] [stdout] | ----^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_mut)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `debug` is never read [INFO] [stdout] --> src/opt.rs:17:9 [INFO] [stdout] | [INFO] [stdout] 10 | pub struct Opt { [INFO] [stdout] | --- field in this struct [INFO] [stdout] ... [INFO] [stdout] 17 | pub debug: bool, [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `Opt` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/choice/test/mod.rs:33:15 [INFO] [stdout] | [INFO] [stdout] 32 | fn str_from_buf_writer(b: BufWriter) -> String { [INFO] [stdout] | ------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 33 | match b.into_inner() { [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/choice/test/get_negative_start_end.rs:70:9 [INFO] [stdout] | [INFO] [stdout] 66 | let config = Config::from_iter(vec!["choose", "-3:-1"]); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 70 | config.opt.choices[0].get_negative_start_end(slice).unwrap() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/choice/test/get_negative_start_end.rs:80:9 [INFO] [stdout] | [INFO] [stdout] 76 | let config = Config::from_iter(vec!["choose", "-3:5"]); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 80 | config.opt.choices[0].get_negative_start_end(slice).unwrap() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/choice/test/get_negative_start_end.rs:90:9 [INFO] [stdout] | [INFO] [stdout] 86 | let config = Config::from_iter(vec!["choose", "2:-1"]); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 90 | config.opt.choices[0].get_negative_start_end(slice).unwrap() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/reader.rs:10:21 [INFO] [stdout] | [INFO] [stdout] 8 | pub fn new(f: R) -> Self { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 9 | Self { [INFO] [stdout] 10 | reader: io::BufReader::new(f), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 5 previous errors; 2 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `choose` (bin "choose" test) due to 6 previous errors; 2 warnings emitted [INFO] running `Command { std: "docker" "inspect" "2798a9160f415e4ab1062edbc3a355a054cf6a5d6820dfc616d4771d6cbfb4a3", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "2798a9160f415e4ab1062edbc3a355a054cf6a5d6820dfc616d4771d6cbfb4a3", kill_on_drop: false }` [INFO] [stdout] 2798a9160f415e4ab1062edbc3a355a054cf6a5d6820dfc616d4771d6cbfb4a3