[INFO] fetching crate chomatter_syntaxer 0.0.1... [INFO] checking chomatter_syntaxer-0.0.1 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate chomatter_syntaxer 0.0.1 into /workspace/builds/worker-2-tc2/source [INFO] validating manifest of crates.io crate chomatter_syntaxer 0.0.1 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate chomatter_syntaxer 0.0.1 [INFO] finished tweaking crates.io crate chomatter_syntaxer 0.0.1 [INFO] tweaked toml for crates.io crate chomatter_syntaxer 0.0.1 written to /workspace/builds/worker-2-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 14 packages to latest compatible versions [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] e419f8e2ed7c18a16a56a606a996c98b2dfde43ed01c344fde4ea1c85081c4dd [INFO] running `Command { std: "docker" "start" "-a" "e419f8e2ed7c18a16a56a606a996c98b2dfde43ed01c344fde4ea1c85081c4dd", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "e419f8e2ed7c18a16a56a606a996c98b2dfde43ed01c344fde4ea1c85081c4dd", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "e419f8e2ed7c18a16a56a606a996c98b2dfde43ed01c344fde4ea1c85081c4dd", kill_on_drop: false }` [INFO] [stdout] e419f8e2ed7c18a16a56a606a996c98b2dfde43ed01c344fde4ea1c85081c4dd [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 86b4eed0a685520bc820e9b059cf22fa7fa9f9b101c56f00a82bafa2abf4a568 [INFO] running `Command { std: "docker" "start" "-a" "86b4eed0a685520bc820e9b059cf22fa7fa9f9b101c56f00a82bafa2abf4a568", kill_on_drop: false }` [INFO] [stderr] Compiling proc-macro2 v1.0.86 [INFO] [stderr] Compiling serde v1.0.209 [INFO] [stderr] Checking json v0.12.4 [INFO] [stderr] Compiling quote v1.0.37 [INFO] [stderr] Compiling syn v2.0.77 [INFO] [stderr] Compiling serde_derive v1.0.209 [INFO] [stderr] Checking serde_json v1.0.127 [INFO] [stderr] Checking chomatter_commons v0.0.1 [INFO] [stderr] Checking chomatter_lexer v0.0.1 [INFO] [stderr] Checking chomatter_syntaxer v0.0.1 (/opt/rustwide/workdir) [INFO] [stdout] warning: unused import: `Segment` [INFO] [stdout] --> src/lib.rs:4:34 [INFO] [stdout] | [INFO] [stdout] 4 | EGenericToken, GenericToken, Segment, [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around `if` condition [INFO] [stdout] --> src/lib.rs:178:24 [INFO] [stdout] | [INFO] [stdout] 178 | if (walker.current().kind == EGenericToken::LeftParen) { [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_parens)]` on by default [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 178 - if (walker.current().kind == EGenericToken::LeftParen) { [INFO] [stdout] 178 + if walker.current().kind == EGenericToken::LeftParen { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `Segment` [INFO] [stdout] --> src/lib.rs:4:34 [INFO] [stdout] | [INFO] [stdout] 4 | EGenericToken, GenericToken, Segment, [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around `if` condition [INFO] [stdout] --> src/lib.rs:178:24 [INFO] [stdout] | [INFO] [stdout] 178 | if (walker.current().kind == EGenericToken::LeftParen) { [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_parens)]` on by default [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 178 - if (walker.current().kind == EGenericToken::LeftParen) { [INFO] [stdout] 178 + if walker.current().kind == EGenericToken::LeftParen { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `y` [INFO] [stdout] --> src/lib.rs:363:82 [INFO] [stdout] | [INFO] [stdout] 363 | tester.forward_custom(chomatter_commons::walker::EMover::WhileBy(|x, y, z, w| { [INFO] [stdout] | ^ help: if this is intentional, prefix it with an underscore: `_y` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `w` [INFO] [stdout] --> src/lib.rs:363:88 [INFO] [stdout] | [INFO] [stdout] 363 | tester.forward_custom(chomatter_commons::walker::EMover::WhileBy(|x, y, z, w| { [INFO] [stdout] | ^ help: if this is intentional, prefix it with an underscore: `_w` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `y` [INFO] [stdout] --> src/lib.rs:363:82 [INFO] [stdout] | [INFO] [stdout] 363 | tester.forward_custom(chomatter_commons::walker::EMover::WhileBy(|x, y, z, w| { [INFO] [stdout] | ^ help: if this is intentional, prefix it with an underscore: `_y` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/lib.rs:502:21 [INFO] [stdout] | [INFO] [stdout] 502 | let mut value = Walker::cook(&raw); [INFO] [stdout] | ----^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_mut)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `w` [INFO] [stdout] --> src/lib.rs:363:88 [INFO] [stdout] | [INFO] [stdout] 363 | tester.forward_custom(chomatter_commons::walker::EMover::WhileBy(|x, y, z, w| { [INFO] [stdout] | ^ help: if this is intentional, prefix it with an underscore: `_w` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/lib.rs:502:21 [INFO] [stdout] | [INFO] [stdout] 502 | let mut value = Walker::cook(&raw); [INFO] [stdout] | ----^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_mut)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/lib.rs:739:21 [INFO] [stdout] | [INFO] [stdout] 739 | let mut case_statements = self.parse(data, scope_level + 1); [INFO] [stdout] | ----^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/lib.rs:763:21 [INFO] [stdout] | [INFO] [stdout] 763 | let mut tbody = self.current(); [INFO] [stdout] | ----^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/lib.rs:764:21 [INFO] [stdout] | [INFO] [stdout] 764 | let mut body: Statement; [INFO] [stdout] | ----^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/lib.rs:984:21 [INFO] [stdout] | [INFO] [stdout] 984 | let mut args = resolve_arguments(self, data); [INFO] [stdout] | ----^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `is_empty_token` is never used [INFO] [stdout] --> src/lib.rs:25:4 [INFO] [stdout] | [INFO] [stdout] 25 | fn is_empty_token(token: &GenericToken) -> bool { [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:523:40 [INFO] [stdout] | [INFO] [stdout] 493 | let mut parts = Vec::new(); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 523 | sts::Statement::TemplateString(sts::TemplateString { [INFO] [stdout] | ________________________________________^ [INFO] [stdout] 524 | | kind: sts::EStatatement::TemplateString, [INFO] [stdout] 525 | | parts, [INFO] [stdout] 526 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 1 previous error; 10 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `chomatter_syntaxer` (lib) due to 2 previous errors; 10 warnings emitted [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/lib.rs:739:21 [INFO] [stdout] | [INFO] [stdout] 739 | let mut case_statements = self.parse(data, scope_level + 1); [INFO] [stdout] | ----^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/lib.rs:763:21 [INFO] [stdout] | [INFO] [stdout] 763 | let mut tbody = self.current(); [INFO] [stdout] | ----^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/lib.rs:764:21 [INFO] [stdout] | [INFO] [stdout] 764 | let mut body: Statement; [INFO] [stdout] | ----^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/lib.rs:984:21 [INFO] [stdout] | [INFO] [stdout] 984 | let mut args = resolve_arguments(self, data); [INFO] [stdout] | ----^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `is_empty_token` is never used [INFO] [stdout] --> src/lib.rs:25:4 [INFO] [stdout] | [INFO] [stdout] 25 | fn is_empty_token(token: &GenericToken) -> bool { [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:523:40 [INFO] [stdout] | [INFO] [stdout] 493 | let mut parts = Vec::new(); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 523 | sts::Statement::TemplateString(sts::TemplateString { [INFO] [stdout] | ________________________________________^ [INFO] [stdout] 524 | | kind: sts::EStatatement::TemplateString, [INFO] [stdout] 525 | | parts, [INFO] [stdout] 526 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 1 previous error; 10 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `chomatter_syntaxer` (lib test) due to 2 previous errors; 10 warnings emitted [INFO] running `Command { std: "docker" "inspect" "86b4eed0a685520bc820e9b059cf22fa7fa9f9b101c56f00a82bafa2abf4a568", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "86b4eed0a685520bc820e9b059cf22fa7fa9f9b101c56f00a82bafa2abf4a568", kill_on_drop: false }` [INFO] [stdout] 86b4eed0a685520bc820e9b059cf22fa7fa9f9b101c56f00a82bafa2abf4a568