[INFO] fetching crate chitchat 0.7.0... [INFO] checking chitchat-0.7.0 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate chitchat 0.7.0 into /workspace/builds/worker-3-tc2/source [INFO] validating manifest of crates.io crate chitchat 0.7.0 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate chitchat 0.7.0 [INFO] finished tweaking crates.io crate chitchat 0.7.0 [INFO] tweaked toml for crates.io crate chitchat 0.7.0 written to /workspace/builds/worker-3-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Updating crates.io index [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Locking 75 packages to latest compatible versions [INFO] [stderr] Adding addr2line v0.22.0 (latest: v0.24.1) [INFO] [stderr] Adding gimli v0.29.0 (latest: v0.31.0) [INFO] [stderr] Adding hermit-abi v0.3.9 (latest: v0.4.0) [INFO] [stderr] Adding itertools v0.10.5 (latest: v0.13.0) [INFO] [stderr] Adding miniz_oxide v0.7.4 (latest: v0.8.0) [INFO] [stderr] Adding mock_instant v0.2.1 (latest: v0.5.1) [INFO] [stderr] Adding nu-ansi-term v0.46.0 (latest: v0.50.1) [INFO] [stderr] Adding wasi v0.11.0+wasi-snapshot-preview1 (latest: v0.13.2+wasi-0.2.1) [INFO] [stderr] Adding windows-sys v0.52.0 (latest: v0.59.0) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 46ea1ccd36e051e831117d2a793cac688cfb16e045b7387fa86728f9f2555d66 [INFO] running `Command { std: "docker" "start" "-a" "46ea1ccd36e051e831117d2a793cac688cfb16e045b7387fa86728f9f2555d66", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "46ea1ccd36e051e831117d2a793cac688cfb16e045b7387fa86728f9f2555d66", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "46ea1ccd36e051e831117d2a793cac688cfb16e045b7387fa86728f9f2555d66", kill_on_drop: false }` [INFO] [stdout] 46ea1ccd36e051e831117d2a793cac688cfb16e045b7387fa86728f9f2555d66 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] e9e2223e92b551bafb51c158871c2a2f8fe6e348bc052d36d4ea90685bedc181 [INFO] running `Command { std: "docker" "start" "-a" "e9e2223e92b551bafb51c158871c2a2f8fe6e348bc052d36d4ea90685bedc181", kill_on_drop: false }` [INFO] [stderr] Compiling proc-macro2 v1.0.86 [INFO] [stderr] Compiling unicode-ident v1.0.12 [INFO] [stderr] Compiling libc v0.2.158 [INFO] [stderr] Checking cfg-if v1.0.0 [INFO] [stderr] Checking once_cell v1.19.0 [INFO] [stderr] Checking pin-project-lite v0.2.14 [INFO] [stderr] Checking byteorder v1.5.0 [INFO] [stderr] Compiling serde v1.0.209 [INFO] [stderr] Compiling anyhow v1.0.86 [INFO] [stderr] Checking bytes v1.7.1 [INFO] [stderr] Checking futures-core v0.3.30 [INFO] [stderr] Compiling serde_json v1.0.127 [INFO] [stderr] Checking futures-sink v0.3.30 [INFO] [stderr] Checking memchr v2.7.4 [INFO] [stderr] Checking lazy_static v1.5.0 [INFO] [stderr] Checking log v0.4.22 [INFO] [stderr] Checking ryu v1.0.18 [INFO] [stderr] Checking itoa v1.0.11 [INFO] [stderr] Checking either v1.13.0 [INFO] [stderr] Checking overload v0.1.1 [INFO] [stderr] Checking sharded-slab v0.1.7 [INFO] [stderr] Checking smallvec v1.13.2 [INFO] [stderr] Checking mock_instant v0.2.1 [INFO] [stderr] Checking tracing-core v0.1.32 [INFO] [stderr] Checking nu-ansi-term v0.46.0 [INFO] [stderr] Checking thread_local v1.1.8 [INFO] [stderr] Checking itertools v0.10.5 [INFO] [stderr] Checking tracing-log v0.2.0 [INFO] [stderr] Compiling quote v1.0.37 [INFO] [stderr] Checking tracing-subscriber v0.3.18 [INFO] [stderr] Compiling syn v2.0.77 [INFO] [stderr] Checking socket2 v0.5.7 [INFO] [stderr] Checking getrandom v0.2.15 [INFO] [stderr] Checking mio v1.0.2 [INFO] [stderr] Checking rand_core v0.6.4 [INFO] [stderr] Compiling zerocopy-derive v0.7.35 [INFO] [stderr] Compiling tokio-macros v2.4.0 [INFO] [stderr] Compiling serde_derive v1.0.209 [INFO] [stderr] Compiling tracing-attributes v0.1.27 [INFO] [stderr] Compiling async-trait v0.1.81 [INFO] [stderr] Checking tokio v1.40.0 [INFO] [stderr] Checking zerocopy v0.7.35 [INFO] [stderr] Checking tracing v0.1.40 [INFO] [stderr] Checking ppv-lite86 v0.2.20 [INFO] [stderr] Checking rand_chacha v0.3.1 [INFO] [stderr] Checking rand v0.8.5 [INFO] [stderr] Checking tokio-util v0.7.11 [INFO] [stderr] Checking tokio-stream v0.1.15 [INFO] [stderr] Checking chitchat v0.7.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: method `serialize_to_vec` is never used [INFO] [stdout] --> src/serialize.rs:16:8 [INFO] [stdout] | [INFO] [stdout] 13 | pub trait Serializable: Sized { [INFO] [stdout] | ------------ method in this trait [INFO] [stdout] ... [INFO] [stdout] 16 | fn serialize_to_vec(&self) -> Vec { [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/delta.rs:40:12 [INFO] [stdout] | [INFO] [stdout] 35 | let mut nodes_to_reset = HashSet::with_capacity(num_nodes_to_reset as usize); [INFO] [stdout] | -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 40 | Ok(Delta { [INFO] [stdout] | ____________^ [INFO] [stdout] 41 | | node_deltas, [INFO] [stdout] 42 | | nodes_to_reset, [INFO] [stdout] 43 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/server.rs:145:14 [INFO] [stdout] | [INFO] [stdout] 128 | let (command_tx, command_rx) = mpsc::unbounded_channel(); [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 133 | let socket = transport.open(config.listen_addr).await?; [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 139 | let chitchat_arc_clone = chitchat_arc.clone(); [INFO] [stdout] | ------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 145 | .await [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/state.rs:387:23 [INFO] [stdout] | [INFO] [stdout] 383 | let mut rng = random_generator(); [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 387 | .flat_map(move |mut stale_nodes| { [INFO] [stdout] | _______________________^ [INFO] [stdout] 388 | | stale_nodes.shuffle(&mut rng); [INFO] [stdout] 389 | | stale_nodes.into_iter() [INFO] [stdout] 390 | | }) [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/transport/channel.rs:131:99 [INFO] [stdout] | [INFO] [stdout] 131 | async fn send(&mut self, to_addr: SocketAddr, message: ChitchatMessage) -> anyhow::Result<()> { [INFO] [stdout] | ___________________________________________________------------------------________________________^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 132 | | self.broker.send(self.listen_addr, to_addr, message).await?; [INFO] [stdout] 133 | | Ok(()) [INFO] [stdout] 134 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/transport/udp.rs:35:99 [INFO] [stdout] | [INFO] [stdout] 35 | async fn send(&mut self, to_addr: SocketAddr, message: ChitchatMessage) -> anyhow::Result<()> { [INFO] [stdout] | ___________________________________________________------------------------________________________^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 36 | | self.buf_send.clear(); [INFO] [stdout] 37 | | message.serialize(&mut self.buf_send); [INFO] [stdout] 38 | | self.send_bytes(to_addr, &self.buf_send).await?; [INFO] [stdout] 39 | | Ok(()) [INFO] [stdout] 40 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/transport/utils.rs:42:94 [INFO] [stdout] | [INFO] [stdout] 42 | async fn send(&mut self, to: SocketAddr, message: ChitchatMessage) -> anyhow::Result<()> { [INFO] [stdout] | ______________________________________________------------------------________________________^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 43 | | let socket_clone = self.socket.clone(); [INFO] [stdout] 44 | | let delay_secs = self.delay_secs.sample(&mut self.rng); [INFO] [stdout] 45 | | let delay = Duration::from_secs_f32(delay_secs); [INFO] [stdout] ... | [INFO] [stdout] 50 | | Ok(()) [INFO] [stdout] 51 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/transport/utils.rs:65:18 [INFO] [stdout] | [INFO] [stdout] 64 | fn drop_message(self, drop_probability: f64) -> Box { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 65 | Box::new(TransportWithMessageDrop { [INFO] [stdout] | __________________^ [INFO] [stdout] 66 | | drop_probability: Bernoulli::new(drop_probability).unwrap(), [INFO] [stdout] 67 | | transport: Box::new(self), [INFO] [stdout] 68 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/transport/utils.rs:72:18 [INFO] [stdout] | [INFO] [stdout] 71 | fn delay(self, delay_secs: D) -> Box { [INFO] [stdout] | ---- ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 72 | Box::new(TransportWithDelay { [INFO] [stdout] | __________________^ [INFO] [stdout] 73 | | delay_secs, [INFO] [stdout] 74 | | transport: Box::new(self), [INFO] [stdout] 75 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/transport/utils.rs:105:94 [INFO] [stdout] | [INFO] [stdout] 105 | async fn send(&mut self, to: SocketAddr, message: ChitchatMessage) -> anyhow::Result<()> { [INFO] [stdout] | ______________________________________________------------------------________________________^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 106 | | let should_drop = self.drop_probability.sample(&mut self.rng); [INFO] [stdout] 107 | | if should_drop { [INFO] [stdout] 108 | | return Ok(()); [INFO] [stdout] 109 | | } [INFO] [stdout] 110 | | self.socket.send(to, message).await [INFO] [stdout] 111 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 9 previous errors; 1 warning emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `chitchat` (lib) due to 10 previous errors; 1 warning emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] running `Command { std: "docker" "inspect" "e9e2223e92b551bafb51c158871c2a2f8fe6e348bc052d36d4ea90685bedc181", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "e9e2223e92b551bafb51c158871c2a2f8fe6e348bc052d36d4ea90685bedc181", kill_on_drop: false }` [INFO] [stdout] e9e2223e92b551bafb51c158871c2a2f8fe6e348bc052d36d4ea90685bedc181