[INFO] fetching crate chessagon 0.1.0... [INFO] checking chessagon-0.1.0 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate chessagon 0.1.0 into /workspace/builds/worker-2-tc2/source [INFO] validating manifest of crates.io crate chessagon 0.1.0 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate chessagon 0.1.0 [INFO] finished tweaking crates.io crate chessagon 0.1.0 [INFO] tweaked toml for crates.io crate chessagon 0.1.0 written to /workspace/builds/worker-2-tc2/source/Cargo.toml [INFO] crate crates.io crate chessagon 0.1.0 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] b0bcd6f82d714bf4e1ac4cb558c39ce743490ed75a4a907615c86e93598ff787 [INFO] running `Command { std: "docker" "start" "-a" "b0bcd6f82d714bf4e1ac4cb558c39ce743490ed75a4a907615c86e93598ff787", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "b0bcd6f82d714bf4e1ac4cb558c39ce743490ed75a4a907615c86e93598ff787", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "b0bcd6f82d714bf4e1ac4cb558c39ce743490ed75a4a907615c86e93598ff787", kill_on_drop: false }` [INFO] [stdout] b0bcd6f82d714bf4e1ac4cb558c39ce743490ed75a4a907615c86e93598ff787 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 28fd888a1ca7597119bf9b4467262ffb8ea6fe88b2c722d379f903e4bfa32484 [INFO] running `Command { std: "docker" "start" "-a" "28fd888a1ca7597119bf9b4467262ffb8ea6fe88b2c722d379f903e4bfa32484", kill_on_drop: false }` [INFO] [stderr] Compiling proc-macro2 v1.0.69 [INFO] [stderr] Compiling wasm-bindgen-shared v0.2.87 [INFO] [stderr] Compiling once_cell v1.18.0 [INFO] [stderr] Compiling bumpalo v3.14.0 [INFO] [stderr] Compiling log v0.4.20 [INFO] [stderr] Compiling wasm-bindgen v0.2.87 [INFO] [stderr] Compiling peg-runtime v0.8.2 [INFO] [stderr] Compiling thiserror v1.0.50 [INFO] [stderr] Checking annotate-snippets v0.6.1 [INFO] [stderr] Checking chic v1.2.2 [INFO] [stderr] Compiling quote v1.0.33 [INFO] [stderr] Compiling syn v2.0.38 [INFO] [stderr] Compiling syn v1.0.109 [INFO] [stderr] Compiling peg-macros v0.8.2 [INFO] [stderr] Checking peg v0.8.2 [INFO] [stderr] Compiling derive_more v0.99.17 [INFO] [stderr] Compiling wasm-bindgen-backend v0.2.87 [INFO] [stderr] Compiling thiserror-impl v1.0.50 [INFO] [stderr] Compiling enum_dispatch v0.3.12 [INFO] [stderr] Compiling wasm-bindgen-macro-support v0.2.87 [INFO] [stderr] Compiling wasm-bindgen-macro v0.2.87 [INFO] [stderr] Checking js-sys v0.3.64 [INFO] [stderr] Checking chessagon v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: unused variable: `last_move` [INFO] [stdout] --> src/piece/pawn.rs:15:5 [INFO] [stdout] | [INFO] [stdout] 15 | last_move: Option<&Move>, [INFO] [stdout] | ^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_last_move` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `last_move` [INFO] [stdout] --> src/piece/pawn.rs:68:37 [INFO] [stdout] | [INFO] [stdout] 68 | pub fn last_move_enables_en_passant(last_move: &Move, board: &impl BoardTrait) -> bool { [INFO] [stdout] | ^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_last_move` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `board` [INFO] [stdout] --> src/piece/pawn.rs:68:55 [INFO] [stdout] | [INFO] [stdout] 68 | pub fn last_move_enables_en_passant(last_move: &Move, board: &impl BoardTrait) -> bool { [INFO] [stdout] | ^^^^^ help: if this is intentional, prefix it with an underscore: `_board` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/board/mod.rs:189:18 [INFO] [stdout] | [INFO] [stdout] 189 | Lazy::new(|| position_iter().collect()) [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/board/mod.rs:244:5 [INFO] [stdout] | [INFO] [stdout] 242 | pieces: impl Iterator, [INFO] [stdout] | --------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 243 | ) -> impl Iterator + { [INFO] [stdout] 244 | / pieces [INFO] [stdout] 245 | | .filter(move |piece| piece.color == color.opposite()) [INFO] [stdout] | |_____________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/board/standard.rs:33:36 [INFO] [stdout] | [INFO] [stdout] 33 | .flat_map(move |piece| super::position_iter().filter_map(move |position| { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/moves/parse.rs:62:5 [INFO] [stdout] | [INFO] [stdout] 58 | fn use_parser(peg_parser: F, input: &str) -> Result [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 62 | peg_parser(input).map_err(|peg_err| ParseError { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `last_move` [INFO] [stdout] --> src/piece/pawn.rs:15:5 [INFO] [stdout] | [INFO] [stdout] 15 | last_move: Option<&Move>, [INFO] [stdout] | ^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_last_move` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `last_move` [INFO] [stdout] --> src/piece/pawn.rs:68:37 [INFO] [stdout] | [INFO] [stdout] 68 | pub fn last_move_enables_en_passant(last_move: &Move, board: &impl BoardTrait) -> bool { [INFO] [stdout] | ^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_last_move` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `board` [INFO] [stdout] --> src/piece/pawn.rs:68:55 [INFO] [stdout] | [INFO] [stdout] 68 | pub fn last_move_enables_en_passant(last_move: &Move, board: &impl BoardTrait) -> bool { [INFO] [stdout] | ^^^^^ help: if this is intentional, prefix it with an underscore: `_board` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 4 previous errors; 3 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `chessagon` (lib) due to 5 previous errors; 3 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/board/mod.rs:189:18 [INFO] [stdout] | [INFO] [stdout] 189 | Lazy::new(|| position_iter().collect()) [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/board/mod.rs:244:5 [INFO] [stdout] | [INFO] [stdout] 242 | pieces: impl Iterator, [INFO] [stdout] | --------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 243 | ) -> impl Iterator + { [INFO] [stdout] 244 | / pieces [INFO] [stdout] 245 | | .filter(move |piece| piece.color == color.opposite()) [INFO] [stdout] | |_____________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/board/standard.rs:33:36 [INFO] [stdout] | [INFO] [stdout] 33 | .flat_map(move |piece| super::position_iter().filter_map(move |position| { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/moves/parse.rs:62:5 [INFO] [stdout] | [INFO] [stdout] 58 | fn use_parser(peg_parser: F, input: &str) -> Result [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 62 | peg_parser(input).map_err(|peg_err| ParseError { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 4 previous errors; 3 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `chessagon` (lib test) due to 5 previous errors; 3 warnings emitted [INFO] running `Command { std: "docker" "inspect" "28fd888a1ca7597119bf9b4467262ffb8ea6fe88b2c722d379f903e4bfa32484", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "28fd888a1ca7597119bf9b4467262ffb8ea6fe88b2c722d379f903e4bfa32484", kill_on_drop: false }` [INFO] [stdout] 28fd888a1ca7597119bf9b4467262ffb8ea6fe88b2c722d379f903e4bfa32484