[INFO] fetching crate chd 0.3.2... [INFO] checking chd-0.3.2 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate chd 0.3.2 into /workspace/builds/worker-0-tc2/source [INFO] validating manifest of crates.io crate chd 0.3.2 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate chd 0.3.2 [INFO] finished tweaking crates.io crate chd 0.3.2 [INFO] tweaked toml for crates.io crate chd 0.3.2 written to /workspace/builds/worker-0-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 49 packages to latest compatible versions [INFO] [stderr] Adding derive_more v0.99.18 (latest: v1.0.0) [INFO] [stderr] Adding ext-trait v1.0.1 (latest: v2.0.0) [INFO] [stderr] Adding ext-trait-proc_macros v1.0.1 (latest: v2.0.0) [INFO] [stderr] Adding extension-traits v1.0.1 (latest: v2.0.0) [INFO] [stderr] Adding macro_rules_attribute v0.1.3 (latest: v0.2.0) [INFO] [stderr] Adding macro_rules_attribute-proc_macro v0.1.3 (latest: v0.2.0) [INFO] [stderr] Adding polonius-the-crab v0.2.1 (latest: v0.4.1) [INFO] [stderr] Adding ruzstd v0.6.0 (latest: v0.7.1) [INFO] [stderr] Adding syn v1.0.109 (latest: v2.0.77) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 8841ea09c2e9f19b6afb76588ba75a7000ba48f90ad58e760a9c2f8fc2e958e5 [INFO] running `Command { std: "docker" "start" "-a" "8841ea09c2e9f19b6afb76588ba75a7000ba48f90ad58e760a9c2f8fc2e958e5", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "8841ea09c2e9f19b6afb76588ba75a7000ba48f90ad58e760a9c2f8fc2e958e5", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "8841ea09c2e9f19b6afb76588ba75a7000ba48f90ad58e760a9c2f8fc2e958e5", kill_on_drop: false }` [INFO] [stdout] 8841ea09c2e9f19b6afb76588ba75a7000ba48f90ad58e760a9c2f8fc2e958e5 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 3471078caa02c3909561bc12d0d451ce9b4bc3b43c0ca491edbeedbf550b340a [INFO] running `Command { std: "docker" "start" "-a" "3471078caa02c3909561bc12d0d451ce9b4bc3b43c0ca491edbeedbf550b340a", kill_on_drop: false }` [INFO] [stderr] Checking crc-catalog v2.4.0 [INFO] [stderr] Checking text_io v0.1.12 [INFO] [stderr] Checking take_mut v0.2.2 [INFO] [stderr] Checking claxon v0.4.3 [INFO] [stderr] Checking bencher v0.1.5 [INFO] [stderr] Checking twox-hash v1.6.3 [INFO] [stderr] Checking bitreader v0.3.8 [INFO] [stderr] Checking flate2 v1.0.33 [INFO] [stderr] Compiling syn v2.0.77 [INFO] [stderr] Checking crc v3.2.1 [INFO] [stderr] Checking lzma-rs-perf-exp v0.2.1 [INFO] [stderr] Compiling derive_more v0.99.18 [INFO] [stderr] Compiling num-derive v0.4.2 [INFO] [stderr] Checking ruzstd v0.6.0 [INFO] [stderr] Checking chd v0.3.2 (/opt/rustwide/workdir) [INFO] [stdout] warning: unexpected `cfg` condition value: `nonstandard_channel_count` [INFO] [stdout] --> src/compression/flac.rs:64:31 [INFO] [stdout] | [INFO] [stdout] 64 | #[cfg(not(feature = "nonstandard_channel_count"))] [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: expected values for `feature` are: `cd_full`, `codec_api`, `default`, `fast_lzma`, `fast_zlib`, `fast_zstd`, `huffman_api`, `lending-iterator`, `max_perf`, `nougat`, `std`, `unstable_lending_iterators`, `verify_block_crc`, `want_raw_data_sector`, `want_subcode`, and `zstd-safe` [INFO] [stdout] = help: consider adding `nonstandard_channel_count` as a feature in `Cargo.toml` [INFO] [stdout] = note: see for more information about checking conditional configuration [INFO] [stdout] = note: `#[warn(unexpected_cfgs)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unexpected `cfg` condition value: `nonstandard_channel_count` [INFO] [stdout] --> src/compression/flac.rs:74:27 [INFO] [stdout] | [INFO] [stdout] 74 | #[cfg(feature = "nonstandard_channel_count")] [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: expected values for `feature` are: `cd_full`, `codec_api`, `default`, `fast_lzma`, `fast_zlib`, `fast_zstd`, `huffman_api`, `lending-iterator`, `max_perf`, `nougat`, `std`, `unstable_lending_iterators`, `verify_block_crc`, `want_raw_data_sector`, `want_subcode`, and `zstd-safe` [INFO] [stdout] = help: consider adding `nonstandard_channel_count` as a feature in `Cargo.toml` [INFO] [stdout] = note: see for more information about checking conditional configuration [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unexpected `cfg` condition value: `write` [INFO] [stdout] --> src/huffman.rs:58:11 [INFO] [stdout] | [INFO] [stdout] 58 | #[cfg(feature = "write")] [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: expected values for `feature` are: `cd_full`, `codec_api`, `default`, `fast_lzma`, `fast_zlib`, `fast_zstd`, `huffman_api`, `lending-iterator`, `max_perf`, `nougat`, `std`, `unstable_lending_iterators`, `verify_block_crc`, `want_raw_data_sector`, `want_subcode`, and `zstd-safe` [INFO] [stdout] = help: consider adding `write` as a feature in `Cargo.toml` [INFO] [stdout] = note: see for more information about checking conditional configuration [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unexpected `cfg` condition value: `write` [INFO] [stdout] --> src/huffman.rs:60:11 [INFO] [stdout] | [INFO] [stdout] 60 | #[cfg(feature = "write")] [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: expected values for `feature` are: `cd_full`, `codec_api`, `default`, `fast_lzma`, `fast_zlib`, `fast_zstd`, `huffman_api`, `lending-iterator`, `max_perf`, `nougat`, `std`, `unstable_lending_iterators`, `verify_block_crc`, `want_raw_data_sector`, `want_subcode`, and `zstd-safe` [INFO] [stdout] = help: consider adding `write` as a feature in `Cargo.toml` [INFO] [stdout] = note: see for more information about checking conditional configuration [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unexpected `cfg` condition value: `write` [INFO] [stdout] --> src/huffman.rs:62:11 [INFO] [stdout] | [INFO] [stdout] 62 | #[cfg(feature = "write")] [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: expected values for `feature` are: `cd_full`, `codec_api`, `default`, `fast_lzma`, `fast_zlib`, `fast_zstd`, `huffman_api`, `lending-iterator`, `max_perf`, `nougat`, `std`, `unstable_lending_iterators`, `verify_block_crc`, `want_raw_data_sector`, `want_subcode`, and `zstd-safe` [INFO] [stdout] = help: consider adding `write` as a feature in `Cargo.toml` [INFO] [stdout] = note: see for more information about checking conditional configuration [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unexpected `cfg` condition value: `unsound_owning_iterators` [INFO] [stdout] --> src/lib.rs:231:11 [INFO] [stdout] | [INFO] [stdout] 231 | #[cfg(feature = "unsound_owning_iterators")] [INFO] [stdout] | ^^^^^^^^^^-------------------------- [INFO] [stdout] | | [INFO] [stdout] | help: there is a expected value with a similar name: `"unstable_lending_iterators"` [INFO] [stdout] | [INFO] [stdout] = note: expected values for `feature` are: `cd_full`, `codec_api`, `default`, `fast_lzma`, `fast_zlib`, `fast_zstd`, `huffman_api`, `lending-iterator`, `max_perf`, `nougat`, `std`, `unstable_lending_iterators`, `verify_block_crc`, `want_raw_data_sector`, `want_subcode`, and `zstd-safe` [INFO] [stdout] = help: consider adding `unsound_owning_iterators` as a feature in `Cargo.toml` [INFO] [stdout] = note: see for more information about checking conditional configuration [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unexpected `cfg` condition value: `nonstandard_channel_count` [INFO] [stdout] --> src/compression/flac.rs:64:31 [INFO] [stdout] | [INFO] [stdout] 64 | #[cfg(not(feature = "nonstandard_channel_count"))] [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: expected values for `feature` are: `cd_full`, `codec_api`, `default`, `fast_lzma`, `fast_zlib`, `fast_zstd`, `huffman_api`, `lending-iterator`, `max_perf`, `nougat`, `std`, `unstable_lending_iterators`, `verify_block_crc`, `want_raw_data_sector`, `want_subcode`, and `zstd-safe` [INFO] [stdout] = help: consider adding `nonstandard_channel_count` as a feature in `Cargo.toml` [INFO] [stdout] = note: see for more information about checking conditional configuration [INFO] [stdout] = note: `#[warn(unexpected_cfgs)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unexpected `cfg` condition value: `unsound_owning_iterators` [INFO] [stdout] --> src/lib.rs:276:11 [INFO] [stdout] | [INFO] [stdout] 276 | #[cfg(feature = "unsound_owning_iterators")] [INFO] [stdout] | ^^^^^^^^^^-------------------------- [INFO] [stdout] | | [INFO] [stdout] | help: there is a expected value with a similar name: `"unstable_lending_iterators"` [INFO] [stdout] | [INFO] [stdout] = note: expected values for `feature` are: `cd_full`, `codec_api`, `default`, `fast_lzma`, `fast_zlib`, `fast_zstd`, `huffman_api`, `lending-iterator`, `max_perf`, `nougat`, `std`, `unstable_lending_iterators`, `verify_block_crc`, `want_raw_data_sector`, `want_subcode`, and `zstd-safe` [INFO] [stdout] = help: consider adding `unsound_owning_iterators` as a feature in `Cargo.toml` [INFO] [stdout] = note: see for more information about checking conditional configuration [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unexpected `cfg` condition value: `nonstandard_channel_count` [INFO] [stdout] --> src/compression/flac.rs:74:27 [INFO] [stdout] | [INFO] [stdout] 74 | #[cfg(feature = "nonstandard_channel_count")] [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: expected values for `feature` are: `cd_full`, `codec_api`, `default`, `fast_lzma`, `fast_zlib`, `fast_zstd`, `huffman_api`, `lending-iterator`, `max_perf`, `nougat`, `std`, `unstable_lending_iterators`, `verify_block_crc`, `want_raw_data_sector`, `want_subcode`, and `zstd-safe` [INFO] [stdout] = help: consider adding `nonstandard_channel_count` as a feature in `Cargo.toml` [INFO] [stdout] = note: see for more information about checking conditional configuration [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unexpected `cfg` condition value: `write` [INFO] [stdout] --> src/huffman.rs:58:11 [INFO] [stdout] | [INFO] [stdout] 58 | #[cfg(feature = "write")] [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: expected values for `feature` are: `cd_full`, `codec_api`, `default`, `fast_lzma`, `fast_zlib`, `fast_zstd`, `huffman_api`, `lending-iterator`, `max_perf`, `nougat`, `std`, `unstable_lending_iterators`, `verify_block_crc`, `want_raw_data_sector`, `want_subcode`, and `zstd-safe` [INFO] [stdout] = help: consider adding `write` as a feature in `Cargo.toml` [INFO] [stdout] = note: see for more information about checking conditional configuration [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unexpected `cfg` condition value: `write` [INFO] [stdout] --> src/huffman.rs:60:11 [INFO] [stdout] | [INFO] [stdout] 60 | #[cfg(feature = "write")] [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: expected values for `feature` are: `cd_full`, `codec_api`, `default`, `fast_lzma`, `fast_zlib`, `fast_zstd`, `huffman_api`, `lending-iterator`, `max_perf`, `nougat`, `std`, `unstable_lending_iterators`, `verify_block_crc`, `want_raw_data_sector`, `want_subcode`, and `zstd-safe` [INFO] [stdout] = help: consider adding `write` as a feature in `Cargo.toml` [INFO] [stdout] = note: see for more information about checking conditional configuration [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unexpected `cfg` condition value: `write` [INFO] [stdout] --> src/huffman.rs:62:11 [INFO] [stdout] | [INFO] [stdout] 62 | #[cfg(feature = "write")] [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: expected values for `feature` are: `cd_full`, `codec_api`, `default`, `fast_lzma`, `fast_zlib`, `fast_zstd`, `huffman_api`, `lending-iterator`, `max_perf`, `nougat`, `std`, `unstable_lending_iterators`, `verify_block_crc`, `want_raw_data_sector`, `want_subcode`, and `zstd-safe` [INFO] [stdout] = help: consider adding `write` as a feature in `Cargo.toml` [INFO] [stdout] = note: see for more information about checking conditional configuration [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `codec_type` is never used [INFO] [stdout] --> src/compression/mod.rs:37:8 [INFO] [stdout] | [INFO] [stdout] 34 | pub trait CompressionCodecType { [INFO] [stdout] | -------------------- method in this trait [INFO] [stdout] ... [INFO] [stdout] 37 | fn codec_type(&self) -> CodecType [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: methods `clear_ecc` and `verify_ecc` are never used [INFO] [stdout] --> src/compression/ecc.rs:744:8 [INFO] [stdout] | [INFO] [stdout] 742 | pub(crate) trait ErrorCorrectedSector { [INFO] [stdout] | -------------------- methods in this trait [INFO] [stdout] 743 | /// Reset the ECC P and Q codes to 0 within a sector [INFO] [stdout] 744 | fn clear_ecc(&mut self); [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 750 | fn verify_ecc(&self) -> bool; [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/chdfile.rs:66:12 [INFO] [stdout] | [INFO] [stdout] 45 | pub fn open(mut file: F, parent: Option>>) -> Result> { [INFO] [stdout] | ----------- --------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 64 | let codecs = AssertUnwindSafe(header.create_compression_codecs()?); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 65 | [INFO] [stdout] 66 | Ok(Chd { [INFO] [stdout] | ____________^ [INFO] [stdout] 67 | | file, [INFO] [stdout] 68 | | header, [INFO] [stdout] 69 | | parent, [INFO] [stdout] 70 | | map, [INFO] [stdout] 71 | | codecs, [INFO] [stdout] 72 | | }) [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/header.rs:75:51 [INFO] [stdout] | [INFO] [stdout] 75 | NoneCodec::new(hunk_size).map(|x| Box::new(x) as Box) [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/header.rs:78:51 [INFO] [stdout] | [INFO] [stdout] 78 | ZlibCodec::new(hunk_size).map(|x| Box::new(x) as Box) [INFO] [stdout] | - ^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/header.rs:81:53 [INFO] [stdout] | [INFO] [stdout] 81 | CdZlibCodec::new(hunk_size).map(|x| Box::new(x) as Box) [INFO] [stdout] | - ^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/header.rs:84:53 [INFO] [stdout] | [INFO] [stdout] 84 | CdLzmaCodec::new(hunk_size).map(|x| Box::new(x) as Box) [INFO] [stdout] | - ^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/header.rs:87:53 [INFO] [stdout] | [INFO] [stdout] 87 | CdFlacCodec::new(hunk_size).map(|x| Box::new(x) as Box) [INFO] [stdout] | - ^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/header.rs:90:51 [INFO] [stdout] | [INFO] [stdout] 90 | LzmaCodec::new(hunk_size).map(|x| Box::new(x) as Box) [INFO] [stdout] | - ^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/header.rs:93:54 [INFO] [stdout] | [INFO] [stdout] 93 | RawFlacCodec::new(hunk_size).map(|x| Box::new(x) as Box) [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/header.rs:96:54 [INFO] [stdout] | [INFO] [stdout] 96 | HuffmanCodec::new(hunk_size).map(|x| Box::new(x) as Box) [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/header.rs:99:53 [INFO] [stdout] | [INFO] [stdout] 99 | AVHuffCodec::new(hunk_size).map(|x| Box::new(x) as Box) [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/header.rs:102:51 [INFO] [stdout] | [INFO] [stdout] 102 | ZstdCodec::new(hunk_size).map(|x| Box::new(x) as Box) [INFO] [stdout] | - ^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/header.rs:105:53 [INFO] [stdout] | [INFO] [stdout] 105 | CdZstdCodec::new(hunk_size).map(|x| Box::new(x) as Box) [INFO] [stdout] | - ^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:217:9 [INFO] [stdout] | [INFO] [stdout] 210 | let mut f = BufReader::new(File::open(".testimages/Test.chd").expect("")); [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 211 | let chd = Chd::open(&mut f, None).expect("file"); [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 212 | let mut read = ChdReader::new(chd); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 216 | let mut f_out = File::create(".testimages/out.bin").expect(""); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 217 | f_out.write_all(&buf).expect("did not write") [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 13 previous errors; 9 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `chd` (lib test) due to 14 previous errors; 9 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] warning: method `codec_type` is never used [INFO] [stdout] --> src/compression/mod.rs:37:8 [INFO] [stdout] | [INFO] [stdout] 34 | pub trait CompressionCodecType { [INFO] [stdout] | -------------------- method in this trait [INFO] [stdout] ... [INFO] [stdout] 37 | fn codec_type(&self) -> CodecType [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: methods `clear_ecc` and `verify_ecc` are never used [INFO] [stdout] --> src/compression/ecc.rs:744:8 [INFO] [stdout] | [INFO] [stdout] 742 | pub(crate) trait ErrorCorrectedSector { [INFO] [stdout] | -------------------- methods in this trait [INFO] [stdout] 743 | /// Reset the ECC P and Q codes to 0 within a sector [INFO] [stdout] 744 | fn clear_ecc(&mut self); [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 750 | fn verify_ecc(&self) -> bool; [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/chdfile.rs:66:12 [INFO] [stdout] | [INFO] [stdout] 45 | pub fn open(mut file: F, parent: Option>>) -> Result> { [INFO] [stdout] | ----------- --------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 64 | let codecs = AssertUnwindSafe(header.create_compression_codecs()?); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 65 | [INFO] [stdout] 66 | Ok(Chd { [INFO] [stdout] | ____________^ [INFO] [stdout] 67 | | file, [INFO] [stdout] 68 | | header, [INFO] [stdout] 69 | | parent, [INFO] [stdout] 70 | | map, [INFO] [stdout] 71 | | codecs, [INFO] [stdout] 72 | | }) [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/header.rs:75:51 [INFO] [stdout] | [INFO] [stdout] 75 | NoneCodec::new(hunk_size).map(|x| Box::new(x) as Box) [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/header.rs:78:51 [INFO] [stdout] | [INFO] [stdout] 78 | ZlibCodec::new(hunk_size).map(|x| Box::new(x) as Box) [INFO] [stdout] | - ^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/header.rs:81:53 [INFO] [stdout] | [INFO] [stdout] 81 | CdZlibCodec::new(hunk_size).map(|x| Box::new(x) as Box) [INFO] [stdout] | - ^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/header.rs:84:53 [INFO] [stdout] | [INFO] [stdout] 84 | CdLzmaCodec::new(hunk_size).map(|x| Box::new(x) as Box) [INFO] [stdout] | - ^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/header.rs:87:53 [INFO] [stdout] | [INFO] [stdout] 87 | CdFlacCodec::new(hunk_size).map(|x| Box::new(x) as Box) [INFO] [stdout] | - ^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/header.rs:90:51 [INFO] [stdout] | [INFO] [stdout] 90 | LzmaCodec::new(hunk_size).map(|x| Box::new(x) as Box) [INFO] [stdout] | - ^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/header.rs:93:54 [INFO] [stdout] | [INFO] [stdout] 93 | RawFlacCodec::new(hunk_size).map(|x| Box::new(x) as Box) [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/header.rs:96:54 [INFO] [stdout] | [INFO] [stdout] 96 | HuffmanCodec::new(hunk_size).map(|x| Box::new(x) as Box) [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/header.rs:99:53 [INFO] [stdout] | [INFO] [stdout] 99 | AVHuffCodec::new(hunk_size).map(|x| Box::new(x) as Box) [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/header.rs:102:51 [INFO] [stdout] | [INFO] [stdout] 102 | ZstdCodec::new(hunk_size).map(|x| Box::new(x) as Box) [INFO] [stdout] | - ^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/header.rs:105:53 [INFO] [stdout] | [INFO] [stdout] 105 | CdZstdCodec::new(hunk_size).map(|x| Box::new(x) as Box) [INFO] [stdout] | - ^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 12 previous errors; 7 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `chd` (lib) due to 13 previous errors; 7 warnings emitted [INFO] running `Command { std: "docker" "inspect" "3471078caa02c3909561bc12d0d451ce9b4bc3b43c0ca491edbeedbf550b340a", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "3471078caa02c3909561bc12d0d451ce9b4bc3b43c0ca491edbeedbf550b340a", kill_on_drop: false }` [INFO] [stdout] 3471078caa02c3909561bc12d0d451ce9b4bc3b43c0ca491edbeedbf550b340a