[INFO] fetching crate chatd 0.2.0... [INFO] checking chatd-0.2.0 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate chatd 0.2.0 into /workspace/builds/worker-0-tc2/source [INFO] validating manifest of crates.io crate chatd 0.2.0 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate chatd 0.2.0 [INFO] finished tweaking crates.io crate chatd 0.2.0 [INFO] tweaked toml for crates.io crate chatd 0.2.0 written to /workspace/builds/worker-0-tc2/source/Cargo.toml [INFO] crate crates.io crate chatd 0.2.0 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 5b6bfc4cc85089b88c7465187a1b385cbe48fb91dcfe2397fa69e0f649580537 [INFO] running `Command { std: "docker" "start" "-a" "5b6bfc4cc85089b88c7465187a1b385cbe48fb91dcfe2397fa69e0f649580537", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "5b6bfc4cc85089b88c7465187a1b385cbe48fb91dcfe2397fa69e0f649580537", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "5b6bfc4cc85089b88c7465187a1b385cbe48fb91dcfe2397fa69e0f649580537", kill_on_drop: false }` [INFO] [stdout] 5b6bfc4cc85089b88c7465187a1b385cbe48fb91dcfe2397fa69e0f649580537 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 0f7ac7ef028377be7cb68122fefb545b9e440e508f07d49d6f45bd7d6a14fc1e [INFO] running `Command { std: "docker" "start" "-a" "0f7ac7ef028377be7cb68122fefb545b9e440e508f07d49d6f45bd7d6a14fc1e", kill_on_drop: false }` [INFO] [stderr] Checking subtle v2.6.1 [INFO] [stderr] Checking const-oid v0.9.6 [INFO] [stderr] Checking base64ct v1.6.0 [INFO] [stderr] Compiling serde v1.0.205 [INFO] [stderr] Compiling generic-array v0.14.7 [INFO] [stderr] Compiling num-traits v0.2.19 [INFO] [stderr] Compiling syn v2.0.72 [INFO] [stderr] Compiling rustc_version v0.4.0 [INFO] [stderr] Checking futures-io v0.3.30 [INFO] [stderr] Checking anstyle v1.0.8 [INFO] [stderr] Compiling num-bigint-dig v0.8.4 [INFO] [stderr] Checking regex-automata v0.4.7 [INFO] [stderr] Checking lazy_static v1.5.0 [INFO] [stderr] Compiling rustix v0.38.34 [INFO] [stderr] Compiling signal-hook v0.3.17 [INFO] [stderr] Compiling heck v0.5.0 [INFO] [stderr] Checking option-ext v0.2.0 [INFO] [stderr] Checking anstyle-parse v0.2.5 [INFO] [stderr] Checking colorchoice v1.0.2 [INFO] [stderr] Checking dirs-sys v0.4.1 [INFO] [stderr] Checking is_terminal_polyfill v1.70.1 [INFO] [stderr] Checking destructure_traitobject v0.2.0 [INFO] [stderr] Compiling serde_json v1.0.122 [INFO] [stderr] Checking ff v0.13.0 [INFO] [stderr] Checking anstyle-query v1.1.1 [INFO] [stderr] Checking pem-rfc7468 v0.7.0 [INFO] [stderr] Checking password-hash v0.4.2 [INFO] [stderr] Compiling portable-atomic v1.7.0 [INFO] [stderr] Checking indexmap v2.3.0 [INFO] [stderr] Checking dirs v5.0.1 [INFO] [stderr] Checking unsafe-any-ors v1.0.0 [INFO] [stderr] Checking anstream v0.6.15 [INFO] [stderr] Checking der v0.7.9 [INFO] [stderr] Compiling syn v1.0.109 [INFO] [stderr] Checking group v0.13.0 [INFO] [stderr] Checking russh-cryptovec v0.7.3 [INFO] [stderr] Checking raw-cpuid v11.1.0 [INFO] [stderr] Compiling mockall_derive v0.13.0 [INFO] [stderr] Compiling curve25519-dalek v4.1.3 [INFO] [stderr] Checking clap_lex v0.7.2 [INFO] [stderr] Checking md5 v0.7.0 [INFO] [stderr] Checking data-encoding v2.6.0 [INFO] [stderr] Checking strsim v0.11.1 [INFO] [stderr] Checking unsafe-libyaml v0.2.11 [INFO] [stderr] Checking predicates v3.1.2 [INFO] [stderr] Checking predicates-tree v1.0.11 [INFO] [stderr] Checking flate2 v1.0.31 [INFO] [stderr] Checking typemap-ors v1.0.0 [INFO] [stderr] Checking dashmap v5.5.3 [INFO] [stderr] Checking clap_builder v4.5.13 [INFO] [stderr] Checking spinning_top v0.3.0 [INFO] [stderr] Checking thread-id v4.2.2 [INFO] [stderr] Checking hex-literal v0.4.1 [INFO] [stderr] Checking crypto-common v0.1.6 [INFO] [stderr] Checking block-buffer v0.10.4 [INFO] [stderr] Checking block-padding v0.3.3 [INFO] [stderr] Checking universal-hash v0.5.1 [INFO] [stderr] Checking inout v0.1.3 [INFO] [stderr] Checking digest v0.10.7 [INFO] [stderr] Checking crypto-bigint v0.5.5 [INFO] [stderr] Checking polyval v0.6.2 [INFO] [stderr] Checking aead v0.5.2 [INFO] [stderr] Checking poly1305 v0.8.0 [INFO] [stderr] Checking cipher v0.4.4 [INFO] [stderr] Checking hmac v0.12.1 [INFO] [stderr] Checking sha2 v0.10.8 [INFO] [stderr] Checking aes v0.8.4 [INFO] [stderr] Checking cbc v0.1.2 [INFO] [stderr] Checking salsa20 v0.10.2 [INFO] [stderr] Checking spki v0.7.3 [INFO] [stderr] Checking signature v2.2.0 [INFO] [stderr] Checking ghash v0.5.1 [INFO] [stderr] Checking pbkdf2 v0.12.2 [INFO] [stderr] Checking hkdf v0.12.4 [INFO] [stderr] Checking num-integer v0.1.46 [INFO] [stderr] Checking rfc6979 v0.4.0 [INFO] [stderr] Checking ctr v0.9.2 [INFO] [stderr] Checking chacha20 v0.9.1 [INFO] [stderr] Checking blowfish v0.9.1 [INFO] [stderr] Checking ordered-float v2.10.1 [INFO] [stderr] Checking sha1 v0.10.6 [INFO] [stderr] Checking chrono v0.4.38 [INFO] [stderr] Checking quanta v0.12.3 [INFO] [stderr] Checking unic-common v0.9.0 [INFO] [stderr] Checking scrypt v0.11.0 [INFO] [stderr] Checking ssh-encoding v0.2.0 [INFO] [stderr] Checking bcrypt-pbkdf v0.10.0 [INFO] [stderr] Checking pbkdf2 v0.11.0 [INFO] [stderr] Checking arc-swap v1.7.1 [INFO] [stderr] Checking unic-char-range v0.9.0 [INFO] [stderr] Checking num-iter v0.1.45 [INFO] [stderr] Checking log-mdc v0.1.0 [INFO] [stderr] Checking no-std-compat v0.4.1 [INFO] [stderr] Checking nonzero_ext v0.3.0 [INFO] [stderr] Checking unic-ucd-version v0.9.0 [INFO] [stderr] Checking regex v1.10.6 [INFO] [stderr] Checking downcast v0.11.0 [INFO] [stderr] Checking unic-char-property v0.9.0 [INFO] [stderr] Checking unicode-segmentation v1.11.0 [INFO] [stderr] Checking circular-buffer v0.1.7 [INFO] [stderr] Checking terminal-keycode v1.1.1 [INFO] [stderr] Checking fragile v2.0.0 [INFO] [stderr] Checking unic-emoji-char v0.9.0 [INFO] [stderr] Checking pkcs5 v0.7.1 [INFO] [stderr] Checking aes-gcm v0.10.3 [INFO] [stderr] Checking ssh-cipher v0.2.0 [INFO] [stderr] Checking pkcs8 v0.10.2 [INFO] [stderr] Checking sec1 v0.7.3 [INFO] [stderr] Checking ed25519 v2.2.3 [INFO] [stderr] Checking pkcs1 v0.7.5 [INFO] [stderr] Checking elliptic-curve v0.13.8 [INFO] [stderr] Checking tempfile v3.12.0 [INFO] [stderr] Checking ecdsa v0.16.9 [INFO] [stderr] Checking primeorder v0.13.6 [INFO] [stderr] Checking p384 v0.13.0 [INFO] [stderr] Checking p256 v0.13.2 [INFO] [stderr] Checking p521 v0.13.3 [INFO] [stderr] Compiling derivative v2.2.0 [INFO] [stderr] Compiling serde_derive v1.0.205 [INFO] [stderr] Compiling zerocopy-derive v0.7.35 [INFO] [stderr] Compiling futures-macro v0.3.30 [INFO] [stderr] Compiling curve25519-dalek-derive v0.1.1 [INFO] [stderr] Compiling thiserror-impl v1.0.63 [INFO] [stderr] Compiling tokio-macros v2.4.0 [INFO] [stderr] Compiling async-trait v0.1.81 [INFO] [stderr] Compiling strum_macros v0.26.4 [INFO] [stderr] Compiling clap_derive v4.5.13 [INFO] [stderr] Compiling enum_dispatch v0.3.13 [INFO] [stderr] Checking zerocopy v0.7.35 [INFO] [stderr] Checking futures-util v0.3.30 [INFO] [stderr] Checking thiserror v1.0.63 [INFO] [stderr] Checking ppv-lite86 v0.2.20 [INFO] [stderr] Checking ed25519-dalek v2.1.1 [INFO] [stderr] Checking rand_chacha v0.3.1 [INFO] [stderr] Checking clap v4.5.13 [INFO] [stderr] Checking strum v0.26.3 [INFO] [stderr] Checking rand v0.8.5 [INFO] [stderr] Checking num-bigint v0.4.6 [INFO] [stderr] Checking mockall v0.13.0 [INFO] [stderr] Checking futures-executor v0.3.30 [INFO] [stderr] Checking futures v0.3.30 [INFO] [stderr] Checking rsa v0.9.6 [INFO] [stderr] Checking governor v0.6.3 [INFO] [stderr] Checking ssh-key v0.6.6 [INFO] [stderr] Checking log v0.4.22 [INFO] [stderr] Checking serde_yaml v0.9.34+deprecated [INFO] [stderr] Checking serde-value v0.7.0 [INFO] [stderr] Checking mio v1.0.1 [INFO] [stderr] Checking globset v0.4.14 [INFO] [stderr] Checking ignore v0.4.22 [INFO] [stderr] Checking tokio v1.39.2 [INFO] [stderr] Checking signal-hook-mio v0.2.4 [INFO] [stderr] Checking crossterm v0.28.1 [INFO] [stderr] Checking globwalk v0.9.1 [INFO] [stderr] Checking log4rs v1.3.0 [INFO] [stderr] Checking assert_fs v1.1.2 [INFO] [stderr] Checking tokio-stream v0.1.15 [INFO] [stderr] Checking russh-keys v0.44.0 [INFO] [stderr] Checking russh v0.44.0 [INFO] [stderr] Checking chatd v0.2.0 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/auth/pubkey_file_manager.rs:76:36 [INFO] [stdout] | [INFO] [stdout] 76 | .filter_map(|(_, key)| russh_keys::parse_public_key_base64(&key).ok()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/pubkey.rs:64:14 [INFO] [stdout] | [INFO] [stdout] 60 | let key_pair = KeyPair::generate_ed25519().unwrap(); [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 61 | let key = key_pair [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 64 | Self(key.into()) [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/server/server.rs:48:26 [INFO] [stdout] | [INFO] [stdout] 40 | repo_event_sender: Sender, [INFO] [stdout] | ------------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 41 | auth: Auth, [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 42 | room: ChatRoom, [INFO] [stdout] | -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 48 | server_keys: server_keys.to_vec(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/server/server.rs:49:19 [INFO] [stdout] | [INFO] [stdout] 40 | repo_event_sender: Sender, [INFO] [stdout] | ------------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 41 | auth: Auth, [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 42 | room: ChatRoom, [INFO] [stdout] | -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 49 | auth: Arc::new(Mutex::new(auth)), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/server/server.rs:50:19 [INFO] [stdout] | [INFO] [stdout] 40 | repo_event_sender: Sender, [INFO] [stdout] | ------------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 41 | auth: Auth, [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 42 | room: ChatRoom, [INFO] [stdout] | -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 50 | room: Arc::new(Mutex::new(room)), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/server/session/handler.rs:35:25 [INFO] [stdout] | [INFO] [stdout] 29 | auth: Arc>, [INFO] [stdout] | ---------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 30 | repo_event_sender: Sender, [INFO] [stdout] | ------------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 35 | public_key: None, [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/server/session/handler.rs:38:35 [INFO] [stdout] | [INFO] [stdout] 29 | auth: Arc>, [INFO] [stdout] | ---------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 30 | repo_event_sender: Sender, [INFO] [stdout] | ------------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 38 | session_event_sender: None, [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/server/session/handler.rs:61:36 [INFO] [stdout] | [INFO] [stdout] 59 | channel: Channel, [INFO] [stdout] | --------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 60 | session: &mut Session, [INFO] [stdout] 61 | ) -> Result { [INFO] [stdout] | ____________________________________^ [INFO] [stdout] 62 | | info!("Starting a new session id={}", self.id); [INFO] [stdout] 63 | | [INFO] [stdout] 64 | | let id = self.id; [INFO] [stdout] ... | [INFO] [stdout] 92 | | Ok(true) [INFO] [stdout] 93 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/server/session_workflow/command_parse.rs:26:19 [INFO] [stdout] | [INFO] [stdout] 24 | pub fn new(next: impl WorkflowHandler + 'static) -> Self { [INFO] [stdout] | --------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 25 | Self { [INFO] [stdout] 26 | next: into_next(next), [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/server/session_workflow/env_parse.rs:29:19 [INFO] [stdout] | [INFO] [stdout] 25 | pub fn new(name: String, value: String, next: impl WorkflowHandler + 'static) -> Self { [INFO] [stdout] | --------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 29 | next: into_next(next), [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/server/session_workflow/handler.rs:49:10 [INFO] [stdout] | [INFO] [stdout] 47 | handler: impl WorkflowHandler + Sized + 'static, [INFO] [stdout] | -------------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 48 | ) -> Option>> { [INFO] [stdout] 49 | Some(Box::new(handler)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/server/session_workflow/input_rate_checker.rs:25:19 [INFO] [stdout] | [INFO] [stdout] 23 | pub fn new(next: impl WorkflowHandler + 'static) -> Self { [INFO] [stdout] | --------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 24 | Self { [INFO] [stdout] 25 | next: into_next(next), [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/server/session_workflow/input_validator.rs:27:19 [INFO] [stdout] | [INFO] [stdout] 25 | pub fn new(next: impl WorkflowHandler + 'static) -> Self { [INFO] [stdout] | --------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 26 | Self { [INFO] [stdout] 27 | next: into_next(next), [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/terminal/terminal.rs:38:20 [INFO] [stdout] | [INFO] [stdout] 33 | pub fn new(handle: H) -> Self { [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 38 | input: Default::default(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 14 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `chatd` (bin "chatd") due to 15 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/auth/auth.rs:193:22 [INFO] [stdout] | [INFO] [stdout] 192 | let key_pair = russh_keys::key::KeyPair::generate_ed25519().unwrap(); [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 193 | PubKey::from(key_pair.clone_public_key().unwrap()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/auth/pubkey_file_manager.rs:76:36 [INFO] [stdout] | [INFO] [stdout] 76 | .filter_map(|(_, key)| russh_keys::parse_public_key_base64(&key).ok()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/auth/pubkey_file_manager.rs:115:22 [INFO] [stdout] | [INFO] [stdout] 114 | let key_pair = russh_keys::key::KeyPair::generate_ed25519().unwrap(); [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 115 | PubKey::from(key_pair.clone_public_key().unwrap()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/pubkey.rs:64:14 [INFO] [stdout] | [INFO] [stdout] 60 | let key_pair = KeyPair::generate_ed25519().unwrap(); [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 61 | let key = key_pair [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 64 | Self(key.into()) [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/pubkey.rs:75:9 [INFO] [stdout] | [INFO] [stdout] 74 | let key_pair = KeyPair::generate_ed25519().unwrap(); [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 75 | / key_pair [INFO] [stdout] 76 | | .clone_public_key() [INFO] [stdout] | |_______________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/server/server.rs:48:26 [INFO] [stdout] | [INFO] [stdout] 40 | repo_event_sender: Sender, [INFO] [stdout] | ------------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 41 | auth: Auth, [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 42 | room: ChatRoom, [INFO] [stdout] | -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 48 | server_keys: server_keys.to_vec(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/server/server.rs:49:19 [INFO] [stdout] | [INFO] [stdout] 40 | repo_event_sender: Sender, [INFO] [stdout] | ------------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 41 | auth: Auth, [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 42 | room: ChatRoom, [INFO] [stdout] | -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 49 | auth: Arc::new(Mutex::new(auth)), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/server/server.rs:50:19 [INFO] [stdout] | [INFO] [stdout] 40 | repo_event_sender: Sender, [INFO] [stdout] | ------------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 41 | auth: Auth, [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 42 | room: ChatRoom, [INFO] [stdout] | -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 50 | room: Arc::new(Mutex::new(room)), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/server/server.rs:110:58 [INFO] [stdout] | [INFO] [stdout] 107 | repository: SessionRepository, [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 108 | ) -> JoinHandle> { [INFO] [stdout] 109 | let mut server = chat_server.clone(); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 110 | tokio::spawn(async move { server.run(repository).await }) [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/server/session/handler.rs:35:25 [INFO] [stdout] | [INFO] [stdout] 29 | auth: Arc>, [INFO] [stdout] | ---------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 30 | repo_event_sender: Sender, [INFO] [stdout] | ------------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 35 | public_key: None, [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/server/session/handler.rs:38:35 [INFO] [stdout] | [INFO] [stdout] 29 | auth: Arc>, [INFO] [stdout] | ---------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 30 | repo_event_sender: Sender, [INFO] [stdout] | ------------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 38 | session_event_sender: None, [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/server/session/handler.rs:61:36 [INFO] [stdout] | [INFO] [stdout] 59 | channel: Channel, [INFO] [stdout] | --------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 60 | session: &mut Session, [INFO] [stdout] 61 | ) -> Result { [INFO] [stdout] | ____________________________________^ [INFO] [stdout] 62 | | info!("Starting a new session id={}", self.id); [INFO] [stdout] 63 | | [INFO] [stdout] 64 | | let id = self.id; [INFO] [stdout] ... | [INFO] [stdout] 92 | | Ok(true) [INFO] [stdout] 93 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/server/session/handler.rs:297:9 [INFO] [stdout] | [INFO] [stdout] 296 | let key_pair = russh_keys::key::KeyPair::generate_ed25519().unwrap(); [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 297 | key_pair.clone_public_key().unwrap() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/server/session/handler.rs:335:13 [INFO] [stdout] | [INFO] [stdout] 311 | async fn test_session(client_handler: CH, server_handler: SH, run_client: RC) [INFO] [stdout] | -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 328 | let server_config = Arc::new(config); [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 329 | let server_socket = tokio::net::TcpListener::bind("127.0.0.1:0").await.unwrap(); [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 334 | let (socket, _) = server_socket.accept().await.unwrap(); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 335 | / server::run_stream(server_config, socket, server_handler) [INFO] [stdout] 336 | | .await [INFO] [stdout] 337 | | .map_err(|_| ()) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |________________________________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/server/session_workflow/command_parse.rs:26:19 [INFO] [stdout] | [INFO] [stdout] 24 | pub fn new(next: impl WorkflowHandler + 'static) -> Self { [INFO] [stdout] | --------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 25 | Self { [INFO] [stdout] 26 | next: into_next(next), [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/server/session_workflow/env_parse.rs:29:19 [INFO] [stdout] | [INFO] [stdout] 25 | pub fn new(name: String, value: String, next: impl WorkflowHandler + 'static) -> Self { [INFO] [stdout] | --------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 29 | next: into_next(next), [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/server/session_workflow/handler.rs:49:10 [INFO] [stdout] | [INFO] [stdout] 47 | handler: impl WorkflowHandler + Sized + 'static, [INFO] [stdout] | -------------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 48 | ) -> Option>> { [INFO] [stdout] 49 | Some(Box::new(handler)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/server/session_workflow/input_rate_checker.rs:25:19 [INFO] [stdout] | [INFO] [stdout] 23 | pub fn new(next: impl WorkflowHandler + 'static) -> Self { [INFO] [stdout] | --------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 24 | Self { [INFO] [stdout] 25 | next: into_next(next), [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/server/session_workflow/input_validator.rs:27:19 [INFO] [stdout] | [INFO] [stdout] 25 | pub fn new(next: impl WorkflowHandler + 'static) -> Self { [INFO] [stdout] | --------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 26 | Self { [INFO] [stdout] 27 | next: into_next(next), [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/terminal/terminal.rs:38:20 [INFO] [stdout] | [INFO] [stdout] 33 | pub fn new(handle: H) -> Self { [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 38 | input: Default::default(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 20 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `chatd` (bin "chatd" test) due to 21 previous errors [INFO] running `Command { std: "docker" "inspect" "0f7ac7ef028377be7cb68122fefb545b9e440e508f07d49d6f45bd7d6a14fc1e", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "0f7ac7ef028377be7cb68122fefb545b9e440e508f07d49d6f45bd7d6a14fc1e", kill_on_drop: false }` [INFO] [stdout] 0f7ac7ef028377be7cb68122fefb545b9e440e508f07d49d6f45bd7d6a14fc1e