[INFO] fetching crate chash 0.1.0... [INFO] checking chash-0.1.0 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate chash 0.1.0 into /workspace/builds/worker-3-tc2/source [INFO] validating manifest of crates.io crate chash 0.1.0 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate chash 0.1.0 [INFO] finished tweaking crates.io crate chash 0.1.0 [INFO] tweaked toml for crates.io crate chash 0.1.0 written to /workspace/builds/worker-3-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 891de9c572dc5aeb5a158fef0ea5f159933fd525b8e30a2e11c5f8552a1313ff [INFO] running `Command { std: "docker" "start" "-a" "891de9c572dc5aeb5a158fef0ea5f159933fd525b8e30a2e11c5f8552a1313ff", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "891de9c572dc5aeb5a158fef0ea5f159933fd525b8e30a2e11c5f8552a1313ff", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "891de9c572dc5aeb5a158fef0ea5f159933fd525b8e30a2e11c5f8552a1313ff", kill_on_drop: false }` [INFO] [stdout] 891de9c572dc5aeb5a158fef0ea5f159933fd525b8e30a2e11c5f8552a1313ff [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 5972cc64a1598dc4e20018878cd4f3d4fe31bc67c67c906a2df0e2feeab5de6e [INFO] running `Command { std: "docker" "start" "-a" "5972cc64a1598dc4e20018878cd4f3d4fe31bc67c67c906a2df0e2feeab5de6e", kill_on_drop: false }` [INFO] [stderr] Checking chash v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:359:21 [INFO] [stdout] | [INFO] [stdout] 355 | pub fn with_config(config: HashRingConfig) -> Self { [INFO] [stdout] | ------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 356 | let storage = Arc::new(Mutex::new(HashRingStorage::default())); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 359 | config: Arc::new(config), [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:375:12 [INFO] [stdout] | [INFO] [stdout] 370 | let storage = self [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 375 | Ok(storage [INFO] [stdout] | ____________^ [INFO] [stdout] 376 | | .list_nodes() [INFO] [stdout] 377 | | .iter() [INFO] [stdout] 378 | | .filter_map(|n| match String::from_utf8(n.clone()) { [INFO] [stdout] ... | [INFO] [stdout] 384 | | }) [INFO] [stdout] 385 | | .collect()) [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |______________________| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:409:35 [INFO] [stdout] | [INFO] [stdout] 409 | .and_then(|s| s.parse::().ok()) [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:429:12 [INFO] [stdout] | [INFO] [stdout] 424 | let storage = self [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 429 | Ok(storage.load_distribution().iter().try_fold( [INFO] [stdout] | ____________^ [INFO] [stdout] 430 | | HashMap::new(), [INFO] [stdout] 431 | | |mut acc, (node, load)| match String::from_utf8(node.clone()) { [INFO] [stdout] 432 | | Ok(s) => match s.parse::() { [INFO] [stdout] ... | [INFO] [stdout] 447 | | }, [INFO] [stdout] 448 | | )?) [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |__________| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:598:12 [INFO] [stdout] | [INFO] [stdout] 579 | let storage = self [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 598 | Ok(nodes [INFO] [stdout] | ____________^ [INFO] [stdout] 599 | | .iter() [INFO] [stdout] 600 | | .filter_map(|n| match String::from_utf8(n.clone()) { [INFO] [stdout] 601 | | Ok(s) => match s.parse::() { [INFO] [stdout] ... | [INFO] [stdout] 606 | | }) [INFO] [stdout] 607 | | .collect()) [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |______________________| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 5 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `chash` (lib) due to 6 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:359:21 [INFO] [stdout] | [INFO] [stdout] 355 | pub fn with_config(config: HashRingConfig) -> Self { [INFO] [stdout] | ------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 356 | let storage = Arc::new(Mutex::new(HashRingStorage::default())); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 359 | config: Arc::new(config), [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:375:12 [INFO] [stdout] | [INFO] [stdout] 370 | let storage = self [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 375 | Ok(storage [INFO] [stdout] | ____________^ [INFO] [stdout] 376 | | .list_nodes() [INFO] [stdout] 377 | | .iter() [INFO] [stdout] 378 | | .filter_map(|n| match String::from_utf8(n.clone()) { [INFO] [stdout] ... | [INFO] [stdout] 384 | | }) [INFO] [stdout] 385 | | .collect()) [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |______________________| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:409:35 [INFO] [stdout] | [INFO] [stdout] 409 | .and_then(|s| s.parse::().ok()) [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:429:12 [INFO] [stdout] | [INFO] [stdout] 424 | let storage = self [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 429 | Ok(storage.load_distribution().iter().try_fold( [INFO] [stdout] | ____________^ [INFO] [stdout] 430 | | HashMap::new(), [INFO] [stdout] 431 | | |mut acc, (node, load)| match String::from_utf8(node.clone()) { [INFO] [stdout] 432 | | Ok(s) => match s.parse::() { [INFO] [stdout] ... | [INFO] [stdout] 447 | | }, [INFO] [stdout] 448 | | )?) [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |__________| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:598:12 [INFO] [stdout] | [INFO] [stdout] 579 | let storage = self [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 598 | Ok(nodes [INFO] [stdout] | ____________^ [INFO] [stdout] 599 | | .iter() [INFO] [stdout] 600 | | .filter_map(|n| match String::from_utf8(n.clone()) { [INFO] [stdout] 601 | | Ok(s) => match s.parse::() { [INFO] [stdout] ... | [INFO] [stdout] 606 | | }) [INFO] [stdout] 607 | | .collect()) [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |______________________| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 5 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `chash` (lib test) due to 6 previous errors [INFO] running `Command { std: "docker" "inspect" "5972cc64a1598dc4e20018878cd4f3d4fe31bc67c67c906a2df0e2feeab5de6e", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "5972cc64a1598dc4e20018878cd4f3d4fe31bc67c67c906a2df0e2feeab5de6e", kill_on_drop: false }` [INFO] [stdout] 5972cc64a1598dc4e20018878cd4f3d4fe31bc67c67c906a2df0e2feeab5de6e