[INFO] fetching crate changeforest 1.1.4... [INFO] checking changeforest-1.1.4 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate changeforest 1.1.4 into /workspace/builds/worker-1-tc2/source [INFO] validating manifest of crates.io crate changeforest 1.1.4 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate changeforest 1.1.4 [INFO] finished tweaking crates.io crate changeforest 1.1.4 [INFO] tweaked toml for crates.io crate changeforest 1.1.4 written to /workspace/builds/worker-1-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 66 packages to latest compatible versions [INFO] [stderr] Adding approx v0.4.0 (latest: v0.5.1) [INFO] [stderr] Adding ndarray v0.15.6 (latest: v0.16.1) [INFO] [stderr] Adding ndarray-rand v0.14.0 (latest: v0.15.0) [INFO] [stderr] Adding rstest v0.18.2 (latest: v0.22.0) [INFO] [stderr] Adding rstest_macros v0.18.2 (latest: v0.22.0) [INFO] [stderr] Adding wasi v0.11.0+wasi-snapshot-preview1 (latest: v0.13.2+wasi-0.2.1) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] f9f8db86fa32eb8a85165fcc274555ab4318a1e08dc6dec5c8effe3509ccba7d [INFO] running `Command { std: "docker" "start" "-a" "f9f8db86fa32eb8a85165fcc274555ab4318a1e08dc6dec5c8effe3509ccba7d", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "f9f8db86fa32eb8a85165fcc274555ab4318a1e08dc6dec5c8effe3509ccba7d", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "f9f8db86fa32eb8a85165fcc274555ab4318a1e08dc6dec5c8effe3509ccba7d", kill_on_drop: false }` [INFO] [stdout] f9f8db86fa32eb8a85165fcc274555ab4318a1e08dc6dec5c8effe3509ccba7d [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 9174b8d3a819cd5f643df56eea3ad4332d2a425291b93a2a91e36950edbd044b [INFO] running `Command { std: "docker" "start" "-a" "9174b8d3a819cd5f643df56eea3ad4332d2a425291b93a2a91e36950edbd044b", kill_on_drop: false }` [INFO] [stderr] Compiling autocfg v1.3.0 [INFO] [stderr] Compiling libm v0.2.8 [INFO] [stderr] Checking byteorder v1.5.0 [INFO] [stderr] Compiling crossbeam-utils v0.8.20 [INFO] [stderr] Compiling semver v1.0.23 [INFO] [stderr] Checking memchr v2.7.4 [INFO] [stderr] Checking rawpointer v0.2.1 [INFO] [stderr] Compiling rayon-core v1.12.1 [INFO] [stderr] Checking futures-core v0.3.30 [INFO] [stderr] Checking futures-sink v0.3.30 [INFO] [stderr] Compiling regex-syntax v0.8.4 [INFO] [stderr] Checking pin-project-lite v0.2.14 [INFO] [stderr] Checking pin-utils v0.1.0 [INFO] [stderr] Checking getrandom v0.2.15 [INFO] [stderr] Compiling syn v2.0.77 [INFO] [stderr] Checking futures-task v0.3.30 [INFO] [stderr] Checking either v1.13.0 [INFO] [stderr] Compiling serde v1.0.209 [INFO] [stderr] Checking futures-io v0.3.30 [INFO] [stderr] Checking futures-channel v0.3.30 [INFO] [stderr] Checking rand_core v0.6.4 [INFO] [stderr] Compiling relative-path v1.9.3 [INFO] [stderr] Compiling glob v0.3.1 [INFO] [stderr] Compiling cfg-if v1.0.0 [INFO] [stderr] Checking futures-timer v3.0.3 [INFO] [stderr] Checking assert_approx_eq v1.1.0 [INFO] [stderr] Compiling num-traits v0.2.19 [INFO] [stderr] Compiling matrixmultiply v0.3.9 [INFO] [stderr] Compiling slab v0.4.9 [INFO] [stderr] Compiling rustc_version v0.4.1 [INFO] [stderr] Checking crossbeam-epoch v0.9.18 [INFO] [stderr] Compiling rstest_macros v0.18.2 [INFO] [stderr] Checking csv-core v0.1.11 [INFO] [stderr] Compiling aho-corasick v1.1.3 [INFO] [stderr] Checking crossbeam-deque v0.8.5 [INFO] [stderr] Checking rayon v1.10.0 [INFO] [stderr] Checking num-complex v0.4.6 [INFO] [stderr] Checking approx v0.4.0 [INFO] [stderr] Checking num-integer v0.1.46 [INFO] [stderr] Compiling regex-automata v0.4.7 [INFO] [stderr] Checking ndarray v0.15.6 [INFO] [stderr] Checking csv v1.3.0 [INFO] [stderr] Compiling zerocopy-derive v0.7.35 [INFO] [stderr] Compiling futures-macro v0.3.30 [INFO] [stderr] Compiling regex v1.10.6 [INFO] [stderr] Checking futures-util v0.3.30 [INFO] [stderr] Checking zerocopy v0.7.35 [INFO] [stderr] Checking ndarray-csv v0.5.2 [INFO] [stderr] Checking ppv-lite86 v0.2.20 [INFO] [stderr] Checking rand_chacha v0.3.1 [INFO] [stderr] Checking rand v0.8.5 [INFO] [stderr] Checking biosphere v0.3.0 [INFO] [stderr] Checking rand_distr v0.4.3 [INFO] [stderr] Checking futures-executor v0.3.30 [INFO] [stderr] Checking changeforest v1.1.4 (/opt/rustwide/workdir) [INFO] [stderr] Checking futures v0.3.30 [INFO] [stderr] Checking rstest v0.18.2 [INFO] [stderr] Checking ndarray-rand v0.14.0 [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/binary_segmentation.rs:105:23 [INFO] [stdout] | [INFO] [stdout] 89 | pub fn from_tree(tree: BinarySegmentationTree) -> Self { [INFO] [stdout] | ---------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 90 | let left = tree [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 94 | let right = tree [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 105 | segments: None, [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/binary_segmentation.rs:92:34 [INFO] [stdout] | [INFO] [stdout] 92 | .map(|tree| Box::new(BinarySegmentationResult::from_tree(*tree))); [INFO] [stdout] | ---- ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/binary_segmentation.rs:96:34 [INFO] [stdout] | [INFO] [stdout] 96 | .map(|tree| Box::new(BinarySegmentationResult::from_tree(*tree))); [INFO] [stdout] | ---- ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/optimizer/grid_search.rs:39:12 [INFO] [stdout] | [INFO] [stdout] 24 | let mut full_gain = self.gain.gain_full(start, stop, &split_candidates); [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 39 | Ok(OptimizerResult { [INFO] [stdout] | ____________^ [INFO] [stdout] 40 | | start, [INFO] [stdout] 41 | | stop, [INFO] [stdout] 42 | | best_split, [INFO] [stdout] 43 | | max_gain, [INFO] [stdout] 44 | | gain_results: vec![GainResult::FullGainResult(full_gain)], [INFO] [stdout] 45 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/optimizer/two_step_search.rs:113:12 [INFO] [stdout] | [INFO] [stdout] 55 | let mut results: Vec = vec![]; [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 113 | Ok(OptimizerResult { [INFO] [stdout] | ____________^ [INFO] [stdout] 114 | | start, [INFO] [stdout] 115 | | stop, [INFO] [stdout] 116 | | best_split: results.last().unwrap().best_split().unwrap(), [INFO] [stdout] 117 | | max_gain: results.last().unwrap().max_gain().unwrap(), [INFO] [stdout] 118 | | gain_results: results, [INFO] [stdout] 119 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 5 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `changeforest` (lib) due to 6 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] running `Command { std: "docker" "inspect" "9174b8d3a819cd5f643df56eea3ad4332d2a425291b93a2a91e36950edbd044b", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "9174b8d3a819cd5f643df56eea3ad4332d2a425291b93a2a91e36950edbd044b", kill_on_drop: false }` [INFO] [stdout] 9174b8d3a819cd5f643df56eea3ad4332d2a425291b93a2a91e36950edbd044b