[INFO] fetching crate ch2rs 0.1.7... [INFO] checking ch2rs-0.1.7 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate ch2rs 0.1.7 into /workspace/builds/worker-2-tc2/source [INFO] validating manifest of crates.io crate ch2rs 0.1.7 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate ch2rs 0.1.7 [INFO] finished tweaking crates.io crate ch2rs 0.1.7 [INFO] tweaked toml for crates.io crate ch2rs 0.1.7 written to /workspace/builds/worker-2-tc2/source/Cargo.toml [INFO] crate crates.io crate ch2rs 0.1.7 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 75a1328ffebea54e9f308c660dac91d2aaf145bfa7db17019e88093179017c38 [INFO] running `Command { std: "docker" "start" "-a" "75a1328ffebea54e9f308c660dac91d2aaf145bfa7db17019e88093179017c38", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "75a1328ffebea54e9f308c660dac91d2aaf145bfa7db17019e88093179017c38", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "75a1328ffebea54e9f308c660dac91d2aaf145bfa7db17019e88093179017c38", kill_on_drop: false }` [INFO] [stdout] 75a1328ffebea54e9f308c660dac91d2aaf145bfa7db17019e88093179017c38 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] b46c5578eacea90e2a97e8793e0b7017f5ac0c0078991918065c2513f51d79c2 [INFO] running `Command { std: "docker" "start" "-a" "b46c5578eacea90e2a97e8793e0b7017f5ac0c0078991918065c2513f51d79c2", kill_on_drop: false }` [INFO] [stderr] Compiling unicode-ident v1.0.0 [INFO] [stderr] Compiling syn v1.0.96 [INFO] [stderr] Compiling libc v0.2.155 [INFO] [stderr] Compiling serde_derive v1.0.137 [INFO] [stderr] Compiling futures-task v0.3.21 [INFO] [stderr] Checking once_cell v1.12.0 [INFO] [stderr] Checking pin-project-lite v0.2.9 [INFO] [stderr] Checking futures-sink v0.3.30 [INFO] [stderr] Compiling futures-util v0.3.21 [INFO] [stderr] Compiling serde v1.0.137 [INFO] [stderr] Checking futures-core v0.3.30 [INFO] [stderr] Checking itoa v1.0.2 [INFO] [stderr] Compiling log v0.4.17 [INFO] [stderr] Compiling cc v1.0.73 [INFO] [stderr] Compiling version_check v0.9.4 [INFO] [stderr] Checking slab v0.4.6 [INFO] [stderr] Checking futures-io v0.3.21 [INFO] [stderr] Checking pin-utils v0.1.0 [INFO] [stderr] Compiling proc-macro2 v1.0.86 [INFO] [stderr] Checking futures-channel v0.3.30 [INFO] [stderr] Checking bytes v1.7.1 [INFO] [stderr] Checking fnv v1.0.7 [INFO] [stderr] Checking tinyvec_macros v0.1.0 [INFO] [stderr] Compiling httparse v1.9.4 [INFO] [stderr] Checking matches v0.1.9 [INFO] [stderr] Checking try-lock v0.2.3 [INFO] [stderr] Checking tracing-core v0.1.27 [INFO] [stderr] Checking tinyvec v1.6.0 [INFO] [stderr] Compiling proc-macro-error-attr v1.0.4 [INFO] [stderr] Compiling proc-macro-error v1.0.4 [INFO] [stderr] Checking percent-encoding v2.1.0 [INFO] [stderr] Checking unicode-width v0.1.9 [INFO] [stderr] Checking unicode-bidi v0.3.8 [INFO] [stderr] Compiling autocfg v1.1.0 [INFO] [stderr] Checking smallvec v1.13.2 [INFO] [stderr] Checking tower-layer v0.3.2 [INFO] [stderr] Checking want v0.3.0 [INFO] [stderr] Checking tower-service v0.3.1 [INFO] [stderr] Compiling unicode-segmentation v1.9.0 [INFO] [stderr] Checking form_urlencoded v1.0.1 [INFO] [stderr] Checking textwrap v0.11.0 [INFO] [stderr] Checking http v1.1.0 [INFO] [stderr] Compiling serde_json v1.0.81 [INFO] [stderr] Compiling quote v1.0.36 [INFO] [stderr] Checking ryu v1.0.10 [INFO] [stderr] Checking vec_map v0.8.2 [INFO] [stderr] Checking strsim v0.8.0 [INFO] [stderr] Compiling heck v0.4.1 [INFO] [stderr] Checking ansi_term v0.12.1 [INFO] [stderr] Compiling indexmap v1.8.2 [INFO] [stderr] Checking tracing v0.1.35 [INFO] [stderr] Compiling anyhow v1.0.57 [INFO] [stderr] Checking bitflags v1.3.2 [INFO] [stderr] Checking bstr v1.10.0 [INFO] [stderr] Checking uuid v1.2.1 [INFO] [stderr] Checking replace_with v0.1.7 [INFO] [stderr] Checking lazy_static v1.4.0 [INFO] [stderr] Checking linked-hash-map v0.5.4 [INFO] [stderr] Compiling syn v2.0.72 [INFO] [stderr] Checking hashbrown v0.11.2 [INFO] [stderr] Checking static_assertions v1.1.0 [INFO] [stderr] Checking unicode-normalization v0.1.19 [INFO] [stderr] Checking heck v0.5.0 [INFO] [stderr] Compiling trybuild v1.0.63 [INFO] [stderr] Checking yaml-rust v0.4.5 [INFO] [stderr] Compiling heck v0.3.3 [INFO] [stderr] Checking glob v0.3.0 [INFO] [stderr] Checking termcolor v1.1.3 [INFO] [stderr] Checking similar v2.1.0 [INFO] [stderr] Compiling lz4-sys v1.9.4 [INFO] [stderr] Compiling clickhouse-rs-cityhash-sys v0.1.2 [INFO] [stderr] Checking http-body v1.0.1 [INFO] [stderr] Checking socket2 v0.4.4 [INFO] [stderr] Checking mio v0.8.3 [INFO] [stderr] Checking atty v0.2.14 [INFO] [stderr] Checking socket2 v0.5.7 [INFO] [stderr] Checking terminal_size v0.1.17 [INFO] [stderr] Checking clap v2.34.0 [INFO] [stderr] Checking console v0.15.0 [INFO] [stderr] Checking idna v0.2.3 [INFO] [stderr] Checking url v2.2.2 [INFO] [stderr] Compiling serde_derive_internals v0.29.1 [INFO] [stderr] Compiling pin-project-internal v1.1.5 [INFO] [stderr] Compiling sealed v0.5.0 [INFO] [stderr] Compiling clickhouse-derive v0.2.0 [INFO] [stderr] Compiling futures-macro v0.3.21 [INFO] [stderr] Compiling tokio-macros v1.8.0 [INFO] [stderr] Compiling thiserror-impl v1.0.31 [INFO] [stderr] Compiling structopt-derive v0.4.18 [INFO] [stderr] Compiling serde_repr v0.1.8 [INFO] [stderr] Checking tokio v1.19.2 [INFO] [stderr] Checking thiserror v1.0.31 [INFO] [stderr] Checking pin-project v1.1.5 [INFO] [stderr] Checking structopt v0.3.26 [INFO] [stderr] Checking futures-executor v0.3.21 [INFO] [stderr] Checking hyper v1.4.1 [INFO] [stderr] Checking tower v0.4.13 [INFO] [stderr] Checking http-body-util v0.1.2 [INFO] [stderr] Checking futures v0.3.21 [INFO] [stderr] Checking hyper-util v0.1.7 [INFO] [stderr] Checking serde_yaml v0.8.24 [INFO] [stderr] Checking toml v0.5.9 [INFO] [stderr] Checking serde_bytes v0.11.6 [INFO] [stderr] Checking insta v1.14.1 [INFO] [stderr] Checking lz4 v1.24.0 [INFO] [stderr] Checking clickhouse v0.12.1 [INFO] [stderr] Checking ch2rs v0.1.7 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/codegen.rs:137:26 [INFO] [stdout] | [INFO] [stdout] 137 | .map(|i| do_make_type(name, i, options).map(|t| format!("{}, ", t))) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/miner.rs:67:8 [INFO] [stdout] | [INFO] [stdout] 55 | let mut columns = Vec::new(); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 67 | Ok(Table { columns }) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/miner.rs:74:8 [INFO] [stdout] | [INFO] [stdout] 71 | let type_ = parse_type(&raw.type_) [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 74 | Ok(Column { [INFO] [stdout] | ________^ [INFO] [stdout] 75 | | name: raw.name, [INFO] [stdout] 76 | | type_, [INFO] [stdout] 77 | | comment: raw.comment, [INFO] [stdout] 78 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/miner.rs:99:8 [INFO] [stdout] | [INFO] [stdout] 90 | bail!("more than 2 args aren't supported in SimpleAggregateFunction"); [INFO] [stdout] | --------------------------------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 99 | Ok(match raw { [INFO] [stdout] | ________^ [INFO] [stdout] 100 | | "UInt8" => SqlType::UInt8, [INFO] [stdout] 101 | | "UInt16" => SqlType::UInt16, [INFO] [stdout] 102 | | "UInt32" => SqlType::UInt32, [INFO] [stdout] ... | [INFO] [stdout] 178 | | } [INFO] [stdout] 179 | | }) [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/options.rs:34:51 [INFO] [stdout] | [INFO] [stdout] 34 | #[structopt(short = "T", parse(try_from_str = parse_type), number_of_values = 1)] [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/options.rs:37:51 [INFO] [stdout] | [INFO] [stdout] 37 | #[structopt(short = "O", parse(try_from_str = parse_override), number_of_values = 1)] [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/options.rs:58:8 [INFO] [stdout] | [INFO] [stdout] 58 | Ok(Type { [INFO] [stdout] | ________^ [INFO] [stdout] 59 | | sql: crate::miner::parse_type(sql)?, [INFO] [stdout] 60 | | type_: type_.into(), [INFO] [stdout] 61 | | }) [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 7 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `ch2rs` (lib) due to 8 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/codegen.rs:137:26 [INFO] [stdout] | [INFO] [stdout] 137 | .map(|i| do_make_type(name, i, options).map(|t| format!("{}, ", t))) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/miner.rs:67:8 [INFO] [stdout] | [INFO] [stdout] 55 | let mut columns = Vec::new(); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 67 | Ok(Table { columns }) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/miner.rs:74:8 [INFO] [stdout] | [INFO] [stdout] 71 | let type_ = parse_type(&raw.type_) [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 74 | Ok(Column { [INFO] [stdout] | ________^ [INFO] [stdout] 75 | | name: raw.name, [INFO] [stdout] 76 | | type_, [INFO] [stdout] 77 | | comment: raw.comment, [INFO] [stdout] 78 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/miner.rs:99:8 [INFO] [stdout] | [INFO] [stdout] 90 | bail!("more than 2 args aren't supported in SimpleAggregateFunction"); [INFO] [stdout] | --------------------------------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 99 | Ok(match raw { [INFO] [stdout] | ________^ [INFO] [stdout] 100 | | "UInt8" => SqlType::UInt8, [INFO] [stdout] 101 | | "UInt16" => SqlType::UInt16, [INFO] [stdout] 102 | | "UInt32" => SqlType::UInt32, [INFO] [stdout] ... | [INFO] [stdout] 178 | | } [INFO] [stdout] 179 | | }) [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/options.rs:34:51 [INFO] [stdout] | [INFO] [stdout] 34 | #[structopt(short = "T", parse(try_from_str = parse_type), number_of_values = 1)] [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/options.rs:37:51 [INFO] [stdout] | [INFO] [stdout] 37 | #[structopt(short = "O", parse(try_from_str = parse_override), number_of_values = 1)] [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/options.rs:58:8 [INFO] [stdout] | [INFO] [stdout] 58 | Ok(Type { [INFO] [stdout] | ________^ [INFO] [stdout] 59 | | sql: crate::miner::parse_type(sql)?, [INFO] [stdout] 60 | | type_: type_.into(), [INFO] [stdout] 61 | | }) [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 7 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `ch2rs` (lib test) due to 8 previous errors [INFO] running `Command { std: "docker" "inspect" "b46c5578eacea90e2a97e8793e0b7017f5ac0c0078991918065c2513f51d79c2", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "b46c5578eacea90e2a97e8793e0b7017f5ac0c0078991918065c2513f51d79c2", kill_on_drop: false }` [INFO] [stdout] b46c5578eacea90e2a97e8793e0b7017f5ac0c0078991918065c2513f51d79c2