[INFO] fetching crate cgl-rs 0.1.7... [INFO] checking cgl-rs-0.1.7 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate cgl-rs 0.1.7 into /workspace/builds/worker-5-tc2/source [INFO] validating manifest of crates.io crate cgl-rs 0.1.7 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate cgl-rs 0.1.7 [INFO] finished tweaking crates.io crate cgl-rs 0.1.7 [INFO] tweaked toml for crates.io crate cgl-rs 0.1.7 written to /workspace/builds/worker-5-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 2 packages to latest compatible versions [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 1e8f13b14a0d59eecc67d9ef095658863a2451572238af32ff0f995943dae49e [INFO] running `Command { std: "docker" "start" "-a" "1e8f13b14a0d59eecc67d9ef095658863a2451572238af32ff0f995943dae49e", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "1e8f13b14a0d59eecc67d9ef095658863a2451572238af32ff0f995943dae49e", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "1e8f13b14a0d59eecc67d9ef095658863a2451572238af32ff0f995943dae49e", kill_on_drop: false }` [INFO] [stdout] 1e8f13b14a0d59eecc67d9ef095658863a2451572238af32ff0f995943dae49e [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 770db4eb6706ee1dcbeffd43b536be05a1f3c11fbcc648d97e88e1ba071e0995 [INFO] running `Command { std: "docker" "start" "-a" "770db4eb6706ee1dcbeffd43b536be05a1f3c11fbcc648d97e88e1ba071e0995", kill_on_drop: false }` [INFO] [stderr] Compiling cgl-rs v0.1.7 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/graphics/shader.rs:139:12 [INFO] [stdout] | [INFO] [stdout] 129 | let vertex_shader_source_c = std::ffi::CString::new(vertex_shader_source).unwrap(); [INFO] [stdout] | ---------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 130 | let fragment_shader_source_c = std::ffi::CString::new(fragment_shader_source).unwrap(); [INFO] [stdout] | ------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 139 | Ok(Shader { [INFO] [stdout] | ____________^ [INFO] [stdout] 140 | | handle, [INFO] [stdout] 141 | | has_been_destroyed: false, [INFO] [stdout] 142 | | uniform_locations: std::collections::HashMap::new() [INFO] [stdout] 143 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/graphics/shader.rs:185:12 [INFO] [stdout] | [INFO] [stdout] 175 | let vertex_shader_path_c = std::ffi::CString::new(vertex_shader_path).unwrap(); [INFO] [stdout] | -------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 176 | let fragment_shader_path_c = std::ffi::CString::new(fragment_shader_path).unwrap(); [INFO] [stdout] | ---------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 185 | Ok(Shader { [INFO] [stdout] | ____________^ [INFO] [stdout] 186 | | handle, [INFO] [stdout] 187 | | has_been_destroyed: false, [INFO] [stdout] 188 | | uniform_locations: std::collections::HashMap::new() [INFO] [stdout] 189 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/graphics/shader.rs:240:12 [INFO] [stdout] | [INFO] [stdout] 231 | let compute_shader_source_c = std::ffi::CString::new(compute_shader_source).unwrap(); [INFO] [stdout] | ----------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 240 | Ok(Shader { [INFO] [stdout] | ____________^ [INFO] [stdout] 241 | | handle, [INFO] [stdout] 242 | | has_been_destroyed: false, [INFO] [stdout] 243 | | uniform_locations: std::collections::HashMap::new() [INFO] [stdout] 244 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/graphics/shader.rs:284:12 [INFO] [stdout] | [INFO] [stdout] 275 | let compute_shader_path_c = std::ffi::CString::new(compute_shader_path).unwrap(); [INFO] [stdout] | --------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 284 | Ok(Shader { [INFO] [stdout] | ____________^ [INFO] [stdout] 285 | | handle, [INFO] [stdout] 286 | | has_been_destroyed: false, [INFO] [stdout] 287 | | uniform_locations: std::collections::HashMap::new() [INFO] [stdout] 288 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 4 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `cgl-rs` (lib) due to 5 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/graphics/shader.rs:139:12 [INFO] [stdout] | [INFO] [stdout] 129 | let vertex_shader_source_c = std::ffi::CString::new(vertex_shader_source).unwrap(); [INFO] [stdout] | ---------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 130 | let fragment_shader_source_c = std::ffi::CString::new(fragment_shader_source).unwrap(); [INFO] [stdout] | ------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 139 | Ok(Shader { [INFO] [stdout] | ____________^ [INFO] [stdout] 140 | | handle, [INFO] [stdout] 141 | | has_been_destroyed: false, [INFO] [stdout] 142 | | uniform_locations: std::collections::HashMap::new() [INFO] [stdout] 143 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/graphics/shader.rs:185:12 [INFO] [stdout] | [INFO] [stdout] 175 | let vertex_shader_path_c = std::ffi::CString::new(vertex_shader_path).unwrap(); [INFO] [stdout] | -------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 176 | let fragment_shader_path_c = std::ffi::CString::new(fragment_shader_path).unwrap(); [INFO] [stdout] | ---------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 185 | Ok(Shader { [INFO] [stdout] | ____________^ [INFO] [stdout] 186 | | handle, [INFO] [stdout] 187 | | has_been_destroyed: false, [INFO] [stdout] 188 | | uniform_locations: std::collections::HashMap::new() [INFO] [stdout] 189 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/graphics/shader.rs:240:12 [INFO] [stdout] | [INFO] [stdout] 231 | let compute_shader_source_c = std::ffi::CString::new(compute_shader_source).unwrap(); [INFO] [stdout] | ----------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 240 | Ok(Shader { [INFO] [stdout] | ____________^ [INFO] [stdout] 241 | | handle, [INFO] [stdout] 242 | | has_been_destroyed: false, [INFO] [stdout] 243 | | uniform_locations: std::collections::HashMap::new() [INFO] [stdout] 244 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/graphics/shader.rs:284:12 [INFO] [stdout] | [INFO] [stdout] 275 | let compute_shader_path_c = std::ffi::CString::new(compute_shader_path).unwrap(); [INFO] [stdout] | --------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 284 | Ok(Shader { [INFO] [stdout] | ____________^ [INFO] [stdout] 285 | | handle, [INFO] [stdout] 286 | | has_been_destroyed: false, [INFO] [stdout] 287 | | uniform_locations: std::collections::HashMap::new() [INFO] [stdout] 288 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 4 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `cgl-rs` (lib test) due to 5 previous errors [INFO] running `Command { std: "docker" "inspect" "770db4eb6706ee1dcbeffd43b536be05a1f3c11fbcc648d97e88e1ba071e0995", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "770db4eb6706ee1dcbeffd43b536be05a1f3c11fbcc648d97e88e1ba071e0995", kill_on_drop: false }` [INFO] [stdout] 770db4eb6706ee1dcbeffd43b536be05a1f3c11fbcc648d97e88e1ba071e0995