[INFO] fetching crate cgi2 0.7.0... [INFO] checking cgi2-0.7.0 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate cgi2 0.7.0 into /workspace/builds/worker-4-tc2/source [INFO] validating manifest of crates.io crate cgi2 0.7.0 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate cgi2 0.7.0 [INFO] finished tweaking crates.io crate cgi2 0.7.0 [INFO] tweaked toml for crates.io crate cgi2 0.7.0 written to /workspace/builds/worker-4-tc2/source/Cargo.toml [INFO] crate crates.io crate cgi2 0.7.0 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] fda77715422f5985332a73649072b7854515c96560428922e0164bf7c5e00e07 [INFO] running `Command { std: "docker" "start" "-a" "fda77715422f5985332a73649072b7854515c96560428922e0164bf7c5e00e07", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "fda77715422f5985332a73649072b7854515c96560428922e0164bf7c5e00e07", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "fda77715422f5985332a73649072b7854515c96560428922e0164bf7c5e00e07", kill_on_drop: false }` [INFO] [stdout] fda77715422f5985332a73649072b7854515c96560428922e0164bf7c5e00e07 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 594b2bd2271cd3612a69e6714fde7e107f15b709f206c4dfaa326e4edfebcb1f [INFO] running `Command { std: "docker" "start" "-a" "594b2bd2271cd3612a69e6714fde7e107f15b709f206c4dfaa326e4edfebcb1f", kill_on_drop: false }` [INFO] [stderr] Compiling proc-macro2 v1.0.71 [INFO] [stderr] Checking bytes v1.5.0 [INFO] [stderr] Checking itoa v1.0.10 [INFO] [stderr] Checking http v1.0.0 [INFO] [stderr] Compiling quote v1.0.33 [INFO] [stderr] Compiling syn v1.0.109 [INFO] [stderr] Compiling cgi-attributes v0.1.0 [INFO] [stderr] Checking cgi2 v0.7.0 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:98:19 [INFO] [stdout] | [INFO] [stdout] 97 | pub fn err_to_500(res: Result) -> Response { [INFO] [stdout] | ------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 98 | res.unwrap_or(empty_response(500)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:107:5 [INFO] [stdout] | [INFO] [stdout] 103 | pub fn empty_response(status_code: T) -> Response [INFO] [stdout] | -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 107 | http::response::Builder::new().status(status_code).body(vec![]).unwrap() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:118:5 [INFO] [stdout] | [INFO] [stdout] 112 | pub fn html_response(status_code: T, body: S) -> Response [INFO] [stdout] | -------------- ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 118 | / http::response::Builder::new() [INFO] [stdout] 119 | | .status(status_code) [INFO] [stdout] 120 | | .header(http::header::CONTENT_TYPE, "text/html; charset=utf-8") [INFO] [stdout] 121 | | .header(http::header::CONTENT_LENGTH, format!("{}", body.len()).as_str()) [INFO] [stdout] 122 | | .body(body) [INFO] [stdout] | |___________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:133:5 [INFO] [stdout] | [INFO] [stdout] 127 | pub fn string_response(status_code: T, body: S) -> Response [INFO] [stdout] | -------------- ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 133 | / http::response::Builder::new() [INFO] [stdout] 134 | | .status(status_code) [INFO] [stdout] 135 | | .header(http::header::CONTENT_LENGTH, format!("{}", body.len()).as_str()) [INFO] [stdout] 136 | | .body(body) [INFO] [stdout] | |___________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:156:5 [INFO] [stdout] | [INFO] [stdout] 150 | pub fn text_response(status_code: T, body: S) -> Response [INFO] [stdout] | -------------- ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 156 | / http::response::Builder::new() [INFO] [stdout] 157 | | .status(status_code) [INFO] [stdout] 158 | | .header(http::header::CONTENT_LENGTH, format!("{}", body.len()).as_str()) [INFO] [stdout] 159 | | .header(http::header::CONTENT_TYPE, "text/plain; charset=utf-8") [INFO] [stdout] 160 | | .body(body) [INFO] [stdout] | |___________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:199:5 [INFO] [stdout] | [INFO] [stdout] 185 | pub fn binary_response<'a, T>(status_code: T, content_type: impl Into>, body: Vec) -> Response [INFO] [stdout] | -------------- ---------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 191 | let mut response = http::response::Builder::new() [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 199 | response.body(body).unwrap() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:252:5 [INFO] [stdout] | [INFO] [stdout] 204 | let mut req = http::Request::builder(); [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 252 | req.body(stdin).unwrap() [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 7 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `cgi2` (lib) due to 8 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:98:19 [INFO] [stdout] | [INFO] [stdout] 97 | pub fn err_to_500(res: Result) -> Response { [INFO] [stdout] | ------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 98 | res.unwrap_or(empty_response(500)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:107:5 [INFO] [stdout] | [INFO] [stdout] 103 | pub fn empty_response(status_code: T) -> Response [INFO] [stdout] | -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 107 | http::response::Builder::new().status(status_code).body(vec![]).unwrap() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:118:5 [INFO] [stdout] | [INFO] [stdout] 112 | pub fn html_response(status_code: T, body: S) -> Response [INFO] [stdout] | -------------- ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 118 | / http::response::Builder::new() [INFO] [stdout] 119 | | .status(status_code) [INFO] [stdout] 120 | | .header(http::header::CONTENT_TYPE, "text/html; charset=utf-8") [INFO] [stdout] 121 | | .header(http::header::CONTENT_LENGTH, format!("{}", body.len()).as_str()) [INFO] [stdout] 122 | | .body(body) [INFO] [stdout] | |___________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:133:5 [INFO] [stdout] | [INFO] [stdout] 127 | pub fn string_response(status_code: T, body: S) -> Response [INFO] [stdout] | -------------- ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 133 | / http::response::Builder::new() [INFO] [stdout] 134 | | .status(status_code) [INFO] [stdout] 135 | | .header(http::header::CONTENT_LENGTH, format!("{}", body.len()).as_str()) [INFO] [stdout] 136 | | .body(body) [INFO] [stdout] | |___________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:156:5 [INFO] [stdout] | [INFO] [stdout] 150 | pub fn text_response(status_code: T, body: S) -> Response [INFO] [stdout] | -------------- ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 156 | / http::response::Builder::new() [INFO] [stdout] 157 | | .status(status_code) [INFO] [stdout] 158 | | .header(http::header::CONTENT_LENGTH, format!("{}", body.len()).as_str()) [INFO] [stdout] 159 | | .header(http::header::CONTENT_TYPE, "text/plain; charset=utf-8") [INFO] [stdout] 160 | | .body(body) [INFO] [stdout] | |___________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:199:5 [INFO] [stdout] | [INFO] [stdout] 185 | pub fn binary_response<'a, T>(status_code: T, content_type: impl Into>, body: Vec) -> Response [INFO] [stdout] | -------------- ---------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 191 | let mut response = http::response::Builder::new() [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 199 | response.body(body).unwrap() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:252:5 [INFO] [stdout] | [INFO] [stdout] 204 | let mut req = http::Request::builder(); [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 252 | req.body(stdin).unwrap() [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 7 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `cgi2` (lib test) due to 8 previous errors [INFO] running `Command { std: "docker" "inspect" "594b2bd2271cd3612a69e6714fde7e107f15b709f206c4dfaa326e4edfebcb1f", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "594b2bd2271cd3612a69e6714fde7e107f15b709f206c4dfaa326e4edfebcb1f", kill_on_drop: false }` [INFO] [stdout] 594b2bd2271cd3612a69e6714fde7e107f15b709f206c4dfaa326e4edfebcb1f