[INFO] fetching crate cfgcomment-core 0.3.0... [INFO] checking cfgcomment-core-0.3.0 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate cfgcomment-core 0.3.0 into /workspace/builds/worker-0-tc2/source [INFO] validating manifest of crates.io crate cfgcomment-core 0.3.0 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate cfgcomment-core 0.3.0 [INFO] finished tweaking crates.io crate cfgcomment-core 0.3.0 [INFO] tweaked toml for crates.io crate cfgcomment-core 0.3.0 written to /workspace/builds/worker-0-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 44 packages to latest compatible versions [INFO] [stderr] Adding linux-raw-sys v0.4.14 (latest: v0.6.5) [INFO] [stderr] Adding peg v0.7.0 (latest: v0.8.4) [INFO] [stderr] Adding peg-macros v0.7.0 (latest: v0.8.4) [INFO] [stderr] Adding peg-runtime v0.7.0 (latest: v0.8.3) [INFO] [stderr] Adding windows-sys v0.52.0 (latest: v0.59.0) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 13c1adebe647b829ef2d303d31db157fcb40a2651cf3b5eed71e2eec799739b1 [INFO] running `Command { std: "docker" "start" "-a" "13c1adebe647b829ef2d303d31db157fcb40a2651cf3b5eed71e2eec799739b1", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "13c1adebe647b829ef2d303d31db157fcb40a2651cf3b5eed71e2eec799739b1", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "13c1adebe647b829ef2d303d31db157fcb40a2651cf3b5eed71e2eec799739b1", kill_on_drop: false }` [INFO] [stdout] 13c1adebe647b829ef2d303d31db157fcb40a2651cf3b5eed71e2eec799739b1 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 3cbc1cfa1997f3efd7242bc6c5213640fdb7e6f41b11a2fb6a702428a81a6fb0 [INFO] running `Command { std: "docker" "start" "-a" "3cbc1cfa1997f3efd7242bc6c5213640fdb7e6f41b11a2fb6a702428a81a6fb0", kill_on_drop: false }` [INFO] [stderr] Compiling crossbeam-utils v0.8.20 [INFO] [stderr] Checking aho-corasick v1.1.3 [INFO] [stderr] Checking bstr v1.10.0 [INFO] [stderr] Compiling peg-runtime v0.7.0 [INFO] [stderr] Compiling peg-macros v0.7.0 [INFO] [stderr] Checking crossbeam-epoch v0.9.18 [INFO] [stderr] Checking regex-automata v0.4.7 [INFO] [stderr] Checking crossbeam-deque v0.8.5 [INFO] [stderr] Checking peg v0.7.0 [INFO] [stderr] Checking globset v0.4.14 [INFO] [stderr] Checking ignore v0.4.22 [INFO] [stderr] Checking cfgcomment-core v0.3.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: use of deprecated associated function `std::array::IntoIter::::new`: use `IntoIterator::into_iter` instead [INFO] [stdout] --> src/lib.rs:124:31 [INFO] [stdout] | [INFO] [stdout] 124 | std::array::IntoIter::new([ [INFO] [stdout] | ^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(deprecated)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated associated function `std::array::IntoIter::::new`: use `IntoIterator::into_iter` instead [INFO] [stdout] --> src/lib.rs:124:31 [INFO] [stdout] | [INFO] [stdout] 124 | std::array::IntoIter::new([ [INFO] [stdout] | ^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(deprecated)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:157:14 [INFO] [stdout] | [INFO] [stdout] 152 | read: impl Iterator, [INFO] [stdout] | ---------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 153 | config: Arc, [INFO] [stdout] | ----------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 157 | read.map(move |s| { [INFO] [stdout] | ______________^ [INFO] [stdout] 158 | | let state = state.clone(); [INFO] [stdout] 159 | | if s.trim_start().starts_with(&desc.cfg_prefix) && s.trim_end().ends_with(&desc.cfg_suffix) [INFO] [stdout] 160 | | { [INFO] [stdout] ... | [INFO] [stdout] 190 | | } [INFO] [stdout] 191 | | }) [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:207:18 [INFO] [stdout] | [INFO] [stdout] 201 | let config = Arc::new(config); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 202 | let lang_config = Arc::new(lang_config); [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 205 | let config = config.clone(); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 206 | let lang_config = lang_config.clone(); [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 207 | Box::new(move |path| { [INFO] [stdout] | __________________^ [INFO] [stdout] 208 | | let path = path.unwrap(); [INFO] [stdout] 209 | | // Skip dirs/symlinks [INFO] [stdout] 210 | | if !path.file_type().map(|f| f.is_file()).unwrap_or(false) { [INFO] [stdout] ... | [INFO] [stdout] 235 | | ignore::WalkState::Continue [INFO] [stdout] 236 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:67:56 [INFO] [stdout] | [INFO] [stdout] 67 | / "not" _ "(" _ p:pred() _ ")" {Group::Not(Box::new(p))} [INFO] [stdout] | - ^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 3 previous errors; 1 warning emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:157:14 [INFO] [stdout] | [INFO] [stdout] 152 | read: impl Iterator, [INFO] [stdout] | ---------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 153 | config: Arc, [INFO] [stdout] | ----------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 157 | read.map(move |s| { [INFO] [stdout] | ______________^ [INFO] [stdout] 158 | | let state = state.clone(); [INFO] [stdout] 159 | | if s.trim_start().starts_with(&desc.cfg_prefix) && s.trim_end().ends_with(&desc.cfg_suffix) [INFO] [stdout] 160 | | { [INFO] [stdout] ... | [INFO] [stdout] 190 | | } [INFO] [stdout] 191 | | }) [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:207:18 [INFO] [stdout] | [INFO] [stdout] 201 | let config = Arc::new(config); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 202 | let lang_config = Arc::new(lang_config); [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 205 | let config = config.clone(); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 206 | let lang_config = lang_config.clone(); [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 207 | Box::new(move |path| { [INFO] [stdout] | __________________^ [INFO] [stdout] 208 | | let path = path.unwrap(); [INFO] [stdout] 209 | | // Skip dirs/symlinks [INFO] [stdout] 210 | | if !path.file_type().map(|f| f.is_file()).unwrap_or(false) { [INFO] [stdout] ... | [INFO] [stdout] 235 | | ignore::WalkState::Continue [INFO] [stdout] 236 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:67:56 [INFO] [stdout] | [INFO] [stdout] 67 | / "not" _ "(" _ p:pred() _ ")" {Group::Not(Box::new(p))} [INFO] [stdout] | - ^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 3 previous errors; 1 warning emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `cfgcomment-core` (lib) due to 4 previous errors; 1 warning emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] error: could not compile `cfgcomment-core` (lib test) due to 4 previous errors; 1 warning emitted [INFO] running `Command { std: "docker" "inspect" "3cbc1cfa1997f3efd7242bc6c5213640fdb7e6f41b11a2fb6a702428a81a6fb0", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "3cbc1cfa1997f3efd7242bc6c5213640fdb7e6f41b11a2fb6a702428a81a6fb0", kill_on_drop: false }` [INFO] [stdout] 3cbc1cfa1997f3efd7242bc6c5213640fdb7e6f41b11a2fb6a702428a81a6fb0