[INFO] fetching crate cfg-rs 0.4.0... [INFO] checking cfg-rs-0.4.0 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate cfg-rs 0.4.0 into /workspace/builds/worker-3-tc2/source [INFO] validating manifest of crates.io crate cfg-rs 0.4.0 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate cfg-rs 0.4.0 [INFO] removed 0 missing examples [INFO] finished tweaking crates.io crate cfg-rs 0.4.0 [INFO] tweaked toml for crates.io crate cfg-rs 0.4.0 written to /workspace/builds/worker-3-tc2/source/Cargo.toml [INFO] crate crates.io crate cfg-rs 0.4.0 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] b893ba9d4b0496997d5559f01361371a9433973be4ec78725da041dea3b28e07 [INFO] running `Command { std: "docker" "start" "-a" "b893ba9d4b0496997d5559f01361371a9433973be4ec78725da041dea3b28e07", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "b893ba9d4b0496997d5559f01361371a9433973be4ec78725da041dea3b28e07", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "b893ba9d4b0496997d5559f01361371a9433973be4ec78725da041dea3b28e07", kill_on_drop: false }` [INFO] [stdout] b893ba9d4b0496997d5559f01361371a9433973be4ec78725da041dea3b28e07 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 3e431325df13ac840f03163b70aeae0a9c20228b052579974a20f3729b0a3058 [INFO] running `Command { std: "docker" "start" "-a" "3e431325df13ac840f03163b70aeae0a9c20228b052579974a20f3729b0a3058", kill_on_drop: false }` [INFO] [stderr] Compiling proc-macro2 v1.0.68 [INFO] [stderr] Checking memchr v2.6.4 [INFO] [stderr] Checking regex-syntax v0.8.2 [INFO] [stderr] Compiling crossbeam-utils v0.8.16 [INFO] [stderr] Compiling serde v1.0.188 [INFO] [stderr] Compiling libc v0.2.149 [INFO] [stderr] Compiling serde_json v1.0.107 [INFO] [stderr] Compiling rustix v0.38.17 [INFO] [stderr] Compiling memoffset v0.9.0 [INFO] [stderr] Compiling crossbeam-epoch v0.9.15 [INFO] [stderr] Compiling num-traits v0.2.17 [INFO] [stderr] Checking either v1.9.0 [INFO] [stderr] Compiling rayon-core v1.12.0 [INFO] [stderr] Checking log v0.4.20 [INFO] [stderr] Checking bitflags v2.4.0 [INFO] [stderr] Checking anstream v0.6.12 [INFO] [stderr] Checking itoa v1.0.9 [INFO] [stderr] Checking plotters-backend v0.3.5 [INFO] [stderr] Checking half v1.8.2 [INFO] [stderr] Checking ciborium-io v0.2.1 [INFO] [stderr] Checking ryu v1.0.15 [INFO] [stderr] Checking linux-raw-sys v0.4.8 [INFO] [stderr] Checking clap_builder v4.5.1 [INFO] [stderr] Checking plotters-svg v0.3.5 [INFO] [stderr] Checking itertools v0.10.5 [INFO] [stderr] Checking walkdir v2.4.0 [INFO] [stderr] Checking oorandom v11.1.3 [INFO] [stderr] Checking ciborium-ll v0.2.1 [INFO] [stderr] Compiling quote v1.0.33 [INFO] [stderr] Checking aho-corasick v1.1.1 [INFO] [stderr] Compiling syn v2.0.38 [INFO] [stderr] Compiling syn v1.0.109 [INFO] [stderr] Checking crossbeam-deque v0.8.3 [INFO] [stderr] Checking plotters v0.3.5 [INFO] [stderr] Checking rayon v1.8.0 [INFO] [stderr] Checking criterion-plot v0.5.0 [INFO] [stderr] Checking is-terminal v0.4.9 [INFO] [stderr] Checking getrandom v0.2.10 [INFO] [stderr] Checking rand_core v0.6.4 [INFO] [stderr] Checking clap v4.5.1 [INFO] [stderr] Checking rand v0.8.5 [INFO] [stderr] Checking regex-automata v0.4.5 [INFO] [stderr] Compiling quickcheck_macros v1.0.0 [INFO] [stderr] Checking regex v1.10.3 [INFO] [stderr] Checking env_filter v0.1.0 [INFO] [stderr] Checking env_logger v0.8.4 [INFO] [stderr] Checking env_logger v0.11.2 [INFO] [stderr] Checking quickcheck v1.0.3 [INFO] [stderr] Compiling serde_derive v1.0.188 [INFO] [stderr] Compiling cfg-derive v0.2.0 [INFO] [stderr] Checking cfg-rs v0.4.0 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/cache.rs:57:20 [INFO] [stdout] | [INFO] [stdout] 55 | pub(crate) fn new(origin: L) -> Self { [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 56 | Self { [INFO] [stdout] 57 | cache: Mutex::new((None, false)), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/cache.rs:21:26 [INFO] [stdout] | [INFO] [stdout] 19 | f: F, [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 20 | ) -> Result { [INFO] [stdout] 21 | BUF.with(move |buf| Self::with_key_buf(buf, f)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] ::: src/configuration.rs:55:1 [INFO] [stdout] | [INFO] [stdout] 55 | impl_cache!(CacheValue); [INFO] [stdout] | ----------------------- in this macro invocation [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: this error originates in the macro `impl_cache` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/configuration.rs:268:28 [INFO] [stdout] | [INFO] [stdout] 267 | pub fn register_kv>(self, name: N) -> ManualSource { [INFO] [stdout] | ---- ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 268 | ManualSource(self, HashSource::new(name)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/configuration.rs:361:12 [INFO] [stdout] | [INFO] [stdout] 346 | let mut s = Configuration::new(); [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 361 | Ok((refreshed, s)) [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/configuration.rs:401:12 [INFO] [stdout] | [INFO] [stdout] 400 | pub fn get_or(&self, key: &str, def: T) -> Result { [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 401 | Ok(self.get::>(key)?.unwrap_or(def)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/configuration.rs:549:25 [INFO] [stdout] | [INFO] [stdout] 549 | .or_else(|| config.get::>("env.prefix").ok().flatten()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/err.rs:35:34 [INFO] [stdout] | [INFO] [stdout] 34 | fn from(e: E) -> Self { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 35 | ConfigError::ConfigCause(Box::new(e)) [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/key.rs:90:18 [INFO] [stdout] | [INFO] [stdout] 88 | f: F, [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 89 | ) -> Result { [INFO] [stdout] 90 | BUG.with(move |buf| Self::with_key_buf(buf, f)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/cache.rs:21:26 [INFO] [stdout] | [INFO] [stdout] 19 | f: F, [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 20 | ) -> Result { [INFO] [stdout] 21 | BUF.with(move |buf| Self::with_key_buf(buf, f)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] ::: src/key.rs:94:1 [INFO] [stdout] | [INFO] [stdout] 94 | impl_cache!(CacheString); [INFO] [stdout] | ------------------------ in this macro invocation [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: this error originates in the macro `impl_cache` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/source/memory.rs:90:20 [INFO] [stdout] | [INFO] [stdout] 88 | pub(crate) fn new>(name: K) -> Self { [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 89 | Self { [INFO] [stdout] 90 | value: HashMap::new(), [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/source/memory.rs:92:19 [INFO] [stdout] | [INFO] [stdout] 88 | pub(crate) fn new>(name: K) -> Self { [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 92 | refs: Refresher::new(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/value_ref.rs:31:14 [INFO] [stdout] | [INFO] [stdout] 30 | fn new(k: String, v: T) -> Self { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 31 | Self(Arc::new(Mutex::new(v)), k) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/value_ref.rs:42:12 [INFO] [stdout] | [INFO] [stdout] 40 | pub fn with R, R>(&self, f: F) -> Result { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 41 | let g = self.0.lock_c()?; [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 42 | Ok((f)(&*g)) [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 13 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `cfg-rs` (lib) due to 14 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] running `Command { std: "docker" "inspect" "3e431325df13ac840f03163b70aeae0a9c20228b052579974a20f3729b0a3058", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "3e431325df13ac840f03163b70aeae0a9c20228b052579974a20f3729b0a3058", kill_on_drop: false }` [INFO] [stdout] 3e431325df13ac840f03163b70aeae0a9c20228b052579974a20f3729b0a3058