[INFO] fetching crate cf 0.0.10... [INFO] checking cf-0.0.10 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate cf 0.0.10 into /workspace/builds/worker-0-tc2/source [INFO] validating manifest of crates.io crate cf 0.0.10 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate cf 0.0.10 [INFO] finished tweaking crates.io crate cf 0.0.10 [INFO] tweaked toml for crates.io crate cf 0.0.10 written to /workspace/builds/worker-0-tc2/source/Cargo.toml [INFO] crate crates.io crate cf 0.0.10 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] cbb419a26d82f23afaf941aae602d3856164a441748adc487306f0310d1770f4 [INFO] running `Command { std: "docker" "start" "-a" "cbb419a26d82f23afaf941aae602d3856164a441748adc487306f0310d1770f4", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "cbb419a26d82f23afaf941aae602d3856164a441748adc487306f0310d1770f4", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "cbb419a26d82f23afaf941aae602d3856164a441748adc487306f0310d1770f4", kill_on_drop: false }` [INFO] [stdout] cbb419a26d82f23afaf941aae602d3856164a441748adc487306f0310d1770f4 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 5b9e1438e6f021c32f0b8bda3068261fcc254b1f8b9ab8ad7114fd99e788a0e6 [INFO] running `Command { std: "docker" "start" "-a" "5b9e1438e6f021c32f0b8bda3068261fcc254b1f8b9ab8ad7114fd99e788a0e6", kill_on_drop: false }` [INFO] [stderr] Compiling libc v0.2.112 [INFO] [stderr] Compiling syn v1.0.85 [INFO] [stderr] Compiling memchr v2.4.1 [INFO] [stderr] Compiling cc v1.0.72 [INFO] [stderr] Compiling parking_lot_core v0.8.6 [INFO] [stderr] Compiling quote v1.0.14 [INFO] [stderr] Compiling pkg-config v0.3.24 [INFO] [stderr] Checking smallvec v1.10.0 [INFO] [stderr] Compiling futures-core v0.3.19 [INFO] [stderr] Compiling futures-task v0.3.19 [INFO] [stderr] Compiling indexmap v1.8.0 [INFO] [stderr] Compiling openssl v0.10.38 [INFO] [stderr] Compiling futures-util v0.3.19 [INFO] [stderr] Compiling serde_derive v1.0.133 [INFO] [stderr] Checking tracing-core v0.1.21 [INFO] [stderr] Compiling httparse v1.5.1 [INFO] [stderr] Compiling serde v1.0.133 [INFO] [stderr] Checking futures-sink v0.3.19 [INFO] [stderr] Compiling futures-channel v0.3.19 [INFO] [stderr] Checking futures-io v0.3.19 [INFO] [stderr] Compiling native-tls v0.2.8 [INFO] [stderr] Checking tracing v0.1.29 [INFO] [stderr] Checking openssl-probe v0.1.4 [INFO] [stderr] Checking try-lock v0.2.3 [INFO] [stderr] Checking mio v0.7.14 [INFO] [stderr] Compiling openssl-sys v0.9.72 [INFO] [stderr] Checking signal-hook-registry v1.4.1 [INFO] [stderr] Checking parking_lot v0.11.2 [INFO] [stderr] Checking num_cpus v1.13.1 [INFO] [stderr] Checking want v0.3.0 [INFO] [stderr] Checking socket2 v0.4.2 [INFO] [stderr] Checking getrandom v0.2.3 [INFO] [stderr] Checking http-body v0.4.4 [INFO] [stderr] Compiling serde_json v1.0.74 [INFO] [stderr] Checking tower-service v0.3.1 [INFO] [stderr] Checking httpdate v1.0.2 [INFO] [stderr] Compiling async-trait v0.1.53 [INFO] [stderr] Checking rand_core v0.6.3 [INFO] [stderr] Checking time v0.1.44 [INFO] [stderr] Checking combine v4.6.4 [INFO] [stderr] Checking ipnet v2.3.1 [INFO] [stderr] Checking rand_chacha v0.3.1 [INFO] [stderr] Checking dtoa v0.4.8 [INFO] [stderr] Checking sha1 v0.2.0 [INFO] [stderr] Checking chrono v0.4.19 [INFO] [stderr] Checking rand v0.8.5 [INFO] [stderr] Checking dotenv v0.15.0 [INFO] [stderr] Compiling tokio-macros v1.8.2 [INFO] [stderr] Checking tokio v1.15.0 [INFO] [stderr] Checking redis v0.21.5 [INFO] [stderr] Checking tokio-util v0.6.9 [INFO] [stderr] Checking tokio-native-tls v0.3.0 [INFO] [stderr] Checking h2 v0.3.10 [INFO] [stderr] Checking serde_urlencoded v0.7.0 [INFO] [stderr] Checking hyper v0.14.16 [INFO] [stderr] Checking hyper-tls v0.5.0 [INFO] [stderr] Checking reqwest v0.11.8 [INFO] [stderr] Checking cf v0.0.10 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:62:9 [INFO] [stdout] | [INFO] [stdout] 59 | pub fn lines_from_file(filename: impl AsRef) -> Vec { [INFO] [stdout] | -------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 60 | let file = std::fs::File::open(filename).expect("Open file failed."); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 61 | let buf = BufReader::new(file); [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 62 | / buf.lines() [INFO] [stdout] 63 | | .map(|l| l.expect("Could not parse line.")) [INFO] [stdout] | |_______________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:107:9 [INFO] [stdout] | [INFO] [stdout] 102 | pub fn walk

(dir_name: P) -> Vec [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 107 | / std::fs::read_dir(dir_name) [INFO] [stdout] 108 | | .expect("read dir failed") [INFO] [stdout] 109 | | .map(|entry| { [INFO] [stdout] 110 | | entry [INFO] [stdout] ... | [INFO] [stdout] 115 | | .to_string() [INFO] [stdout] 116 | | }) [INFO] [stdout] | |______________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:110:17 [INFO] [stdout] | [INFO] [stdout] 109 | .map(|entry| { [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 110 | / entry [INFO] [stdout] 111 | | .expect("parse extry failed") [INFO] [stdout] | |_________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:126:12 [INFO] [stdout] | [INFO] [stdout] 120 | pub fn read_to_lines

(filename: P) -> io::Result>> [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 125 | let file = std::fs::File::open(filename)?; [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 126 | Ok(io::BufReader::new(file).lines()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:142:9 [INFO] [stdout] | [INFO] [stdout] 137 | pub fn read_to_vector

(filename: P) -> Vec [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 141 | let fh = std::fs::File::open(filename).expect("failed to open file"); [INFO] [stdout] | -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 142 | / std::io::BufReader::new(fh) [INFO] [stdout] 143 | | .lines() [INFO] [stdout] 144 | | .map(|ln| ln.expect("read line failed")) [INFO] [stdout] | |____________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:189:13 [INFO] [stdout] | [INFO] [stdout] 171 | pub fn dir_size(path: impl Into) -> io::Result { [INFO] [stdout] | ------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 189 | rec(fs::read_dir(&buf)?) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 6 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `cf` (lib) due to 7 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:62:9 [INFO] [stdout] | [INFO] [stdout] 59 | pub fn lines_from_file(filename: impl AsRef) -> Vec { [INFO] [stdout] | -------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 60 | let file = std::fs::File::open(filename).expect("Open file failed."); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 61 | let buf = BufReader::new(file); [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 62 | / buf.lines() [INFO] [stdout] 63 | | .map(|l| l.expect("Could not parse line.")) [INFO] [stdout] | |_______________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:107:9 [INFO] [stdout] | [INFO] [stdout] 102 | pub fn walk

(dir_name: P) -> Vec [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 107 | / std::fs::read_dir(dir_name) [INFO] [stdout] 108 | | .expect("read dir failed") [INFO] [stdout] 109 | | .map(|entry| { [INFO] [stdout] 110 | | entry [INFO] [stdout] ... | [INFO] [stdout] 115 | | .to_string() [INFO] [stdout] 116 | | }) [INFO] [stdout] | |______________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:110:17 [INFO] [stdout] | [INFO] [stdout] 109 | .map(|entry| { [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 110 | / entry [INFO] [stdout] 111 | | .expect("parse extry failed") [INFO] [stdout] | |_________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:126:12 [INFO] [stdout] | [INFO] [stdout] 120 | pub fn read_to_lines

(filename: P) -> io::Result>> [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 125 | let file = std::fs::File::open(filename)?; [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 126 | Ok(io::BufReader::new(file).lines()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:142:9 [INFO] [stdout] | [INFO] [stdout] 137 | pub fn read_to_vector

(filename: P) -> Vec [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 141 | let fh = std::fs::File::open(filename).expect("failed to open file"); [INFO] [stdout] | -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 142 | / std::io::BufReader::new(fh) [INFO] [stdout] 143 | | .lines() [INFO] [stdout] 144 | | .map(|ln| ln.expect("read line failed")) [INFO] [stdout] | |____________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:189:13 [INFO] [stdout] | [INFO] [stdout] 171 | pub fn dir_size(path: impl Into) -> io::Result { [INFO] [stdout] | ------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 189 | rec(fs::read_dir(&buf)?) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 6 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `cf` (lib test) due to 7 previous errors [INFO] running `Command { std: "docker" "inspect" "5b9e1438e6f021c32f0b8bda3068261fcc254b1f8b9ab8ad7114fd99e788a0e6", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "5b9e1438e6f021c32f0b8bda3068261fcc254b1f8b9ab8ad7114fd99e788a0e6", kill_on_drop: false }` [INFO] [stdout] 5b9e1438e6f021c32f0b8bda3068261fcc254b1f8b9ab8ad7114fd99e788a0e6