[INFO] fetching crate centrosome 0.2.1... [INFO] checking centrosome-0.2.1 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate centrosome 0.2.1 into /workspace/builds/worker-3-tc2/source [INFO] validating manifest of crates.io crate centrosome 0.2.1 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate centrosome 0.2.1 [INFO] finished tweaking crates.io crate centrosome 0.2.1 [INFO] tweaked toml for crates.io crate centrosome 0.2.1 written to /workspace/builds/worker-3-tc2/source/Cargo.toml [INFO] crate crates.io crate centrosome 0.2.1 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 22386b9bec9ae0579f241573aa7f4be69c2b1019f9b1a05685e3dd3affe9da5f [INFO] running `Command { std: "docker" "start" "-a" "22386b9bec9ae0579f241573aa7f4be69c2b1019f9b1a05685e3dd3affe9da5f", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "22386b9bec9ae0579f241573aa7f4be69c2b1019f9b1a05685e3dd3affe9da5f", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "22386b9bec9ae0579f241573aa7f4be69c2b1019f9b1a05685e3dd3affe9da5f", kill_on_drop: false }` [INFO] [stdout] 22386b9bec9ae0579f241573aa7f4be69c2b1019f9b1a05685e3dd3affe9da5f [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] c74f23704cb2a90d7f6dd407e6e192aad0a52f6984c12bb8cde01013dd3cb7f9 [INFO] running `Command { std: "docker" "start" "-a" "c74f23704cb2a90d7f6dd407e6e192aad0a52f6984c12bb8cde01013dd3cb7f9", kill_on_drop: false }` [INFO] [stderr] Compiling libc v0.2.66 [INFO] [stderr] Compiling autocfg v0.1.7 [INFO] [stderr] Compiling getrandom v0.1.14 [INFO] [stderr] Compiling proc-macro2 v1.0.8 [INFO] [stderr] Compiling unicode-xid v0.2.0 [INFO] [stderr] Checking unicode-width v0.1.7 [INFO] [stderr] Checking ppv-lite86 v0.2.6 [INFO] [stderr] Compiling cc v1.0.50 [INFO] [stderr] Checking scopeguard v1.0.0 [INFO] [stderr] Compiling syn v1.0.14 [INFO] [stderr] Compiling crc32fast v1.2.0 [INFO] [stderr] Compiling rayon-core v1.7.0 [INFO] [stderr] Checking regex-syntax v0.6.14 [INFO] [stderr] Compiling serde v1.0.104 [INFO] [stderr] Compiling ryu v1.0.2 [INFO] [stderr] Compiling memoffset v0.5.3 [INFO] [stderr] Checking adler32 v1.0.4 [INFO] [stderr] Checking either v1.5.3 [INFO] [stderr] Checking remove_dir_all v0.5.2 [INFO] [stderr] Checking miniz_oxide v0.3.5 [INFO] [stderr] Checking textwrap v0.11.0 [INFO] [stderr] Checking podio v0.1.6 [INFO] [stderr] Checking yaml-rust v0.3.5 [INFO] [stderr] Compiling crossbeam-utils v0.7.0 [INFO] [stderr] Compiling crossbeam-epoch v0.8.0 [INFO] [stderr] Checking itoa v0.4.5 [INFO] [stderr] Checking vec_map v0.8.1 [INFO] [stderr] Checking number_prefix v0.3.0 [INFO] [stderr] Checking c2-chacha v0.2.3 [INFO] [stderr] Compiling bzip2-sys v0.1.7 [INFO] [stderr] Checking num_cpus v1.12.0 [INFO] [stderr] Checking clicolors-control v1.0.1 [INFO] [stderr] Checking termios v0.3.1 [INFO] [stderr] Checking atty v0.2.14 [INFO] [stderr] Checking flate2 v1.0.13 [INFO] [stderr] Checking time v0.1.42 [INFO] [stderr] Compiling quote v1.0.2 [INFO] [stderr] Checking crossbeam-queue v0.2.1 [INFO] [stderr] Checking colored v1.9.2 [INFO] [stderr] Checking clap v2.33.0 [INFO] [stderr] Checking rand_core v0.5.1 [INFO] [stderr] Checking regex v1.3.4 [INFO] [stderr] Checking crossbeam-deque v0.7.2 [INFO] [stderr] Checking rand_chacha v0.2.1 [INFO] [stderr] Checking rand v0.7.3 [INFO] [stderr] Checking rayon v1.3.0 [INFO] [stderr] Checking console v0.9.2 [INFO] [stderr] Checking tempfile v3.1.0 [INFO] [stderr] Checking dialoguer v0.5.0 [INFO] [stderr] Checking bzip2 v0.3.3 [INFO] [stderr] Checking zip v0.5.4 [INFO] [stderr] Checking indicatif v0.14.0 [INFO] [stderr] Compiling serde_derive v1.0.104 [INFO] [stderr] Checking serde_json v1.0.47 [INFO] [stderr] Checking centrosome v0.2.1 (/opt/rustwide/workdir) [INFO] [stdout] warning: unexpected `cfg` condition value: `bzip2` [INFO] [stdout] --> src/utils.rs:82:10 [INFO] [stdout] | [INFO] [stdout] 82 | if cfg!(feature = "bzip2") { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: remove the condition [INFO] [stdout] | [INFO] [stdout] = note: no expected values for `feature` [INFO] [stdout] = help: consider adding `bzip2` as a feature in `Cargo.toml` [INFO] [stdout] = note: see for more information about checking conditional configuration [INFO] [stdout] = note: `#[warn(unexpected_cfgs)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unexpected `cfg` condition value: `deflate` [INFO] [stdout] --> src/utils.rs:84:17 [INFO] [stdout] | [INFO] [stdout] 84 | } else if cfg!(feature = "deflate") { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ help: remove the condition [INFO] [stdout] | [INFO] [stdout] = note: no expected values for `feature` [INFO] [stdout] = help: consider adding `deflate` as a feature in `Cargo.toml` [INFO] [stdout] = note: see for more information about checking conditional configuration [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unexpected `cfg` condition value: `bzip2` [INFO] [stdout] --> src/utils.rs:82:10 [INFO] [stdout] | [INFO] [stdout] 82 | if cfg!(feature = "bzip2") { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: remove the condition [INFO] [stdout] | [INFO] [stdout] = note: no expected values for `feature` [INFO] [stdout] = help: consider adding `bzip2` as a feature in `Cargo.toml` [INFO] [stdout] = note: see for more information about checking conditional configuration [INFO] [stdout] = note: `#[warn(unexpected_cfgs)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unexpected `cfg` condition value: `deflate` [INFO] [stdout] --> src/utils.rs:84:17 [INFO] [stdout] | [INFO] [stdout] 84 | } else if cfg!(feature = "deflate") { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ help: remove the condition [INFO] [stdout] | [INFO] [stdout] = note: no expected values for `feature` [INFO] [stdout] = help: consider adding `deflate` as a feature in `Cargo.toml` [INFO] [stdout] = note: see for more information about checking conditional configuration [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/main.rs:142:2 [INFO] [stdout] | [INFO] [stdout] 141 | fn get_selection_items(datapack_entries: DatapackIterator) -> (Vec, Vec) { [INFO] [stdout] | ---------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 142 | / datapack_entries [INFO] [stdout] 143 | | .map(|entry| -> (String, DatapackLoader) { [INFO] [stdout] 144 | | let name = os_str_to_string(&entry.file_name()); [INFO] [stdout] 145 | | let loader = DatapackLoader::new(entry.path()).unwrap(); [INFO] [stdout] 146 | | (name, loader) [INFO] [stdout] 147 | | }) [INFO] [stdout] | |__________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/utils.rs:12:5 [INFO] [stdout] | [INFO] [stdout] 9 | let result = directory [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 12 | Ok(Box::new(result)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/utils.rs:11:23 [INFO] [stdout] | [INFO] [stdout] 11 | .filter_map(|entry| check_datapack(entry).ok()); [INFO] [stdout] | ----- ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 3 previous errors; 2 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `centrosome` (bin "centrosome") due to 4 previous errors; 2 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/main.rs:142:2 [INFO] [stdout] | [INFO] [stdout] 141 | fn get_selection_items(datapack_entries: DatapackIterator) -> (Vec, Vec) { [INFO] [stdout] | ---------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 142 | / datapack_entries [INFO] [stdout] 143 | | .map(|entry| -> (String, DatapackLoader) { [INFO] [stdout] 144 | | let name = os_str_to_string(&entry.file_name()); [INFO] [stdout] 145 | | let loader = DatapackLoader::new(entry.path()).unwrap(); [INFO] [stdout] 146 | | (name, loader) [INFO] [stdout] 147 | | }) [INFO] [stdout] | |__________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/utils.rs:12:5 [INFO] [stdout] | [INFO] [stdout] 9 | let result = directory [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 12 | Ok(Box::new(result)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/utils.rs:11:23 [INFO] [stdout] | [INFO] [stdout] 11 | .filter_map(|entry| check_datapack(entry).ok()); [INFO] [stdout] | ----- ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 3 previous errors; 2 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `centrosome` (bin "centrosome" test) due to 4 previous errors; 2 warnings emitted [INFO] running `Command { std: "docker" "inspect" "c74f23704cb2a90d7f6dd407e6e192aad0a52f6984c12bb8cde01013dd3cb7f9", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "c74f23704cb2a90d7f6dd407e6e192aad0a52f6984c12bb8cde01013dd3cb7f9", kill_on_drop: false }` [INFO] [stdout] c74f23704cb2a90d7f6dd407e6e192aad0a52f6984c12bb8cde01013dd3cb7f9