[INFO] fetching crate cellopt 0.3.0... [INFO] checking cellopt-0.3.0 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate cellopt 0.3.0 into /workspace/builds/worker-1-tc2/source [INFO] validating manifest of crates.io crate cellopt 0.3.0 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate cellopt 0.3.0 [INFO] finished tweaking crates.io crate cellopt 0.3.0 [INFO] tweaked toml for crates.io crate cellopt 0.3.0 written to /workspace/builds/worker-1-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 48a29c0cf725239876cb8a67d8872e1ea7d92e4169dcdb7a2bc96f414af03270 [INFO] running `Command { std: "docker" "start" "-a" "48a29c0cf725239876cb8a67d8872e1ea7d92e4169dcdb7a2bc96f414af03270", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "48a29c0cf725239876cb8a67d8872e1ea7d92e4169dcdb7a2bc96f414af03270", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "48a29c0cf725239876cb8a67d8872e1ea7d92e4169dcdb7a2bc96f414af03270", kill_on_drop: false }` [INFO] [stdout] 48a29c0cf725239876cb8a67d8872e1ea7d92e4169dcdb7a2bc96f414af03270 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 5f85b586e3b0cfd95520753a6886fbfd68838cc4fe7042eea646cab26d067056 [INFO] running `Command { std: "docker" "start" "-a" "5f85b586e3b0cfd95520753a6886fbfd68838cc4fe7042eea646cab26d067056", kill_on_drop: false }` [INFO] [stderr] Checking cellopt v0.3.0 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:18:54 [INFO] [stdout] | [INFO] [stdout] 18 | self.apply_then_restore(|inner| CellOpt::new(inner.clone())) [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:45:19 [INFO] [stdout] | [INFO] [stdout] 43 | pub fn new(value: T) -> Self { [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 44 | Self { [INFO] [stdout] 45 | slot: Cell::new(value.into()), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:51:9 [INFO] [stdout] | [INFO] [stdout] 50 | pub fn apply_then_restore U>(&self, mut f: F) -> Option { [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 51 | / self.take() [INFO] [stdout] 52 | | .map(|t| { [INFO] [stdout] 53 | | let u = f(&t); [INFO] [stdout] 54 | | self.overwrite(t); [INFO] [stdout] 55 | | u [INFO] [stdout] 56 | | }) [INFO] [stdout] | |______________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `cellopt` (lib test) due to 4 previous errors [INFO] [stdout] error: aborting due to 3 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:18:54 [INFO] [stdout] | [INFO] [stdout] 18 | self.apply_then_restore(|inner| CellOpt::new(inner.clone())) [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:45:19 [INFO] [stdout] | [INFO] [stdout] 43 | pub fn new(value: T) -> Self { [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 44 | Self { [INFO] [stdout] 45 | slot: Cell::new(value.into()), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:51:9 [INFO] [stdout] | [INFO] [stdout] 50 | pub fn apply_then_restore U>(&self, mut f: F) -> Option { [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 51 | / self.take() [INFO] [stdout] 52 | | .map(|t| { [INFO] [stdout] 53 | | let u = f(&t); [INFO] [stdout] 54 | | self.overwrite(t); [INFO] [stdout] 55 | | u [INFO] [stdout] 56 | | }) [INFO] [stdout] | |______________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 3 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `cellopt` (lib) due to 4 previous errors [INFO] running `Command { std: "docker" "inspect" "5f85b586e3b0cfd95520753a6886fbfd68838cc4fe7042eea646cab26d067056", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "5f85b586e3b0cfd95520753a6886fbfd68838cc4fe7042eea646cab26d067056", kill_on_drop: false }` [INFO] [stdout] 5f85b586e3b0cfd95520753a6886fbfd68838cc4fe7042eea646cab26d067056