[INFO] fetching crate cdx 0.1.22... [INFO] checking cdx-0.1.22 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate cdx 0.1.22 into /workspace/builds/worker-3-tc2/source [INFO] validating manifest of crates.io crate cdx 0.1.22 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate cdx 0.1.22 [INFO] finished tweaking crates.io crate cdx 0.1.22 [INFO] tweaked toml for crates.io crate cdx 0.1.22 written to /workspace/builds/worker-3-tc2/source/Cargo.toml [INFO] crate crates.io crate cdx 0.1.22 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 5fd8ad949cb9721055fc32bddfefdbd4b1c831199cbd19518bb68c23635e29b2 [INFO] running `Command { std: "docker" "start" "-a" "5fd8ad949cb9721055fc32bddfefdbd4b1c831199cbd19518bb68c23635e29b2", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "5fd8ad949cb9721055fc32bddfefdbd4b1c831199cbd19518bb68c23635e29b2", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "5fd8ad949cb9721055fc32bddfefdbd4b1c831199cbd19518bb68c23635e29b2", kill_on_drop: false }` [INFO] [stdout] 5fd8ad949cb9721055fc32bddfefdbd4b1c831199cbd19518bb68c23635e29b2 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] a02b270dbc17a342f7f31d5e9cf400be2a8ae81055ac54d722700d726d3fbd65 [INFO] running `Command { std: "docker" "start" "-a" "a02b270dbc17a342f7f31d5e9cf400be2a8ae81055ac54d722700d726d3fbd65", kill_on_drop: false }` [INFO] [stderr] Compiling libc v0.2.154 [INFO] [stderr] Compiling proc-macro2 v1.0.81 [INFO] [stderr] Checking subtle v2.5.0 [INFO] [stderr] Compiling libm v0.2.8 [INFO] [stderr] Checking zeroize v1.7.0 [INFO] [stderr] Compiling num-traits v0.2.19 [INFO] [stderr] Checking http v0.2.12 [INFO] [stderr] Checking either v1.11.0 [INFO] [stderr] Checking http v1.1.0 [INFO] [stderr] Checking ryu v1.0.17 [INFO] [stderr] Compiling cc v1.0.97 [INFO] [stderr] Compiling semver v1.0.22 [INFO] [stderr] Compiling ahash v0.8.11 [INFO] [stderr] Checking const-oid v0.9.6 [INFO] [stderr] Compiling crc32fast v1.4.0 [INFO] [stderr] Checking zerocopy v0.7.33 [INFO] [stderr] Checking digest v0.10.7 [INFO] [stderr] Checking bytes-utils v0.1.4 [INFO] [stderr] Checking base64ct v1.6.0 [INFO] [stderr] Checking allocator-api2 v0.2.18 [INFO] [stderr] Checking der v0.6.1 [INFO] [stderr] Checking base16ct v0.1.1 [INFO] [stderr] Compiling httparse v1.8.0 [INFO] [stderr] Checking log v0.4.21 [INFO] [stderr] Checking tower-service v0.3.2 [INFO] [stderr] Compiling rustc_version v0.4.0 [INFO] [stderr] Checking uuid v1.8.0 [INFO] [stderr] Checking tinyvec v1.6.0 [INFO] [stderr] Checking hmac v0.12.1 [INFO] [stderr] Checking sha2 v0.10.8 [INFO] [stderr] Checking regex-lite v0.1.5 [INFO] [stderr] Checking memchr v2.7.2 [INFO] [stderr] Checking ppv-lite86 v0.2.17 [INFO] [stderr] Checking hashbrown v0.14.5 [INFO] [stderr] Checking md-5 v0.10.6 [INFO] [stderr] Checking sha1 v0.10.6 [INFO] [stderr] Compiling aws-types v1.2.0 [INFO] [stderr] Compiling quote v1.0.36 [INFO] [stderr] Compiling crc32c v0.6.5 [INFO] [stderr] Checking getrandom v0.2.15 [INFO] [stderr] Checking parking_lot_core v0.9.10 [INFO] [stderr] Checking num_cpus v1.16.0 [INFO] [stderr] Checking mio v0.8.11 [INFO] [stderr] Checking socket2 v0.5.7 [INFO] [stderr] Checking signal-hook-registry v1.4.2 [INFO] [stderr] Checking http-body v0.4.6 [INFO] [stderr] Checking http-body v1.0.0 [INFO] [stderr] Compiling syn v2.0.60 [INFO] [stderr] Checking rand_core v0.6.4 [INFO] [stderr] Checking parking_lot v0.12.2 [INFO] [stderr] Checking http-body-util v0.1.1 [INFO] [stderr] Checking aho-corasick v1.1.3 [INFO] [stderr] Checking spki v0.6.0 [INFO] [stderr] Checking linux-raw-sys v0.4.13 [INFO] [stderr] Checking os_str_bytes v6.6.1 [INFO] [stderr] Checking unicode-normalization v0.1.23 [INFO] [stderr] Checking indexmap v2.2.6 [INFO] [stderr] Compiling anyhow v1.0.83 [INFO] [stderr] Checking pkcs8 v0.9.0 [INFO] [stderr] Checking bitflags v2.5.0 [INFO] [stderr] Compiling ring v0.17.8 [INFO] [stderr] Checking regex-syntax v0.8.3 [INFO] [stderr] Checking ff v0.12.1 [INFO] [stderr] Checking crypto-bigint v0.4.9 [INFO] [stderr] Checking signature v1.6.4 [INFO] [stderr] Checking crypto-bigint v0.5.5 [INFO] [stderr] Checking rand_chacha v0.3.1 [INFO] [stderr] Checking group v0.12.1 [INFO] [stderr] Checking sec1 v0.3.0 [INFO] [stderr] Checking clap_lex v0.2.4 [INFO] [stderr] Checking lru v0.12.3 [INFO] [stderr] Checking miniz_oxide v0.7.2 [INFO] [stderr] Checking rand v0.8.5 [INFO] [stderr] Checking rustix v0.38.34 [INFO] [stderr] Checking atty v0.2.14 [INFO] [stderr] Checking itertools v0.12.1 [INFO] [stderr] Checking strsim v0.10.0 [INFO] [stderr] Checking compare v0.1.0 [INFO] [stderr] Checking textwrap v0.16.1 [INFO] [stderr] Checking unicode-width v0.1.12 [INFO] [stderr] Checking binary-heap-plus v0.5.0 [INFO] [stderr] Checking clap v3.2.25 [INFO] [stderr] Checking idna v0.5.0 [INFO] [stderr] Checking memmap2 v0.9.4 [INFO] [stderr] Checking num-integer v0.1.46 [INFO] [stderr] Checking flate2 v1.0.30 [INFO] [stderr] Checking rand_distr v0.4.3 [INFO] [stderr] Checking elliptic-curve v0.12.3 [INFO] [stderr] Checking rfc6979 v0.3.1 [INFO] [stderr] Checking url v2.5.0 [INFO] [stderr] Checking ecdsa v0.14.8 [INFO] [stderr] Checking unicode-truncate v1.0.0 [INFO] [stderr] Checking p256 v0.11.1 [INFO] [stderr] Checking regex-automata v0.4.6 [INFO] [stderr] Checking tempfile v3.10.1 [INFO] [stderr] Compiling tokio-macros v2.2.0 [INFO] [stderr] Compiling tracing-attributes v0.1.27 [INFO] [stderr] Checking regex v1.10.4 [INFO] [stderr] Checking tokio v1.37.0 [INFO] [stderr] Compiling rustls v0.21.12 [INFO] [stderr] Checking tracing v0.1.40 [INFO] [stderr] Checking sct v0.7.1 [INFO] [stderr] Checking rustls-webpki v0.101.7 [INFO] [stderr] Checking tokio-util v0.7.11 [INFO] [stderr] Checking aws-smithy-async v1.2.1 [INFO] [stderr] Checking tokio-rustls v0.24.1 [INFO] [stderr] Checking aws-smithy-types v1.1.8 [INFO] [stderr] Checking h2 v0.3.26 [INFO] [stderr] Checking aws-smithy-runtime-api v1.5.0 [INFO] [stderr] Checking aws-smithy-eventstream v0.60.4 [INFO] [stderr] Checking aws-smithy-json v0.60.7 [INFO] [stderr] Checking aws-smithy-query v0.60.7 [INFO] [stderr] Checking aws-smithy-http v0.60.8 [INFO] [stderr] Checking aws-credential-types v1.2.0 [INFO] [stderr] Checking aws-sigv4 v1.2.1 [INFO] [stderr] Checking aws-smithy-checksums v0.60.7 [INFO] [stderr] Checking aws-runtime v1.2.0 [INFO] [stderr] Checking hyper v0.14.28 [INFO] [stderr] Checking hyper-rustls v0.24.2 [INFO] [stderr] Checking aws-smithy-runtime v1.4.0 [INFO] [stderr] Checking aws-sdk-ssooidc v1.22.0 [INFO] [stderr] Checking aws-sdk-sso v1.22.0 [INFO] [stderr] Checking aws-sdk-sts v1.22.0 [INFO] [stderr] Checking aws-sdk-s3 v1.25.0 [INFO] [stderr] Checking aws-config v1.3.0 [INFO] [stderr] Checking cdx v0.1.22 (/opt/rustwide/workdir) [INFO] [stdout] warning: unnecessary qualification [INFO] [stdout] --> src/comp.rs:816:23 [INFO] [stdout] | [INFO] [stdout] 816 | const _: () = assert!(std::mem::size_of::() == 16); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] note: the lint level is defined here [INFO] [stdout] --> src/lib.rs:31:5 [INFO] [stdout] | [INFO] [stdout] 31 | unused_qualifications, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] help: remove the unnecessary path segments [INFO] [stdout] | [INFO] [stdout] 816 - const _: () = assert!(std::mem::size_of::() == 16); [INFO] [stdout] 816 + const _: () = assert!(size_of::() == 16); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary qualification [INFO] [stdout] --> src/sort.rs:348:40 [INFO] [stdout] | [INFO] [stdout] 348 | let ptr_size = max_alloc / 2 / std::mem::size_of::(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] help: remove the unnecessary path segments [INFO] [stdout] | [INFO] [stdout] 348 - let ptr_size = max_alloc / 2 / std::mem::size_of::(); [INFO] [stdout] 348 + let ptr_size = max_alloc / 2 / size_of::(); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary qualification [INFO] [stdout] --> src/comp.rs:816:23 [INFO] [stdout] | [INFO] [stdout] 816 | const _: () = assert!(std::mem::size_of::() == 16); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] note: the lint level is defined here [INFO] [stdout] --> src/lib.rs:31:5 [INFO] [stdout] | [INFO] [stdout] 31 | unused_qualifications, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] help: remove the unnecessary path segments [INFO] [stdout] | [INFO] [stdout] 816 - const _: () = assert!(std::mem::size_of::() == 16); [INFO] [stdout] 816 + const _: () = assert!(size_of::() == 16); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary qualification [INFO] [stdout] --> src/sort.rs:348:40 [INFO] [stdout] | [INFO] [stdout] 348 | let ptr_size = max_alloc / 2 / std::mem::size_of::(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] help: remove the unnecessary path segments [INFO] [stdout] | [INFO] [stdout] 348 - let ptr_size = max_alloc / 2 / std::mem::size_of::(); [INFO] [stdout] 348 + let ptr_size = max_alloc / 2 / size_of::(); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/agg.rs:1328:20 [INFO] [stdout] | [INFO] [stdout] 1328 | |p| Ok(Rc::new(RefCell::new(Min::new(p)?))), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/agg.rs:1333:20 [INFO] [stdout] | [INFO] [stdout] 1333 | |p| Ok(Rc::new(RefCell::new(Max::new(p)?))), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/binsearch.rs:40:12 [INFO] [stdout] | [INFO] [stdout] 25 | let file = fs::File::open(fname)?; [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 26 | let map = unsafe { memmap2::Mmap::map(&file)? }; [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 40 | Ok(Self { [INFO] [stdout] | ____________^ [INFO] [stdout] 41 | | map, [INFO] [stdout] 42 | | header_len, [INFO] [stdout] 43 | | header, [INFO] [stdout] 44 | | delim, [INFO] [stdout] 45 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/column.rs:1299:12 [INFO] [stdout] | [INFO] [stdout] 1292 | let mut g = ColumnSet::new(); [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 1293 | g.add_yes(parts.1)?; [INFO] [stdout] 1294 | let cols = Box::new(ReaderColumns::new(g)); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 1299 | Ok(Self { [INFO] [stdout] | ____________^ [INFO] [stdout] 1300 | | cols, [INFO] [stdout] 1301 | | name: parts.0.to_string(), [INFO] [stdout] 1302 | | text, [INFO] [stdout] 1303 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/comp.rs:484:12 [INFO] [stdout] | [INFO] [stdout] 479 | fn new(comp: Comp, spec: &str) -> Result { [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 484 | Ok(Self { cols, comp }) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/comp.rs:899:21 [INFO] [stdout] | [INFO] [stdout] 899 | |_p| Ok(Box::new(Comparef64::new())), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/matcher.rs:638:12 [INFO] [stdout] | [INFO] [stdout] 636 | let mut d = HashSet::new(); [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 637 | load_hashset(&mut d, file_name)?; [INFO] [stdout] 638 | Ok(Self { [INFO] [stdout] | ____________^ [INFO] [stdout] 639 | | data: d, [INFO] [stdout] 640 | | file_name: file_name.to_string(), [INFO] [stdout] 641 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/matcher.rs:693:12 [INFO] [stdout] | [INFO] [stdout] 691 | let mut d = HashSet::new(); [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 692 | load_hashset_c(&mut d, file_name, unicode)?; [INFO] [stdout] 693 | Ok(Self { [INFO] [stdout] | ____________^ [INFO] [stdout] 694 | | data: d, [INFO] [stdout] 695 | | file_name: file_name.to_string(), [INFO] [stdout] 696 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/matcher.rs:977:12 [INFO] [stdout] | [INFO] [stdout] 958 | let op1 = pattern[0..2].parse::(); [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 975 | let (col, rest) = ColGroup::new_with(pattern)?; [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 976 | let comp = CompMaker::make_comp(rest)?; [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 977 | Ok(Self { [INFO] [stdout] | ____________^ [INFO] [stdout] 978 | | target, [INFO] [stdout] 979 | | op, [INFO] [stdout] 980 | | col, [INFO] [stdout] 981 | | comp, [INFO] [stdout] 982 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/matcher.rs:1668:23 [INFO] [stdout] | [INFO] [stdout] 1668 | |m, p| Ok(Box::new(RegexMatch::new(p, m.case)?)), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/matcher.rs:1673:24 [INFO] [stdout] | [INFO] [stdout] 1673 | |_m, p| Ok(Box::new(CheckBuff::new(p)?)), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/matcher.rs:1700:24 [INFO] [stdout] | [INFO] [stdout] 1700 | |_m, p| Ok(Box::new(LengthMatch::new(p)?)), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/matcher.rs:1702:60 [INFO] [stdout] | [INFO] [stdout] 1702 | Self::do_push("yes", "always matches", |_m, _p| Ok(Box::new(YesMatch {})))?; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/sort.rs:81:66 [INFO] [stdout] | [INFO] [stdout] 81 | let mut heap = BinaryHeap::new_by(|a: &usize, b: &usize| mc.borrow_mut().compare(*a, *b)); [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/sort.rs:354:18 [INFO] [stdout] | [INFO] [stdout] 343 | pub fn new(cmp: LineCompList, max_alloc: usize, unique: bool) -> Self { [INFO] [stdout] | ----------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 354 | tmp: TempDir::new().unwrap(), // FIXME - new should return Result [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/sort.rs:574:20 [INFO] [stdout] | [INFO] [stdout] 573 | fn new_node(left: NodeType, right: NodeType) -> Self { [INFO] [stdout] | -------------- --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 574 | Self::Node(NodeData::new(left, right)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/textgen.rs:306:20 [INFO] [stdout] | [INFO] [stdout] 306 | |p| Ok(Box::new(ExprGen::new(p)?)), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/textgen.rs:314:59 [INFO] [stdout] | [INFO] [stdout] 314 | Self::do_push("grid", "Produce line_col", |_p| Ok(Box::new(GridGen {})))?; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/util.rs:1044:12 [INFO] [stdout] | [INFO] [stdout] 1037 | let rt = tokio::runtime::Builder::new_current_thread() [INFO] [stdout] | -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 1041 | let shared_config = rt.block_on(aws_config::load_defaults(version)); [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 1042 | let client = aws_sdk_s3::Client::new(&shared_config); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 1043 | let obj = rt.block_on(client.get_object().bucket(bucket).key(key).send())?; [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 1044 | Ok(Self { [INFO] [stdout] | ____________^ [INFO] [stdout] 1045 | | // name : key.to_string(), [INFO] [stdout] 1046 | | rt, [INFO] [stdout] 1047 | | // client, [INFO] [stdout] 1048 | | f: obj, [INFO] [stdout] 1049 | | left: None, [INFO] [stdout] 1050 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/util.rs:1213:8 [INFO] [stdout] | [INFO] [stdout] 1204 | let inner: Box = { [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 1213 | Ok(Outfile::new(io::BufWriter::new(inner), name)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/util.rs:1260:8 [INFO] [stdout] | [INFO] [stdout] 1243 | let inner: Box = { [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 1255 | let mut outer = io::BufReader::new(inner); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 1260 | Ok(Infile::new(outer, name)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 21 previous errors; 2 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/agg.rs:1328:20 [INFO] [stdout] | [INFO] [stdout] 1328 | |p| Ok(Rc::new(RefCell::new(Min::new(p)?))), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/agg.rs:1333:20 [INFO] [stdout] | [INFO] [stdout] 1333 | |p| Ok(Rc::new(RefCell::new(Max::new(p)?))), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/binsearch.rs:40:12 [INFO] [stdout] | [INFO] [stdout] 25 | let file = fs::File::open(fname)?; [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 26 | let map = unsafe { memmap2::Mmap::map(&file)? }; [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 40 | Ok(Self { [INFO] [stdout] | ____________^ [INFO] [stdout] 41 | | map, [INFO] [stdout] 42 | | header_len, [INFO] [stdout] 43 | | header, [INFO] [stdout] 44 | | delim, [INFO] [stdout] 45 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/column.rs:1299:12 [INFO] [stdout] | [INFO] [stdout] 1292 | let mut g = ColumnSet::new(); [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 1293 | g.add_yes(parts.1)?; [INFO] [stdout] 1294 | let cols = Box::new(ReaderColumns::new(g)); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 1299 | Ok(Self { [INFO] [stdout] | ____________^ [INFO] [stdout] 1300 | | cols, [INFO] [stdout] 1301 | | name: parts.0.to_string(), [INFO] [stdout] 1302 | | text, [INFO] [stdout] 1303 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/comp.rs:484:12 [INFO] [stdout] | [INFO] [stdout] 479 | fn new(comp: Comp, spec: &str) -> Result { [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 484 | Ok(Self { cols, comp }) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/comp.rs:899:21 [INFO] [stdout] | [INFO] [stdout] 899 | |_p| Ok(Box::new(Comparef64::new())), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/matcher.rs:638:12 [INFO] [stdout] | [INFO] [stdout] 636 | let mut d = HashSet::new(); [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 637 | load_hashset(&mut d, file_name)?; [INFO] [stdout] 638 | Ok(Self { [INFO] [stdout] | ____________^ [INFO] [stdout] 639 | | data: d, [INFO] [stdout] 640 | | file_name: file_name.to_string(), [INFO] [stdout] 641 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/matcher.rs:693:12 [INFO] [stdout] | [INFO] [stdout] 691 | let mut d = HashSet::new(); [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 692 | load_hashset_c(&mut d, file_name, unicode)?; [INFO] [stdout] 693 | Ok(Self { [INFO] [stdout] | ____________^ [INFO] [stdout] 694 | | data: d, [INFO] [stdout] 695 | | file_name: file_name.to_string(), [INFO] [stdout] 696 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/matcher.rs:977:12 [INFO] [stdout] | [INFO] [stdout] 958 | let op1 = pattern[0..2].parse::(); [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 975 | let (col, rest) = ColGroup::new_with(pattern)?; [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 976 | let comp = CompMaker::make_comp(rest)?; [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 977 | Ok(Self { [INFO] [stdout] | ____________^ [INFO] [stdout] 978 | | target, [INFO] [stdout] 979 | | op, [INFO] [stdout] 980 | | col, [INFO] [stdout] 981 | | comp, [INFO] [stdout] 982 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/matcher.rs:1668:23 [INFO] [stdout] | [INFO] [stdout] 1668 | |m, p| Ok(Box::new(RegexMatch::new(p, m.case)?)), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/matcher.rs:1673:24 [INFO] [stdout] | [INFO] [stdout] 1673 | |_m, p| Ok(Box::new(CheckBuff::new(p)?)), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/matcher.rs:1700:24 [INFO] [stdout] | [INFO] [stdout] 1700 | |_m, p| Ok(Box::new(LengthMatch::new(p)?)), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/matcher.rs:1702:60 [INFO] [stdout] | [INFO] [stdout] 1702 | Self::do_push("yes", "always matches", |_m, _p| Ok(Box::new(YesMatch {})))?; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/sort.rs:81:66 [INFO] [stdout] | [INFO] [stdout] 81 | let mut heap = BinaryHeap::new_by(|a: &usize, b: &usize| mc.borrow_mut().compare(*a, *b)); [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/sort.rs:354:18 [INFO] [stdout] | [INFO] [stdout] 343 | pub fn new(cmp: LineCompList, max_alloc: usize, unique: bool) -> Self { [INFO] [stdout] | ----------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 354 | tmp: TempDir::new().unwrap(), // FIXME - new should return Result [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/sort.rs:574:20 [INFO] [stdout] | [INFO] [stdout] 573 | fn new_node(left: NodeType, right: NodeType) -> Self { [INFO] [stdout] | -------------- --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 574 | Self::Node(NodeData::new(left, right)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/textgen.rs:306:20 [INFO] [stdout] | [INFO] [stdout] 306 | |p| Ok(Box::new(ExprGen::new(p)?)), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `cdx` (lib) due to 22 previous errors; 2 warnings emitted [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/textgen.rs:314:59 [INFO] [stdout] | [INFO] [stdout] 314 | Self::do_push("grid", "Produce line_col", |_p| Ok(Box::new(GridGen {})))?; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/util.rs:1044:12 [INFO] [stdout] | [INFO] [stdout] 1037 | let rt = tokio::runtime::Builder::new_current_thread() [INFO] [stdout] | -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 1041 | let shared_config = rt.block_on(aws_config::load_defaults(version)); [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 1042 | let client = aws_sdk_s3::Client::new(&shared_config); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 1043 | let obj = rt.block_on(client.get_object().bucket(bucket).key(key).send())?; [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 1044 | Ok(Self { [INFO] [stdout] | ____________^ [INFO] [stdout] 1045 | | // name : key.to_string(), [INFO] [stdout] 1046 | | rt, [INFO] [stdout] 1047 | | // client, [INFO] [stdout] 1048 | | f: obj, [INFO] [stdout] 1049 | | left: None, [INFO] [stdout] 1050 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/util.rs:1213:8 [INFO] [stdout] | [INFO] [stdout] 1204 | let inner: Box = { [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 1213 | Ok(Outfile::new(io::BufWriter::new(inner), name)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/util.rs:1260:8 [INFO] [stdout] | [INFO] [stdout] 1243 | let inner: Box = { [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 1255 | let mut outer = io::BufReader::new(inner); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 1260 | Ok(Infile::new(outer, name)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 21 previous errors; 2 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `cdx` (lib test) due to 22 previous errors; 2 warnings emitted [INFO] running `Command { std: "docker" "inspect" "a02b270dbc17a342f7f31d5e9cf400be2a8ae81055ac54d722700d726d3fbd65", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "a02b270dbc17a342f7f31d5e9cf400be2a8ae81055ac54d722700d726d3fbd65", kill_on_drop: false }` [INFO] [stdout] a02b270dbc17a342f7f31d5e9cf400be2a8ae81055ac54d722700d726d3fbd65