[INFO] fetching crate cdb 0.6.0... [INFO] checking cdb-0.6.0 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate cdb 0.6.0 into /workspace/builds/worker-1-tc2/source [INFO] validating manifest of crates.io crate cdb 0.6.0 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate cdb 0.6.0 [INFO] finished tweaking crates.io crate cdb 0.6.0 [INFO] tweaked toml for crates.io crate cdb 0.6.0 written to /workspace/builds/worker-1-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 61 packages to latest compatible versions [INFO] [stderr] Adding bitflags v1.3.2 (latest: v2.6.0) [INFO] [stderr] Adding cast v0.2.7 (latest: v0.3.0) [INFO] [stderr] Adding clap v2.34.0 (latest: v4.5.16) [INFO] [stderr] Adding cloudabi v0.0.3 (latest: v0.1.0) [INFO] [stderr] Adding criterion v0.2.11 (latest: v0.5.1) [INFO] [stderr] Adding criterion-plot v0.3.1 (latest: v0.5.0) [INFO] [stderr] Adding filebuffer v0.4.0 (latest: v1.0.0) [INFO] [stderr] Adding hermit-abi v0.1.19 (latest: v0.4.0) [INFO] [stderr] Adding itertools v0.8.2 (latest: v0.13.0) [INFO] [stderr] Adding rand_core v0.3.1 (latest: v0.6.4) [INFO] [stderr] Adding rand_core v0.4.2 (latest: v0.6.4) [INFO] [stderr] Adding rand_os v0.1.3 (latest: v0.2.2) [INFO] [stderr] Adding rand_xoshiro v0.1.0 (latest: v0.6.0) [INFO] [stderr] Adding rdrand v0.4.0 (latest: v0.8.3) [INFO] [stderr] Adding textwrap v0.11.0 (latest: v0.16.1) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] warning: no edition set: defaulting to the 2015 edition while the latest is 2021 [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 4c7f4a851b5bcbd1d1f51d2fe46cfd48b85b61f54bf54a8cec3f4f89d37c8de7 [INFO] running `Command { std: "docker" "start" "-a" "4c7f4a851b5bcbd1d1f51d2fe46cfd48b85b61f54bf54a8cec3f4f89d37c8de7", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "4c7f4a851b5bcbd1d1f51d2fe46cfd48b85b61f54bf54a8cec3f4f89d37c8de7", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "4c7f4a851b5bcbd1d1f51d2fe46cfd48b85b61f54bf54a8cec3f4f89d37c8de7", kill_on_drop: false }` [INFO] [stdout] 4c7f4a851b5bcbd1d1f51d2fe46cfd48b85b61f54bf54a8cec3f4f89d37c8de7 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 128df8ee74f59ca06d7206355d3240b5db6c410e32d96c8fc7af99fb6170fc69 [INFO] running `Command { std: "docker" "start" "-a" "128df8ee74f59ca06d7206355d3240b5db6c410e32d96c8fc7af99fb6170fc69", kill_on_drop: false }` [INFO] [stderr] warning: no edition set: defaulting to the 2015 edition while the latest is 2021 [INFO] [stderr] Compiling crossbeam-utils v0.8.20 [INFO] [stderr] Compiling proc-macro2 v1.0.86 [INFO] [stderr] Checking rand_core v0.4.2 [INFO] [stderr] Checking csv-core v0.1.11 [INFO] [stderr] Checking itertools v0.8.2 [INFO] [stderr] Checking textwrap v0.11.0 [INFO] [stderr] Compiling cast v0.2.7 [INFO] [stderr] Checking serde_json v1.0.127 [INFO] [stderr] Checking filebuffer v0.4.0 [INFO] [stderr] Checking atty v0.2.14 [INFO] [stderr] Checking rand_core v0.3.1 [INFO] [stderr] Checking rand_os v0.1.3 [INFO] [stderr] Checking rand_xoshiro v0.1.0 [INFO] [stderr] Checking cdb v0.6.0 (/opt/rustwide/workdir) [INFO] [stderr] Checking clap v2.34.0 [INFO] [stdout] warning: use of deprecated macro `try`: use the `?` operator instead [INFO] [stdout] --> src/reader.rs:79:13 [INFO] [stdout] | [INFO] [stdout] 79 | try!(self.read(&mut buf[..n], pos)); [INFO] [stdout] | ^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(deprecated)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated macro `try`: use the `?` operator instead [INFO] [stdout] --> src/reader.rs:174:9 [INFO] [stdout] | [INFO] [stdout] 174 | try!(self.cdb.read(&mut result[..], self.dpos)); [INFO] [stdout] | ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated macro `try`: use the `?` operator instead [INFO] [stdout] --> src/writer.rs:56:9 [INFO] [stdout] | [INFO] [stdout] 56 | try!(w.seek(io::SeekFrom::Start(0))); [INFO] [stdout] | ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated macro `try`: use the `?` operator instead [INFO] [stdout] --> src/writer.rs:57:9 [INFO] [stdout] | [INFO] [stdout] 57 | try!(w.write(&buf)); [INFO] [stdout] | ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated macro `try`: use the `?` operator instead [INFO] [stdout] --> src/writer.rs:77:9 [INFO] [stdout] | [INFO] [stdout] 77 | try!(self.pos_plus(8)); [INFO] [stdout] | ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated macro `try`: use the `?` operator instead [INFO] [stdout] --> src/writer.rs:78:9 [INFO] [stdout] | [INFO] [stdout] 78 | try!(self.pos_plus(keylen)); [INFO] [stdout] | ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated macro `try`: use the `?` operator instead [INFO] [stdout] --> src/writer.rs:79:9 [INFO] [stdout] | [INFO] [stdout] 79 | try!(self.pos_plus(datalen)); [INFO] [stdout] | ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated macro `try`: use the `?` operator instead [INFO] [stdout] --> src/writer.rs:86:9 [INFO] [stdout] | [INFO] [stdout] 86 | try!(self.file.write(&buf)); [INFO] [stdout] | ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated macro `try`: use the `?` operator instead [INFO] [stdout] --> src/writer.rs:95:9 [INFO] [stdout] | [INFO] [stdout] 95 | try!(self.add_begin(key.len() as u32, data.len() as u32)); [INFO] [stdout] | ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated macro `try`: use the `?` operator instead [INFO] [stdout] --> src/writer.rs:96:9 [INFO] [stdout] | [INFO] [stdout] 96 | try!(self.file.write(key)); [INFO] [stdout] | ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated macro `try`: use the `?` operator instead [INFO] [stdout] --> src/writer.rs:97:9 [INFO] [stdout] | [INFO] [stdout] 97 | try!(self.file.write(data)); [INFO] [stdout] | ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated macro `try`: use the `?` operator instead [INFO] [stdout] --> src/writer.rs:143:9 [INFO] [stdout] | [INFO] [stdout] 143 | try!(self.file.flush()); [INFO] [stdout] | ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated macro `try`: use the `?` operator instead [INFO] [stdout] --> src/writer.rs:144:9 [INFO] [stdout] | [INFO] [stdout] 144 | try!(self.file.seek(io::SeekFrom::Start(0))); [INFO] [stdout] | ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated macro `try`: use the `?` operator instead [INFO] [stdout] --> src/writer.rs:145:9 [INFO] [stdout] | [INFO] [stdout] 145 | try!(self.file.write(&header)); [INFO] [stdout] | ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated macro `try`: use the `?` operator instead [INFO] [stdout] --> src/writer.rs:146:9 [INFO] [stdout] | [INFO] [stdout] 146 | try!(self.file.flush()); [INFO] [stdout] | ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated macro `try`: use the `?` operator instead [INFO] [stdout] --> src/writer.rs:137:17 [INFO] [stdout] | [INFO] [stdout] 137 | try!(self.file.write(&buf)); [INFO] [stdout] | ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated macro `try`: use the `?` operator instead [INFO] [stdout] --> src/writer.rs:138:17 [INFO] [stdout] | [INFO] [stdout] 138 | try!(self.pos_plus(8)); [INFO] [stdout] | ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated macro `try`: use the `?` operator instead [INFO] [stdout] --> src/writer.rs:199:20 [INFO] [stdout] | [INFO] [stdout] 199 | let file = try!(fs::File::create(&tmpname)); [INFO] [stdout] | ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated macro `try`: use the `?` operator instead [INFO] [stdout] --> src/writer.rs:200:19 [INFO] [stdout] | [INFO] [stdout] 200 | let cdb = try!(CDBMake::new(file)); [INFO] [stdout] | ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated macro `try`: use the `?` operator instead [INFO] [stdout] --> src/writer.rs:224:9 [INFO] [stdout] | [INFO] [stdout] 224 | try!(self.cdb.take().unwrap().finish()); [INFO] [stdout] | ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated macro `try`: use the `?` operator instead [INFO] [stdout] --> src/writer.rs:225:9 [INFO] [stdout] | [INFO] [stdout] 225 | try!(fs::rename(&self.tmpname, &self.dstname)); [INFO] [stdout] | ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Checking csv v1.3.0 [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/reader.rs:48:12 [INFO] [stdout] | [INFO] [stdout] 42 | pub fn open>(filename: P) -> Result { [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 43 | let file = FileBuffer::open(&filename)?; [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 48 | Ok(CDB { [INFO] [stdout] | ____________^ [INFO] [stdout] 49 | | file, [INFO] [stdout] 50 | | size, [INFO] [stdout] 51 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/writer.rs:58:12 [INFO] [stdout] | [INFO] [stdout] 53 | pub fn new(file: fs::File) -> Result { [INFO] [stdout] | -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 54 | let mut w = io::BufWriter::new(file); [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 58 | Ok(CDBMake{ [INFO] [stdout] | ____________^ [INFO] [stdout] 59 | | entries: iter::repeat(vec![]).take(256).collect::>(), [INFO] [stdout] 60 | | pos: 2048, [INFO] [stdout] 61 | | file: w, [INFO] [stdout] 62 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/writer.rs:201:12 [INFO] [stdout] | [INFO] [stdout] 198 | Q: AsRef + string::ToString>(filename: P, tmpname: Q) -> Result { [INFO] [stdout] | ----------- ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 199 | let file = try!(fs::File::create(&tmpname)); [INFO] [stdout] | ---- -------------------------------- [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 200 | let cdb = try!(CDBMake::new(file)); [INFO] [stdout] | --- ------------------------ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 201 | Ok(CDBWriter { [INFO] [stdout] | ____________^ [INFO] [stdout] 202 | | dstname: filename.to_string(), [INFO] [stdout] 203 | | tmpname: tmpname.to_string(), [INFO] [stdout] 204 | | cdb: Some(cdb), [INFO] [stdout] 205 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 3 previous errors; 21 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `cdb` (lib) due to 4 previous errors; 21 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] running `Command { std: "docker" "inspect" "128df8ee74f59ca06d7206355d3240b5db6c410e32d96c8fc7af99fb6170fc69", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "128df8ee74f59ca06d7206355d3240b5db6c410e32d96c8fc7af99fb6170fc69", kill_on_drop: false }` [INFO] [stdout] 128df8ee74f59ca06d7206355d3240b5db6c410e32d96c8fc7af99fb6170fc69