[INFO] fetching crate cc6502 1.0.24... [INFO] checking cc6502-1.0.24 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate cc6502 1.0.24 into /workspace/builds/worker-1-tc2/source [INFO] validating manifest of crates.io crate cc6502 1.0.24 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate cc6502 1.0.24 [INFO] finished tweaking crates.io crate cc6502 1.0.24 [INFO] tweaked toml for crates.io crate cc6502 1.0.24 written to /workspace/builds/worker-1-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 56 packages to latest compatible versions [INFO] [stderr] Adding generic-array v0.14.7 (latest: v1.1.0) [INFO] [stderr] Adding windows-sys v0.52.0 (latest: v0.59.0) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] a9d1743230eb284010532ae1eef27b1e310361e7913cc6635b0ab20d0f36691a [INFO] running `Command { std: "docker" "start" "-a" "a9d1743230eb284010532ae1eef27b1e310361e7913cc6635b0ab20d0f36691a", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "a9d1743230eb284010532ae1eef27b1e310361e7913cc6635b0ab20d0f36691a", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "a9d1743230eb284010532ae1eef27b1e310361e7913cc6635b0ab20d0f36691a", kill_on_drop: false }` [INFO] [stdout] a9d1743230eb284010532ae1eef27b1e310361e7913cc6635b0ab20d0f36691a [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] d23b43c8ef74792c68bff7a7138c75fce36500dde638c2827bac0ede5828302c [INFO] running `Command { std: "docker" "start" "-a" "d23b43c8ef74792c68bff7a7138c75fce36500dde638c2827bac0ede5828302c", kill_on_drop: false }` [INFO] [stderr] Checking utf8parse v0.2.2 [INFO] [stderr] Compiling ucd-trie v0.1.6 [INFO] [stderr] Checking anstyle-query v1.1.1 [INFO] [stderr] Checking is_terminal_polyfill v1.70.1 [INFO] [stderr] Checking anstyle v1.0.8 [INFO] [stderr] Checking colorchoice v1.0.2 [INFO] [stderr] Checking strsim v0.11.1 [INFO] [stderr] Checking clap_lex v0.7.2 [INFO] [stderr] Compiling heck v0.5.0 [INFO] [stderr] Checking humantime v2.1.0 [INFO] [stderr] Checking env_filter v0.1.2 [INFO] [stderr] Compiling thiserror v1.0.63 [INFO] [stderr] Checking anstyle-parse v0.2.5 [INFO] [stderr] Compiling pest v2.7.11 [INFO] [stderr] Compiling clap_derive v4.5.13 [INFO] [stderr] Checking anstream v0.6.15 [INFO] [stderr] Checking clap_builder v4.5.15 [INFO] [stderr] Checking env_logger v0.11.5 [INFO] [stderr] Compiling pest_meta v2.7.11 [INFO] [stderr] Checking clap v4.5.16 [INFO] [stderr] Compiling pest_generator v2.7.11 [INFO] [stderr] Compiling pest_derive v2.7.11 [INFO] [stderr] Checking cc6502 v1.0.24 (/opt/rustwide/workdir) [INFO] [stdout] warning: unexpected `cfg` condition name: `constant_time` [INFO] [stdout] --> src/assemble.rs:70:11 [INFO] [stdout] | [INFO] [stdout] 70 | #[cfg(constant_time)] [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: expected names are: `clippy`, `debug_assertions`, `doc`, `docsrs`, `doctest`, `feature`, `miri`, `overflow_checks`, `panic`, `proc_macro`, `relocation_model`, `rustfmt`, `sanitize`, `sanitizer_cfi_generalize_pointers`, `sanitizer_cfi_normalize_integers`, `target_abi`, `target_arch`, `target_endian`, `target_env`, `target_family`, `target_feature`, `target_has_atomic`, `target_has_atomic_equal_alignment`, `target_has_atomic_load_store`, `target_os`, `target_pointer_width`, `target_thread_local`, `target_vendor`, `test`, `ub_checks`, `unix`, and `windows` [INFO] [stdout] = help: consider using a Cargo feature instead [INFO] [stdout] = help: or consider adding in `Cargo.toml` the `check-cfg` lint config for the lint: [INFO] [stdout] [lints.rust] [INFO] [stdout] unexpected_cfgs = { level = "warn", check-cfg = ['cfg(constant_time)'] } [INFO] [stdout] = help: or consider adding `println!("cargo::rustc-check-cfg=cfg(constant_time)");` to the top of the `build.rs` [INFO] [stdout] = note: see for more information about checking conditional configuration [INFO] [stdout] = note: `#[warn(unexpected_cfgs)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unexpected `cfg` condition name: `constant_time` [INFO] [stdout] --> src/assemble.rs:72:11 [INFO] [stdout] | [INFO] [stdout] 72 | #[cfg(constant_time)] [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: consider using a Cargo feature instead [INFO] [stdout] = help: or consider adding in `Cargo.toml` the `check-cfg` lint config for the lint: [INFO] [stdout] [lints.rust] [INFO] [stdout] unexpected_cfgs = { level = "warn", check-cfg = ['cfg(constant_time)'] } [INFO] [stdout] = help: or consider adding `println!("cargo::rustc-check-cfg=cfg(constant_time)");` to the top of the `build.rs` [INFO] [stdout] = note: see for more information about checking conditional configuration [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unexpected `cfg` condition name: `constant_time` [INFO] [stdout] --> src/generate/generate_arithm.rs:769:15 [INFO] [stdout] | [INFO] [stdout] 769 | #[cfg(constant_time)] [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: consider using a Cargo feature instead [INFO] [stdout] = help: or consider adding in `Cargo.toml` the `check-cfg` lint config for the lint: [INFO] [stdout] [lints.rust] [INFO] [stdout] unexpected_cfgs = { level = "warn", check-cfg = ['cfg(constant_time)'] } [INFO] [stdout] = help: or consider adding `println!("cargo::rustc-check-cfg=cfg(constant_time)");` to the top of the `build.rs` [INFO] [stdout] = note: see for more information about checking conditional configuration [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unexpected `cfg` condition name: `constant_time` [INFO] [stdout] --> src/generate/generate_arithm.rs:779:19 [INFO] [stdout] | [INFO] [stdout] 779 | #[cfg(not(constant_time))] [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: consider using a Cargo feature instead [INFO] [stdout] = help: or consider adding in `Cargo.toml` the `check-cfg` lint config for the lint: [INFO] [stdout] [lints.rust] [INFO] [stdout] unexpected_cfgs = { level = "warn", check-cfg = ['cfg(constant_time)'] } [INFO] [stdout] = help: or consider adding `println!("cargo::rustc-check-cfg=cfg(constant_time)");` to the top of the `build.rs` [INFO] [stdout] = note: see for more information about checking conditional configuration [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unexpected `cfg` condition name: `constant_time` [INFO] [stdout] --> src/assemble.rs:70:11 [INFO] [stdout] | [INFO] [stdout] 70 | #[cfg(constant_time)] [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: expected names are: `clippy`, `debug_assertions`, `doc`, `docsrs`, `doctest`, `feature`, `miri`, `overflow_checks`, `panic`, `proc_macro`, `relocation_model`, `rustfmt`, `sanitize`, `sanitizer_cfi_generalize_pointers`, `sanitizer_cfi_normalize_integers`, `target_abi`, `target_arch`, `target_endian`, `target_env`, `target_family`, `target_feature`, `target_has_atomic`, `target_has_atomic_equal_alignment`, `target_has_atomic_load_store`, `target_os`, `target_pointer_width`, `target_thread_local`, `target_vendor`, `test`, `ub_checks`, `unix`, and `windows` [INFO] [stdout] = help: consider using a Cargo feature instead [INFO] [stdout] = help: or consider adding in `Cargo.toml` the `check-cfg` lint config for the lint: [INFO] [stdout] [lints.rust] [INFO] [stdout] unexpected_cfgs = { level = "warn", check-cfg = ['cfg(constant_time)'] } [INFO] [stdout] = help: or consider adding `println!("cargo::rustc-check-cfg=cfg(constant_time)");` to the top of the `build.rs` [INFO] [stdout] = note: see for more information about checking conditional configuration [INFO] [stdout] = note: `#[warn(unexpected_cfgs)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unexpected `cfg` condition name: `constant_time` [INFO] [stdout] --> src/assemble.rs:72:11 [INFO] [stdout] | [INFO] [stdout] 72 | #[cfg(constant_time)] [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: consider using a Cargo feature instead [INFO] [stdout] = help: or consider adding in `Cargo.toml` the `check-cfg` lint config for the lint: [INFO] [stdout] [lints.rust] [INFO] [stdout] unexpected_cfgs = { level = "warn", check-cfg = ['cfg(constant_time)'] } [INFO] [stdout] = help: or consider adding `println!("cargo::rustc-check-cfg=cfg(constant_time)");` to the top of the `build.rs` [INFO] [stdout] = note: see for more information about checking conditional configuration [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unexpected `cfg` condition name: `constant_time` [INFO] [stdout] --> src/generate/generate_arithm.rs:769:15 [INFO] [stdout] | [INFO] [stdout] 769 | #[cfg(constant_time)] [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: consider using a Cargo feature instead [INFO] [stdout] = help: or consider adding in `Cargo.toml` the `check-cfg` lint config for the lint: [INFO] [stdout] [lints.rust] [INFO] [stdout] unexpected_cfgs = { level = "warn", check-cfg = ['cfg(constant_time)'] } [INFO] [stdout] = help: or consider adding `println!("cargo::rustc-check-cfg=cfg(constant_time)");` to the top of the `build.rs` [INFO] [stdout] = note: see for more information about checking conditional configuration [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unexpected `cfg` condition name: `constant_time` [INFO] [stdout] --> src/generate/generate_arithm.rs:779:19 [INFO] [stdout] | [INFO] [stdout] 779 | #[cfg(not(constant_time))] [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: consider using a Cargo feature instead [INFO] [stdout] = help: or consider adding in `Cargo.toml` the `check-cfg` lint config for the lint: [INFO] [stdout] [lints.rust] [INFO] [stdout] unexpected_cfgs = { level = "warn", check-cfg = ['cfg(constant_time)'] } [INFO] [stdout] = help: or consider adding `println!("cargo::rustc-check-cfg=cfg(constant_time)");` to the top of the `build.rs` [INFO] [stdout] = note: see for more information about checking conditional configuration [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/compile.rs:453:16 [INFO] [stdout] | [INFO] [stdout] 419 | .map_infix(|lhs, op, rhs| { [INFO] [stdout] | --- --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 453 | Ok(Expr::BinOp { [INFO] [stdout] | ________________^ [INFO] [stdout] 454 | | lhs: Box::new(lhs?), [INFO] [stdout] 455 | | op, [INFO] [stdout] 456 | | rhs: Box::new(rhs?), [INFO] [stdout] 457 | | }) [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/compile.rs:597:16 [INFO] [stdout] | [INFO] [stdout] 564 | .map_infix(|lhs, op, rhs| { [INFO] [stdout] | --- --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 597 | Ok(Expr::BinOp { [INFO] [stdout] | ________________^ [INFO] [stdout] 598 | | lhs: Box::new(lhs?), [INFO] [stdout] 599 | | op, [INFO] [stdout] 600 | | rhs: Box::new(rhs?), [INFO] [stdout] 601 | | }) [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/compile.rs:1482:12 [INFO] [stdout] | [INFO] [stdout] 1470 | let mut statements = Vec::::new(); [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 1482 | Ok(StatementLoc { [INFO] [stdout] | ____________^ [INFO] [stdout] 1483 | | pos, label: None, statement: Statement::Block(statements) [INFO] [stdout] 1484 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 3 previous errors; 4 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `cc6502` (lib) due to 4 previous errors; 4 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/compile.rs:453:16 [INFO] [stdout] | [INFO] [stdout] 419 | .map_infix(|lhs, op, rhs| { [INFO] [stdout] | --- --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 453 | Ok(Expr::BinOp { [INFO] [stdout] | ________________^ [INFO] [stdout] 454 | | lhs: Box::new(lhs?), [INFO] [stdout] 455 | | op, [INFO] [stdout] 456 | | rhs: Box::new(rhs?), [INFO] [stdout] 457 | | }) [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/compile.rs:597:16 [INFO] [stdout] | [INFO] [stdout] 564 | .map_infix(|lhs, op, rhs| { [INFO] [stdout] | --- --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 597 | Ok(Expr::BinOp { [INFO] [stdout] | ________________^ [INFO] [stdout] 598 | | lhs: Box::new(lhs?), [INFO] [stdout] 599 | | op, [INFO] [stdout] 600 | | rhs: Box::new(rhs?), [INFO] [stdout] 601 | | }) [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/compile.rs:1482:12 [INFO] [stdout] | [INFO] [stdout] 1470 | let mut statements = Vec::::new(); [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 1482 | Ok(StatementLoc { [INFO] [stdout] | ____________^ [INFO] [stdout] 1483 | | pos, label: None, statement: Statement::Block(statements) [INFO] [stdout] 1484 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 3 previous errors; 4 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `cc6502` (lib test) due to 4 previous errors; 4 warnings emitted [INFO] running `Command { std: "docker" "inspect" "d23b43c8ef74792c68bff7a7138c75fce36500dde638c2827bac0ede5828302c", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "d23b43c8ef74792c68bff7a7138c75fce36500dde638c2827bac0ede5828302c", kill_on_drop: false }` [INFO] [stdout] d23b43c8ef74792c68bff7a7138c75fce36500dde638c2827bac0ede5828302c