[INFO] fetching crate cbsk_log_rayon 2.0.1... [INFO] checking cbsk_log_rayon-2.0.1 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate cbsk_log_rayon 2.0.1 into /workspace/builds/worker-3-tc2/source [INFO] validating manifest of crates.io crate cbsk_log_rayon 2.0.1 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate cbsk_log_rayon 2.0.1 [INFO] finished tweaking crates.io crate cbsk_log_rayon 2.0.1 [INFO] tweaked toml for crates.io crate cbsk_log_rayon 2.0.1 written to /workspace/builds/worker-3-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 69 packages to latest compatible versions [INFO] [stderr] Adding windows-sys v0.52.0 (latest: v0.59.0) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 776ce853ff3290e78a890fc06ca59ffddb86a9d4a7fbdb11433616a30b943146 [INFO] running `Command { std: "docker" "start" "-a" "776ce853ff3290e78a890fc06ca59ffddb86a9d4a7fbdb11433616a30b943146", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "776ce853ff3290e78a890fc06ca59ffddb86a9d4a7fbdb11433616a30b943146", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "776ce853ff3290e78a890fc06ca59ffddb86a9d4a7fbdb11433616a30b943146", kill_on_drop: false }` [INFO] [stdout] 776ce853ff3290e78a890fc06ca59ffddb86a9d4a7fbdb11433616a30b943146 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 8cf3610f6dcd88e62df1ab1fb0e04254431a89325401d8e968c05634bfd505da [INFO] running `Command { std: "docker" "start" "-a" "8cf3610f6dcd88e62df1ab1fb0e04254431a89325401d8e968c05634bfd505da", kill_on_drop: false }` [INFO] [stderr] Compiling serde v1.0.209 [INFO] [stderr] Compiling parking_lot_core v0.9.10 [INFO] [stderr] Checking smallvec v1.13.2 [INFO] [stderr] Checking crc32fast v1.4.2 [INFO] [stderr] Compiling lock_api v0.4.12 [INFO] [stderr] Checking adler2 v2.0.0 [INFO] [stderr] Checking cbsk_mut_data v2.0.0 [INFO] [stderr] Checking simd-adler32 v0.3.7 [INFO] [stderr] Checking bumpalo v3.16.0 [INFO] [stderr] Checking lockfree-object-pool v0.1.6 [INFO] [stderr] Compiling zip v2.2.0 [INFO] [stderr] Checking crossbeam-queue v0.3.11 [INFO] [stderr] Checking crossbeam-channel v0.5.13 [INFO] [stderr] Checking rayon v1.10.0 [INFO] [stderr] Compiling displaydoc v0.2.5 [INFO] [stderr] Checking miniz_oxide v0.8.0 [INFO] [stderr] Checking zopfli v0.8.1 [INFO] [stderr] Checking crossbeam v0.8.4 [INFO] [stderr] Checking parking_lot v0.12.3 [INFO] [stderr] Checking flate2 v1.0.33 [INFO] [stderr] Checking deranged v0.3.11 [INFO] [stderr] Checking time v0.3.36 [INFO] [stderr] Checking fastdate v0.3.33 [INFO] [stderr] Checking cbsk_base v2.0.0 [INFO] [stderr] Checking cbsk_timer v2.0.0 [INFO] [stderr] Checking cbsk_file v2.0.0 [INFO] [stderr] Checking cbsk_log v2.0.1 [INFO] [stderr] Checking cbsk_log_rayon v2.0.1 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/actuator/file_split_actuator.rs:62:12 [INFO] [stdout] | [INFO] [stdout] 49 | pub fn new(log_dir: impl Into, log_size: LogSize, packer: impl Packer + 'static) -> io::Result { [INFO] [stdout] | -------------------------- ----------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 59 | let file = cbsk_file::open_create_file(log_path.path.as_path())?; [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 62 | Ok(Self { [INFO] [stdout] | ____________^ [INFO] [stdout] 63 | | file: RwLock::new(file), [INFO] [stdout] 64 | | log_path: log_path.into(), [INFO] [stdout] 65 | | log_size: log_size.len(), [INFO] [stdout] ... | [INFO] [stdout] 70 | | packer: Arc::new(Box::new(packer)), [INFO] [stdout] 71 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/actuator/file_split_actuator.rs:62:12 [INFO] [stdout] | [INFO] [stdout] 49 | pub fn new(log_dir: impl Into, log_size: LogSize, packer: impl Packer + 'static) -> io::Result { [INFO] [stdout] | -------------------------- ----------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 59 | let file = cbsk_file::open_create_file(log_path.path.as_path())?; [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 62 | Ok(Self { [INFO] [stdout] | ____________^ [INFO] [stdout] 63 | | file: RwLock::new(file), [INFO] [stdout] 64 | | log_path: log_path.into(), [INFO] [stdout] 65 | | log_size: log_size.len(), [INFO] [stdout] ... | [INFO] [stdout] 70 | | packer: Arc::new(Box::new(packer)), [INFO] [stdout] 71 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/actuator/file_split_actuator.rs:94:66 [INFO] [stdout] | [INFO] [stdout] 92 | let packer = self.packer.clone(); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 93 | let log_path = self.log_path.clone(); [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 94 | cbsk_timer::push_once_with_name("[cbsk_log split file]", move || { [INFO] [stdout] | __________________________________________________________________^ [INFO] [stdout] 95 | | packer.pack(split_name, split_file, log_path); [INFO] [stdout] 96 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/actuator/file_split_actuator.rs:94:66 [INFO] [stdout] | [INFO] [stdout] 92 | let packer = self.packer.clone(); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 93 | let log_path = self.log_path.clone(); [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 94 | cbsk_timer::push_once_with_name("[cbsk_log split file]", move || { [INFO] [stdout] | __________________________________________________________________^ [INFO] [stdout] 95 | | packer.pack(split_name, split_file, log_path); [INFO] [stdout] 96 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/packer/zip_packer.rs:50:50 [INFO] [stdout] | [INFO] [stdout] 49 | pub fn pack_end(f: impl Fn(String) + Sync + Send + 'static) -> Self { [INFO] [stdout] | ------------------------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 50 | Self { lock: Mutex::default(), pack_end: Some(Box::new(f)) } [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/config/mod.rs:16:9 [INFO] [stdout] | [INFO] [stdout] 15 | fn file_split(self, log_dir: impl Into, log_size: LogSize, packer: impl Packer + 'static) -> Self { [INFO] [stdout] | ---- -------------------------- ----------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 16 | self.try_file_split(log_dir, log_size, packer).expect("create file split fail") [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/packer/zip_packer.rs:50:50 [INFO] [stdout] | [INFO] [stdout] 49 | pub fn pack_end(f: impl Fn(String) + Sync + Send + 'static) -> Self { [INFO] [stdout] | ------------------------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 50 | Self { lock: Mutex::default(), pack_end: Some(Box::new(f)) } [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/config/mod.rs:16:9 [INFO] [stdout] | [INFO] [stdout] 15 | fn file_split(self, log_dir: impl Into, log_size: LogSize, packer: impl Packer + 'static) -> Self { [INFO] [stdout] | ---- -------------------------- ----------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 16 | self.try_file_split(log_dir, log_size, packer).expect("create file split fail") [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 4 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 4 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `cbsk_log_rayon` (lib test) due to 5 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] error: could not compile `cbsk_log_rayon` (lib) due to 5 previous errors [INFO] running `Command { std: "docker" "inspect" "8cf3610f6dcd88e62df1ab1fb0e04254431a89325401d8e968c05634bfd505da", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "8cf3610f6dcd88e62df1ab1fb0e04254431a89325401d8e968c05634bfd505da", kill_on_drop: false }` [INFO] [stdout] 8cf3610f6dcd88e62df1ab1fb0e04254431a89325401d8e968c05634bfd505da