[INFO] fetching crate cavalier_contours 0.4.0... [INFO] checking cavalier_contours-0.4.0 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate cavalier_contours 0.4.0 into /workspace/builds/worker-0-tc2/source [INFO] validating manifest of crates.io crate cavalier_contours 0.4.0 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate cavalier_contours 0.4.0 [INFO] finished tweaking crates.io crate cavalier_contours 0.4.0 [INFO] tweaked toml for crates.io crate cavalier_contours 0.4.0 written to /workspace/builds/worker-0-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 10 packages to latest compatible versions [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] a33e5745b3508064f7825c6e0719e173ddf118e61ddbce84e3f4183b9c0acc98 [INFO] running `Command { std: "docker" "start" "-a" "a33e5745b3508064f7825c6e0719e173ddf118e61ddbce84e3f4183b9c0acc98", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "a33e5745b3508064f7825c6e0719e173ddf118e61ddbce84e3f4183b9c0acc98", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "a33e5745b3508064f7825c6e0719e173ddf118e61ddbce84e3f4183b9c0acc98", kill_on_drop: false }` [INFO] [stdout] a33e5745b3508064f7825c6e0719e173ddf118e61ddbce84e3f4183b9c0acc98 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 273c741cb501255083c6aeadd1466ac6a22c636dd5bff838b50b61745f7762cc [INFO] running `Command { std: "docker" "start" "-a" "273c741cb501255083c6aeadd1466ac6a22c636dd5bff838b50b61745f7762cc", kill_on_drop: false }` [INFO] [stderr] Checking static_aabb2d_index v2.0.0 [INFO] [stderr] Checking cavalier_contours v0.4.0 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/polyline/internal/pline_offset.rs:1532:26 [INFO] [stdout] | [INFO] [stdout] 1532 | .all(|p: &O| p.remove_repeat_pos(options.pos_equal_eps).is_none()), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/polyline/pline_types.rs:202:25 [INFO] [stdout] | [INFO] [stdout] 194 | pos_plines: I, [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 195 | neg_plines: I, [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 202 | pos_plines: pos_plines [INFO] [stdout] | _________________________^ [INFO] [stdout] 203 | | .into_iter() [INFO] [stdout] 204 | | .map(|p| BooleanResultPline::new(p, Vec::new())) [INFO] [stdout] 205 | | .collect(), [INFO] [stdout] | |__________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/polyline/pline_types.rs:206:25 [INFO] [stdout] | [INFO] [stdout] 194 | pos_plines: I, [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 195 | neg_plines: I, [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 206 | neg_plines: neg_plines [INFO] [stdout] | _________________________^ [INFO] [stdout] 207 | | .into_iter() [INFO] [stdout] 208 | | .map(|p| BooleanResultPline::new(p, Vec::new())) [INFO] [stdout] 209 | | .collect(), [INFO] [stdout] | |__________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/polyline/pline_types.rs:398:31 [INFO] [stdout] | [INFO] [stdout] 397 | pub fn new_basic(start_index1: usize, start_index2: usize, point: Vector2) -> Self { [INFO] [stdout] | ----------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 398 | PlineIntersect::Basic(PlineBasicIntersect::new(start_index1, start_index2, point)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/polyline/pline_types.rs:408:37 [INFO] [stdout] | [INFO] [stdout] 405 | point1: Vector2, [INFO] [stdout] | ------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 406 | point2: Vector2, [INFO] [stdout] | ------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 407 | ) -> Self { [INFO] [stdout] 408 | PlineIntersect::Overlapping(PlineOverlappingIntersect::new( [INFO] [stdout] | _____________________________________^ [INFO] [stdout] 409 | | start_index1, [INFO] [stdout] 410 | | start_index2, [INFO] [stdout] 411 | | point1, [INFO] [stdout] 412 | | point2, [INFO] [stdout] 413 | | )) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/polyline/traits.rs:2064:11 [INFO] [stdout] | [INFO] [stdout] 2060 | fn unwrap_spatial_index(builder: StaticAABB2DIndexBuilder) -> StaticAABB2DIndex [INFO] [stdout] | ------------------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 2064 | match builder.build() { [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 6 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `cavalier_contours` (lib) due to 7 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/polyline/internal/pline_offset.rs:1532:26 [INFO] [stdout] | [INFO] [stdout] 1532 | .all(|p: &O| p.remove_repeat_pos(options.pos_equal_eps).is_none()), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/polyline/pline_types.rs:202:25 [INFO] [stdout] | [INFO] [stdout] 194 | pos_plines: I, [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 195 | neg_plines: I, [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 202 | pos_plines: pos_plines [INFO] [stdout] | _________________________^ [INFO] [stdout] 203 | | .into_iter() [INFO] [stdout] 204 | | .map(|p| BooleanResultPline::new(p, Vec::new())) [INFO] [stdout] 205 | | .collect(), [INFO] [stdout] | |__________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/polyline/pline_types.rs:206:25 [INFO] [stdout] | [INFO] [stdout] 194 | pos_plines: I, [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 195 | neg_plines: I, [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 206 | neg_plines: neg_plines [INFO] [stdout] | _________________________^ [INFO] [stdout] 207 | | .into_iter() [INFO] [stdout] 208 | | .map(|p| BooleanResultPline::new(p, Vec::new())) [INFO] [stdout] 209 | | .collect(), [INFO] [stdout] | |__________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/polyline/pline_types.rs:398:31 [INFO] [stdout] | [INFO] [stdout] 397 | pub fn new_basic(start_index1: usize, start_index2: usize, point: Vector2) -> Self { [INFO] [stdout] | ----------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 398 | PlineIntersect::Basic(PlineBasicIntersect::new(start_index1, start_index2, point)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/polyline/pline_types.rs:408:37 [INFO] [stdout] | [INFO] [stdout] 405 | point1: Vector2, [INFO] [stdout] | ------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 406 | point2: Vector2, [INFO] [stdout] | ------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 407 | ) -> Self { [INFO] [stdout] 408 | PlineIntersect::Overlapping(PlineOverlappingIntersect::new( [INFO] [stdout] | _____________________________________^ [INFO] [stdout] 409 | | start_index1, [INFO] [stdout] 410 | | start_index2, [INFO] [stdout] 411 | | point1, [INFO] [stdout] 412 | | point2, [INFO] [stdout] 413 | | )) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/polyline/traits.rs:2064:11 [INFO] [stdout] | [INFO] [stdout] 2060 | fn unwrap_spatial_index(builder: StaticAABB2DIndexBuilder) -> StaticAABB2DIndex [INFO] [stdout] | ------------------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 2064 | match builder.build() { [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 6 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `cavalier_contours` (lib test) due to 7 previous errors [INFO] running `Command { std: "docker" "inspect" "273c741cb501255083c6aeadd1466ac6a22c636dd5bff838b50b61745f7762cc", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "273c741cb501255083c6aeadd1466ac6a22c636dd5bff838b50b61745f7762cc", kill_on_drop: false }` [INFO] [stdout] 273c741cb501255083c6aeadd1466ac6a22c636dd5bff838b50b61745f7762cc