[INFO] fetching crate catj 0.2.3... [INFO] checking catj-0.2.3 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate catj 0.2.3 into /workspace/builds/worker-1-tc2/source [INFO] validating manifest of crates.io crate catj 0.2.3 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate catj 0.2.3 [INFO] finished tweaking crates.io crate catj 0.2.3 [INFO] tweaked toml for crates.io crate catj 0.2.3 written to /workspace/builds/worker-1-tc2/source/Cargo.toml [INFO] crate crates.io crate catj 0.2.3 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 6e6d9b551a630206679dc559856b340d9fbbf5a8a7a9d5ee256f558ff869a7a6 [INFO] running `Command { std: "docker" "start" "-a" "6e6d9b551a630206679dc559856b340d9fbbf5a8a7a9d5ee256f558ff869a7a6", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "6e6d9b551a630206679dc559856b340d9fbbf5a8a7a9d5ee256f558ff869a7a6", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "6e6d9b551a630206679dc559856b340d9fbbf5a8a7a9d5ee256f558ff869a7a6", kill_on_drop: false }` [INFO] [stdout] 6e6d9b551a630206679dc559856b340d9fbbf5a8a7a9d5ee256f558ff869a7a6 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 2c89b544a54c622eb804b74844e971811164fac27bf9295e506121929e7f9727 [INFO] running `Command { std: "docker" "start" "-a" "2c89b544a54c622eb804b74844e971811164fac27bf9295e506121929e7f9727", kill_on_drop: false }` [INFO] [stderr] Compiling proc-macro2 v1.0.68 [INFO] [stderr] Compiling unicode-ident v1.0.5 [INFO] [stderr] Compiling libc v0.2.148 [INFO] [stderr] Compiling syn v1.0.103 [INFO] [stderr] Compiling memchr v2.5.0 [INFO] [stderr] Compiling memoffset v0.7.1 [INFO] [stderr] Compiling rustix v0.38.17 [INFO] [stderr] Compiling num-traits v0.2.15 [INFO] [stderr] Checking linux-raw-sys v0.4.8 [INFO] [stderr] Checking bitflags v2.4.0 [INFO] [stderr] Checking utf8parse v0.2.1 [INFO] [stderr] Compiling thiserror v1.0.38 [INFO] [stderr] Checking anstyle v1.0.4 [INFO] [stderr] Checking colorchoice v1.0.0 [INFO] [stderr] Compiling cc v1.0.78 [INFO] [stderr] Checking regex-syntax v0.6.28 [INFO] [stderr] Checking anstyle-query v1.0.0 [INFO] [stderr] Checking anstyle-parse v0.2.2 [INFO] [stderr] Checking cvt v0.1.2 [INFO] [stderr] Checking log v0.4.20 [INFO] [stderr] Checking once_cell v1.17.0 [INFO] [stderr] Checking clap_lex v0.5.1 [INFO] [stderr] Checking strsim v0.10.0 [INFO] [stderr] Checking iana-time-zone v0.1.53 [INFO] [stderr] Compiling heck v0.4.0 [INFO] [stderr] Checking path-dedot v3.1.1 [INFO] [stderr] Checking anstream v0.6.4 [INFO] [stderr] Checking glob v0.3.1 [INFO] [stderr] Checking nu-ansi-term v0.49.0 [INFO] [stderr] Checking fastrand v2.0.1 [INFO] [stderr] Checking normpath v1.1.1 [INFO] [stderr] Checking path-absolutize v3.1.1 [INFO] [stderr] Checking clap_builder v4.4.6 [INFO] [stderr] Compiling quote v1.0.33 [INFO] [stderr] Checking aho-corasick v0.7.20 [INFO] [stderr] Compiling syn v2.0.38 [INFO] [stderr] Compiling libc-stdhandle v0.1.0 [INFO] [stderr] Checking chrono v0.4.31 [INFO] [stderr] Checking nix v0.26.4 [INFO] [stderr] Checking nix v0.25.1 [INFO] [stderr] Checking regex v1.7.0 [INFO] [stderr] Checking is-terminal v0.4.9 [INFO] [stderr] Checking tempfile v3.8.0 [INFO] [stderr] Compiling thiserror-impl v1.0.38 [INFO] [stderr] Checking cgroups-rs v0.3.3 [INFO] [stderr] Checking flexi_logger v0.27.2 [INFO] [stderr] Compiling clap_derive v4.4.2 [INFO] [stderr] Checking fs_at v0.1.10 [INFO] [stderr] Checking clap v4.4.6 [INFO] [stderr] Checking remove_dir_all v0.8.2 [INFO] [stderr] Checking catj v0.2.3 (/opt/rustwide/workdir) [INFO] [stdout] warning: unused imports: `CatBoxReadPipe` and `CatBoxWritePipe` [INFO] [stdout] --> src/utils/mod.rs:8:28 [INFO] [stdout] | [INFO] [stdout] 8 | pub use pipe::{CatBoxPipe, CatBoxReadPipe, CatBoxWritePipe}; [INFO] [stdout] | ^^^^^^^^^^^^^^ ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused imports: `CatBoxReadPipe` and `CatBoxWritePipe` [INFO] [stdout] --> src/utils/mod.rs:8:28 [INFO] [stdout] | [INFO] [stdout] 8 | pub use pipe::{CatBoxPipe, CatBoxReadPipe, CatBoxWritePipe}; [INFO] [stdout] | ^^^^^^^^^^^^^^ ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: irrefutable `if let` pattern [INFO] [stdout] --> src/catbox.rs:433:10 [INFO] [stdout] | [INFO] [stdout] 433 | if let Err(e) = result { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this pattern will always match, so the `if let` is useless [INFO] [stdout] = help: consider replacing the `if let` with a `let` [INFO] [stdout] = note: `#[warn(irrefutable_let_patterns)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: irrefutable `if let` pattern [INFO] [stdout] --> src/catbox.rs:433:10 [INFO] [stdout] | [INFO] [stdout] 433 | if let Err(e) = result { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this pattern will always match, so the `if let` is useless [INFO] [stdout] = help: consider replacing the `if let` with a `let` [INFO] [stdout] = note: `#[warn(irrefutable_let_patterns)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `result` [INFO] [stdout] --> src/context/mod.rs:285:45 [INFO] [stdout] | [INFO] [stdout] 285 | fn add_result(&mut self, _label: &String, result: CatBoxResult) -> bool { [INFO] [stdout] | ^^^^^^ help: if this is intentional, prefix it with an underscore: `_result` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `result` [INFO] [stdout] --> src/context/mod.rs:285:45 [INFO] [stdout] | [INFO] [stdout] 285 | fn add_result(&mut self, _label: &String, result: CatBoxResult) -> bool { [INFO] [stdout] | ^^^^^^ help: if this is intentional, prefix it with an underscore: `_result` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/cgroup.rs:203:8 [INFO] [stdout] | [INFO] [stdout] 34 | let hierarchy = cgroups_rs::hierarchies::auto(); [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 108 | let cgroup = match builder.build(hierarchy) { [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 109 | Ok(cgroup) => cgroup, [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 110 | Err(err) => { [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 203 | Ok(CatBoxCgroup { [INFO] [stdout] | ________^ [INFO] [stdout] 204 | | name: cgroup_name, [INFO] [stdout] 205 | | cgroup: Some(cgroup), [INFO] [stdout] 206 | | enable_cpuacct, [INFO] [stdout] 207 | | enable_memory, [INFO] [stdout] 208 | | }) [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/context/builder.rs:400:18 [INFO] [stdout] | [INFO] [stdout] 388 | pub fn default, AS: Into>(program: PS, arguments: Vec) -> Self { [INFO] [stdout] | ----------- ------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 389 | let current_user = User::from_uid(Uid::current()).unwrap().unwrap(); [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 392 | let catbox_user = User::from_name("nobody").unwrap().unwrap(); [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 393 | let catbox_group = Group::from_gid(catbox_user.gid).unwrap().unwrap(); [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 400 | arguments: arguments.into_iter().map(|a| a.into()).collect(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/context/builder.rs:408:12 [INFO] [stdout] | [INFO] [stdout] 388 | pub fn default, AS: Into>(program: PS, arguments: Vec) -> Self { [INFO] [stdout] | ----------- ------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 389 | let current_user = User::from_uid(Uid::current()).unwrap().unwrap(); [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 392 | let catbox_user = User::from_name("nobody").unwrap().unwrap(); [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 393 | let catbox_group = Group::from_gid(catbox_user.gid).unwrap().unwrap(); [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 408 | cwd: env::current_dir().unwrap(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 3 previous errors; 3 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `catj` (lib) due to 4 previous errors; 3 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/cgroup.rs:203:8 [INFO] [stdout] | [INFO] [stdout] 34 | let hierarchy = cgroups_rs::hierarchies::auto(); [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 108 | let cgroup = match builder.build(hierarchy) { [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 109 | Ok(cgroup) => cgroup, [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 110 | Err(err) => { [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 203 | Ok(CatBoxCgroup { [INFO] [stdout] | ________^ [INFO] [stdout] 204 | | name: cgroup_name, [INFO] [stdout] 205 | | cgroup: Some(cgroup), [INFO] [stdout] 206 | | enable_cpuacct, [INFO] [stdout] 207 | | enable_memory, [INFO] [stdout] 208 | | }) [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/context/builder.rs:400:18 [INFO] [stdout] | [INFO] [stdout] 388 | pub fn default, AS: Into>(program: PS, arguments: Vec) -> Self { [INFO] [stdout] | ----------- ------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 389 | let current_user = User::from_uid(Uid::current()).unwrap().unwrap(); [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 392 | let catbox_user = User::from_name("nobody").unwrap().unwrap(); [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 393 | let catbox_group = Group::from_gid(catbox_user.gid).unwrap().unwrap(); [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 400 | arguments: arguments.into_iter().map(|a| a.into()).collect(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/context/builder.rs:408:12 [INFO] [stdout] | [INFO] [stdout] 388 | pub fn default, AS: Into>(program: PS, arguments: Vec) -> Self { [INFO] [stdout] | ----------- ------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 389 | let current_user = User::from_uid(Uid::current()).unwrap().unwrap(); [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 392 | let catbox_user = User::from_name("nobody").unwrap().unwrap(); [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 393 | let catbox_group = Group::from_gid(catbox_user.gid).unwrap().unwrap(); [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 408 | cwd: env::current_dir().unwrap(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 3 previous errors; 3 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `catj` (lib test) due to 4 previous errors; 3 warnings emitted [INFO] running `Command { std: "docker" "inspect" "2c89b544a54c622eb804b74844e971811164fac27bf9295e506121929e7f9727", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "2c89b544a54c622eb804b74844e971811164fac27bf9295e506121929e7f9727", kill_on_drop: false }` [INFO] [stdout] 2c89b544a54c622eb804b74844e971811164fac27bf9295e506121929e7f9727