[INFO] fetching crate cassowary 0.3.0... [INFO] checking cassowary-0.3.0 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate cassowary 0.3.0 into /workspace/builds/worker-3-tc2/source [INFO] validating manifest of crates.io crate cassowary 0.3.0 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate cassowary 0.3.0 [INFO] finished tweaking crates.io crate cassowary 0.3.0 [INFO] tweaked toml for crates.io crate cassowary 0.3.0 written to /workspace/builds/worker-3-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] warning: no edition set: defaulting to the 2015 edition while the latest is 2021 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 7d88375111a6df2afd0ab8c5a98bb2728a0700903fd1ef32064cb3c856d76332 [INFO] running `Command { std: "docker" "start" "-a" "7d88375111a6df2afd0ab8c5a98bb2728a0700903fd1ef32064cb3c856d76332", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "7d88375111a6df2afd0ab8c5a98bb2728a0700903fd1ef32064cb3c856d76332", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "7d88375111a6df2afd0ab8c5a98bb2728a0700903fd1ef32064cb3c856d76332", kill_on_drop: false }` [INFO] [stdout] 7d88375111a6df2afd0ab8c5a98bb2728a0700903fd1ef32064cb3c856d76332 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 25f64bc94c2517ecdb6373da09e6844ab0a73c0aa77042ec9479cd1140d5a43d [INFO] running `Command { std: "docker" "start" "-a" "25f64bc94c2517ecdb6373da09e6844ab0a73c0aa77042ec9479cd1140d5a43d", kill_on_drop: false }` [INFO] [stderr] warning: no edition set: defaulting to the 2015 edition while the latest is 2021 [INFO] [stderr] Checking cassowary v0.3.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: use of deprecated macro `try`: use the `?` operator instead [INFO] [stdout] --> src/solver_impl.rs:77:13 [INFO] [stdout] | [INFO] [stdout] 77 | try!(self.add_constraint(constraint.clone())); [INFO] [stdout] | ^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(deprecated)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated macro `try`: use the `?` operator instead [INFO] [stdout] --> src/solver_impl.rs:135:9 [INFO] [stdout] | [INFO] [stdout] 135 | try!(self.optimise(&objective).map_err(|e| AddConstraintError::InternalSolverError(e.0))); [INFO] [stdout] | ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated macro `try`: use the `?` operator instead [INFO] [stdout] --> src/solver_impl.rs:115:17 [INFO] [stdout] | [INFO] [stdout] 115 | if !try!(self.add_with_artificial_variable(&row) [INFO] [stdout] | ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated macro `try`: use the `?` operator instead [INFO] [stdout] --> src/solver_impl.rs:163:9 [INFO] [stdout] | [INFO] [stdout] 163 | try!(self.optimise(&objective).map_err(|e| RemoveConstraintError::InternalSolverError(e.0))); [INFO] [stdout] | ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated macro `try`: use the `?` operator instead [INFO] [stdout] --> src/solver_impl.rs:141:19 [INFO] [stdout] | [INFO] [stdout] 141 | let tag = try!(self.cns.remove(constraint).ok_or(RemoveConstraintError::UnknownConstraint)); [INFO] [stdout] | ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated macro `try`: use the `?` operator instead [INFO] [stdout] --> src/solver_impl.rs:151:38 [INFO] [stdout] | [INFO] [stdout] 151 | let (leaving, mut row) = try!(self.get_marker_leaving_row(tag.marker) [INFO] [stdout] | ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated macro `try`: use the `?` operator instead [INFO] [stdout] --> src/solver_impl.rs:215:13 [INFO] [stdout] | [INFO] [stdout] 215 | try!(self.remove_constraint(&constraint) [INFO] [stdout] | ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated macro `try`: use the `?` operator instead [INFO] [stdout] --> src/solver_impl.rs:286:9 [INFO] [stdout] | [INFO] [stdout] 286 | try!(self.dual_optimise().map_err(|e| SuggestValueError::InternalSolverError(e.0))); [INFO] [stdout] | ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated macro `try`: use the `?` operator instead [INFO] [stdout] --> src/solver_impl.rs:239:24 [INFO] [stdout] | [INFO] [stdout] 239 | let info = try!(self.edits.get_mut(&variable).ok_or(SuggestValueError::UnknownEditVariable)); [INFO] [stdout] | ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated macro `try`: use the `?` operator instead [INFO] [stdout] --> src/solver_impl.rs:497:9 [INFO] [stdout] | [INFO] [stdout] 497 | try!(self.optimise(&artificial)); [INFO] [stdout] | ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated macro `try`: use the `?` operator instead [INFO] [stdout] --> src/solver_impl.rs:560:38 [INFO] [stdout] | [INFO] [stdout] 560 | let (leaving, mut row) = try!(self.get_leaving_row(entering) [INFO] [stdout] | ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated constant `std::sync::atomic::ATOMIC_USIZE_INIT`: the `new` function is now preferred [INFO] [stdout] --> src/lib.rs:235:77 [INFO] [stdout] | [INFO] [stdout] 235 | static VARIABLE_ID: ::std::sync::atomic::AtomicUsize = ::std::sync::atomic::ATOMIC_USIZE_INIT; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] help: replace the use of the deprecated constant [INFO] [stdout] | [INFO] [stdout] 235 | static VARIABLE_ID: ::std::sync::atomic::AtomicUsize = ::std::sync::atomic::AtomicUsize::new(0); [INFO] [stdout] | ~~~~~~~~~~~~~~~~~~~ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated macro `try`: use the `?` operator instead [INFO] [stdout] --> src/solver_impl.rs:77:13 [INFO] [stdout] | [INFO] [stdout] 77 | try!(self.add_constraint(constraint.clone())); [INFO] [stdout] | ^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(deprecated)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated macro `try`: use the `?` operator instead [INFO] [stdout] --> src/solver_impl.rs:135:9 [INFO] [stdout] | [INFO] [stdout] 135 | try!(self.optimise(&objective).map_err(|e| AddConstraintError::InternalSolverError(e.0))); [INFO] [stdout] | ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated macro `try`: use the `?` operator instead [INFO] [stdout] --> src/solver_impl.rs:115:17 [INFO] [stdout] | [INFO] [stdout] 115 | if !try!(self.add_with_artificial_variable(&row) [INFO] [stdout] | ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated macro `try`: use the `?` operator instead [INFO] [stdout] --> src/solver_impl.rs:163:9 [INFO] [stdout] | [INFO] [stdout] 163 | try!(self.optimise(&objective).map_err(|e| RemoveConstraintError::InternalSolverError(e.0))); [INFO] [stdout] | ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated macro `try`: use the `?` operator instead [INFO] [stdout] --> src/solver_impl.rs:141:19 [INFO] [stdout] | [INFO] [stdout] 141 | let tag = try!(self.cns.remove(constraint).ok_or(RemoveConstraintError::UnknownConstraint)); [INFO] [stdout] | ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated macro `try`: use the `?` operator instead [INFO] [stdout] --> src/solver_impl.rs:151:38 [INFO] [stdout] | [INFO] [stdout] 151 | let (leaving, mut row) = try!(self.get_marker_leaving_row(tag.marker) [INFO] [stdout] | ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated macro `try`: use the `?` operator instead [INFO] [stdout] --> src/solver_impl.rs:215:13 [INFO] [stdout] | [INFO] [stdout] 215 | try!(self.remove_constraint(&constraint) [INFO] [stdout] | ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated macro `try`: use the `?` operator instead [INFO] [stdout] --> src/solver_impl.rs:286:9 [INFO] [stdout] | [INFO] [stdout] 286 | try!(self.dual_optimise().map_err(|e| SuggestValueError::InternalSolverError(e.0))); [INFO] [stdout] | ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated macro `try`: use the `?` operator instead [INFO] [stdout] --> src/solver_impl.rs:239:24 [INFO] [stdout] | [INFO] [stdout] 239 | let info = try!(self.edits.get_mut(&variable).ok_or(SuggestValueError::UnknownEditVariable)); [INFO] [stdout] | ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated macro `try`: use the `?` operator instead [INFO] [stdout] --> src/solver_impl.rs:497:9 [INFO] [stdout] | [INFO] [stdout] 497 | try!(self.optimise(&artificial)); [INFO] [stdout] | ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated macro `try`: use the `?` operator instead [INFO] [stdout] --> src/solver_impl.rs:560:38 [INFO] [stdout] | [INFO] [stdout] 560 | let (leaving, mut row) = try!(self.get_leaving_row(entering) [INFO] [stdout] | ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated constant `std::sync::atomic::ATOMIC_USIZE_INIT`: the `new` function is now preferred [INFO] [stdout] --> src/lib.rs:235:77 [INFO] [stdout] | [INFO] [stdout] 235 | static VARIABLE_ID: ::std::sync::atomic::AtomicUsize = ::std::sync::atomic::ATOMIC_USIZE_INIT; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] help: replace the use of the deprecated constant [INFO] [stdout] | [INFO] [stdout] 235 | static VARIABLE_ID: ::std::sync::atomic::AtomicUsize = ::std::sync::atomic::AtomicUsize::new(0); [INFO] [stdout] | ~~~~~~~~~~~~~~~~~~~ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/solver_impl.rs:450:10 [INFO] [stdout] | [INFO] [stdout] 390 | let mut objective = self.objective.borrow_mut(); [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 450 | (Box::new(row), tag) [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/solver_impl.rs:686:27 [INFO] [stdout] | [INFO] [stdout] 686 | found.map(|s| (s, self.rows.remove(&s).unwrap())) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 2 previous errors; 12 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `cassowary` (lib) due to 3 previous errors; 12 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/solver_impl.rs:450:10 [INFO] [stdout] | [INFO] [stdout] 390 | let mut objective = self.objective.borrow_mut(); [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 450 | (Box::new(row), tag) [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/solver_impl.rs:686:27 [INFO] [stdout] | [INFO] [stdout] 686 | found.map(|s| (s, self.rows.remove(&s).unwrap())) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 2 previous errors; 12 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `cassowary` (lib test) due to 3 previous errors; 12 warnings emitted [INFO] running `Command { std: "docker" "inspect" "25f64bc94c2517ecdb6373da09e6844ab0a73c0aa77042ec9479cd1140d5a43d", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "25f64bc94c2517ecdb6373da09e6844ab0a73c0aa77042ec9479cd1140d5a43d", kill_on_drop: false }` [INFO] [stdout] 25f64bc94c2517ecdb6373da09e6844ab0a73c0aa77042ec9479cd1140d5a43d