[INFO] fetching crate cassiopeia 0.3.0... [INFO] checking cassiopeia-0.3.0 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate cassiopeia 0.3.0 into /workspace/builds/worker-6-tc2/source [INFO] validating manifest of crates.io crate cassiopeia 0.3.0 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate cassiopeia 0.3.0 [INFO] finished tweaking crates.io crate cassiopeia 0.3.0 [INFO] tweaked toml for crates.io crate cassiopeia 0.3.0 written to /workspace/builds/worker-6-tc2/source/Cargo.toml [INFO] crate crates.io crate cassiopeia 0.3.0 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 37efb16d7902fa6769e4e5b970af48eeb0fc00db37d8bcf683378683fad9bb4a [INFO] running `Command { std: "docker" "start" "-a" "37efb16d7902fa6769e4e5b970af48eeb0fc00db37d8bcf683378683fad9bb4a", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "37efb16d7902fa6769e4e5b970af48eeb0fc00db37d8bcf683378683fad9bb4a", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "37efb16d7902fa6769e4e5b970af48eeb0fc00db37d8bcf683378683fad9bb4a", kill_on_drop: false }` [INFO] [stdout] 37efb16d7902fa6769e4e5b970af48eeb0fc00db37d8bcf683378683fad9bb4a [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] e0d48b6ac1a8e6552c60b391ede2a6a220bb79ccefb91673cd5221ca886d893d [INFO] running `Command { std: "docker" "start" "-a" "e0d48b6ac1a8e6552c60b391ede2a6a220bb79ccefb91673cd5221ca886d893d", kill_on_drop: false }` [INFO] [stderr] Compiling libc v0.2.81 [INFO] [stderr] Compiling memchr v2.3.4 [INFO] [stderr] Compiling syn v1.0.54 [INFO] [stderr] Compiling log v0.4.11 [INFO] [stderr] Compiling regex-syntax v0.6.21 [INFO] [stderr] Compiling utf8-ranges v1.0.4 [INFO] [stderr] Compiling beef v0.4.4 [INFO] [stderr] Compiling num-traits v0.2.14 [INFO] [stderr] Compiling num-integer v0.1.44 [INFO] [stderr] Checking thread_local v1.0.1 [INFO] [stderr] Checking termcolor v1.1.2 [INFO] [stderr] Checking humantime v2.0.1 [INFO] [stderr] Checking aho-corasick v0.7.15 [INFO] [stderr] Checking atty v0.2.14 [INFO] [stderr] Checking term_size v0.3.2 [INFO] [stderr] Checking time v0.1.44 [INFO] [stderr] Checking textwrap v0.11.0 [INFO] [stderr] Checking clap v2.33.3 [INFO] [stderr] Checking chrono v0.4.19 [INFO] [stderr] Checking regex v1.4.2 [INFO] [stderr] Checking env_logger v0.8.2 [INFO] [stderr] Compiling logos-derive v0.11.5 [INFO] [stderr] Checking logos v0.11.4 [INFO] [stderr] Checking cassiopeia v0.3.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: unused imports: `DateTime`, `FixedOffset as Offset`, `Local`, and `NaiveDate` [INFO] [stdout] --> src/data.rs:11:14 [INFO] [stdout] | [INFO] [stdout] 11 | use chrono::{DateTime, Duration, FixedOffset as Offset, Local, NaiveDate}; [INFO] [stdout] | ^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^ ^^^^^ ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `TimeFile` [INFO] [stdout] --> src/format/ir.rs:1:42 [INFO] [stdout] | [INFO] [stdout] 1 | use crate::{format::LineCfg, Date, Time, TimeFile}; [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `cmp::Ordering` [INFO] [stdout] --> src/time.rs:6:11 [INFO] [stdout] | [INFO] [stdout] 6 | use std::{cmp::Ordering, ops::Sub}; [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused imports: `Invoice` and `Session` [INFO] [stdout] --> src/lib.rs:20:12 [INFO] [stdout] | [INFO] [stdout] 20 | use data::{Invoice, Session, TimeFile}; [INFO] [stdout] | ^^^^^^^ ^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused imports: `DateTime`, `FixedOffset as Offset`, `Local`, and `NaiveDate` [INFO] [stdout] --> src/data.rs:11:14 [INFO] [stdout] | [INFO] [stdout] 11 | use chrono::{DateTime, Duration, FixedOffset as Offset, Local, NaiveDate}; [INFO] [stdout] | ^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^ ^^^^^ ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `TimeFile` [INFO] [stdout] --> src/format/ir.rs:1:42 [INFO] [stdout] | [INFO] [stdout] 1 | use crate::{format::LineCfg, Date, Time, TimeFile}; [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `cmp::Ordering` [INFO] [stdout] --> src/time.rs:6:11 [INFO] [stdout] | [INFO] [stdout] 6 | use std::{cmp::Ordering, ops::Sub}; [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused imports: `Invoice` and `Session` [INFO] [stdout] --> src/lib.rs:20:12 [INFO] [stdout] | [INFO] [stdout] 20 | use data::{Invoice, Session, TimeFile}; [INFO] [stdout] | ^^^^^^^ ^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `lo` [INFO] [stdout] --> src/data.rs:33:17 [INFO] [stdout] | [INFO] [stdout] 33 | lo, [INFO] [stdout] | ^^ help: try ignoring the field: `lo: _` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `lo` [INFO] [stdout] --> src/data.rs:37:17 [INFO] [stdout] | [INFO] [stdout] 37 | lo, [INFO] [stdout] | ^^ help: try ignoring the field: `lo: _` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `lo` [INFO] [stdout] --> src/data.rs:41:17 [INFO] [stdout] | [INFO] [stdout] 41 | lo, [INFO] [stdout] | ^^ help: try ignoring the field: `lo: _` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `lo` [INFO] [stdout] --> src/format/gen.rs:11:22 [INFO] [stdout] | [INFO] [stdout] 11 | let IrItem { tt, lo } = ir; [INFO] [stdout] | ^^ help: try ignoring the field: `lo: _` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `lo` [INFO] [stdout] --> src/data.rs:33:17 [INFO] [stdout] | [INFO] [stdout] 33 | lo, [INFO] [stdout] | ^^ help: try ignoring the field: `lo: _` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `lo` [INFO] [stdout] --> src/data.rs:37:17 [INFO] [stdout] | [INFO] [stdout] 37 | lo, [INFO] [stdout] | ^^ help: try ignoring the field: `lo: _` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `lo` [INFO] [stdout] --> src/data.rs:41:17 [INFO] [stdout] | [INFO] [stdout] 41 | lo, [INFO] [stdout] | ^^ help: try ignoring the field: `lo: _` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `lo` [INFO] [stdout] --> src/format/gen.rs:11:22 [INFO] [stdout] | [INFO] [stdout] 11 | let IrItem { tt, lo } = ir; [INFO] [stdout] | ^^ help: try ignoring the field: `lo: _` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unreachable pattern [INFO] [stdout] --> src/format/parser.rs:60:9 [INFO] [stdout] | [INFO] [stdout] 60 | _ => Ignore, [INFO] [stdout] | ^ no value can reach this [INFO] [stdout] | [INFO] [stdout] note: multiple earlier patterns match some of the same values [INFO] [stdout] --> src/format/parser.rs:60:9 [INFO] [stdout] | [INFO] [stdout] 43 | (Ignore, LineToken { tt: T::Comment, .. }, ) => Ignore, [INFO] [stdout] | -------------------------------------------- matches some of the same values [INFO] [stdout] 44 | // If the first token is a keyword, we wait for more data [INFO] [stdout] 45 | (Ignore, LineToken { tt: T::Header, .. }) => Header(Default::default()), [INFO] [stdout] | ----------------------------------------- matches some of the same values [INFO] [stdout] 46 | (Ignore, LineToken { tt: T::Start, .. }) => Start(None), [INFO] [stdout] | ---------------------------------------- matches some of the same values [INFO] [stdout] 47 | (Ignore, LineToken { tt: T::Stop, .. }) => Stop(None), [INFO] [stdout] | --------------------------------------- matches some of the same values [INFO] [stdout] ... [INFO] [stdout] 60 | _ => Ignore, [INFO] [stdout] | ^ ...and 6 other patterns collectively make this unreachable [INFO] [stdout] = note: `#[warn(unreachable_patterns)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/lib.rs:139:16 [INFO] [stdout] | [INFO] [stdout] 139 | pub fn run(mut self) -> Option<()> { [INFO] [stdout] | ----^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_mut)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: fields `client_db`, `client`, and `project` are never read [INFO] [stdout] --> src/lib.rs:101:5 [INFO] [stdout] | [INFO] [stdout] 98 | pub struct Invoicer<'cass> { [INFO] [stdout] | -------- fields in this struct [INFO] [stdout] ... [INFO] [stdout] 101 | client_db: String, [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] 102 | client: String, [INFO] [stdout] | ^^^^^^ [INFO] [stdout] 103 | project: String, [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `length` is never used [INFO] [stdout] --> src/data.rs:149:12 [INFO] [stdout] | [INFO] [stdout] 132 | impl Session { [INFO] [stdout] | ------------ method in this implementation [INFO] [stdout] ... [INFO] [stdout] 149 | pub fn length(&self) -> Option { [INFO] [stdout] | ^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `valid` is never used [INFO] [stdout] --> src/format/parser.rs:28:19 [INFO] [stdout] | [INFO] [stdout] 27 | impl LineCfg { [INFO] [stdout] | ------------ method in this implementation [INFO] [stdout] 28 | pub(crate) fn valid(&self) -> bool { [INFO] [stdout] | ^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/format/ir.rs:44:5 [INFO] [stdout] | [INFO] [stdout] 43 | pub(crate) fn generate_ir(buf: impl Iterator) -> IrStream { [INFO] [stdout] | ---------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 44 | buf.enumerate().fold(vec![], |mut buf, (lo, item)| { [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable `Empty` should have a snake case name [INFO] [stdout] --> src/format/parser.rs:57:10 [INFO] [stdout] | [INFO] [stdout] 57 | (Empty, _) => Empty, [INFO] [stdout] | ^^^^^ help: convert the identifier to snake case: `empty` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(non_snake_case)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: comparison is useless due to type limits [INFO] [stdout] --> src/time.rs:75:18 [INFO] [stdout] | [INFO] [stdout] 75 | m if m >= 0 && m < 7 => (0, false), [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_comparisons)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unreachable pattern [INFO] [stdout] --> src/format/parser.rs:60:9 [INFO] [stdout] | [INFO] [stdout] 60 | _ => Ignore, [INFO] [stdout] | ^ no value can reach this [INFO] [stdout] | [INFO] [stdout] note: multiple earlier patterns match some of the same values [INFO] [stdout] --> src/format/parser.rs:60:9 [INFO] [stdout] | [INFO] [stdout] 43 | (Ignore, LineToken { tt: T::Comment, .. }, ) => Ignore, [INFO] [stdout] | -------------------------------------------- matches some of the same values [INFO] [stdout] 44 | // If the first token is a keyword, we wait for more data [INFO] [stdout] 45 | (Ignore, LineToken { tt: T::Header, .. }) => Header(Default::default()), [INFO] [stdout] | ----------------------------------------- matches some of the same values [INFO] [stdout] 46 | (Ignore, LineToken { tt: T::Start, .. }) => Start(None), [INFO] [stdout] | ---------------------------------------- matches some of the same values [INFO] [stdout] 47 | (Ignore, LineToken { tt: T::Stop, .. }) => Stop(None), [INFO] [stdout] | --------------------------------------- matches some of the same values [INFO] [stdout] ... [INFO] [stdout] 60 | _ => Ignore, [INFO] [stdout] | ^ ...and 6 other patterns collectively make this unreachable [INFO] [stdout] = note: `#[warn(unreachable_patterns)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 1 previous error; 15 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/lib.rs:139:16 [INFO] [stdout] | [INFO] [stdout] 139 | pub fn run(mut self) -> Option<()> { [INFO] [stdout] | ----^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_mut)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `cassiopeia` (lib test) due to 2 previous errors; 15 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] warning: fields `client_db`, `client`, and `project` are never read [INFO] [stdout] --> src/lib.rs:101:5 [INFO] [stdout] | [INFO] [stdout] 98 | pub struct Invoicer<'cass> { [INFO] [stdout] | -------- fields in this struct [INFO] [stdout] ... [INFO] [stdout] 101 | client_db: String, [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] 102 | client: String, [INFO] [stdout] | ^^^^^^ [INFO] [stdout] 103 | project: String, [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `length` is never used [INFO] [stdout] --> src/data.rs:149:12 [INFO] [stdout] | [INFO] [stdout] 132 | impl Session { [INFO] [stdout] | ------------ method in this implementation [INFO] [stdout] ... [INFO] [stdout] 149 | pub fn length(&self) -> Option { [INFO] [stdout] | ^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `valid` is never used [INFO] [stdout] --> src/format/parser.rs:28:19 [INFO] [stdout] | [INFO] [stdout] 27 | impl LineCfg { [INFO] [stdout] | ------------ method in this implementation [INFO] [stdout] 28 | pub(crate) fn valid(&self) -> bool { [INFO] [stdout] | ^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/format/ir.rs:44:5 [INFO] [stdout] | [INFO] [stdout] 43 | pub(crate) fn generate_ir(buf: impl Iterator) -> IrStream { [INFO] [stdout] | ---------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 44 | buf.enumerate().fold(vec![], |mut buf, (lo, item)| { [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable `Empty` should have a snake case name [INFO] [stdout] --> src/format/parser.rs:57:10 [INFO] [stdout] | [INFO] [stdout] 57 | (Empty, _) => Empty, [INFO] [stdout] | ^^^^^ help: convert the identifier to snake case: `empty` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(non_snake_case)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: comparison is useless due to type limits [INFO] [stdout] --> src/time.rs:75:18 [INFO] [stdout] | [INFO] [stdout] 75 | m if m >= 0 && m < 7 => (0, false), [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_comparisons)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 1 previous error; 15 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `cassiopeia` (lib) due to 2 previous errors; 15 warnings emitted [INFO] running `Command { std: "docker" "inspect" "e0d48b6ac1a8e6552c60b391ede2a6a220bb79ccefb91673cd5221ca886d893d", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "e0d48b6ac1a8e6552c60b391ede2a6a220bb79ccefb91673cd5221ca886d893d", kill_on_drop: false }` [INFO] [stdout] e0d48b6ac1a8e6552c60b391ede2a6a220bb79ccefb91673cd5221ca886d893d