[INFO] fetching crate caspaxos-kv 0.2.2... [INFO] checking caspaxos-kv-0.2.2 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate caspaxos-kv 0.2.2 into /workspace/builds/worker-1-tc2/source [INFO] validating manifest of crates.io crate caspaxos-kv 0.2.2 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate caspaxos-kv 0.2.2 [INFO] finished tweaking crates.io crate caspaxos-kv 0.2.2 [INFO] tweaked toml for crates.io crate caspaxos-kv 0.2.2 written to /workspace/builds/worker-1-tc2/source/Cargo.toml [INFO] crate crates.io crate caspaxos-kv 0.2.2 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] b8df4836cd379eaf051b29fb2a040cd592cd0954ac4c3f9cf5facfdc6d1c6c9d [INFO] running `Command { std: "docker" "start" "-a" "b8df4836cd379eaf051b29fb2a040cd592cd0954ac4c3f9cf5facfdc6d1c6c9d", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "b8df4836cd379eaf051b29fb2a040cd592cd0954ac4c3f9cf5facfdc6d1c6c9d", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "b8df4836cd379eaf051b29fb2a040cd592cd0954ac4c3f9cf5facfdc6d1c6c9d", kill_on_drop: false }` [INFO] [stdout] b8df4836cd379eaf051b29fb2a040cd592cd0954ac4c3f9cf5facfdc6d1c6c9d [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] c6a1348ebeb9b95ddc55c1654397be1624b232f0e65f032643ea3aa53dce8e84 [INFO] running `Command { std: "docker" "start" "-a" "c6a1348ebeb9b95ddc55c1654397be1624b232f0e65f032643ea3aa53dce8e84", kill_on_drop: false }` [INFO] [stderr] Compiling libc v0.2.80 [INFO] [stderr] Compiling autocfg v1.0.1 [INFO] [stderr] Compiling memchr v2.3.3 [INFO] [stderr] Checking futures-core v0.3.7 [INFO] [stderr] Checking cache-padded v1.1.1 [INFO] [stderr] Checking futures-io v0.3.7 [INFO] [stderr] Checking fastrand v1.4.0 [INFO] [stderr] Checking pin-project-lite v0.1.11 [INFO] [stderr] Checking waker-fn v1.1.0 [INFO] [stderr] Checking parking v2.0.0 [INFO] [stderr] Checking once_cell v1.4.1 [INFO] [stderr] Compiling getrandom v0.1.15 [INFO] [stderr] Checking event-listener v2.5.1 [INFO] [stderr] Checking async-task v4.0.3 [INFO] [stderr] Checking vec-arena v1.0.0 [INFO] [stderr] Checking atomic-waker v1.0.0 [INFO] [stderr] Checking ppv-lite86 v0.2.9 [INFO] [stderr] Compiling byteorder v1.3.4 [INFO] [stderr] Checking arc-swap v0.4.7 [INFO] [stderr] Checking concurrent-queue v1.2.2 [INFO] [stderr] Checking instant v0.1.8 [INFO] [stderr] Compiling crc32fast v1.2.1 [INFO] [stderr] Checking smallvec v1.4.2 [INFO] [stderr] Checking lock_api v0.4.1 [INFO] [stderr] Checking async-lock v2.3.0 [INFO] [stderr] Checking thread_local v1.0.1 [INFO] [stderr] Checking adler v0.2.3 [INFO] [stderr] Checking gimli v0.22.0 [INFO] [stderr] Checking async-channel v1.5.1 [INFO] [stderr] Checking regex-syntax v0.6.20 [INFO] [stderr] Checking rustc-demangle v0.1.18 [INFO] [stderr] Checking object v0.21.1 [INFO] [stderr] Checking futures-channel v0.3.7 [INFO] [stderr] Checking historian v4.0.3 [INFO] [stderr] Checking futures-lite v1.11.2 [INFO] [stderr] Checking aho-corasick v0.7.14 [INFO] [stderr] Compiling memoffset v0.5.6 [INFO] [stderr] Compiling crossbeam-utils v0.7.2 [INFO] [stderr] Compiling miniz_oxide v0.4.3 [INFO] [stderr] Compiling crossbeam-epoch v0.8.2 [INFO] [stderr] Checking fxhash v0.2.1 [INFO] [stderr] Checking nb-connect v1.0.2 [INFO] [stderr] Checking polling v2.0.2 [INFO] [stderr] Checking signal-hook-registry v1.2.1 [INFO] [stderr] Checking atty v0.2.14 [INFO] [stderr] Checking parking_lot_core v0.8.0 [INFO] [stderr] Checking fs2 v0.4.3 [INFO] [stderr] Checking rand_core v0.5.1 [INFO] [stderr] Checking rand_chacha v0.2.2 [INFO] [stderr] Checking signal-hook v0.1.16 [INFO] [stderr] Checking rand v0.7.3 [INFO] [stderr] Checking parking_lot v0.11.0 [INFO] [stderr] Checking blocking v1.0.2 [INFO] [stderr] Checking async-io v1.1.10 [INFO] [stderr] Checking async-executor v1.3.0 [INFO] [stderr] Checking sled v0.34.4 [INFO] [stderr] Checking async-fs v1.5.0 [INFO] [stderr] Checking async-process v1.0.1 [INFO] [stderr] Checking async-net v1.5.0 [INFO] [stderr] Checking uuid v0.8.1 [INFO] [stderr] Checking regex v1.4.1 [INFO] [stderr] Checking addr2line v0.13.0 [INFO] [stderr] Checking smol v1.2.4 [INFO] [stderr] Checking backtrace v0.3.53 [INFO] [stderr] Checking color-backtrace v0.4.2 [INFO] [stderr] Checking env_logger v0.7.1 [INFO] [stderr] Checking caspaxos-kv v0.2.2 (/opt/rustwide/workdir) [INFO] [stderr] Checking quickcheck v0.9.2 [INFO] [stdout] warning: unnecessary `unsafe` block [INFO] [stdout] --> src/udp_net.rs:78:13 [INFO] [stdout] | [INFO] [stdout] 78 | unsafe { [INFO] [stdout] | ^^^^^^ unnecessary `unsafe` block [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_unsafe)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `0` is never read [INFO] [stdout] --> src/simulator.rs:114:10 [INFO] [stdout] | [INFO] [stdout] 114 | Loss(OneshotSender), [INFO] [stdout] | ---- ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | field in this variant [INFO] [stdout] | [INFO] [stdout] = note: `LossyDelivery` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] help: consider changing the field to be of unit type to suppress this warning while preserving the field numbering, or remove the field [INFO] [stdout] | [INFO] [stdout] 114 | Loss(()), [INFO] [stdout] | ~~ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:143:8 [INFO] [stdout] | [INFO] [stdout] 120 | listen_addr: A, [INFO] [stdout] | -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 139 | let (process_task, net) = Net::new_udp(listen_addr, timeout)?; [INFO] [stdout] | ------------ --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 140 | [INFO] [stdout] 141 | let processor = smol::spawn(process_task); [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 142 | [INFO] [stdout] 143 | Ok(Client { [INFO] [stdout] | ________^ [INFO] [stdout] 144 | | known_servers, [INFO] [stdout] 145 | | net, [INFO] [stdout] 146 | | cache: Default::default(), [INFO] [stdout] 147 | | processor: Some(processor), [INFO] [stdout] 148 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:177:8 [INFO] [stdout] | [INFO] [stdout] 155 | listen_addr: A, [INFO] [stdout] | -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 156 | storage_directory: P, [INFO] [stdout] | -------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 159 | let db = match sled::open(&storage_directory) { [INFO] [stdout] | -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 160 | Ok(db) => versioned_storage::VersionedStorage { db }, [INFO] [stdout] | -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 161 | Err(e) => { [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 173 | let (process_task, net) = Net::new_udp(listen_addr, timeout)?; [INFO] [stdout] | ------------ --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 174 | [INFO] [stdout] 175 | let processor = smol::spawn(process_task); [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 176 | [INFO] [stdout] 177 | Ok(Server { [INFO] [stdout] | ________^ [INFO] [stdout] 178 | | net, [INFO] [stdout] 179 | | db, [INFO] [stdout] 180 | | processor: Some(processor), [INFO] [stdout] 181 | | promises: Default::default(), [INFO] [stdout] 182 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/network.rs:146:12 [INFO] [stdout] | [INFO] [stdout] 125 | listen_addr: A, [INFO] [stdout] | -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 128 | let (outgoing, incoming) = channel::unbounded(); [INFO] [stdout] | -------- -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 129 | [INFO] [stdout] 130 | let mut addrs_iter = listen_addr.to_socket_addrs()?; [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 141 | let udp_net = UdpNet::new(listen_addr)?; [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 142 | let udp_net_2 = udp_net.clone(); [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 143 | [INFO] [stdout] 144 | let server = smol::spawn(udp_net_2.server_loop(outgoing)); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 145 | [INFO] [stdout] 146 | Ok(( [INFO] [stdout] | ____________^ [INFO] [stdout] 147 | | server, [INFO] [stdout] 148 | | Net { [INFO] [stdout] 149 | | address, [INFO] [stdout] ... | [INFO] [stdout] 153 | | }, [INFO] [stdout] 154 | | )) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/paxos.rs:130:31 [INFO] [stdout] | [INFO] [stdout] 130 | .map(|(r, from)| (transform(r), from)) [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/simulator.rs:62:20 [INFO] [stdout] | [INFO] [stdout] 57 | let (mut nets, simulation_runner) = [INFO] [stdout] | ---- ----------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 60 | let mut ret: Vec = vec![]; [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 61 | [INFO] [stdout] 62 | smol::block_on(async move { [INFO] [stdout] | ____________________^ [INFO] [stdout] 63 | | // start simulator [INFO] [stdout] 64 | | let simulation_runner_task = smol::spawn(async move { [INFO] [stdout] 65 | | simulation_runner.run().await; [INFO] [stdout] ... | [INFO] [stdout] 108 | | ret [INFO] [stdout] 109 | | }) [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/udp_net.rs:35:15 [INFO] [stdout] | [INFO] [stdout] 33 | addr: A, [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 34 | ) -> io::Result { [INFO] [stdout] 35 | match UdpSocket::bind(&addr) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 6 previous errors; 2 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `caspaxos-kv` (lib) due to 7 previous errors; 2 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] running `Command { std: "docker" "inspect" "c6a1348ebeb9b95ddc55c1654397be1624b232f0e65f032643ea3aa53dce8e84", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "c6a1348ebeb9b95ddc55c1654397be1624b232f0e65f032643ea3aa53dce8e84", kill_on_drop: false }` [INFO] [stdout] c6a1348ebeb9b95ddc55c1654397be1624b232f0e65f032643ea3aa53dce8e84