[INFO] fetching crate cash_tx_builder 0.3.1... [INFO] checking cash_tx_builder-0.3.1 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate cash_tx_builder 0.3.1 into /workspace/builds/worker-6-tc2/source [INFO] validating manifest of crates.io crate cash_tx_builder 0.3.1 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate cash_tx_builder 0.3.1 [INFO] finished tweaking crates.io crate cash_tx_builder 0.3.1 [INFO] tweaked toml for crates.io crate cash_tx_builder 0.3.1 written to /workspace/builds/worker-6-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 46 packages to latest compatible versions [INFO] [stderr] Adding addr2line v0.22.0 (latest: v0.24.1) [INFO] [stderr] Adding bech32 v0.6.0 (latest: v0.11.0) [INFO] [stderr] Adding block-buffer v0.7.3 (latest: v0.10.4) [INFO] [stderr] Adding block-padding v0.1.5 (latest: v0.3.3) [INFO] [stderr] Adding bs58 v0.2.5 (latest: v0.5.1) [INFO] [stderr] Adding digest v0.8.1 (latest: v0.10.7) [INFO] [stderr] Adding generic-array v0.12.4 (latest: v1.1.0) [INFO] [stderr] Adding gimli v0.29.0 (latest: v0.31.0) [INFO] [stderr] Adding hex v0.3.2 (latest: v0.4.3) [INFO] [stderr] Adding hex-literal v0.1.4 (latest: v0.4.1) [INFO] [stderr] Adding hex-literal-impl v0.1.2 (latest: v0.2.3) [INFO] [stderr] Adding miniz_oxide v0.7.4 (latest: v0.8.0) [INFO] [stderr] Adding opaque-debug v0.2.3 (latest: v0.3.1) [INFO] [stderr] Adding proc-macro-hack v0.4.3 (latest: v0.5.20+deprecated) [INFO] [stderr] Adding sha2 v0.8.2 (latest: v0.10.8) [INFO] [stderr] Adding syn v1.0.109 (latest: v2.0.77) [INFO] [stderr] Adding synstructure v0.12.6 (latest: v0.13.1) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 0d6ff91114d7730e4dcfa21055ec10ccb9f7d9f80ac2b7a6c306e8ce16660a18 [INFO] running `Command { std: "docker" "start" "-a" "0d6ff91114d7730e4dcfa21055ec10ccb9f7d9f80ac2b7a6c306e8ce16660a18", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "0d6ff91114d7730e4dcfa21055ec10ccb9f7d9f80ac2b7a6c306e8ce16660a18", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "0d6ff91114d7730e4dcfa21055ec10ccb9f7d9f80ac2b7a6c306e8ce16660a18", kill_on_drop: false }` [INFO] [stdout] 0d6ff91114d7730e4dcfa21055ec10ccb9f7d9f80ac2b7a6c306e8ce16660a18 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] c70e99b1276efae7a0f50c6fa425e8f5c94f8900558d26551048044cc3a3b385 [INFO] running `Command { std: "docker" "start" "-a" "c70e99b1276efae7a0f50c6fa425e8f5c94f8900558d26551048044cc3a3b385", kill_on_drop: false }` [INFO] [stderr] Compiling syn v1.0.109 [INFO] [stderr] Compiling libc v0.2.158 [INFO] [stderr] Checking gimli v0.29.0 [INFO] [stderr] Checking byte-tools v0.3.1 [INFO] [stderr] Compiling failure_derive v0.1.8 [INFO] [stderr] Checking adler v1.0.2 [INFO] [stderr] Checking rustc-demangle v0.1.24 [INFO] [stderr] Checking fake-simd v0.1.2 [INFO] [stderr] Compiling proc-macro-hack-impl v0.4.3 [INFO] [stderr] Checking generic-array v0.12.4 [INFO] [stderr] Compiling backtrace v0.3.73 [INFO] [stderr] Checking object v0.36.4 [INFO] [stderr] Checking opaque-debug v0.2.3 [INFO] [stderr] Compiling serde v1.0.209 [INFO] [stderr] Checking bech32 v0.6.0 [INFO] [stderr] Checking hex v0.3.2 [INFO] [stderr] Checking block-padding v0.1.5 [INFO] [stderr] Checking miniz_oxide v0.7.4 [INFO] [stderr] Compiling proc-macro-hack v0.4.3 [INFO] [stderr] Checking digest v0.8.1 [INFO] [stderr] Checking block-buffer v0.7.3 [INFO] [stderr] Compiling hex-literal-impl v0.1.2 [INFO] [stderr] Checking sha2 v0.8.2 [INFO] [stderr] Checking bs58 v0.2.5 [INFO] [stderr] Checking hex-literal v0.1.4 [INFO] [stderr] Compiling synstructure v0.12.6 [INFO] [stderr] Checking addr2line v0.22.0 [INFO] [stderr] Checking serde_json v1.0.127 [INFO] [stderr] Checking failure v0.1.8 [INFO] [stderr] Checking cash_addr v0.1.0 [INFO] [stderr] Checking cash_tx_builder v0.3.1 (/opt/rustwide/workdir) [INFO] [stderr] Checking bch_addr v0.1.0 [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/tx_builder.rs:90:12 [INFO] [stdout] | [INFO] [stdout] 89 | pub fn from_tx(tx: &Transaction, address_parser: F) -> Result> { [INFO] [stdout] | ----------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 90 | Ok(TxBuilder { [INFO] [stdout] | ____________^ [INFO] [stdout] 91 | | tx: tx.clone(), [INFO] [stdout] 92 | | prev_outputs: HashMap::new(), [INFO] [stdout] 93 | | fork_id: 0, [INFO] [stdout] 94 | | address_parser, [INFO] [stdout] 95 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/types/transaction.rs:36:10 [INFO] [stdout] | [INFO] [stdout] 29 | let mut ret = T::default(); [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 36 | Some((ret, &v[size..])) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 2 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `cash_tx_builder` (lib) due to 3 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] running `Command { std: "docker" "inspect" "c70e99b1276efae7a0f50c6fa425e8f5c94f8900558d26551048044cc3a3b385", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "c70e99b1276efae7a0f50c6fa425e8f5c94f8900558d26551048044cc3a3b385", kill_on_drop: false }` [INFO] [stdout] c70e99b1276efae7a0f50c6fa425e8f5c94f8900558d26551048044cc3a3b385