[INFO] fetching crate cargo-workspace2 0.2.2... [INFO] checking cargo-workspace2-0.2.2 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate cargo-workspace2 0.2.2 into /workspace/builds/worker-3-tc2/source [INFO] validating manifest of crates.io crate cargo-workspace2 0.2.2 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate cargo-workspace2 0.2.2 [INFO] finished tweaking crates.io crate cargo-workspace2 0.2.2 [INFO] tweaked toml for crates.io crate cargo-workspace2 0.2.2 written to /workspace/builds/worker-3-tc2/source/Cargo.toml [INFO] crate crates.io crate cargo-workspace2 0.2.2 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 7a6a11c77afcce177f65f16bbff3d04dde43a010f070e255862141cc4a31214f [INFO] running `Command { std: "docker" "start" "-a" "7a6a11c77afcce177f65f16bbff3d04dde43a010f070e255862141cc4a31214f", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "7a6a11c77afcce177f65f16bbff3d04dde43a010f070e255862141cc4a31214f", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "7a6a11c77afcce177f65f16bbff3d04dde43a010f070e255862141cc4a31214f", kill_on_drop: false }` [INFO] [stdout] 7a6a11c77afcce177f65f16bbff3d04dde43a010f070e255862141cc4a31214f [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] bada0d912da1725299d10b251415f9faca4bbdf2184f99cbd89b1b7bed8e1398 [INFO] running `Command { std: "docker" "start" "-a" "bada0d912da1725299d10b251415f9faca4bbdf2184f99cbd89b1b7bed8e1398", kill_on_drop: false }` [INFO] [stderr] Compiling num-traits v0.2.12 [INFO] [stderr] Compiling libc v0.2.79 [INFO] [stderr] Compiling num-integer v0.1.43 [INFO] [stderr] Compiling byteorder v1.3.4 [INFO] [stderr] Compiling memchr v2.3.3 [INFO] [stderr] Checking either v1.6.1 [INFO] [stderr] Checking ascii v0.9.3 [INFO] [stderr] Compiling cargo-workspace2 v0.2.2 (/opt/rustwide/workdir) [INFO] [stderr] Checking linked-hash-map v0.5.3 [INFO] [stderr] Checking semver-parser v0.7.0 [INFO] [stderr] Checking textwrap v0.12.1 [INFO] [stderr] Checking semver v0.9.0 [INFO] [stderr] Checking combine v3.8.1 [INFO] [stderr] Checking time v0.1.44 [INFO] [stderr] Checking chrono v0.4.19 [INFO] [stderr] Checking toml_edit v0.1.5 [INFO] [stdout] warning: unused import: `value` [INFO] [stdout] --> src/cargo/gen.rs:5:17 [INFO] [stdout] | [INFO] [stdout] 5 | use toml_edit::{value, Document, Item, Value}; [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around pattern [INFO] [stdout] --> src/ops/publish/exec.rs:41:31 [INFO] [stdout] | [INFO] [stdout] 41 | vec.into_iter().for_each(|(id)| { [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_parens)]` on by default [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 41 - vec.into_iter().for_each(|(id)| { [INFO] [stdout] 41 + vec.into_iter().for_each(|id| { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused imports: `PublishMod as Mod`, `PublishType`, `Publish`, and `versions` [INFO] [stdout] --> src/ops/executor.rs:3:13 [INFO] [stdout] | [INFO] [stdout] 3 | use super::{versions, Print, Publish, PublishMod as Mod, PublishType}; [INFO] [stdout] | ^^^^^^^^ ^^^^^^^ ^^^^^^^^^^^^^^^^^ ^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `semver::Version` [INFO] [stdout] --> src/ops/executor.rs:5:5 [INFO] [stdout] | [INFO] [stdout] 5 | use semver::Version; [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `semver::Version` [INFO] [stdout] --> src/ops/parser.rs:2:5 [INFO] [stdout] | [INFO] [stdout] 2 | use semver::Version; [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `value` [INFO] [stdout] --> src/cargo/gen.rs:5:17 [INFO] [stdout] | [INFO] [stdout] 5 | use toml_edit::{value, Document, Item, Value}; [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around pattern [INFO] [stdout] --> src/ops/publish/exec.rs:41:31 [INFO] [stdout] | [INFO] [stdout] 41 | vec.into_iter().for_each(|(id)| { [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_parens)]` on by default [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 41 - vec.into_iter().for_each(|(id)| { [INFO] [stdout] 41 + vec.into_iter().for_each(|id| { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused macro definition: `assert_bump` [INFO] [stdout] --> src/ops/publish/exec.rs:96:14 [INFO] [stdout] | [INFO] [stdout] 96 | macro_rules! assert_bump { [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_macros)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused imports: `PublishMod as Mod`, `PublishType`, `Publish`, and `versions` [INFO] [stdout] --> src/ops/executor.rs:3:13 [INFO] [stdout] | [INFO] [stdout] 3 | use super::{versions, Print, Publish, PublishMod as Mod, PublishType}; [INFO] [stdout] | ^^^^^^^^ ^^^^^^^ ^^^^^^^^^^^^^^^^^ ^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `semver::Version` [INFO] [stdout] --> src/ops/executor.rs:5:5 [INFO] [stdout] | [INFO] [stdout] 5 | use semver::Version; [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `semver::Version` [INFO] [stdout] --> src/ops/parser.rs:2:5 [INFO] [stdout] | [INFO] [stdout] 2 | use semver::Version; [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `devel` [INFO] [stdout] --> src/ops/publish/exec.rs:12:27 [INFO] [stdout] | [INFO] [stdout] 12 | let Publish { ref tt, devel } = p; [INFO] [stdout] | ^^^^^ help: try ignoring the field: `devel: _` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `devel` [INFO] [stdout] --> src/ops/publish/exec.rs:12:27 [INFO] [stdout] | [INFO] [stdout] 12 | let Publish { ref tt, devel } = p; [INFO] [stdout] | ^^^^^ help: try ignoring the field: `devel: _` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `new_version` is never read [INFO] [stdout] --> src/models/publish.rs:6:5 [INFO] [stdout] | [INFO] [stdout] 4 | pub struct PubMutation { [INFO] [stdout] | ----------- field in this struct [INFO] [stdout] 5 | _crate: CrateId, [INFO] [stdout] 6 | new_version: String, [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `major` is never used [INFO] [stdout] --> src/ops/publish/mod.rs:98:12 [INFO] [stdout] | [INFO] [stdout] 98 | pub fn major(_mod: PublishMod) -> PublishType { [INFO] [stdout] | ^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `minor` is never used [INFO] [stdout] --> src/ops/publish/mod.rs:103:12 [INFO] [stdout] | [INFO] [stdout] 103 | pub fn minor(_mod: PublishMod) -> PublishType { [INFO] [stdout] | ^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `patch` is never used [INFO] [stdout] --> src/ops/publish/mod.rs:108:12 [INFO] [stdout] | [INFO] [stdout] 108 | pub fn patch(_mod: PublishMod) -> PublishType { [INFO] [stdout] | ^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `mod_none` is never used [INFO] [stdout] --> src/ops/publish/mod.rs:113:12 [INFO] [stdout] | [INFO] [stdout] 113 | pub fn mod_none() -> PublishMod { [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `mod_alpha` is never used [INFO] [stdout] --> src/ops/publish/mod.rs:118:12 [INFO] [stdout] | [INFO] [stdout] 118 | pub fn mod_alpha() -> PublishMod { [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `mod_beta` is never used [INFO] [stdout] --> src/ops/publish/mod.rs:123:12 [INFO] [stdout] | [INFO] [stdout] 123 | pub fn mod_beta() -> PublishMod { [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `mod_rc` is never used [INFO] [stdout] --> src/ops/publish/mod.rs:128:12 [INFO] [stdout] | [INFO] [stdout] 128 | pub fn mod_rc() -> PublishMod { [INFO] [stdout] | ^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `get_nth` is never used [INFO] [stdout] --> src/cli.rs:10:4 [INFO] [stdout] | [INFO] [stdout] 10 | fn get_nth(idx: usize) -> Option { [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: panic message is not a string literal [INFO] [stdout] --> src/models/cargo.rs:26:25 [INFO] [stdout] | [INFO] [stdout] 26 | _ => panic!(format!("Invalid Cargo.toml: {:?}", self.path)), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this usage of `panic!()` is deprecated; it will be a hard error in Rust 2021 [INFO] [stdout] = note: for more information, see [INFO] [stdout] = note: the `panic!()` macro supports formatting, so there's no need for the `format!()` macro here [INFO] [stdout] = note: `#[warn(non_fmt_panics)]` on by default [INFO] [stdout] help: remove the `format!(..)` macro call [INFO] [stdout] | [INFO] [stdout] 26 - _ => panic!(format!("Invalid Cargo.toml: {:?}", self.path)), [INFO] [stdout] 26 + _ => panic!("Invalid Cargo.toml: {:?}", self.path), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: panic message is not a string literal [INFO] [stdout] --> src/models/cargo.rs:36:25 [INFO] [stdout] | [INFO] [stdout] 36 | _ => panic!(format!("Invalid Cargo.toml: {:?}", self.path)), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this usage of `panic!()` is deprecated; it will be a hard error in Rust 2021 [INFO] [stdout] = note: for more information, see [INFO] [stdout] = note: the `panic!()` macro supports formatting, so there's no need for the `format!()` macro here [INFO] [stdout] help: remove the `format!(..)` macro call [INFO] [stdout] | [INFO] [stdout] 36 - _ => panic!(format!("Invalid Cargo.toml: {:?}", self.path)), [INFO] [stdout] 36 + _ => panic!("Invalid Cargo.toml: {:?}", self.path), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/models/cargo.rs:120:12 [INFO] [stdout] | [INFO] [stdout] 94 | pub fn open(p: impl Into) -> Result { [INFO] [stdout] | --------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 97 | let root_cfg = cargo::parse_root_toml(path.join("Cargo.toml"))?; [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 100 | let m_cfg: Vec<_> = members [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 120 | Ok(Self { [INFO] [stdout] | ____________^ [INFO] [stdout] 121 | | root: path, [INFO] [stdout] 122 | | crates: m_cfg [INFO] [stdout] 123 | | .into_iter() [INFO] [stdout] ... | [INFO] [stdout] 129 | | .collect(), [INFO] [stdout] 130 | | }) [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/models/cargo.rs:103:30 [INFO] [stdout] | [INFO] [stdout] 103 | |name| match cargo::parse_toml(path.join(&name).join("Cargo.toml")) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: calls to `std::mem::drop` with a reference instead of an owned value does nothing [INFO] [stdout] --> src/ops/publish/exec.rs:21:9 [INFO] [stdout] | [INFO] [stdout] 21 | drop(c); [INFO] [stdout] | ^^^^^-^ [INFO] [stdout] | | [INFO] [stdout] | argument has type `&mut Crate` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dropping_references)]` on by default [INFO] [stdout] help: use `let _ = ...` to ignore the expression or result [INFO] [stdout] | [INFO] [stdout] 21 - drop(c); [INFO] [stdout] 21 + let _ = c; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 2 previous errors; 19 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `cargo-workspace2` (lib) due to 3 previous errors; 19 warnings emitted [INFO] [stdout] warning: field `new_version` is never read [INFO] [stdout] --> src/models/publish.rs:6:5 [INFO] [stdout] | [INFO] [stdout] 4 | pub struct PubMutation { [INFO] [stdout] | ----------- field in this struct [INFO] [stdout] 5 | _crate: CrateId, [INFO] [stdout] 6 | new_version: String, [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] warning: function `major` is never used [INFO] [stdout] --> src/ops/publish/mod.rs:98:12 [INFO] [stdout] | [INFO] [stdout] 98 | pub fn major(_mod: PublishMod) -> PublishType { [INFO] [stdout] | ^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `minor` is never used [INFO] [stdout] --> src/ops/publish/mod.rs:103:12 [INFO] [stdout] | [INFO] [stdout] 103 | pub fn minor(_mod: PublishMod) -> PublishType { [INFO] [stdout] | ^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `patch` is never used [INFO] [stdout] --> src/ops/publish/mod.rs:108:12 [INFO] [stdout] | [INFO] [stdout] 108 | pub fn patch(_mod: PublishMod) -> PublishType { [INFO] [stdout] | ^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `mod_none` is never used [INFO] [stdout] --> src/ops/publish/mod.rs:113:12 [INFO] [stdout] | [INFO] [stdout] 113 | pub fn mod_none() -> PublishMod { [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `mod_alpha` is never used [INFO] [stdout] --> src/ops/publish/mod.rs:118:12 [INFO] [stdout] | [INFO] [stdout] 118 | pub fn mod_alpha() -> PublishMod { [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `mod_beta` is never used [INFO] [stdout] --> src/ops/publish/mod.rs:123:12 [INFO] [stdout] | [INFO] [stdout] 123 | pub fn mod_beta() -> PublishMod { [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `mod_rc` is never used [INFO] [stdout] --> src/ops/publish/mod.rs:128:12 [INFO] [stdout] | [INFO] [stdout] 128 | pub fn mod_rc() -> PublishMod { [INFO] [stdout] | ^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `get_nth` is never used [INFO] [stdout] --> src/cli.rs:10:4 [INFO] [stdout] | [INFO] [stdout] 10 | fn get_nth(idx: usize) -> Option { [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: panic message is not a string literal [INFO] [stdout] --> src/models/cargo.rs:26:25 [INFO] [stdout] | [INFO] [stdout] 26 | _ => panic!(format!("Invalid Cargo.toml: {:?}", self.path)), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this usage of `panic!()` is deprecated; it will be a hard error in Rust 2021 [INFO] [stdout] = note: for more information, see [INFO] [stdout] = note: the `panic!()` macro supports formatting, so there's no need for the `format!()` macro here [INFO] [stdout] = note: `#[warn(non_fmt_panics)]` on by default [INFO] [stdout] help: remove the `format!(..)` macro call [INFO] [stdout] | [INFO] [stdout] 26 - _ => panic!(format!("Invalid Cargo.toml: {:?}", self.path)), [INFO] [stdout] 26 + _ => panic!("Invalid Cargo.toml: {:?}", self.path), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: panic message is not a string literal [INFO] [stdout] --> src/models/cargo.rs:36:25 [INFO] [stdout] | [INFO] [stdout] 36 | _ => panic!(format!("Invalid Cargo.toml: {:?}", self.path)), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this usage of `panic!()` is deprecated; it will be a hard error in Rust 2021 [INFO] [stdout] = note: for more information, see [INFO] [stdout] = note: the `panic!()` macro supports formatting, so there's no need for the `format!()` macro here [INFO] [stdout] help: remove the `format!(..)` macro call [INFO] [stdout] | [INFO] [stdout] 36 - _ => panic!(format!("Invalid Cargo.toml: {:?}", self.path)), [INFO] [stdout] 36 + _ => panic!("Invalid Cargo.toml: {:?}", self.path), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/models/cargo.rs:120:12 [INFO] [stdout] | [INFO] [stdout] 94 | pub fn open(p: impl Into) -> Result { [INFO] [stdout] | --------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 97 | let root_cfg = cargo::parse_root_toml(path.join("Cargo.toml"))?; [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 100 | let m_cfg: Vec<_> = members [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 120 | Ok(Self { [INFO] [stdout] | ____________^ [INFO] [stdout] 121 | | root: path, [INFO] [stdout] 122 | | crates: m_cfg [INFO] [stdout] 123 | | .into_iter() [INFO] [stdout] ... | [INFO] [stdout] 129 | | .collect(), [INFO] [stdout] 130 | | }) [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/models/cargo.rs:103:30 [INFO] [stdout] | [INFO] [stdout] 103 | |name| match cargo::parse_toml(path.join(&name).join("Cargo.toml")) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: calls to `std::mem::drop` with a reference instead of an owned value does nothing [INFO] [stdout] --> src/ops/publish/exec.rs:21:9 [INFO] [stdout] | [INFO] [stdout] 21 | drop(c); [INFO] [stdout] | ^^^^^-^ [INFO] [stdout] | | [INFO] [stdout] | argument has type `&mut Crate` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dropping_references)]` on by default [INFO] [stdout] help: use `let _ = ...` to ignore the expression or result [INFO] [stdout] | [INFO] [stdout] 21 - drop(c); [INFO] [stdout] 21 + let _ = c; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 2 previous errors; 18 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `cargo-workspace2` (lib test) due to 3 previous errors; 18 warnings emitted [INFO] running `Command { std: "docker" "inspect" "bada0d912da1725299d10b251415f9faca4bbdf2184f99cbd89b1b7bed8e1398", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "bada0d912da1725299d10b251415f9faca4bbdf2184f99cbd89b1b7bed8e1398", kill_on_drop: false }` [INFO] [stdout] bada0d912da1725299d10b251415f9faca4bbdf2184f99cbd89b1b7bed8e1398