[INFO] fetching crate cargo-whatfeatures 0.9.13... [INFO] checking cargo-whatfeatures-0.9.13 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate cargo-whatfeatures 0.9.13 into /workspace/builds/worker-4-tc2/source [INFO] validating manifest of crates.io crate cargo-whatfeatures 0.9.13 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate cargo-whatfeatures 0.9.13 [INFO] finished tweaking crates.io crate cargo-whatfeatures 0.9.13 [INFO] tweaked toml for crates.io crate cargo-whatfeatures 0.9.13 written to /workspace/builds/worker-4-tc2/source/Cargo.toml [INFO] crate crates.io crate cargo-whatfeatures 0.9.13 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 1981e7756f0d238ac352e55f9496d8e83d2a03952b0c19c32ff0d3681ef273c6 [INFO] running `Command { std: "docker" "start" "-a" "1981e7756f0d238ac352e55f9496d8e83d2a03952b0c19c32ff0d3681ef273c6", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "1981e7756f0d238ac352e55f9496d8e83d2a03952b0c19c32ff0d3681ef273c6", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "1981e7756f0d238ac352e55f9496d8e83d2a03952b0c19c32ff0d3681ef273c6", kill_on_drop: false }` [INFO] [stdout] 1981e7756f0d238ac352e55f9496d8e83d2a03952b0c19c32ff0d3681ef273c6 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 54c72f5e75c7e2569f3aade0ebcc92591bd977c0d147840b9ce976838a106dd8 [INFO] running `Command { std: "docker" "start" "-a" "54c72f5e75c7e2569f3aade0ebcc92591bd977c0d147840b9ce976838a106dd8", kill_on_drop: false }` [INFO] [stderr] Compiling libc v0.2.157 [INFO] [stderr] Compiling serde v1.0.208 [INFO] [stderr] Checking bitflags v2.6.0 [INFO] [stderr] Compiling serde_json v1.0.125 [INFO] [stderr] Compiling rustix v0.38.34 [INFO] [stderr] Compiling cc v1.1.13 [INFO] [stderr] Compiling camino v1.1.9 [INFO] [stderr] Compiling quote v1.0.36 [INFO] [stderr] Checking linux-raw-sys v0.4.14 [INFO] [stderr] Checking miniz_oxide v0.7.4 [INFO] [stderr] Checking option-ext v0.2.0 [INFO] [stderr] Checking pico-args v0.5.0 [INFO] [stderr] Checking crate_version_parse v0.2.0 [INFO] [stderr] Checking home v0.5.9 [INFO] [stderr] Compiling syn v2.0.75 [INFO] [stderr] Checking flate2 v1.0.31 [INFO] [stderr] Compiling openssl-sys v0.9.103 [INFO] [stderr] Checking filetime v0.2.24 [INFO] [stderr] Checking dirs-sys v0.4.1 [INFO] [stderr] Checking directories v5.0.1 [INFO] [stderr] Compiling openssl v0.10.66 [INFO] [stderr] Compiling native-tls v0.2.12 [INFO] [stderr] Checking xattr v1.3.1 [INFO] [stderr] Checking tar v0.4.41 [INFO] [stderr] Compiling serde_derive v1.0.208 [INFO] [stderr] Compiling openssl-macros v0.1.1 [INFO] [stderr] Compiling thiserror-impl v1.0.63 [INFO] [stderr] Checking thiserror v1.0.63 [INFO] [stderr] Checking deranged v0.3.11 [INFO] [stderr] Checking semver v1.0.23 [INFO] [stderr] Checking cargo-platform v0.1.8 [INFO] [stderr] Checking attohttpc v0.27.0 [INFO] [stderr] Checking cargo_metadata v0.18.1 [INFO] [stderr] Checking time v0.3.36 [INFO] [stderr] Checking cargo-whatfeatures v0.9.13 (/opt/rustwide/workdir) [INFO] [stdout] warning: field `right` is never read [INFO] [stdout] --> src/printer/style.rs:6:9 [INFO] [stdout] | [INFO] [stdout] 2 | pub struct Style { [INFO] [stdout] | ----- field in this struct [INFO] [stdout] ... [INFO] [stdout] 6 | pub right: &'static str, [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `Style` has derived impls for the traits `Clone` and `Debug`, but these are intentionally ignored during dead code analysis [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/args.rs:53:18 [INFO] [stdout] | [INFO] [stdout] 46 | fn exclusive(bad: I) -> Self [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 53 | bad: bad [INFO] [stdout] | __________________^ [INFO] [stdout] 54 | | .into_iter() [INFO] [stdout] 55 | | .map(|s| s.into_iter().map(|s| s.to_string()).collect()) [INFO] [stdout] | |________________________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/args.rs:55:26 [INFO] [stdout] | [INFO] [stdout] 55 | .map(|s| s.into_iter().map(|s| s.to_string()).collect()) [INFO] [stdout] | - ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/args.rs:67:18 [INFO] [stdout] | [INFO] [stdout] 60 | fn inclusive_with(bad: I, short: impl ToString, long: impl ToString) -> Self [INFO] [stdout] | ------ -------------------- ------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 67 | bad: bad [INFO] [stdout] | __________________^ [INFO] [stdout] 68 | | .into_iter() [INFO] [stdout] 69 | | .map(|s| s.into_iter().map(|s| s.to_string()).collect()) [INFO] [stdout] | |________________________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/args.rs:69:26 [INFO] [stdout] | [INFO] [stdout] 69 | .map(|s| s.into_iter().map(|s| s.to_string()).collect()) [INFO] [stdout] | - ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/args.rs:83:18 [INFO] [stdout] | [INFO] [stdout] 76 | fn exclusive_with(bad: I, short: impl ToString, long: impl ToString) -> Self [INFO] [stdout] | ------ -------------------- ------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 83 | bad: bad [INFO] [stdout] | __________________^ [INFO] [stdout] 84 | | .into_iter() [INFO] [stdout] 85 | | .map(|s| s.into_iter().map(|s| s.to_string()).collect()) [INFO] [stdout] | |________________________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/args.rs:85:26 [INFO] [stdout] | [INFO] [stdout] 85 | .map(|s| s.into_iter().map(|s| s.to_string()).collect()) [INFO] [stdout] | - ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/args.rs:214:5 [INFO] [stdout] | [INFO] [stdout] 204 | fn join_iter<'a, I, S, O, M, W>(iter: I, one: O, many: M, with: W) -> String [INFO] [stdout] | ------- ------ ------- ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | | | [INFO] [stdout] | | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 214 | / iter.map(|s| match s { [INFO] [stdout] 215 | | [n] => one(n), [INFO] [stdout] 216 | | n => many(n), [INFO] [stdout] 217 | | }) [INFO] [stdout] | |______^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/client.rs:27:9 [INFO] [stdout] | [INFO] [stdout] 27 | crate::util::extract_crate(&data, crate_name, crate_version).map(|path| Crate { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/client.rs:87:9 [INFO] [stdout] | [INFO] [stdout] 87 | self.fetch_bytes(&version.dl_path) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/client.rs:105:9 [INFO] [stdout] | [INFO] [stdout] 95 | let resp = attohttpc::get(format!("{}{}", self.host, endpoint)) [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 105 | resp.json() [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/printer/tree.rs:30:23 [INFO] [stdout] | [INFO] [stdout] 22 | pub fn new(data: S, children: I) -> Self [INFO] [stdout] | ------- ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 30 | children: children.into_iter().map(Into::into).collect(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/printer/workspace.rs:299:5 [INFO] [stdout] | [INFO] [stdout] 275 | deps: impl IntoIterator + 'a, [INFO] [stdout] | ----------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 299 | deps.into_iter().map(map) [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/registry.rs:75:12 [INFO] [stdout] | [INFO] [stdout] 18 | let home = home::cargo_home()? [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 24 | let (mut set, mut local) = (HashSet::new(), HashSet::new()); [INFO] [stdout] | --- ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 75 | Ok(Self { cached: set, local }) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/registry.rs:27:31 [INFO] [stdout] | [INFO] [stdout] 27 | .filter_map(|dir| dir.ok()?.path().read_dir().ok()) [INFO] [stdout] | --- ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/registry.rs:172:9 [INFO] [stdout] | [INFO] [stdout] 153 | pub fn from_local(path: impl Into) -> anyhow::Result { [INFO] [stdout] | ------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 172 | / cargo_metadata::MetadataCommand::new() [INFO] [stdout] 173 | | .current_dir(&path) [INFO] [stdout] 174 | | .no_deps() [INFO] [stdout] 175 | | .exec() [INFO] [stdout] ... | [INFO] [stdout] 185 | | ws [INFO] [stdout] 186 | | }) [INFO] [stdout] | |______________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/registry.rs:220:9 [INFO] [stdout] | [INFO] [stdout] 191 | pub fn from_path(path: impl Into) -> anyhow::Result { [INFO] [stdout] | ------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 220 | / cargo_metadata::MetadataCommand::new() [INFO] [stdout] 221 | | .current_dir(&path) [INFO] [stdout] 222 | | .no_deps() [INFO] [stdout] 223 | | .exec() [INFO] [stdout] 224 | | .map(|md| Workspace::parse(md, &name)) [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |__________________________________________________| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `right` is never read [INFO] [stdout] --> src/printer/style.rs:6:9 [INFO] [stdout] | [INFO] [stdout] 2 | pub struct Style { [INFO] [stdout] | ----- field in this struct [INFO] [stdout] ... [INFO] [stdout] 6 | pub right: &'static str, [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `Style` has derived impls for the traits `Clone` and `Debug`, but these are intentionally ignored during dead code analysis [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/args.rs:53:18 [INFO] [stdout] | [INFO] [stdout] 46 | fn exclusive(bad: I) -> Self [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 53 | bad: bad [INFO] [stdout] | __________________^ [INFO] [stdout] 54 | | .into_iter() [INFO] [stdout] 55 | | .map(|s| s.into_iter().map(|s| s.to_string()).collect()) [INFO] [stdout] | |________________________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/args.rs:55:26 [INFO] [stdout] | [INFO] [stdout] 55 | .map(|s| s.into_iter().map(|s| s.to_string()).collect()) [INFO] [stdout] | - ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/args.rs:67:18 [INFO] [stdout] | [INFO] [stdout] 60 | fn inclusive_with(bad: I, short: impl ToString, long: impl ToString) -> Self [INFO] [stdout] | ------ -------------------- ------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 67 | bad: bad [INFO] [stdout] | __________________^ [INFO] [stdout] 68 | | .into_iter() [INFO] [stdout] 69 | | .map(|s| s.into_iter().map(|s| s.to_string()).collect()) [INFO] [stdout] | |________________________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/args.rs:69:26 [INFO] [stdout] | [INFO] [stdout] 69 | .map(|s| s.into_iter().map(|s| s.to_string()).collect()) [INFO] [stdout] | - ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/args.rs:83:18 [INFO] [stdout] | [INFO] [stdout] 76 | fn exclusive_with(bad: I, short: impl ToString, long: impl ToString) -> Self [INFO] [stdout] | ------ -------------------- ------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 83 | bad: bad [INFO] [stdout] | __________________^ [INFO] [stdout] 84 | | .into_iter() [INFO] [stdout] 85 | | .map(|s| s.into_iter().map(|s| s.to_string()).collect()) [INFO] [stdout] | |________________________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/args.rs:85:26 [INFO] [stdout] | [INFO] [stdout] 85 | .map(|s| s.into_iter().map(|s| s.to_string()).collect()) [INFO] [stdout] | - ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/args.rs:214:5 [INFO] [stdout] | [INFO] [stdout] 204 | fn join_iter<'a, I, S, O, M, W>(iter: I, one: O, many: M, with: W) -> String [INFO] [stdout] | ------- ------ ------- ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | | | [INFO] [stdout] | | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 214 | / iter.map(|s| match s { [INFO] [stdout] 215 | | [n] => one(n), [INFO] [stdout] 216 | | n => many(n), [INFO] [stdout] 217 | | }) [INFO] [stdout] | |______^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 16 previous errors; 1 warning emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/client.rs:27:9 [INFO] [stdout] | [INFO] [stdout] 27 | crate::util::extract_crate(&data, crate_name, crate_version).map(|path| Crate { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/client.rs:87:9 [INFO] [stdout] | [INFO] [stdout] 87 | self.fetch_bytes(&version.dl_path) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/client.rs:105:9 [INFO] [stdout] | [INFO] [stdout] 95 | let resp = attohttpc::get(format!("{}{}", self.host, endpoint)) [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 105 | resp.json() [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/printer/tree.rs:30:23 [INFO] [stdout] | [INFO] [stdout] 22 | pub fn new(data: S, children: I) -> Self [INFO] [stdout] | ------- ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 30 | children: children.into_iter().map(Into::into).collect(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/printer/workspace.rs:299:5 [INFO] [stdout] | [INFO] [stdout] 275 | deps: impl IntoIterator + 'a, [INFO] [stdout] | ----------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 299 | deps.into_iter().map(map) [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/registry.rs:75:12 [INFO] [stdout] | [INFO] [stdout] 18 | let home = home::cargo_home()? [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 24 | let (mut set, mut local) = (HashSet::new(), HashSet::new()); [INFO] [stdout] | --- ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 75 | Ok(Self { cached: set, local }) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/registry.rs:27:31 [INFO] [stdout] | [INFO] [stdout] 27 | .filter_map(|dir| dir.ok()?.path().read_dir().ok()) [INFO] [stdout] | --- ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/registry.rs:172:9 [INFO] [stdout] | [INFO] [stdout] 153 | pub fn from_local(path: impl Into) -> anyhow::Result { [INFO] [stdout] | ------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 172 | / cargo_metadata::MetadataCommand::new() [INFO] [stdout] 173 | | .current_dir(&path) [INFO] [stdout] 174 | | .no_deps() [INFO] [stdout] 175 | | .exec() [INFO] [stdout] ... | [INFO] [stdout] 185 | | ws [INFO] [stdout] 186 | | }) [INFO] [stdout] | |______________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/registry.rs:220:9 [INFO] [stdout] | [INFO] [stdout] 191 | pub fn from_path(path: impl Into) -> anyhow::Result { [INFO] [stdout] | ------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 220 | / cargo_metadata::MetadataCommand::new() [INFO] [stdout] 221 | | .current_dir(&path) [INFO] [stdout] 222 | | .no_deps() [INFO] [stdout] 223 | | .exec() [INFO] [stdout] 224 | | .map(|md| Workspace::parse(md, &name)) [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |__________________________________________________| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `cargo-whatfeatures` (lib test) due to 17 previous errors; 1 warning emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: aborting due to 16 previous errors; 1 warning emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `cargo-whatfeatures` (lib) due to 17 previous errors; 1 warning emitted [INFO] running `Command { std: "docker" "inspect" "54c72f5e75c7e2569f3aade0ebcc92591bd977c0d147840b9ce976838a106dd8", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "54c72f5e75c7e2569f3aade0ebcc92591bd977c0d147840b9ce976838a106dd8", kill_on_drop: false }` [INFO] [stdout] 54c72f5e75c7e2569f3aade0ebcc92591bd977c0d147840b9ce976838a106dd8