[INFO] fetching crate cargo-watt 0.2.3... [INFO] checking cargo-watt-0.2.3 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate cargo-watt 0.2.3 into /workspace/builds/worker-3-tc2/source [INFO] validating manifest of crates.io crate cargo-watt 0.2.3 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate cargo-watt 0.2.3 [INFO] finished tweaking crates.io crate cargo-watt 0.2.3 [INFO] tweaked toml for crates.io crate cargo-watt 0.2.3 written to /workspace/builds/worker-3-tc2/source/Cargo.toml [INFO] crate crates.io crate cargo-watt 0.2.3 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] c4d6faef3d9ac22162bc20412af0c6ad2f0ec4763142018e7ff05244b8af5a4d [INFO] running `Command { std: "docker" "start" "-a" "c4d6faef3d9ac22162bc20412af0c6ad2f0ec4763142018e7ff05244b8af5a4d", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "c4d6faef3d9ac22162bc20412af0c6ad2f0ec4763142018e7ff05244b8af5a4d", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "c4d6faef3d9ac22162bc20412af0c6ad2f0ec4763142018e7ff05244b8af5a4d", kill_on_drop: false }` [INFO] [stdout] c4d6faef3d9ac22162bc20412af0c6ad2f0ec4763142018e7ff05244b8af5a4d [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 1ca74121e1b28851ad9a50977397fc34d55a17d4dbd3d63f56c986728833db74 [INFO] running `Command { std: "docker" "start" "-a" "1ca74121e1b28851ad9a50977397fc34d55a17d4dbd3d63f56c986728833db74", kill_on_drop: false }` [INFO] [stderr] Compiling autocfg v1.0.1 [INFO] [stderr] Compiling libc v0.2.79 [INFO] [stderr] Compiling proc-macro2 v1.0.24 [INFO] [stderr] Checking cfg-if v0.1.10 [INFO] [stderr] Compiling unicode-xid v0.2.1 [INFO] [stderr] Compiling syn v1.0.44 [INFO] [stderr] Compiling cc v1.0.61 [INFO] [stderr] Compiling version_check v0.9.2 [INFO] [stderr] Compiling memchr v2.3.3 [INFO] [stderr] Compiling maybe-uninit v2.0.0 [INFO] [stderr] Compiling serde_derive v1.0.116 [INFO] [stderr] Compiling log v0.4.11 [INFO] [stderr] Compiling crossbeam-utils v0.7.2 [INFO] [stderr] Compiling memoffset v0.5.6 [INFO] [stderr] Checking once_cell v1.4.1 [INFO] [stderr] Compiling num-traits v0.2.12 [INFO] [stderr] Compiling proc-macro-error-attr v1.0.4 [INFO] [stderr] Compiling crossbeam-epoch v0.8.2 [INFO] [stderr] Compiling serde v1.0.116 [INFO] [stderr] Compiling num-integer v0.1.43 [INFO] [stderr] Compiling quote v1.0.7 [INFO] [stderr] Compiling proc-macro-error v1.0.4 [INFO] [stderr] Checking scopeguard v1.1.0 [INFO] [stderr] Checking tinyvec v0.3.4 [INFO] [stderr] Compiling rayon-core v1.8.1 [INFO] [stderr] Compiling ryu v1.0.5 [INFO] [stderr] Checking matches v0.1.8 [INFO] [stderr] Compiling byteorder v1.3.4 [INFO] [stderr] Compiling ring v0.16.15 [INFO] [stderr] Checking unicode-bidi v0.3.4 [INFO] [stderr] Checking unicode-normalization v0.1.13 [INFO] [stderr] Checking atty v0.2.14 [INFO] [stderr] Checking aho-corasick v0.7.14 [INFO] [stderr] Compiling miniz_oxide v0.4.3 [INFO] [stderr] Compiling indexmap v1.6.0 [INFO] [stderr] Checking either v1.6.1 [INFO] [stderr] Compiling unicode-segmentation v1.6.0 [INFO] [stderr] Checking termcolor v1.1.0 [INFO] [stderr] Compiling bitflags v1.2.1 [INFO] [stderr] Compiling crc32fast v1.2.0 [INFO] [stderr] Checking regex-syntax v0.6.20 [INFO] [stderr] Checking void v1.0.2 [INFO] [stderr] Checking percent-encoding v2.1.0 [INFO] [stderr] Compiling serde_json v1.0.59 [INFO] [stderr] Checking quick-error v1.2.3 [INFO] [stderr] Checking unreachable v1.0.0 [INFO] [stderr] Checking humantime v1.3.0 [INFO] [stderr] Checking idna v0.2.0 [INFO] [stderr] Compiling heck v0.3.1 [INFO] [stderr] Checking crossbeam-deque v0.7.3 [INFO] [stderr] Checking crossbeam-channel v0.4.4 [INFO] [stderr] Checking time v0.1.44 [INFO] [stderr] Checking num_cpus v1.13.0 [INFO] [stderr] Compiling rayon v1.4.1 [INFO] [stderr] Checking semver-parser v0.7.0 [INFO] [stderr] Checking ascii v0.9.3 [INFO] [stderr] Checking hashbrown v0.9.1 [INFO] [stderr] Compiling anyhow v1.0.33 [INFO] [stderr] Checking unicode-width v0.1.8 [INFO] [stderr] Checking adler v0.2.3 [INFO] [stderr] Checking base64 v0.12.3 [INFO] [stderr] Checking itoa v0.4.6 [INFO] [stderr] Checking combine v3.8.1 [INFO] [stderr] Checking textwrap v0.12.1 [INFO] [stderr] Checking chrono v0.4.19 [INFO] [stderr] Checking url v2.1.1 [INFO] [stderr] Checking qstring v0.7.2 [INFO] [stderr] Checking filetime v0.2.12 [INFO] [stderr] Checking base64 v0.13.0 [INFO] [stderr] Checking chunked_transfer v1.3.0 [INFO] [stderr] Checking webpki v0.21.3 [INFO] [stderr] Checking sct v0.6.0 [INFO] [stderr] Checking strsim v0.10.0 [INFO] [stderr] Checking linked-hash-map v0.5.3 [INFO] [stderr] Checking regex v1.4.1 [INFO] [stderr] Checking os_str_bytes v2.3.2 [INFO] [stderr] Checking vec_map v0.8.2 [INFO] [stderr] Checking walkdir v2.3.1 [INFO] [stderr] Checking tar v0.4.30 [INFO] [stderr] Checking rustls v0.18.1 [INFO] [stderr] Checking webpki-roots v0.20.0 [INFO] [stderr] Checking flate2 v1.0.18 [INFO] [stderr] Checking fastrand v1.4.0 [INFO] [stderr] Checking env_logger v0.7.1 [INFO] [stderr] Checking pretty_env_logger v0.4.0 [INFO] [stderr] Compiling clap_derive v3.0.0-beta.2 [INFO] [stderr] Checking ureq v1.5.1 [INFO] [stderr] Checking clap v3.0.0-beta.2 [INFO] [stderr] Checking toml_edit v0.2.0 [INFO] [stderr] Checking semver v0.10.0 [INFO] [stderr] Checking cargo_metadata v0.11.4 [INFO] [stderr] Checking cargo-watt v0.2.3 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/utils_toml.rs:17:20 [INFO] [stdout] | [INFO] [stdout] 5 | let mut a_table = Table::new(); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 13 | let mut b_table = Table::new(); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 17 | .or_insert(Item::Table(b_table)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/utils_toml.rs:17:20 [INFO] [stdout] | [INFO] [stdout] 5 | let mut a_table = Table::new(); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 13 | let mut b_table = Table::new(); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 17 | .or_insert(Item::Table(b_table)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/wasm/mod.rs:93:8 [INFO] [stdout] | [INFO] [stdout] 32 | let fns = modifications::make_modifications(&directory) [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 93 | Ok((fns, wasm)) [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/wasm/mod.rs:93:8 [INFO] [stdout] | [INFO] [stdout] 32 | let fns = modifications::make_modifications(&directory) [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 93 | Ok((fns, wasm)) [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/wasm/modifications.rs:155:8 [INFO] [stdout] | [INFO] [stdout] 126 | let mut file = syn::parse_str::(input)?; [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 130 | let c_abi: syn::Abi = syn::parse_quote!(extern "C"); [INFO] [stdout] | ----- ----------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 131 | let no_mangle = parse_attributes(quote::quote!(#[no_mangle]))?; [INFO] [stdout] | --------- --------------------------- [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 132 | [INFO] [stdout] 133 | let mut fns = Vec::new(); [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 155 | Ok((fns, quote::quote!(#file).to_string())) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/wasm/modifications.rs:191:28 [INFO] [stdout] | [INFO] [stdout] 191 | .filter_map(|attr| attr.parse_meta().ok()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/wasm/modifications.rs:155:8 [INFO] [stdout] | [INFO] [stdout] 126 | let mut file = syn::parse_str::(input)?; [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 130 | let c_abi: syn::Abi = syn::parse_quote!(extern "C"); [INFO] [stdout] | ----- ----------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 131 | let no_mangle = parse_attributes(quote::quote!(#[no_mangle]))?; [INFO] [stdout] | --------- --------------------------- [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 132 | [INFO] [stdout] 133 | let mut fns = Vec::new(); [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 155 | Ok((fns, quote::quote!(#file).to_string())) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/wasm/modifications.rs:191:28 [INFO] [stdout] | [INFO] [stdout] 191 | .filter_map(|attr| attr.parse_meta().ok()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 4 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `cargo-watt` (bin "cargo-watt" test) due to 5 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: aborting due to 4 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `cargo-watt` (bin "cargo-watt") due to 5 previous errors [INFO] running `Command { std: "docker" "inspect" "1ca74121e1b28851ad9a50977397fc34d55a17d4dbd3d63f56c986728833db74", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "1ca74121e1b28851ad9a50977397fc34d55a17d4dbd3d63f56c986728833db74", kill_on_drop: false }` [INFO] [stdout] 1ca74121e1b28851ad9a50977397fc34d55a17d4dbd3d63f56c986728833db74