[INFO] fetching crate cargo-vita 0.2.1... [INFO] checking cargo-vita-0.2.1 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate cargo-vita 0.2.1 into /workspace/builds/worker-4-tc2/source [INFO] validating manifest of crates.io crate cargo-vita 0.2.1 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate cargo-vita 0.2.1 [INFO] finished tweaking crates.io crate cargo-vita 0.2.1 [INFO] tweaked toml for crates.io crate cargo-vita 0.2.1 written to /workspace/builds/worker-4-tc2/source/Cargo.toml [INFO] crate crates.io crate cargo-vita 0.2.1 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 713253a36906cc7c467de32cad09f8c303bd07be79e22dc3df1b71278ad7322b [INFO] running `Command { std: "docker" "start" "-a" "713253a36906cc7c467de32cad09f8c303bd07be79e22dc3df1b71278ad7322b", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "713253a36906cc7c467de32cad09f8c303bd07be79e22dc3df1b71278ad7322b", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "713253a36906cc7c467de32cad09f8c303bd07be79e22dc3df1b71278ad7322b", kill_on_drop: false }` [INFO] [stdout] 713253a36906cc7c467de32cad09f8c303bd07be79e22dc3df1b71278ad7322b [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 71e30df1b8c47eb7104d3b6bf19adca50a07aef4a94ed5c86dbdcf1d3fd0ac42 [INFO] running `Command { std: "docker" "start" "-a" "71e30df1b8c47eb7104d3b6bf19adca50a07aef4a94ed5c86dbdcf1d3fd0ac42", kill_on_drop: false }` [INFO] [stderr] Compiling proc-macro2 v1.0.79 [INFO] [stderr] Compiling unicode-ident v1.0.12 [INFO] [stderr] Compiling serde v1.0.197 [INFO] [stderr] Checking memchr v2.7.2 [INFO] [stderr] Compiling libc v0.2.153 [INFO] [stderr] Checking regex-syntax v0.8.3 [INFO] [stderr] Checking log v0.4.21 [INFO] [stderr] Checking utf8parse v0.2.1 [INFO] [stderr] Compiling autocfg v1.2.0 [INFO] [stderr] Compiling thiserror v1.0.58 [INFO] [stderr] Compiling syn v1.0.109 [INFO] [stderr] Compiling semver v1.0.22 [INFO] [stderr] Checking anstyle v1.0.6 [INFO] [stderr] Compiling cc v1.0.90 [INFO] [stderr] Checking anstyle-parse v0.2.3 [INFO] [stderr] Checking colorchoice v1.0.0 [INFO] [stderr] Checking anstyle-query v1.0.2 [INFO] [stderr] Compiling rustix v0.38.32 [INFO] [stderr] Checking adler v1.0.2 [INFO] [stderr] Checking gimli v0.28.1 [INFO] [stderr] Compiling serde_json v1.0.115 [INFO] [stderr] Checking anstream v0.6.13 [INFO] [stderr] Compiling camino v1.1.6 [INFO] [stderr] Compiling either v1.10.0 [INFO] [stderr] Checking miniz_oxide v0.7.2 [INFO] [stderr] Checking linux-raw-sys v0.4.13 [INFO] [stderr] Checking rustc-demangle v0.1.23 [INFO] [stderr] Compiling num-traits v0.2.18 [INFO] [stderr] Checking once_cell v1.19.0 [INFO] [stderr] Compiling heck v0.5.0 [INFO] [stderr] Checking ryu v1.0.17 [INFO] [stderr] Checking bitflags v2.5.0 [INFO] [stderr] Compiling anyhow v1.0.81 [INFO] [stderr] Checking strsim v0.11.0 [INFO] [stderr] Checking aho-corasick v1.1.3 [INFO] [stderr] Checking object v0.32.2 [INFO] [stderr] Checking byteorder v1.5.0 [INFO] [stderr] Checking iana-time-zone v0.1.60 [INFO] [stderr] Checking clap_lex v0.7.0 [INFO] [stderr] Checking lazy_static v1.4.0 [INFO] [stderr] Checking fastrand v2.0.2 [INFO] [stderr] Checking humantime v2.1.0 [INFO] [stderr] Checking colored v2.1.0 [INFO] [stderr] Checking clap_builder v4.5.2 [INFO] [stderr] Compiling quote v1.0.35 [INFO] [stderr] Checking walkdir v2.5.0 [INFO] [stderr] Checking tee v0.1.0 [INFO] [stderr] Compiling syn v2.0.57 [INFO] [stderr] Checking chrono v0.4.37 [INFO] [stderr] Compiling backtrace v0.3.71 [INFO] [stderr] Checking regex-automata v0.4.6 [INFO] [stderr] Checking addr2line v0.21.0 [INFO] [stderr] Checking tempfile v3.10.1 [INFO] [stderr] Checking regex v1.10.4 [INFO] [stderr] Compiling serde_derive v1.0.197 [INFO] [stderr] Compiling thiserror-impl v1.0.58 [INFO] [stderr] Compiling clap_derive v4.5.4 [INFO] [stderr] Compiling enum_dispatch v0.3.13 [INFO] [stderr] Checking env_filter v0.1.0 [INFO] [stderr] Checking env_logger v0.11.3 [INFO] [stderr] Compiling lazy-regex-proc_macros v3.1.0 [INFO] [stderr] Checking clap v4.5.4 [INFO] [stderr] Checking lazy-regex v3.1.0 [INFO] [stderr] Checking suppaftp v5.3.1 [INFO] [stderr] Checking cargo-platform v0.1.8 [INFO] [stderr] Checking rustc_version v0.4.0 [INFO] [stderr] Compiling neli-proc-macros v0.1.3 [INFO] [stderr] Checking cargo_metadata v0.18.1 [INFO] [stderr] Checking neli v0.6.4 [INFO] [stderr] Checking local-ip-address v0.6.1 [INFO] [stderr] Checking cargo-vita v0.2.1 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/check.rs:43:13 [INFO] [stdout] | [INFO] [stdout] 42 | .and_then(|stdout| { [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 43 | serde_json::from_reader(stdout) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/commands/build.rs:123:12 [INFO] [stdout] | [INFO] [stdout] 114 | let (meta, package, _) = parse_crate_metadata(Some(&artifact))?; [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 115 | let package = package.context("artifact does not have a package")?; [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 123 | Ok(Self { [INFO] [stdout] | ____________^ [INFO] [stdout] 124 | | artifact, [INFO] [stdout] 125 | | meta, [INFO] [stdout] 126 | | package, [INFO] [stdout] 127 | | elf: executable, [INFO] [stdout] 128 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/commands/build.rs:533:31 [INFO] [stdout] | [INFO] [stdout] 533 | self.pass_env(key, || default().as_ref().to_string_lossy().to_string()) [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/check.rs:43:13 [INFO] [stdout] | [INFO] [stdout] 42 | .and_then(|stdout| { [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 43 | serde_json::from_reader(stdout) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/meta.rs:136:8 [INFO] [stdout] | [INFO] [stdout] 116 | let meta = MetadataCommand::new() [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 136 | Ok(( [INFO] [stdout] | ________^ [INFO] [stdout] 137 | | PackageMetadata::default(), [INFO] [stdout] 138 | | pkg.cloned(), [INFO] [stdout] 139 | | meta.target_directory, [INFO] [stdout] 140 | | )) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/commands/build.rs:123:12 [INFO] [stdout] | [INFO] [stdout] 114 | let (meta, package, _) = parse_crate_metadata(Some(&artifact))?; [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 115 | let package = package.context("artifact does not have a package")?; [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 123 | Ok(Self { [INFO] [stdout] | ____________^ [INFO] [stdout] 124 | | artifact, [INFO] [stdout] 125 | | meta, [INFO] [stdout] 126 | | package, [INFO] [stdout] 127 | | elf: executable, [INFO] [stdout] 128 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/commands/build.rs:533:31 [INFO] [stdout] | [INFO] [stdout] 533 | self.pass_env(key, || default().as_ref().to_string_lossy().to_string()) [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/meta.rs:136:8 [INFO] [stdout] | [INFO] [stdout] 116 | let meta = MetadataCommand::new() [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 136 | Ok(( [INFO] [stdout] | ________^ [INFO] [stdout] 137 | | PackageMetadata::default(), [INFO] [stdout] 138 | | pkg.cloned(), [INFO] [stdout] 139 | | meta.target_directory, [INFO] [stdout] 140 | | )) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 4 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 4 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `cargo-vita` (bin "cargo-vita" test) due to 5 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] error: could not compile `cargo-vita` (bin "cargo-vita") due to 5 previous errors [INFO] running `Command { std: "docker" "inspect" "71e30df1b8c47eb7104d3b6bf19adca50a07aef4a94ed5c86dbdcf1d3fd0ac42", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "71e30df1b8c47eb7104d3b6bf19adca50a07aef4a94ed5c86dbdcf1d3fd0ac42", kill_on_drop: false }` [INFO] [stdout] 71e30df1b8c47eb7104d3b6bf19adca50a07aef4a94ed5c86dbdcf1d3fd0ac42