[INFO] fetching crate cargo-upgrades 2.1.2... [INFO] checking cargo-upgrades-2.1.2 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate cargo-upgrades 2.1.2 into /workspace/builds/worker-7-tc2/source [INFO] validating manifest of crates.io crate cargo-upgrades 2.1.2 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate cargo-upgrades 2.1.2 [INFO] finished tweaking crates.io crate cargo-upgrades 2.1.2 [INFO] tweaked toml for crates.io crate cargo-upgrades 2.1.2 written to /workspace/builds/worker-7-tc2/source/Cargo.toml [INFO] crate crates.io crate cargo-upgrades 2.1.2 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 4a55475dda5f3bac2a086ed05ef3238117bedd1150aab0041622458548edb6c2 [INFO] running `Command { std: "docker" "start" "-a" "4a55475dda5f3bac2a086ed05ef3238117bedd1150aab0041622458548edb6c2", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "4a55475dda5f3bac2a086ed05ef3238117bedd1150aab0041622458548edb6c2", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "4a55475dda5f3bac2a086ed05ef3238117bedd1150aab0041622458548edb6c2", kill_on_drop: false }` [INFO] [stdout] 4a55475dda5f3bac2a086ed05ef3238117bedd1150aab0041622458548edb6c2 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 1ae7b7b616e558752f6b5267a76e1856205467d15555173421396c822b78b57d [INFO] running `Command { std: "docker" "start" "-a" "1ae7b7b616e558752f6b5267a76e1856205467d15555173421396c822b78b57d", kill_on_drop: false }` [INFO] [stderr] Compiling libc v0.2.155 [INFO] [stderr] Compiling serde v1.0.204 [INFO] [stderr] Compiling dunce v1.0.4 [INFO] [stderr] Compiling fs_extra v1.3.0 [INFO] [stderr] Compiling aws-lc-rs v1.8.0 [INFO] [stderr] Checking rustls-pki-types v1.7.0 [INFO] [stderr] Compiling quote v1.0.36 [INFO] [stderr] Checking cfg-if v1.0.0 [INFO] [stderr] Checking tinyvec_macros v0.1.1 [INFO] [stderr] Checking itoa v1.0.11 [INFO] [stderr] Checking tinyvec v1.8.0 [INFO] [stderr] Checking mirai-annotations v1.12.0 [INFO] [stderr] Checking spin v0.9.8 [INFO] [stderr] Checking untrusted v0.9.0 [INFO] [stderr] Compiling semver v1.0.23 [INFO] [stderr] Checking hashbrown v0.14.5 [INFO] [stderr] Compiling serde_json v1.0.120 [INFO] [stderr] Checking equivalent v1.0.1 [INFO] [stderr] Compiling syn v2.0.71 [INFO] [stderr] Compiling thiserror v1.0.62 [INFO] [stderr] Checking fnv v1.0.7 [INFO] [stderr] Compiling camino v1.1.7 [INFO] [stderr] Checking ryu v1.0.18 [INFO] [stderr] Checking unicode-bidi v0.3.15 [INFO] [stderr] Checking percent-encoding v2.3.1 [INFO] [stderr] Checking bytes v1.6.1 [INFO] [stderr] Checking winnow v0.6.13 [INFO] [stderr] Checking indexmap v2.2.6 [INFO] [stderr] Compiling rustls v0.23.11 [INFO] [stderr] Compiling jobserver v0.1.31 [INFO] [stderr] Checking base64 v0.22.1 [INFO] [stderr] Checking unicode-normalization v0.1.23 [INFO] [stderr] Checking http v1.1.0 [INFO] [stderr] Checking getrandom v0.2.15 [INFO] [stderr] Compiling cc v1.1.4 [INFO] [stderr] Checking rustls-pemfile v2.1.2 [INFO] [stderr] Checking form_urlencoded v1.2.1 [INFO] [stderr] Checking subtle v2.6.1 [INFO] [stderr] Checking idna v0.5.0 [INFO] [stderr] Checking log v0.4.22 [INFO] [stderr] Checking once_cell v1.19.0 [INFO] [stderr] Checking openssl-probe v0.1.5 [INFO] [stderr] Checking rustls-native-certs v0.7.1 [INFO] [stderr] Checking is-terminal v0.4.12 [INFO] [stderr] Checking webpki-roots v0.26.3 [INFO] [stderr] Checking unicode-width v0.1.13 [INFO] [stderr] Compiling xflags-macros v0.3.2 [INFO] [stderr] Checking memchr v2.7.4 [INFO] [stderr] Checking rustc-hash v1.1.0 [INFO] [stderr] Checking home v0.5.9 [INFO] [stderr] Checking tabwriter v1.4.0 [INFO] [stderr] Checking url v2.5.2 [INFO] [stderr] Checking yansi v1.0.1 [INFO] [stderr] Compiling cmake v0.1.50 [INFO] [stderr] Checking quick-error v2.0.1 [INFO] [stderr] Checking xflags v0.3.2 [INFO] [stderr] Compiling aws-lc-sys v0.19.0 [INFO] [stderr] Compiling ring v0.17.8 [INFO] [stderr] Compiling serde_derive v1.0.204 [INFO] [stderr] Compiling zeroize_derive v1.4.2 [INFO] [stderr] Compiling thiserror-impl v1.0.62 [INFO] [stderr] Checking zeroize v1.8.1 [INFO] [stderr] Checking serde_spanned v0.6.6 [INFO] [stderr] Checking toml_datetime v0.6.6 [INFO] [stderr] Checking toml_edit v0.22.15 [INFO] [stderr] Checking smol_str v0.2.2 [INFO] [stderr] Checking cargo-platform v0.1.8 [INFO] [stderr] Checking hex v0.4.3 [INFO] [stderr] Checking cargo_metadata v0.18.1 [INFO] [stderr] Checking toml v0.8.14 [INFO] [stderr] Checking crates-index v3.0.0 [INFO] [stderr] Checking rustls-webpki v0.102.5 [INFO] [stderr] Checking ureq v2.10.0 [INFO] [stderr] Checking cargo-upgrades v2.1.2 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:69:12 [INFO] [stdout] | [INFO] [stdout] 62 | let t = std::thread::spawn(move || { [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 67 | let workspace = t.join().unwrap()?; [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 68 | [INFO] [stdout] 69 | Ok(Self { [INFO] [stdout] | ____________^ [INFO] [stdout] 70 | | workspace, [INFO] [stdout] 71 | | index, [INFO] [stdout] 72 | | refreshed_crates: Default::default(), [INFO] [stdout] 73 | | retries: AtomicU32::new(0), [INFO] [stdout] 74 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:97:12 [INFO] [stdout] | [INFO] [stdout] 91 | let metadata = Self::new_metadata(manifest_path, CargoOpt::AllFeatures) [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 97 | Ok(Self { [INFO] [stdout] | ____________^ [INFO] [stdout] 98 | | packages: metadata.packages.into_iter().map(|p| (p.id.clone(), p)).collect(), [INFO] [stdout] 99 | | members: metadata.workspace_members, [INFO] [stdout] 100 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:93:13 [INFO] [stdout] | [INFO] [stdout] 92 | .or_else(move |e| { [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 93 | / Self::new_metadata(manifest_path, CargoOpt::SomeFeatures(vec![])) [INFO] [stdout] 94 | | .or_else(move |_| Self::new_metadata(manifest_path, CargoOpt::NoDefaultFeatures)) [INFO] [stdout] | |_____________________________________________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:95:22 [INFO] [stdout] | [INFO] [stdout] 92 | .or_else(move |e| { [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 95 | .map_err(|_| e) [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:69:12 [INFO] [stdout] | [INFO] [stdout] 62 | let t = std::thread::spawn(move || { [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 67 | let workspace = t.join().unwrap()?; [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 68 | [INFO] [stdout] 69 | Ok(Self { [INFO] [stdout] | ____________^ [INFO] [stdout] 70 | | workspace, [INFO] [stdout] 71 | | index, [INFO] [stdout] 72 | | refreshed_crates: Default::default(), [INFO] [stdout] 73 | | retries: AtomicU32::new(0), [INFO] [stdout] 74 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:169:18 [INFO] [stdout] | [INFO] [stdout] 115 | let threads: Vec<_> = package.dependencies.iter().map(move |dep| std::thread::Builder::new().spawn_scoped(s, move || { [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 162 | let deps: Vec<_> = threads.into_iter() [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 169 | Some((package, deps)) [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:97:12 [INFO] [stdout] | [INFO] [stdout] 91 | let metadata = Self::new_metadata(manifest_path, CargoOpt::AllFeatures) [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 97 | Ok(Self { [INFO] [stdout] | ____________^ [INFO] [stdout] 98 | | packages: metadata.packages.into_iter().map(|p| (p.id.clone(), p)).collect(), [INFO] [stdout] 99 | | members: metadata.workspace_members, [INFO] [stdout] 100 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:93:13 [INFO] [stdout] | [INFO] [stdout] 92 | .or_else(move |e| { [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 93 | / Self::new_metadata(manifest_path, CargoOpt::SomeFeatures(vec![])) [INFO] [stdout] 94 | | .or_else(move |_| Self::new_metadata(manifest_path, CargoOpt::NoDefaultFeatures)) [INFO] [stdout] | |_____________________________________________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:95:22 [INFO] [stdout] | [INFO] [stdout] 92 | .or_else(move |e| { [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 95 | .map_err(|_| e) [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:169:18 [INFO] [stdout] | [INFO] [stdout] 115 | let threads: Vec<_> = package.dependencies.iter().map(move |dep| std::thread::Builder::new().spawn_scoped(s, move || { [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 162 | let deps: Vec<_> = threads.into_iter() [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 169 | Some((package, deps)) [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:154:20 [INFO] [stdout] | [INFO] [stdout] 121 | let (c, fetch_err) = checker.get_crate(dep_name)?; [INFO] [stdout] | - --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 122 | let fetch_err = fetch_err.map(Err).unwrap_or(Ok(())); [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 123 | [INFO] [stdout] 124 | let (matching, non_matching): (Vec<_>, Vec<_>) = c.versions().iter() [INFO] [stdout] | -------- ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 154 | Ok(Some(Match { [INFO] [stdout] | ____________________^ [INFO] [stdout] 155 | | latest: latest.clone(), [INFO] [stdout] 156 | | matches: matching.into_iter().max(), [INFO] [stdout] 157 | | dependency: dep, [INFO] [stdout] 158 | | })) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |__________________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:126:37 [INFO] [stdout] | [INFO] [stdout] 126 | .filter_map(|v| Version::parse(v.version()).ok()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:163:26 [INFO] [stdout] | [INFO] [stdout] 163 | .map(|t| t.unwrap().join().unwrap()) [INFO] [stdout] | - ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:154:20 [INFO] [stdout] | [INFO] [stdout] 121 | let (c, fetch_err) = checker.get_crate(dep_name)?; [INFO] [stdout] | - --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 122 | let fetch_err = fetch_err.map(Err).unwrap_or(Ok(())); [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 123 | [INFO] [stdout] 124 | let (matching, non_matching): (Vec<_>, Vec<_>) = c.versions().iter() [INFO] [stdout] | -------- ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 154 | Ok(Some(Match { [INFO] [stdout] | ____________________^ [INFO] [stdout] 155 | | latest: latest.clone(), [INFO] [stdout] 156 | | matches: matching.into_iter().max(), [INFO] [stdout] 157 | | dependency: dep, [INFO] [stdout] 158 | | })) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |__________________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:126:37 [INFO] [stdout] | [INFO] [stdout] 126 | .filter_map(|v| Version::parse(v.version()).ok()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:193:12 [INFO] [stdout] | [INFO] [stdout] 183 | let fetch_err = if not_updated_yet { [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 184 | match self.fetch_crate(crate_name) { [INFO] [stdout] 185 | Ok(Some(c)) => return Ok((c, None)), [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 186 | Ok(None) => None, [INFO] [stdout] 187 | Err(e) => Some(e), [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 193 | Ok((self.index.crate_from_cache(crate_name)?, fetch_err)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:163:26 [INFO] [stdout] | [INFO] [stdout] 163 | .map(|t| t.unwrap().join().unwrap()) [INFO] [stdout] | - ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:193:12 [INFO] [stdout] | [INFO] [stdout] 183 | let fetch_err = if not_updated_yet { [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 184 | match self.fetch_crate(crate_name) { [INFO] [stdout] 185 | Ok(Some(c)) => return Ok((c, None)), [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 186 | Ok(None) => None, [INFO] [stdout] 187 | Err(e) => Some(e), [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 193 | Ok((self.index.crate_from_cache(crate_name)?, fetch_err)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:215:12 [INFO] [stdout] | [INFO] [stdout] 197 | let request = ureq::Request::try_from(self.index.make_cache_request(crate_name)?).unwrap(); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 198 | [INFO] [stdout] 199 | let response: Result, _> = loop { [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 200 | break match request.clone().call() { [INFO] [stdout] 201 | Ok(response) => Ok(response.into()), [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 202 | Err(e) => { [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 213 | let (parts, body) = response?.into_parts(); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 214 | let response = http::Response::from_parts(parts, body.into_bytes()); [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 215 | Ok(self.index.parse_cache_response(crate_name, response, true)?) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 10 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:215:12 [INFO] [stdout] | [INFO] [stdout] 197 | let request = ureq::Request::try_from(self.index.make_cache_request(crate_name)?).unwrap(); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 198 | [INFO] [stdout] 199 | let response: Result, _> = loop { [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 200 | break match request.clone().call() { [INFO] [stdout] 201 | Ok(response) => Ok(response.into()), [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 202 | Err(e) => { [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 213 | let (parts, body) = response?.into_parts(); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 214 | let response = http::Response::from_parts(parts, body.into_bytes()); [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 215 | Ok(self.index.parse_cache_response(crate_name, response, true)?) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 10 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `cargo-upgrades` (lib test) due to 11 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] error: could not compile `cargo-upgrades` (lib) due to 11 previous errors [INFO] running `Command { std: "docker" "inspect" "1ae7b7b616e558752f6b5267a76e1856205467d15555173421396c822b78b57d", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "1ae7b7b616e558752f6b5267a76e1856205467d15555173421396c822b78b57d", kill_on_drop: false }` [INFO] [stdout] 1ae7b7b616e558752f6b5267a76e1856205467d15555173421396c822b78b57d