[INFO] fetching crate cargo-tally 1.0.48... [INFO] checking cargo-tally-1.0.48 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate cargo-tally 1.0.48 into /workspace/builds/worker-5-tc2/source [INFO] validating manifest of crates.io crate cargo-tally 1.0.48 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate cargo-tally 1.0.48 [INFO] finished tweaking crates.io crate cargo-tally 1.0.48 [INFO] tweaked toml for crates.io crate cargo-tally 1.0.48 written to /workspace/builds/worker-5-tc2/source/Cargo.toml [INFO] crate crates.io crate cargo-tally 1.0.48 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] a485cde44ff74471bb394a76f423d5f31d2bd4d5937d90c548cf2590aff317f7 [INFO] running `Command { std: "docker" "start" "-a" "a485cde44ff74471bb394a76f423d5f31d2bd4d5937d90c548cf2590aff317f7", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "a485cde44ff74471bb394a76f423d5f31d2bd4d5937d90c548cf2590aff317f7", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "a485cde44ff74471bb394a76f423d5f31d2bd4d5937d90c548cf2590aff317f7", kill_on_drop: false }` [INFO] [stdout] a485cde44ff74471bb394a76f423d5f31d2bd4d5937d90c548cf2590aff317f7 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] ef9b40d18b2ebc3320a48c2316470f61823197390ab79c8cf8c3e4b9ba041f1a [INFO] running `Command { std: "docker" "start" "-a" "ef9b40d18b2ebc3320a48c2316470f61823197390ab79c8cf8c3e4b9ba041f1a", kill_on_drop: false }` [INFO] [stderr] Compiling serde v1.0.203 [INFO] [stderr] Checking memchr v2.7.4 [INFO] [stderr] Compiling syn v1.0.109 [INFO] [stderr] Compiling syn v2.0.68 [INFO] [stderr] Compiling unicode-xid v0.2.4 [INFO] [stderr] Compiling rustix v0.38.34 [INFO] [stderr] Compiling portable-atomic v1.6.0 [INFO] [stderr] Checking anstyle-parse v0.2.4 [INFO] [stderr] Checking crossbeam-channel v0.5.13 [INFO] [stderr] Checking columnation-master v0.1.0-dev.1 [INFO] [stderr] Checking futures-core v0.3.30 [INFO] [stderr] Checking colorchoice v1.0.1 [INFO] [stderr] Checking timely-bytes-master v0.13.0-dev.1 [INFO] [stderr] Checking abomonation v0.7.3 [INFO] [stderr] Checking anstyle v1.0.7 [INFO] [stderr] Checking is_terminal_polyfill v1.70.0 [INFO] [stderr] Compiling semver v1.0.23 [INFO] [stderr] Checking aho-corasick v1.1.3 [INFO] [stderr] Checking anstyle-query v1.1.0 [INFO] [stderr] Checking timely-logging-master v0.13.0-dev.1 [INFO] [stderr] Checking anstream v0.6.14 [INFO] [stderr] Checking csv-core v0.1.11 [INFO] [stderr] Checking console v0.15.8 [INFO] [stderr] Checking filetime v0.2.23 [INFO] [stderr] Checking number_prefix v0.4.0 [INFO] [stderr] Compiling thiserror v1.0.61 [INFO] [stderr] Checking clap_lex v0.7.1 [INFO] [stderr] Checking regex-automata v0.4.7 [INFO] [stderr] Checking strsim v0.11.1 [INFO] [stderr] Compiling ref-cast v1.0.23 [INFO] [stderr] Checking indicatif v0.17.8 [INFO] [stderr] Checking clap_builder v4.5.8 [INFO] [stderr] Checking memmap v0.7.0 [INFO] [stderr] Compiling cargo-tally v1.0.48 (/opt/rustwide/workdir) [INFO] [stderr] Checking sysinfo v0.30.12 [INFO] [stderr] Checking num_cpus v1.16.0 [INFO] [stderr] Checking typed-arena v2.0.2 [INFO] [stderr] Checking cargo-subcommand-metadata v0.1.0 [INFO] [stderr] Checking atomic-take v1.1.0 [INFO] [stderr] Checking xattr v1.3.1 [INFO] [stderr] Checking bytesize v1.3.0 [INFO] [stderr] Checking tar v0.4.41 [INFO] [stderr] Compiling synstructure v0.12.6 [INFO] [stderr] Compiling abomonation_derive v0.5.0 [INFO] [stderr] Checking clap v4.5.8 [INFO] [stderr] Compiling serde_derive v1.0.203 [INFO] [stderr] Compiling futures-macro v0.3.30 [INFO] [stderr] Compiling thiserror-impl v1.0.61 [INFO] [stderr] Compiling ref-cast-impl v1.0.23 [INFO] [stderr] Checking regex v1.10.5 [INFO] [stderr] Checking bstr v1.9.1 [INFO] [stderr] Checking minipre v0.2.0 [INFO] [stderr] Checking futures-util v0.3.30 [INFO] [stderr] Checking opener v0.7.1 [INFO] [stderr] Checking timely-communication-master v0.13.0-dev.1 [INFO] [stderr] Checking timely-container-master v0.13.0-dev.1 [INFO] [stderr] Checking csv v1.3.0 [INFO] [stderr] Checking serde_json v1.0.120 [INFO] [stderr] Checking timely-master v0.13.0-dev.1 [INFO] [stderr] Checking db-dump v0.7.4 [INFO] [stderr] Checking differential-dataflow-master v0.13.0-dev.1 [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:236:43 [INFO] [stdout] | [INFO] [stdout] 236 | releases.map(|rel| (rel.crate_id, (rel.id, rel.num))); [INFO] [stdout] | --- ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:236:43 [INFO] [stdout] | [INFO] [stdout] 236 | releases.map(|rel| (rel.crate_id, (rel.id, rel.num))); [INFO] [stdout] | --- ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:248:50 [INFO] [stdout] | [INFO] [stdout] 248 | .then(|| ((*crate_id, *req), (version.clone(), *version_id))) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:359:13 [INFO] [stdout] | [INFO] [stdout] 356 | let feature_intracrate_edges: dependency_edges = releases.explode(|rel| { [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 359 | / rel.features [INFO] [stdout] 360 | | .iter() [INFO] [stdout] 361 | | .flat_map(move |feature| { [INFO] [stdout] 362 | | let edge_from = VersionFeature { [INFO] [stdout] ... | [INFO] [stdout] 401 | | once((edge_from, edge_to)) [INFO] [stdout] 402 | | }) [INFO] [stdout] | |__________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:496:17 [INFO] [stdout] | [INFO] [stdout] 286 | let match_releases: match_releases = queries [INFO] [stdout] | -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 472 | let match_releases = match_releases [INFO] [stdout] | -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 484 | let variable = Variable::new_from(match_releases, summary); [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 485 | let result = variable [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 496 | variable.set(&result).leave() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/arena.rs:81:41 [INFO] [stdout] | [INFO] [stdout] 81 | .or_insert_with(|| Box::new(Arena::::new())); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/collect.rs:71:9 [INFO] [stdout] | [INFO] [stdout] 69 | fn into_iter(self) -> Self::IntoIter { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 70 | let mut out = self.out.lock().unwrap_or_else(PoisonError::into_inner); [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 71 | mem::take(&mut *out).into_iter() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/max.rs:31:42 [INFO] [stdout] | [INFO] [stdout] 31 | self.explode(|(key, value)| once((key, Max { value }))) [INFO] [stdout] | ------------ ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 7 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:248:50 [INFO] [stdout] | [INFO] [stdout] 248 | .then(|| ((*crate_id, *req), (version.clone(), *version_id))) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:359:13 [INFO] [stdout] | [INFO] [stdout] 356 | let feature_intracrate_edges: dependency_edges = releases.explode(|rel| { [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 359 | / rel.features [INFO] [stdout] 360 | | .iter() [INFO] [stdout] 361 | | .flat_map(move |feature| { [INFO] [stdout] 362 | | let edge_from = VersionFeature { [INFO] [stdout] ... | [INFO] [stdout] 401 | | once((edge_from, edge_to)) [INFO] [stdout] 402 | | }) [INFO] [stdout] | |__________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:496:17 [INFO] [stdout] | [INFO] [stdout] 286 | let match_releases: match_releases = queries [INFO] [stdout] | -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 472 | let match_releases = match_releases [INFO] [stdout] | -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 484 | let variable = Variable::new_from(match_releases, summary); [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 485 | let result = variable [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 496 | variable.set(&result).leave() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/arena.rs:81:41 [INFO] [stdout] | [INFO] [stdout] 81 | .or_insert_with(|| Box::new(Arena::::new())); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/collect.rs:71:9 [INFO] [stdout] | [INFO] [stdout] 69 | fn into_iter(self) -> Self::IntoIter { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 70 | let mut out = self.out.lock().unwrap_or_else(PoisonError::into_inner); [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 71 | mem::take(&mut *out).into_iter() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/max.rs:31:42 [INFO] [stdout] | [INFO] [stdout] 31 | self.explode(|(key, value)| once((key, Max { value }))) [INFO] [stdout] | ------------ ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 7 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `cargo-tally` (lib) due to 8 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] error: could not compile `cargo-tally` (lib test) due to 8 previous errors [INFO] running `Command { std: "docker" "inspect" "ef9b40d18b2ebc3320a48c2316470f61823197390ab79c8cf8c3e4b9ba041f1a", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "ef9b40d18b2ebc3320a48c2316470f61823197390ab79c8cf8c3e4b9ba041f1a", kill_on_drop: false }` [INFO] [stdout] ef9b40d18b2ebc3320a48c2316470f61823197390ab79c8cf8c3e4b9ba041f1a