[INFO] fetching crate cargo-supply-chain 0.3.3... [INFO] checking cargo-supply-chain-0.3.3 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate cargo-supply-chain 0.3.3 into /workspace/builds/worker-5-tc2/source [INFO] validating manifest of crates.io crate cargo-supply-chain 0.3.3 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate cargo-supply-chain 0.3.3 [INFO] finished tweaking crates.io crate cargo-supply-chain 0.3.3 [INFO] tweaked toml for crates.io crate cargo-supply-chain 0.3.3 written to /workspace/builds/worker-5-tc2/source/Cargo.toml [INFO] crate crates.io crate cargo-supply-chain 0.3.3 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 1b09dad5f76e3b4f3449ea36affd1d4775d6d2feed5a30160138d6d993619142 [INFO] running `Command { std: "docker" "start" "-a" "1b09dad5f76e3b4f3449ea36affd1d4775d6d2feed5a30160138d6d993619142", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "1b09dad5f76e3b4f3449ea36affd1d4775d6d2feed5a30160138d6d993619142", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "1b09dad5f76e3b4f3449ea36affd1d4775d6d2feed5a30160138d6d993619142", kill_on_drop: false }` [INFO] [stdout] 1b09dad5f76e3b4f3449ea36affd1d4775d6d2feed5a30160138d6d993619142 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 6d859ed61c3899baba4a4414883f67a66b62f2ec3111e2239b5e5447ff4d9beb [INFO] running `Command { std: "docker" "start" "-a" "6d859ed61c3899baba4a4414883f67a66b62f2ec3111e2239b5e5447ff4d9beb", kill_on_drop: false }` [INFO] [stderr] Compiling proc-macro2 v1.0.42 [INFO] [stderr] Compiling quote v1.0.20 [INFO] [stderr] Compiling unicode-ident v1.0.2 [INFO] [stderr] Compiling syn v1.0.98 [INFO] [stderr] Compiling libc v0.2.142 [INFO] [stderr] Compiling serde_derive v1.0.140 [INFO] [stderr] Compiling serde v1.0.140 [INFO] [stderr] Compiling cc v1.0.73 [INFO] [stderr] Checking once_cell v1.13.0 [INFO] [stderr] Checking spin v0.5.2 [INFO] [stderr] Checking untrusted v0.7.1 [INFO] [stderr] Checking ryu v1.0.10 [INFO] [stderr] Checking tinyvec_macros v0.1.0 [INFO] [stderr] Compiling memchr v2.5.0 [INFO] [stderr] Compiling serde_json v1.0.82 [INFO] [stderr] Checking itoa v1.0.2 [INFO] [stderr] Checking matches v0.1.9 [INFO] [stderr] Checking tinyvec v1.6.0 [INFO] [stderr] Compiling log v0.4.17 [INFO] [stderr] Compiling rustls v0.20.6 [INFO] [stderr] Compiling semver v1.0.12 [INFO] [stderr] Compiling camino v1.0.9 [INFO] [stderr] Checking base64 v0.13.0 [INFO] [stderr] Checking percent-encoding v2.1.0 [INFO] [stderr] Checking unicode-bidi v0.3.8 [INFO] [stderr] Checking regex-automata v0.1.10 [INFO] [stderr] Compiling anyhow v1.0.58 [INFO] [stderr] Checking lazy_static v1.4.0 [INFO] [stderr] Checking unicode-width v0.1.9 [INFO] [stderr] Checking miniz_oxide v0.5.3 [INFO] [stderr] Checking form_urlencoded v1.0.1 [INFO] [stderr] Checking number_prefix v0.4.0 [INFO] [stderr] Compiling schemars v0.8.10 [INFO] [stderr] Checking itoa v0.4.8 [INFO] [stderr] Checking chunked_transfer v1.4.0 [INFO] [stderr] Checking dyn-clone v1.0.8 [INFO] [stderr] Checking rustls-pemfile v1.0.0 [INFO] [stderr] Checking rustls-native-certs v0.6.2 [INFO] [stderr] Compiling ring v0.16.20 [INFO] [stderr] Checking csv-core v0.1.10 [INFO] [stderr] Checking flate2 v1.0.24 [INFO] [stderr] Checking unicode-normalization v0.1.21 [INFO] [stderr] Checking terminal_size v0.1.17 [INFO] [stderr] Checking dirs-sys-next v0.1.2 [INFO] [stderr] Checking filetime v0.2.17 [INFO] [stderr] Checking xattr v0.2.3 [INFO] [stderr] Checking console v0.15.1 [INFO] [stderr] Checking directories-next v2.0.0 [INFO] [stderr] Checking tar v0.4.38 [INFO] [stderr] Checking indicatif v0.17.0 [INFO] [stderr] Checking idna v0.2.3 [INFO] [stderr] Checking url v2.2.2 [INFO] [stderr] Checking webpki v0.22.0 [INFO] [stderr] Checking sct v0.7.0 [INFO] [stderr] Checking webpki-roots v0.22.4 [INFO] [stderr] Compiling serde_derive_internals v0.26.0 [INFO] [stderr] Compiling bpaf_derive v0.3.1 [INFO] [stderr] Compiling schemars_derive v0.8.10 [INFO] [stderr] Checking bpaf v0.7.0 [INFO] [stderr] Checking bstr v0.2.17 [INFO] [stderr] Checking cargo-platform v0.1.2 [INFO] [stderr] Checking humantime-serde v1.1.1 [INFO] [stderr] Checking csv v1.1.6 [INFO] [stderr] Checking ureq v2.5.0 [INFO] [stderr] Checking cargo_metadata v0.15.0 [INFO] [stderr] Checking cargo-supply-chain v0.3.3 (/opt/rustwide/workdir) [INFO] [stdout] warning: field `versions` is never read [INFO] [stdout] --> src/crates_cache.rs:21:5 [INFO] [stdout] | [INFO] [stdout] 14 | pub struct CratesCache { [INFO] [stdout] | ----------- field in this struct [INFO] [stdout] ... [INFO] [stdout] 21 | versions: Option>, [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: associated items `VERSIONS_FS` and `load_versions` are never used [INFO] [stdout] --> src/crates_cache.rs:98:11 [INFO] [stdout] | [INFO] [stdout] 92 | impl CratesCache { [INFO] [stdout] | ---------------- associated items in this implementation [INFO] [stdout] ... [INFO] [stdout] 98 | const VERSIONS_FS: &'static str = "versions.json"; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 370 | fn load_versions(&mut self) -> Option<&HashMap<(u64, String), Publisher>> { [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/common.rs:71:45 [INFO] [stdout] | [INFO] [stdout] 71 | .map(|package| (package.id.clone(), package.clone())) [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/crates_cache.rs:386:5 [INFO] [stdout] | [INFO] [stdout] 379 | from: impl io::Read, [INFO] [stdout] | ------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 380 | ) -> Result, csv::Error> { [INFO] [stdout] 381 | let mut reader = csv::ReaderBuilder::new() [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 386 | reader.deserialize().collect() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/crates_cache.rs:499:27 [INFO] [stdout] | [INFO] [stdout] 499 | .map(|entry| (key_fn(entry), entry.clone())) [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/crates_cache.rs:499:42 [INFO] [stdout] | [INFO] [stdout] 499 | .map(|entry| (key_fn(entry), entry.clone())) [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/publishers.rs:65:21 [INFO] [stdout] | [INFO] [stdout] 65 | #[derive(Serialize, Deserialize, Debug, Copy, Clone, Ord, PartialOrd, Eq, PartialEq)] [INFO] [stdout] | ^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: this error originates in the macro `try` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 5 previous errors; 2 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `cargo-supply-chain` (bin "cargo-supply-chain") due to 6 previous errors; 2 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] warning: field `versions` is never read [INFO] [stdout] --> src/crates_cache.rs:21:5 [INFO] [stdout] | [INFO] [stdout] 14 | pub struct CratesCache { [INFO] [stdout] | ----------- field in this struct [INFO] [stdout] ... [INFO] [stdout] 21 | versions: Option>, [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: associated items `VERSIONS_FS` and `load_versions` are never used [INFO] [stdout] --> src/crates_cache.rs:98:11 [INFO] [stdout] | [INFO] [stdout] 92 | impl CratesCache { [INFO] [stdout] | ---------------- associated items in this implementation [INFO] [stdout] ... [INFO] [stdout] 98 | const VERSIONS_FS: &'static str = "versions.json"; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 370 | fn load_versions(&mut self) -> Option<&HashMap<(u64, String), Publisher>> { [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/common.rs:11:25 [INFO] [stdout] | [INFO] [stdout] 11 | #[cfg_attr(test, derive(serde::Deserialize, serde::Serialize))] [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] = note: this error originates in the macro `try` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/common.rs:71:45 [INFO] [stdout] | [INFO] [stdout] 71 | .map(|package| (package.id.clone(), package.clone())) [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/common.rs:307:9 [INFO] [stdout] | [INFO] [stdout] 305 | fn sourced_dependencies_from_file(path: impl AsRef) -> Vec { [INFO] [stdout] | ---------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 306 | let contents = read_to_string(path).unwrap(); [INFO] [stdout] 307 | serde_json::from_str::>(&contents).unwrap() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/crates_cache.rs:386:5 [INFO] [stdout] | [INFO] [stdout] 379 | from: impl io::Read, [INFO] [stdout] | ------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 380 | ) -> Result, csv::Error> { [INFO] [stdout] 381 | let mut reader = csv::ReaderBuilder::new() [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 386 | reader.deserialize().collect() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/crates_cache.rs:499:27 [INFO] [stdout] | [INFO] [stdout] 499 | .map(|entry| (key_fn(entry), entry.clone())) [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/crates_cache.rs:499:42 [INFO] [stdout] | [INFO] [stdout] 499 | .map(|entry| (key_fn(entry), entry.clone())) [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/publishers.rs:65:21 [INFO] [stdout] | [INFO] [stdout] 65 | #[derive(Serialize, Deserialize, Debug, Copy, Clone, Ord, PartialOrd, Eq, PartialEq)] [INFO] [stdout] | ^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: this error originates in the macro `try` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 7 previous errors; 2 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `cargo-supply-chain` (bin "cargo-supply-chain" test) due to 8 previous errors; 2 warnings emitted [INFO] running `Command { std: "docker" "inspect" "6d859ed61c3899baba4a4414883f67a66b62f2ec3111e2239b5e5447ff4d9beb", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "6d859ed61c3899baba4a4414883f67a66b62f2ec3111e2239b5e5447ff4d9beb", kill_on_drop: false }` [INFO] [stdout] 6d859ed61c3899baba4a4414883f67a66b62f2ec3111e2239b5e5447ff4d9beb