[INFO] fetching crate cargo-sonar 1.2.0... [INFO] checking cargo-sonar-1.2.0 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate cargo-sonar 1.2.0 into /workspace/builds/worker-3-tc2/source [INFO] validating manifest of crates.io crate cargo-sonar 1.2.0 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] removed /workspace/builds/worker-3-tc2/source/.cargo/config.toml [INFO] removed /workspace/builds/worker-3-tc2/source/rust-toolchain.toml [INFO] started tweaking crates.io crate cargo-sonar 1.2.0 [INFO] finished tweaking crates.io crate cargo-sonar 1.2.0 [INFO] tweaked toml for crates.io crate cargo-sonar 1.2.0 written to /workspace/builds/worker-3-tc2/source/Cargo.toml [INFO] crate crates.io crate cargo-sonar 1.2.0 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 81e3b66129b8bc84e8b1778f3086057153d19d2a647358732e66989f6bf0fdfb [INFO] running `Command { std: "docker" "start" "-a" "81e3b66129b8bc84e8b1778f3086057153d19d2a647358732e66989f6bf0fdfb", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "81e3b66129b8bc84e8b1778f3086057153d19d2a647358732e66989f6bf0fdfb", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "81e3b66129b8bc84e8b1778f3086057153d19d2a647358732e66989f6bf0fdfb", kill_on_drop: false }` [INFO] [stdout] 81e3b66129b8bc84e8b1778f3086057153d19d2a647358732e66989f6bf0fdfb [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 30a89694019144b7cabd22d5a7b484d2256672a04ccc5c82e735c3eba1bdbacc [INFO] running `Command { std: "docker" "start" "-a" "30a89694019144b7cabd22d5a7b484d2256672a04ccc5c82e735c3eba1bdbacc", kill_on_drop: false }` [INFO] [stderr] Compiling proc-macro2 v1.0.66 [INFO] [stderr] Compiling unicode-ident v1.0.11 [INFO] [stderr] Compiling serde v1.0.188 [INFO] [stderr] Compiling libc v0.2.147 [INFO] [stderr] Checking regex-syntax v0.7.5 [INFO] [stderr] Compiling io-lifetimes v1.0.11 [INFO] [stderr] Compiling rustix v0.37.23 [INFO] [stderr] Checking anstyle v1.0.3 [INFO] [stderr] Checking linux-raw-sys v0.3.8 [INFO] [stderr] Checking tracing-core v0.1.31 [INFO] [stderr] Checking anstyle-parse v0.2.1 [INFO] [stderr] Compiling syn v1.0.109 [INFO] [stderr] Checking memchr v2.6.3 [INFO] [stderr] Compiling semver v1.0.18 [INFO] [stderr] Checking hashbrown v0.14.0 [INFO] [stderr] Checking sharded-slab v0.1.4 [INFO] [stderr] Checking winnow v0.5.15 [INFO] [stderr] Compiling thiserror v1.0.48 [INFO] [stderr] Checking clap_lex v0.5.1 [INFO] [stderr] Checking anstream v0.5.0 [INFO] [stderr] Checking tracing-log v0.1.3 [INFO] [stderr] Checking smallvec v1.11.0 [INFO] [stderr] Compiling eyre v0.6.8 [INFO] [stderr] Checking gimli v0.28.0 [INFO] [stderr] Compiling serde_json v1.0.106 [INFO] [stderr] Compiling camino v1.1.6 [INFO] [stderr] Checking miniz_oxide v0.7.1 [INFO] [stderr] Checking rustc-demangle v0.1.23 [INFO] [stderr] Checking indenter v0.3.3 [INFO] [stderr] Checking owo-colors v3.5.0 [INFO] [stderr] Checking indexmap v2.0.0 [INFO] [stderr] Checking fs-err v2.9.0 [INFO] [stderr] Checking predicates-core v1.0.6 [INFO] [stderr] Checking dyn-iter v1.0.1 [INFO] [stderr] Checking either v1.9.0 [INFO] [stderr] Compiling rustix v0.38.13 [INFO] [stderr] Compiling quote v1.0.33 [INFO] [stderr] Compiling doc-comment v0.3.3 [INFO] [stderr] Checking termtree v0.4.1 [INFO] [stderr] Checking itertools v0.10.5 [INFO] [stderr] Checking object v0.32.1 [INFO] [stderr] Checking difflib v0.4.0 [INFO] [stderr] Compiling cc v1.0.83 [INFO] [stderr] Compiling syn v2.0.32 [INFO] [stderr] Checking bitflags v2.4.0 [INFO] [stderr] Checking linux-raw-sys v0.4.7 [INFO] [stderr] Checking predicates-tree v1.0.9 [INFO] [stderr] Checking fastrand v2.0.0 [INFO] [stderr] Checking wait-timeout v0.2.0 [INFO] [stderr] Checking regex-automata v0.3.8 [INFO] [stderr] Compiling backtrace v0.3.69 [INFO] [stderr] Checking predicates v3.0.3 [INFO] [stderr] Checking addr2line v0.21.0 [INFO] [stderr] Checking terminal_size v0.2.6 [INFO] [stderr] Checking clap_builder v4.4.2 [INFO] [stderr] Checking tempfile v3.8.0 [INFO] [stderr] Checking regex v1.9.5 [INFO] [stderr] Checking bstr v1.6.2 [INFO] [stderr] Compiling serde_derive v1.0.188 [INFO] [stderr] Compiling tracing-attributes v0.1.26 [INFO] [stderr] Compiling thiserror-impl v1.0.48 [INFO] [stderr] Compiling clap_derive v4.4.2 [INFO] [stderr] Checking assert_cmd v2.0.12 [INFO] [stderr] Checking tracing v0.1.37 [INFO] [stderr] Checking tracing-subscriber v0.3.17 [INFO] [stderr] Checking skip_error v3.1.1 [INFO] [stderr] Compiling strum_macros v0.24.3 [INFO] [stderr] Compiling test-log v0.2.12 [INFO] [stderr] Checking clap v4.4.3 [INFO] [stderr] Checking clap_complete v4.4.4 [INFO] [stderr] Checking tracing-error v0.2.0 [INFO] [stderr] Checking clap_complete_nushell v4.4.2 [INFO] [stderr] Checking color-spantrace v0.2.0 [INFO] [stderr] Checking strum v0.24.1 [INFO] [stderr] Checking color-eyre v0.6.2 [INFO] [stderr] Checking serde_spanned v0.6.3 [INFO] [stderr] Checking toml_datetime v0.6.3 [INFO] [stderr] Checking url v2.4.1 [INFO] [stderr] Checking cargo-platform v0.1.3 [INFO] [stderr] Checking cvss v2.0.0 [INFO] [stderr] Checking platforms v3.1.2 [INFO] [stderr] Checking toml_edit v0.19.15 [INFO] [stderr] Checking cargo_metadata v0.15.4 [INFO] [stderr] Checking toml v0.7.8 [INFO] [stderr] Checking cargo-lock v9.0.0 [INFO] [stderr] Checking rustsec v0.27.0 [INFO] [stderr] Checking cargo-sonar v1.2.0 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:317:12 [INFO] [stdout] | [INFO] [stdout] 283 | let mut issues: Box>> = Box::new(std::iter::empty()); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 317 | Ok(F::from_issues(issues)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/deny.rs:79:40 [INFO] [stdout] | [INFO] [stdout] 79 | .filter_map(move |s| match serde_json::from_str::(&s) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/codeclimate.rs:118:14 [INFO] [stdout] | [INFO] [stdout] 117 | fn from_iter>(issues: T) -> Self { [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 118 | Self(issues.into_iter().collect()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/codeclimate.rs:129:9 [INFO] [stdout] | [INFO] [stdout] 128 | fn from_issues(issues: impl IntoIterator>) -> Self::Report { [INFO] [stdout] | ------------------------------------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 129 | / issues [INFO] [stdout] 130 | | .into_iter() [INFO] [stdout] 131 | | .filter_map(|issue| { [INFO] [stdout] 132 | | issue.location().map(|location| Issue { [INFO] [stdout] ... | [INFO] [stdout] 138 | | }) [INFO] [stdout] 139 | | }) [INFO] [stdout] | |______________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/sonar.rs:188:20 [INFO] [stdout] | [INFO] [stdout] 157 | fn from_issues(issues: impl IntoIterator>) -> Self::Report { [INFO] [stdout] | ------------------------------------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 188 | rules: rules.into_values().collect(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 5 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `cargo-sonar` (lib) due to 6 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:317:12 [INFO] [stdout] | [INFO] [stdout] 283 | let mut issues: Box>> = Box::new(std::iter::empty()); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 317 | Ok(F::from_issues(issues)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/deny.rs:79:40 [INFO] [stdout] | [INFO] [stdout] 79 | .filter_map(move |s| match serde_json::from_str::(&s) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/codeclimate.rs:118:14 [INFO] [stdout] | [INFO] [stdout] 117 | fn from_iter>(issues: T) -> Self { [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 118 | Self(issues.into_iter().collect()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/codeclimate.rs:129:9 [INFO] [stdout] | [INFO] [stdout] 128 | fn from_issues(issues: impl IntoIterator>) -> Self::Report { [INFO] [stdout] | ------------------------------------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 129 | / issues [INFO] [stdout] 130 | | .into_iter() [INFO] [stdout] 131 | | .filter_map(|issue| { [INFO] [stdout] 132 | | issue.location().map(|location| Issue { [INFO] [stdout] ... | [INFO] [stdout] 138 | | }) [INFO] [stdout] 139 | | }) [INFO] [stdout] | |______________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/sonar.rs:188:20 [INFO] [stdout] | [INFO] [stdout] 157 | fn from_issues(issues: impl IntoIterator>) -> Self::Report { [INFO] [stdout] | ------------------------------------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 188 | rules: rules.into_values().collect(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 5 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `cargo-sonar` (lib test) due to 6 previous errors [INFO] running `Command { std: "docker" "inspect" "30a89694019144b7cabd22d5a7b484d2256672a04ccc5c82e735c3eba1bdbacc", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "30a89694019144b7cabd22d5a7b484d2256672a04ccc5c82e735c3eba1bdbacc", kill_on_drop: false }` [INFO] [stdout] 30a89694019144b7cabd22d5a7b484d2256672a04ccc5c82e735c3eba1bdbacc