[INFO] fetching crate cargo-public-api 0.37.0... [INFO] checking cargo-public-api-0.37.0 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate cargo-public-api 0.37.0 into /workspace/builds/worker-0-tc2/source [INFO] validating manifest of crates.io crate cargo-public-api 0.37.0 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate cargo-public-api 0.37.0 [INFO] finished tweaking crates.io crate cargo-public-api 0.37.0 [INFO] tweaked toml for crates.io crate cargo-public-api 0.37.0 written to /workspace/builds/worker-0-tc2/source/Cargo.toml [INFO] crate crates.io crate cargo-public-api 0.37.0 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] ed1db8deedd322f480445b1df79453d957390ef0c61bee400625df640c266d42 [INFO] running `Command { std: "docker" "start" "-a" "ed1db8deedd322f480445b1df79453d957390ef0c61bee400625df640c266d42", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "ed1db8deedd322f480445b1df79453d957390ef0c61bee400625df640c266d42", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "ed1db8deedd322f480445b1df79453d957390ef0c61bee400625df640c266d42", kill_on_drop: false }` [INFO] [stdout] ed1db8deedd322f480445b1df79453d957390ef0c61bee400625df640c266d42 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 0e19c7dd96354427736a18cced350bf1fba2b3b29fb6390603fd4634541b4ebb [INFO] running `Command { std: "docker" "start" "-a" "0e19c7dd96354427736a18cced350bf1fba2b3b29fb6390603fd4634541b4ebb", kill_on_drop: false }` [INFO] [stderr] Compiling proc-macro2 v1.0.76 [INFO] [stderr] Compiling unicode-ident v1.0.8 [INFO] [stderr] Compiling serde v1.0.179 [INFO] [stderr] Compiling serde_derive v1.0.179 [INFO] [stderr] Compiling cc v1.0.79 [INFO] [stderr] Compiling rustix v0.38.31 [INFO] [stderr] Compiling pkg-config v0.3.27 [INFO] [stderr] Checking bitflags v2.4.1 [INFO] [stderr] Checking linux-raw-sys v0.4.12 [INFO] [stderr] Checking once_cell v1.17.1 [INFO] [stderr] Checking anstyle v1.0.0 [INFO] [stderr] Compiling typenum v1.16.0 [INFO] [stderr] Compiling generic-array v0.14.7 [INFO] [stderr] Checking anstyle-parse v0.2.0 [INFO] [stderr] Compiling thiserror v1.0.56 [INFO] [stderr] Checking clap_lex v0.7.0 [INFO] [stderr] Checking strsim v0.11.0 [INFO] [stderr] Checking equivalent v1.0.0 [INFO] [stderr] Compiling serde_json v1.0.104 [INFO] [stderr] Checking hashbrown v0.14.0 [INFO] [stderr] Checking anstream v0.6.11 [INFO] [stderr] Checking ryu v1.0.13 [INFO] [stderr] Compiling camino v1.1.4 [INFO] [stderr] Checking tracing-core v0.1.32 [INFO] [stderr] Compiling semver v1.0.18 [INFO] [stderr] Checking itoa v1.0.6 [INFO] [stderr] Checking winnow v0.6.5 [INFO] [stderr] Compiling memchr v2.5.0 [INFO] [stderr] Compiling anyhow v1.0.75 [INFO] [stderr] Checking regex-syntax v0.7.5 [INFO] [stderr] Compiling num-traits v0.2.15 [INFO] [stderr] Compiling doc-comment v0.3.3 [INFO] [stderr] Checking predicates-core v1.0.6 [INFO] [stderr] Checking cpufeatures v0.2.7 [INFO] [stderr] Checking log v0.4.21 [INFO] [stderr] Checking nix v0.26.2 [INFO] [stderr] Checking walkdir v2.4.0 [INFO] [stderr] Checking thread_local v1.1.8 [INFO] [stderr] Checking dirs-sys v0.4.0 [INFO] [stderr] Checking socket2 v0.5.5 [INFO] [stderr] Checking indexmap v2.0.0 [INFO] [stderr] Checking filetime v0.2.22 [INFO] [stderr] Checking tracing-log v0.2.0 [INFO] [stderr] Compiling quote v1.0.35 [INFO] [stderr] Checking jobserver v0.1.27 [INFO] [stderr] Checking cvt v0.1.2 [INFO] [stderr] Checking difflib v0.4.0 [INFO] [stderr] Checking hashbag v0.1.12 [INFO] [stderr] Compiling assert_cmd v2.0.14 [INFO] [stderr] Compiling syn v2.0.48 [INFO] [stderr] Checking termtree v0.4.1 [INFO] [stderr] Checking shell-escape v0.1.5 [INFO] [stderr] Checking dirs v5.0.0 [INFO] [stderr] Checking predicates v3.1.0 [INFO] [stderr] Checking wait-timeout v0.2.0 [INFO] [stderr] Checking bstr v1.4.0 [INFO] [stderr] Checking normpath v1.1.1 [INFO] [stderr] Checking diff v0.1.13 [INFO] [stderr] Checking predicates-tree v1.0.9 [INFO] [stderr] Checking dissimilar v1.0.6 [INFO] [stderr] Compiling openssl-sys v0.9.88 [INFO] [stderr] Compiling libz-sys v1.1.9 [INFO] [stderr] Compiling curl-sys v0.4.72+curl-8.6.0 [INFO] [stderr] Checking rustc-hash v2.0.0 [INFO] [stderr] Checking nu-ansi-term v0.50.0 [INFO] [stderr] Checking regex-automata v0.3.7 [INFO] [stderr] Checking expect-test v1.5.0 [INFO] [stderr] Checking fs_at v0.1.8 [INFO] [stderr] Checking remove_dir_all v0.8.2 [INFO] [stderr] Checking chrono v0.4.38 [INFO] [stderr] Compiling curl v0.4.46 [INFO] [stderr] Checking crypto-common v0.1.6 [INFO] [stderr] Checking block-buffer v0.10.4 [INFO] [stderr] Checking digest v0.10.7 [INFO] [stderr] Checking terminal_size v0.3.0 [INFO] [stderr] Checking tempfile v3.10.1 [INFO] [stderr] Checking clap_builder v4.5.0 [INFO] [stderr] Checking sha2 v0.10.8 [INFO] [stderr] Checking regex v1.9.4 [INFO] [stderr] Checking toml_datetime v0.6.6 [INFO] [stderr] Checking serde_spanned v0.6.6 [INFO] [stderr] Checking cargo-platform v0.1.2 [INFO] [stderr] Checking rustdoc-types v0.27.0 [INFO] [stderr] Checking hex v0.4.3 [INFO] [stderr] Checking smol_str v0.2.2 [INFO] [stderr] Checking toml_edit v0.22.16 [INFO] [stderr] Compiling thiserror-impl v1.0.56 [INFO] [stderr] Compiling clap_derive v4.5.0 [INFO] [stderr] Compiling tracing-attributes v0.1.27 [INFO] [stderr] Checking toml v0.8.15 [INFO] [stderr] Checking cargo-manifest v0.15.0 [INFO] [stderr] Checking cargo_metadata v0.18.1 [INFO] [stderr] Checking public-api v0.37.0 [INFO] [stderr] Checking rustup-toolchain v0.1.7 [INFO] [stderr] Checking tracing v0.1.40 [INFO] [stderr] Checking cargo-util v0.2.8 [INFO] [stderr] Checking tracing-subscriber v0.3.18 [INFO] [stderr] Checking clap v4.5.0 [INFO] [stderr] Checking clap_complete v4.2.0 [INFO] [stderr] Checking clap_complete_fig v4.2.0 [INFO] [stderr] Checking clap_complete_nushell v0.1.10 [INFO] [stderr] Checking clap_complete_command v0.5.1 [INFO] [stderr] Checking rustdoc-json v0.9.2 [INFO] [stderr] Checking cargo-public-api v0.37.0 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> tests/cargo-public-api-bin-tests.rs:1282:5 [INFO] [stdout] | [INFO] [stdout] 1281 | fn rustdoc_json_path_for_crate(test_crate: &str, target_dir: impl AsRef) -> PathBuf { [INFO] [stdout] | ---------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 1282 | / rustdoc_json_builder_for_crate(test_crate, target_dir) [INFO] [stdout] 1283 | | .build() [INFO] [stdout] | |________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> tests/cargo-public-api-bin-tests.rs:1479:24 [INFO] [stdout] | [INFO] [stdout] 1466 | let mut cmd: Command = cmd_type.into(); [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 1479 | test_repo: None, [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> tests/cargo-public-api-bin-tests.rs:1480:25 [INFO] [stdout] | [INFO] [stdout] 1466 | let mut cmd: Command = cmd_type.into(); [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 1480 | target_dir: None, [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> tests/../src/git_utils.rs:46:9 [INFO] [stdout] | [INFO] [stdout] 46 | Err(err_fn()) [INFO] [stdout] | ^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 4 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `cargo-public-api` (test "cargo-public-api-bin-tests") due to 5 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/git_utils.rs:46:9 [INFO] [stdout] | [INFO] [stdout] 46 | Err(err_fn()) [INFO] [stdout] | ^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/published_crate.rs:167:5 [INFO] [stdout] | [INFO] [stdout] 150 | let mut curl = curl::easy::Easy::new(); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 154 | let mut list = curl::easy::List::new(); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 167 | Crate::from_slice(&body).with_context(|| anyhow!("Could not find crate `{name}`")) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/vendor/crates_index.rs:243:29 [INFO] [stdout] | [INFO] [stdout] 243 | .max_by_key(|v| semver::Version::parse(&v.vers).ok()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/vendor/crates_index.rs:303:12 [INFO] [stdout] | [INFO] [stdout] 280 | let mut versions = Vec::with_capacity(num_versions); [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 303 | Ok(Crate { [INFO] [stdout] | ____________^ [INFO] [stdout] 304 | | versions: versions.into_boxed_slice(), [INFO] [stdout] 305 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 4 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `cargo-public-api` (bin "cargo-public-api") due to 5 previous errors [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/git_utils.rs:46:9 [INFO] [stdout] | [INFO] [stdout] 46 | Err(err_fn()) [INFO] [stdout] | ^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/published_crate.rs:167:5 [INFO] [stdout] | [INFO] [stdout] 150 | let mut curl = curl::easy::Easy::new(); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 154 | let mut list = curl::easy::List::new(); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 167 | Crate::from_slice(&body).with_context(|| anyhow!("Could not find crate `{name}`")) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/vendor/crates_index.rs:243:29 [INFO] [stdout] | [INFO] [stdout] 243 | .max_by_key(|v| semver::Version::parse(&v.vers).ok()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/vendor/crates_index.rs:303:12 [INFO] [stdout] | [INFO] [stdout] 280 | let mut versions = Vec::with_capacity(num_versions); [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 303 | Ok(Crate { [INFO] [stdout] | ____________^ [INFO] [stdout] 304 | | versions: versions.into_boxed_slice(), [INFO] [stdout] 305 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 4 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `cargo-public-api` (bin "cargo-public-api" test) due to 5 previous errors [INFO] running `Command { std: "docker" "inspect" "0e19c7dd96354427736a18cced350bf1fba2b3b29fb6390603fd4634541b4ebb", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "0e19c7dd96354427736a18cced350bf1fba2b3b29fb6390603fd4634541b4ebb", kill_on_drop: false }` [INFO] [stdout] 0e19c7dd96354427736a18cced350bf1fba2b3b29fb6390603fd4634541b4ebb