[INFO] fetching crate cargo-pgrx 0.12.1... [INFO] checking cargo-pgrx-0.12.1 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate cargo-pgrx 0.12.1 into /workspace/builds/worker-5-tc2/source [INFO] validating manifest of crates.io crate cargo-pgrx 0.12.1 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate cargo-pgrx 0.12.1 [INFO] finished tweaking crates.io crate cargo-pgrx 0.12.1 [INFO] tweaked toml for crates.io crate cargo-pgrx 0.12.1 written to /workspace/builds/worker-5-tc2/source/Cargo.toml [INFO] crate crates.io crate cargo-pgrx 0.12.1 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 6b765796845f95576019adf7656bf96031cd7705b38df8f66a2c53e8fbb61e3e [INFO] running `Command { std: "docker" "start" "-a" "6b765796845f95576019adf7656bf96031cd7705b38df8f66a2c53e8fbb61e3e", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "6b765796845f95576019adf7656bf96031cd7705b38df8f66a2c53e8fbb61e3e", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "6b765796845f95576019adf7656bf96031cd7705b38df8f66a2c53e8fbb61e3e", kill_on_drop: false }` [INFO] [stdout] 6b765796845f95576019adf7656bf96031cd7705b38df8f66a2c53e8fbb61e3e [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 16937e24c63e51c5f3b874d6e947ccea7547f0dce3d83b2acb1387dd4d6d2941 [INFO] running `Command { std: "docker" "start" "-a" "16937e24c63e51c5f3b874d6e947ccea7547f0dce3d83b2acb1387dd4d6d2941", kill_on_drop: false }` [INFO] [stderr] Compiling libc v0.2.155 [INFO] [stderr] Compiling proc-macro2 v1.0.83 [INFO] [stderr] Compiling serde v1.0.202 [INFO] [stderr] Compiling pkg-config v0.3.29 [INFO] [stderr] Checking log v0.4.20 [INFO] [stderr] Checking memchr v2.7.1 [INFO] [stderr] Compiling rustix v0.38.30 [INFO] [stderr] Checking hashbrown v0.14.3 [INFO] [stderr] Checking linux-raw-sys v0.4.13 [INFO] [stderr] Checking bitflags v2.4.2 [INFO] [stderr] Checking tinyvec v1.6.0 [INFO] [stderr] Compiling serde_json v1.0.117 [INFO] [stderr] Compiling thiserror v1.0.56 [INFO] [stderr] Compiling crossbeam-utils v0.8.19 [INFO] [stderr] Compiling semver v1.0.21 [INFO] [stderr] Checking regex-syntax v0.8.2 [INFO] [stderr] Checking anstyle-parse v0.2.3 [INFO] [stderr] Checking tracing-core v0.1.32 [INFO] [stderr] Checking anstyle v1.0.4 [INFO] [stderr] Checking regex-syntax v0.6.29 [INFO] [stderr] Compiling camino v1.1.6 [INFO] [stderr] Checking anstyle-query v1.0.2 [INFO] [stderr] Checking miniz_oxide v0.7.1 [INFO] [stderr] Checking anstream v0.6.11 [INFO] [stderr] Checking clap_lex v0.6.0 [INFO] [stderr] Compiling rayon-core v1.12.1 [INFO] [stderr] Compiling eyre v0.6.12 [INFO] [stderr] Compiling anyhow v1.0.79 [INFO] [stderr] Checking pin-project-lite v0.2.13 [INFO] [stderr] Checking indexmap v2.1.0 [INFO] [stderr] Compiling crc32fast v1.3.2 [INFO] [stderr] Checking crossbeam-epoch v0.9.18 [INFO] [stderr] Checking overload v0.1.1 [INFO] [stderr] Checking aho-corasick v1.1.2 [INFO] [stderr] Checking sharded-slab v0.1.7 [INFO] [stderr] Checking unicode-normalization v0.1.22 [INFO] [stderr] Checking nu-ansi-term v0.46.0 [INFO] [stderr] Checking crossbeam-deque v0.8.5 [INFO] [stderr] Checking tracing-log v0.2.0 [INFO] [stderr] Checking thread_local v1.1.7 [INFO] [stderr] Compiling quote v1.0.36 [INFO] [stderr] Checking winnow v0.6.5 [INFO] [stderr] Checking unicode-ident v1.0.12 [INFO] [stderr] Compiling rustls v0.21.10 [INFO] [stderr] Checking smallvec v1.13.1 [INFO] [stderr] Checking indenter v0.3.3 [INFO] [stderr] Checking winnow v0.5.40 [INFO] [stderr] Compiling jobserver v0.1.31 [INFO] [stderr] Compiling syn v2.0.65 [INFO] [stderr] Checking getrandom v0.2.12 [INFO] [stderr] Checking is-terminal v0.4.12 [INFO] [stderr] Compiling cc v1.0.83 [INFO] [stderr] Compiling indexmap v1.9.3 [INFO] [stderr] Checking gimli v0.28.1 [INFO] [stderr] Checking either v1.9.0 [INFO] [stderr] Checking byteorder v1.5.0 [INFO] [stderr] Checking is_ci v1.1.1 [INFO] [stderr] Checking flate2 v1.0.28 [INFO] [stderr] Checking supports-color v2.1.0 [INFO] [stderr] Checking atty v0.2.14 [INFO] [stderr] Checking socks v0.3.4 [INFO] [stderr] Checking object v0.32.2 [INFO] [stderr] Checking webpki-roots v0.25.3 [INFO] [stderr] Checking rayon v1.8.1 [INFO] [stderr] Checking fixedbitset v0.4.2 [INFO] [stderr] Checking regex-automata v0.1.10 [INFO] [stderr] Checking idna v0.5.0 [INFO] [stderr] Checking concolor-query v0.0.4 [INFO] [stderr] Checking hashbrown v0.12.3 [INFO] [stderr] Checking rustc-demangle v0.1.23 [INFO] [stderr] Checking regex-automata v0.4.5 [INFO] [stderr] Checking owo-colors v3.5.0 [INFO] [stderr] Checking unicode-segmentation v1.10.1 [INFO] [stderr] Checking concolor-control v0.0.7 [INFO] [stderr] Checking petgraph v0.6.4 [INFO] [stderr] Checking matchers v0.1.0 [INFO] [stderr] Checking terminal_size v0.3.0 [INFO] [stderr] Checking convert_case v0.6.0 [INFO] [stderr] Checking xattr v1.3.1 [INFO] [stderr] Checking clap_builder v4.4.18 [INFO] [stderr] Checking owo-colors v4.0.0 [INFO] [stderr] Checking pathsearch v0.2.0 [INFO] [stderr] Checking filetime v0.2.23 [INFO] [stderr] Checking subprocess v0.2.9 [INFO] [stderr] Checking unescape v0.1.0 [INFO] [stderr] Checking xml-rs v0.8.19 [INFO] [stderr] Checking url v2.5.0 [INFO] [stderr] Checking fastrand v2.0.1 [INFO] [stderr] Compiling openssl-sys v0.9.99 [INFO] [stderr] Compiling libz-sys v1.1.16 [INFO] [stderr] Compiling ring v0.17.7 [INFO] [stderr] Compiling libssh2-sys v0.3.0 [INFO] [stderr] Compiling libgit2-sys v0.15.2+1.6.4 [INFO] [stderr] Compiling bzip2-sys v0.1.11+1.0.8 [INFO] [stderr] Compiling backtrace v0.3.69 [INFO] [stderr] Checking env_proxy v0.4.1 [INFO] [stderr] Checking dunce v1.0.4 [INFO] [stderr] Compiling cargo-pgrx v0.12.1 (/opt/rustwide/workdir) [INFO] [stderr] Checking termcolor v1.4.1 [INFO] [stderr] Checking scopeguard v1.2.0 [INFO] [stderr] Checking pathdiff v0.2.1 [INFO] [stderr] Checking tempfile v3.9.0 [INFO] [stderr] Checking regex v1.10.3 [INFO] [stderr] Checking jobslot v0.2.14 [INFO] [stderr] Checking tar v0.4.40 [INFO] [stderr] Checking addr2line v0.21.0 [INFO] [stderr] Checking bzip2 v0.4.4 [INFO] [stderr] Compiling serde_derive v1.0.202 [INFO] [stderr] Compiling thiserror-impl v1.0.56 [INFO] [stderr] Compiling tracing-attributes v0.1.27 [INFO] [stderr] Compiling clap_derive v4.4.7 [INFO] [stderr] Checking tracing v0.1.40 [INFO] [stderr] Checking pgrx-sql-entity-graph v0.12.1 [INFO] [stderr] Checking tracing-subscriber v0.3.18 [INFO] [stderr] Checking rustls-webpki v0.101.7 [INFO] [stderr] Checking sct v0.7.1 [INFO] [stderr] Checking clap v4.4.18 [INFO] [stderr] Checking clap-cargo v0.12.0 [INFO] [stderr] Checking tracing-error v0.2.0 [INFO] [stderr] Checking color-spantrace v0.2.1 [INFO] [stderr] Checking color-eyre v0.6.2 [INFO] [stderr] Checking git2 v0.17.2 [INFO] [stderr] Checking serde_spanned v0.6.5 [INFO] [stderr] Checking toml_datetime v0.6.5 [INFO] [stderr] Checking cargo-platform v0.1.6 [INFO] [stderr] Checking hex v0.4.3 [INFO] [stderr] Checking smol_str v0.2.1 [INFO] [stderr] Checking serde-xml-rs v0.6.0 [INFO] [stderr] Checking toml_edit v0.19.15 [INFO] [stderr] Checking toml_edit v0.22.12 [INFO] [stderr] Checking cargo_metadata v0.15.4 [INFO] [stderr] Checking cargo_metadata v0.18.1 [INFO] [stderr] Checking ureq v2.8.0 [INFO] [stderr] Checking toml v0.8.10 [INFO] [stderr] Checking cargo_toml v0.19.1 [INFO] [stderr] Checking toml v0.7.8 [INFO] [stderr] Checking clap-cargo v0.14.0 [INFO] [stderr] Checking crates-index v0.19.13 [INFO] [stderr] Checking cargo-edit v0.12.2 [INFO] [stderr] Checking pgrx-pg-config v0.12.1 [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/command/schema.rs:304:8 [INFO] [stdout] | [INFO] [stdout] 236 | let mut fns_to_call = HashSet::new(); [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 304 | Ok(fns_to_call.into_iter().collect()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/manifest.rs:208:8 [INFO] [stdout] | [INFO] [stdout] 200 | manifest_path: Option>, [INFO] [stdout] | -------------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 201 | ) -> eyre::Result<(Manifest, PathBuf)> { [INFO] [stdout] 202 | let metadata = crate::metadata::metadata(features, manifest_path.as_ref()) [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 208 | Ok(( [INFO] [stdout] | ________^ [INFO] [stdout] 209 | | Manifest::from_path(&package_manifest_path).wrap_err("Couldn't parse manifest")?, [INFO] [stdout] 210 | | package_manifest_path, [INFO] [stdout] 211 | | )) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 2 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/command/schema.rs:304:8 [INFO] [stdout] | [INFO] [stdout] 236 | let mut fns_to_call = HashSet::new(); [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 304 | Ok(fns_to_call.into_iter().collect()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `cargo-pgrx` (bin "cargo-pgrx") due to 3 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/manifest.rs:208:8 [INFO] [stdout] | [INFO] [stdout] 200 | manifest_path: Option>, [INFO] [stdout] | -------------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 201 | ) -> eyre::Result<(Manifest, PathBuf)> { [INFO] [stdout] 202 | let metadata = crate::metadata::metadata(features, manifest_path.as_ref()) [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 208 | Ok(( [INFO] [stdout] | ________^ [INFO] [stdout] 209 | | Manifest::from_path(&package_manifest_path).wrap_err("Couldn't parse manifest")?, [INFO] [stdout] 210 | | package_manifest_path, [INFO] [stdout] 211 | | )) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 2 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `cargo-pgrx` (bin "cargo-pgrx" test) due to 3 previous errors [INFO] running `Command { std: "docker" "inspect" "16937e24c63e51c5f3b874d6e947ccea7547f0dce3d83b2acb1387dd4d6d2941", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "16937e24c63e51c5f3b874d6e947ccea7547f0dce3d83b2acb1387dd4d6d2941", kill_on_drop: false }` [INFO] [stdout] 16937e24c63e51c5f3b874d6e947ccea7547f0dce3d83b2acb1387dd4d6d2941