[INFO] fetching crate cargo-modules 0.17.0... [INFO] checking cargo-modules-0.17.0 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate cargo-modules 0.17.0 into /workspace/builds/worker-2-tc2/source [INFO] validating manifest of crates.io crate cargo-modules 0.17.0 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate cargo-modules 0.17.0 [INFO] removed 0 missing tests [INFO] finished tweaking crates.io crate cargo-modules 0.17.0 [INFO] tweaked toml for crates.io crate cargo-modules 0.17.0 written to /workspace/builds/worker-2-tc2/source/Cargo.toml [INFO] crate crates.io crate cargo-modules 0.17.0 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] b8de6fbdd22946ee11ef5190641a13fe74c53082260d29a9738d959742ad0507 [INFO] running `Command { std: "docker" "start" "-a" "b8de6fbdd22946ee11ef5190641a13fe74c53082260d29a9738d959742ad0507", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "b8de6fbdd22946ee11ef5190641a13fe74c53082260d29a9738d959742ad0507", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "b8de6fbdd22946ee11ef5190641a13fe74c53082260d29a9738d959742ad0507", kill_on_drop: false }` [INFO] [stdout] b8de6fbdd22946ee11ef5190641a13fe74c53082260d29a9738d959742ad0507 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 8c4f7c4b5e8d161a475c4bda5c1af70e06dc5ec54ddd03ae565e2eaf0f321a26 [INFO] running `Command { std: "docker" "start" "-a" "8c4f7c4b5e8d161a475c4bda5c1af70e06dc5ec54ddd03ae565e2eaf0f321a26", kill_on_drop: false }` [INFO] [stderr] Compiling proc-macro2 v1.0.78 [INFO] [stderr] Compiling serde v1.0.197 [INFO] [stderr] Checking pin-project-lite v0.2.13 [INFO] [stderr] Checking hashbrown v0.14.3 [INFO] [stderr] Compiling crossbeam-utils v0.8.19 [INFO] [stderr] Checking smallvec v1.13.1 [INFO] [stderr] Checking either v1.10.0 [INFO] [stderr] Checking rustc-hash v1.1.0 [INFO] [stderr] Checking scopeguard v1.2.0 [INFO] [stderr] Compiling camino v1.1.6 [INFO] [stderr] Checking lock_api v0.4.11 [INFO] [stderr] Checking itertools v0.12.1 [INFO] [stderr] Checking parking_lot_core v0.9.9 [INFO] [stderr] Checking stable_deref_trait v1.2.0 [INFO] [stderr] Checking text-size v1.1.1 [INFO] [stderr] Checking unicode-xid v0.2.4 [INFO] [stderr] Checking jod-thread v0.1.2 [INFO] [stderr] Checking unicode-properties v0.1.1 [INFO] [stderr] Checking arrayvec v0.7.4 [INFO] [stderr] Compiling memoffset v0.9.1 [INFO] [stderr] Compiling fst v0.4.7 [INFO] [stderr] Checking ra-ap-rustc_lexer v0.63.0 [INFO] [stderr] Compiling heck v0.4.1 [INFO] [stderr] Checking crossbeam-channel v0.5.12 [INFO] [stderr] Checking nohash-hasher v0.2.0 [INFO] [stderr] Checking parking_lot v0.12.1 [INFO] [stderr] Checking drop_bomb v0.1.5 [INFO] [stderr] Checking sptr v0.3.2 [INFO] [stderr] Checking countme v3.0.1 [INFO] [stderr] Checking indexmap v2.2.5 [INFO] [stderr] Checking dashmap v5.5.3 [INFO] [stderr] Compiling quote v1.0.35 [INFO] [stderr] Checking ra_ap_limit v0.0.230 [INFO] [stderr] Checking oorandom v11.1.3 [INFO] [stderr] Checking rowan v0.15.15 [INFO] [stderr] Checking memchr v2.7.1 [INFO] [stderr] Compiling syn v2.0.52 [INFO] [stderr] Checking smol_str v0.2.1 [INFO] [stderr] Checking cov-mark v2.0.0-pre.1 [INFO] [stderr] Checking la-arena v0.3.1 [INFO] [stderr] Compiling semver v1.0.22 [INFO] [stderr] Checking bitflags v1.3.2 [INFO] [stderr] Checking lz4_flex v0.11.2 [INFO] [stderr] Compiling rustc_apfloat v0.2.0+llvm-462a31f5a5ab [INFO] [stderr] Checking fixedbitset v0.4.2 [INFO] [stderr] Checking ena v0.14.2 [INFO] [stderr] Checking crossbeam-epoch v0.9.18 [INFO] [stderr] Checking perf-event-open-sys v1.0.1 [INFO] [stderr] Checking typed-arena v2.0.2 [INFO] [stderr] Checking petgraph v0.6.5 [INFO] [stderr] Checking scoped-tls v1.0.1 [INFO] [stderr] Compiling serde_json v1.0.114 [INFO] [stderr] Checking aho-corasick v1.1.2 [INFO] [stderr] Checking crossbeam-deque v0.8.5 [INFO] [stderr] Checking perf-event v0.4.7 [INFO] [stderr] Checking line-index v0.1.1 [INFO] [stderr] Checking rayon-core v1.12.1 [INFO] [stderr] Checking ra_ap_text_edit v0.0.230 [INFO] [stderr] Checking ra_ap_profile v0.0.230 [INFO] [stderr] Checking ryu v1.0.17 [INFO] [stderr] Checking regex-syntax v0.8.2 [INFO] [stderr] Checking itoa v1.0.10 [INFO] [stderr] Compiling unicase v2.7.0 [INFO] [stderr] Compiling thiserror v1.0.57 [INFO] [stderr] Checking tinyvec v1.6.0 [INFO] [stderr] Checking rayon v1.10.0 [INFO] [stderr] Checking inotify-sys v0.1.5 [INFO] [stderr] Compiling pulldown-cmark v0.9.6 [INFO] [stderr] Checking anstream v0.6.13 [INFO] [stderr] Checking inotify v0.9.6 [INFO] [stderr] Checking mio v0.8.11 [INFO] [stderr] Checking filetime v0.2.23 [INFO] [stderr] Compiling radium v0.7.0 [INFO] [stderr] Checking tap v1.0.1 [INFO] [stderr] Checking notify v6.1.1 [INFO] [stderr] Compiling pulldown-cmark v0.12.0 [INFO] [stderr] Checking unicode-normalization v0.1.23 [INFO] [stderr] Checking clap_lex v0.7.0 [INFO] [stderr] Checking strsim v0.11.0 [INFO] [stderr] Checking unicode-width v0.1.11 [INFO] [stderr] Checking getopts v0.2.21 [INFO] [stderr] Checking clap_builder v4.5.15 [INFO] [stderr] Checking wyz v0.5.1 [INFO] [stderr] Checking idna v0.5.0 [INFO] [stderr] Compiling doc-comment v0.3.3 [INFO] [stderr] Checking predicates-core v1.0.6 [INFO] [stderr] Checking dot v0.1.4 [INFO] [stderr] Checking pulldown-cmark-to-cmark v10.0.4 [INFO] [stderr] Checking funty v2.0.0 [INFO] [stderr] Checking pulldown-cmark-escape v0.11.0 [INFO] [stderr] Checking url v2.5.0 [INFO] [stderr] Checking wyz v0.6.1 [INFO] [stderr] Checking regex-automata v0.4.6 [INFO] [stderr] Checking thread_local v1.1.8 [INFO] [stderr] Checking json v0.12.4 [INFO] [stderr] Checking bitvec v1.0.1 [INFO] [stderr] Checking difflib v0.4.0 [INFO] [stderr] Compiling indoc v2.0.5 [INFO] [stderr] Checking sugar_path v1.2.0 [INFO] [stderr] Checking dunce v1.0.5 [INFO] [stderr] Compiling assert_cmd v2.0.16 [INFO] [stderr] Checking termtree v0.4.1 [INFO] [stderr] Checking predicates v3.1.0 [INFO] [stderr] Checking predicates-tree v1.0.9 [INFO] [stderr] Checking console v0.15.8 [INFO] [stderr] Checking wait-timeout v0.2.0 [INFO] [stderr] Checking similar v2.4.0 [INFO] [stderr] Compiling synstructure v0.13.1 [INFO] [stderr] Checking insta v1.39.0 [INFO] [stderr] Compiling serde_derive v1.0.197 [INFO] [stderr] Compiling tracing-attributes v0.1.27 [INFO] [stderr] Compiling ra_ap_salsa-macros v0.0.230 [INFO] [stderr] Compiling ra-ap-rustc_index_macros v0.63.0 [INFO] [stderr] Compiling chalk-derive v0.98.0 [INFO] [stderr] Compiling thiserror-impl v1.0.57 [INFO] [stderr] Checking ra-ap-rustc_index v0.63.0 [INFO] [stderr] Checking regex v1.10.3 [INFO] [stderr] Checking chalk-ir v0.98.0 [INFO] [stderr] Compiling rust-analyzer-salsa-macros v0.17.0-pre.6 [INFO] [stderr] Checking ra-ap-rustc_parse_format v0.63.0 [INFO] [stderr] Checking env_filter v0.1.0 [INFO] [stderr] Compiling clap_derive v4.5.13 [INFO] [stderr] Checking env_logger v0.11.5 [INFO] [stderr] Checking bstr v1.9.1 [INFO] [stderr] Checking shellwords v1.1.0 [INFO] [stderr] Checking tracing v0.1.40 [INFO] [stderr] Checking always-assert v0.2.0 [INFO] [stderr] Checking ra_ap_parser v0.0.230 [INFO] [stderr] Checking ra-ap-rustc_abi v0.63.0 [INFO] [stderr] Checking ra-ap-rustc_pattern_analysis v0.63.0 [INFO] [stderr] Checking ra_ap_stdx v0.0.230 [INFO] [stderr] Checking chalk-solve v0.98.0 [INFO] [stderr] Checking clap v4.5.16 [INFO] [stderr] Checking chalk-recursive v0.98.0 [INFO] [stderr] Checking triomphe v0.1.11 [INFO] [stderr] Checking cargo-platform v0.1.7 [INFO] [stderr] Checking ra_ap_intern v0.0.230 [INFO] [stderr] Checking ra_ap_syntax v0.0.230 [INFO] [stderr] Checking ra_ap_salsa v0.0.230 [INFO] [stderr] Checking rust-analyzer-salsa v0.17.0-pre.6 [INFO] [stderr] Checking ra_ap_paths v0.0.230 [INFO] [stderr] Checking ra_ap_toolchain v0.0.230 [INFO] [stderr] Checking ra_ap_vfs v0.0.230 [INFO] [stderr] Checking ra_ap_vfs-notify v0.0.230 [INFO] [stderr] Checking cargo_metadata v0.18.1 [INFO] [stderr] Checking ra_ap_tt v0.0.230 [INFO] [stderr] Checking ra_ap_cfg v0.0.230 [INFO] [stderr] Checking ra_ap_span v0.0.230 [INFO] [stderr] Checking ra_ap_base_db v0.0.230 [INFO] [stderr] Checking ra_ap_syntax-bridge v0.0.230 [INFO] [stderr] Checking ra_ap_proc_macro_api v0.0.230 [INFO] [stderr] Checking ra_ap_project_model v0.0.230 [INFO] [stderr] Checking ra_ap_mbe v0.0.230 [INFO] [stderr] Checking ra_ap_hir_expand v0.0.230 [INFO] [stderr] Checking ra_ap_hir_def v0.0.230 [INFO] [stderr] Checking ra_ap_hir_ty v0.0.230 [INFO] [stderr] Checking ra_ap_hir v0.0.230 [INFO] [stderr] Checking ra_ap_ide_db v0.0.230 [INFO] [stderr] Checking ra_ap_ide_completion v0.0.230 [INFO] [stderr] Checking ra_ap_ide_ssr v0.0.230 [INFO] [stderr] Checking ra_ap_ide_assists v0.0.230 [INFO] [stderr] Checking ra_ap_ide_diagnostics v0.0.230 [INFO] [stderr] Checking ra_ap_load-cargo v0.0.230 [INFO] [stderr] Checking ra_ap_ide v0.0.230 [INFO] [stderr] Checking cargo-modules v0.17.0 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/command/dependencies/filter.rs:63:32 [INFO] [stdout] | [INFO] [stdout] 63 | .unwrap_or_else(|| self.krate.display_name(self.db).unwrap().to_string()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/command/orphans/scanner.rs:130:5 [INFO] [stdout] | [INFO] [stdout] 122 | let read_dir = match fs::read_dir(dir_path) { [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 123 | Ok(read_dir) => read_dir, [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 130 | / possible_orphans_in(read_dir) [INFO] [stdout] 131 | | .filter_map(|possible_orphan| { [INFO] [stdout] 132 | | if submodule_names.contains(&possible_orphan.name) { [INFO] [stdout] 133 | | return None; [INFO] [stdout] ... | [INFO] [stdout] 141 | | }) [INFO] [stdout] 142 | | }) [INFO] [stdout] | |__________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/command/orphans/scanner.rs:169:5 [INFO] [stdout] | [INFO] [stdout] 164 | fn possible_orphans_in(read_dir: ReadDir) -> impl Iterator { [INFO] [stdout] | ----------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 169 | read_dir.into_iter().filter_map(|dir_entry| { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/command/structure/filter.rs:42:32 [INFO] [stdout] | [INFO] [stdout] 42 | .unwrap_or_else(|| self.krate.display_name(self.db).unwrap().to_string()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/analyzer.rs:78:8 [INFO] [stdout] | [INFO] [stdout] 45 | let cargo_config = cargo_config(project_options, load_options); [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 52 | let mut project_workspace = load_project_workspace(&project_path, &cargo_config, &progress)?; [INFO] [stdout] | ----------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 53 | [INFO] [stdout] 54 | let (package, target) = select_package_and_target(&project_workspace, project_options)?; [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 71 | let (db, vfs, _proc_macro_client) = [INFO] [stdout] | -- --- ------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 74 | let host = ide::AnalysisHost::with_database(db); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 78 | Ok((krate, host, vfs, edition)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/analyzer.rs:214:8 [INFO] [stdout] | [INFO] [stdout] 199 | Err(anyhow::anyhow!("Unexpected JSON workspace")) [INFO] [stdout] | -------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 202 | Err(anyhow::anyhow!("Unexpected detached files")) [INFO] [stdout] | -------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 207 | let package = cargo_workspace[package_idx].clone(); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 214 | Ok((package, target)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/analyzer.rs:460:33 [INFO] [stdout] | [INFO] [stdout] 460 | .map(|name| name.display(db, edition).to_string()) [INFO] [stdout] | ---- ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/analyzer.rs:473:25 [INFO] [stdout] | [INFO] [stdout] 473 | .map(|name| name.display(db, edition).to_string()) [INFO] [stdout] | ---- ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/analyzer.rs:485:21 [INFO] [stdout] | [INFO] [stdout] 485 | .map(|name| name.display(db, edition).to_string()) [INFO] [stdout] | ---- ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/analyzer.rs:561:25 [INFO] [stdout] | [INFO] [stdout] 561 | .map(|name| name.display(db, edition).to_string()), [INFO] [stdout] | ---- ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/analyzer.rs:564:25 [INFO] [stdout] | [INFO] [stdout] 564 | .map(|name| name.display(db, edition).to_string()), [INFO] [stdout] | ---- ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/analyzer.rs:567:25 [INFO] [stdout] | [INFO] [stdout] 567 | .map(|name| name.display(db, edition).to_string()), [INFO] [stdout] | ---- ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/analyzer.rs:645:5 [INFO] [stdout] | [INFO] [stdout] 614 | let mut path_segments_iter = path.segments(); [INFO] [stdout] | ------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 633 | let path_segments: Vec<_> = path_segments_iter.collect(); [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 643 | let path_suffix = ast::make::path_from_segments(path_segments, false); [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 644 | [INFO] [stdout] 645 | / use_tree [INFO] [stdout] 646 | | .use_tree_list() [INFO] [stdout] 647 | | .into_iter() [INFO] [stdout] 648 | | .flat_map(|list| list.use_trees()) [INFO] [stdout] | |__________________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/analyzer.rs:662:26 [INFO] [stdout] | [INFO] [stdout] 662 | .map(|tree_list| tree_list.use_trees().any(|tree| tree_is_self(&tree))) [INFO] [stdout] | --------- ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/graph/builder.rs:782:25 [INFO] [stdout] | [INFO] [stdout] 782 | .map(|name| name.display(self.db, self.edition).to_string()); [INFO] [stdout] | ---- ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/item/attr.rs:31:74 [INFO] [stdout] | [INFO] [stdout] 31 | cfg::CfgExpr::Not(cfg) => Self::new(cfg).map(|cfg| Self::Not(Box::new(cfg))), [INFO] [stdout] | --- ^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 16 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `cargo-modules` (lib test) due to 17 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/command/dependencies/filter.rs:63:32 [INFO] [stdout] | [INFO] [stdout] 63 | .unwrap_or_else(|| self.krate.display_name(self.db).unwrap().to_string()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/command/orphans/scanner.rs:130:5 [INFO] [stdout] | [INFO] [stdout] 122 | let read_dir = match fs::read_dir(dir_path) { [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 123 | Ok(read_dir) => read_dir, [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 130 | / possible_orphans_in(read_dir) [INFO] [stdout] 131 | | .filter_map(|possible_orphan| { [INFO] [stdout] 132 | | if submodule_names.contains(&possible_orphan.name) { [INFO] [stdout] 133 | | return None; [INFO] [stdout] ... | [INFO] [stdout] 141 | | }) [INFO] [stdout] 142 | | }) [INFO] [stdout] | |__________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/command/orphans/scanner.rs:169:5 [INFO] [stdout] | [INFO] [stdout] 164 | fn possible_orphans_in(read_dir: ReadDir) -> impl Iterator { [INFO] [stdout] | ----------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 169 | read_dir.into_iter().filter_map(|dir_entry| { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/command/structure/filter.rs:42:32 [INFO] [stdout] | [INFO] [stdout] 42 | .unwrap_or_else(|| self.krate.display_name(self.db).unwrap().to_string()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/analyzer.rs:78:8 [INFO] [stdout] | [INFO] [stdout] 45 | let cargo_config = cargo_config(project_options, load_options); [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 52 | let mut project_workspace = load_project_workspace(&project_path, &cargo_config, &progress)?; [INFO] [stdout] | ----------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 53 | [INFO] [stdout] 54 | let (package, target) = select_package_and_target(&project_workspace, project_options)?; [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 71 | let (db, vfs, _proc_macro_client) = [INFO] [stdout] | -- --- ------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 74 | let host = ide::AnalysisHost::with_database(db); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 78 | Ok((krate, host, vfs, edition)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/analyzer.rs:214:8 [INFO] [stdout] | [INFO] [stdout] 199 | Err(anyhow::anyhow!("Unexpected JSON workspace")) [INFO] [stdout] | -------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 202 | Err(anyhow::anyhow!("Unexpected detached files")) [INFO] [stdout] | -------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 207 | let package = cargo_workspace[package_idx].clone(); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 214 | Ok((package, target)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/analyzer.rs:460:33 [INFO] [stdout] | [INFO] [stdout] 460 | .map(|name| name.display(db, edition).to_string()) [INFO] [stdout] | ---- ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/analyzer.rs:473:25 [INFO] [stdout] | [INFO] [stdout] 473 | .map(|name| name.display(db, edition).to_string()) [INFO] [stdout] | ---- ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/analyzer.rs:485:21 [INFO] [stdout] | [INFO] [stdout] 485 | .map(|name| name.display(db, edition).to_string()) [INFO] [stdout] | ---- ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/analyzer.rs:561:25 [INFO] [stdout] | [INFO] [stdout] 561 | .map(|name| name.display(db, edition).to_string()), [INFO] [stdout] | ---- ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/analyzer.rs:564:25 [INFO] [stdout] | [INFO] [stdout] 564 | .map(|name| name.display(db, edition).to_string()), [INFO] [stdout] | ---- ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/analyzer.rs:567:25 [INFO] [stdout] | [INFO] [stdout] 567 | .map(|name| name.display(db, edition).to_string()), [INFO] [stdout] | ---- ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/analyzer.rs:645:5 [INFO] [stdout] | [INFO] [stdout] 614 | let mut path_segments_iter = path.segments(); [INFO] [stdout] | ------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 633 | let path_segments: Vec<_> = path_segments_iter.collect(); [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 643 | let path_suffix = ast::make::path_from_segments(path_segments, false); [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 644 | [INFO] [stdout] 645 | / use_tree [INFO] [stdout] 646 | | .use_tree_list() [INFO] [stdout] 647 | | .into_iter() [INFO] [stdout] 648 | | .flat_map(|list| list.use_trees()) [INFO] [stdout] | |__________________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/analyzer.rs:662:26 [INFO] [stdout] | [INFO] [stdout] 662 | .map(|tree_list| tree_list.use_trees().any(|tree| tree_is_self(&tree))) [INFO] [stdout] | --------- ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/graph/builder.rs:782:25 [INFO] [stdout] | [INFO] [stdout] 782 | .map(|name| name.display(self.db, self.edition).to_string()); [INFO] [stdout] | ---- ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/item/attr.rs:31:74 [INFO] [stdout] | [INFO] [stdout] 31 | cfg::CfgExpr::Not(cfg) => Self::new(cfg).map(|cfg| Self::Not(Box::new(cfg))), [INFO] [stdout] | --- ^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 16 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `cargo-modules` (lib) due to 17 previous errors [INFO] running `Command { std: "docker" "inspect" "8c4f7c4b5e8d161a475c4bda5c1af70e06dc5ec54ddd03ae565e2eaf0f321a26", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "8c4f7c4b5e8d161a475c4bda5c1af70e06dc5ec54ddd03ae565e2eaf0f321a26", kill_on_drop: false }` [INFO] [stdout] 8c4f7c4b5e8d161a475c4bda5c1af70e06dc5ec54ddd03ae565e2eaf0f321a26