[INFO] fetching crate cargo-manifest 0.15.1... [INFO] checking cargo-manifest-0.15.1 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate cargo-manifest 0.15.1 into /workspace/builds/worker-7-tc2/source [INFO] validating manifest of crates.io crate cargo-manifest 0.15.1 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate cargo-manifest 0.15.1 [INFO] finished tweaking crates.io crate cargo-manifest 0.15.1 [INFO] tweaked toml for crates.io crate cargo-manifest 0.15.1 written to /workspace/builds/worker-7-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 44 packages to latest compatible versions [INFO] [stderr] Adding encode_unicode v0.3.6 (latest: v1.0.0) [INFO] [stderr] Adding linux-raw-sys v0.4.14 (latest: v0.6.5) [INFO] [stderr] Adding windows-sys v0.52.0 (latest: v0.59.0) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] cb7af5978b9b4b54ff93633c95bc5301067de00d59e0c55692b21b64d47feac4 [INFO] running `Command { std: "docker" "start" "-a" "cb7af5978b9b4b54ff93633c95bc5301067de00d59e0c55692b21b64d47feac4", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "cb7af5978b9b4b54ff93633c95bc5301067de00d59e0c55692b21b64d47feac4", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "cb7af5978b9b4b54ff93633c95bc5301067de00d59e0c55692b21b64d47feac4", kill_on_drop: false }` [INFO] [stdout] cb7af5978b9b4b54ff93633c95bc5301067de00d59e0c55692b21b64d47feac4 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 8a9d094a0161a0ac5642b8b7bbe0a9cc6f6625c3899d23c4469dbf73672499a9 [INFO] running `Command { std: "docker" "start" "-a" "8a9d094a0161a0ac5642b8b7bbe0a9cc6f6625c3899d23c4469dbf73672499a9", kill_on_drop: false }` [INFO] [stderr] Compiling serde v1.0.209 [INFO] [stderr] Compiling rustix v0.38.35 [INFO] [stderr] Checking winnow v0.6.18 [INFO] [stderr] Checking console v0.15.8 [INFO] [stderr] Checking linked-hash-map v0.5.6 [INFO] [stderr] Checking similar v2.6.0 [INFO] [stderr] Checking once_cell v1.19.0 [INFO] [stderr] Checking insta v1.39.0 [INFO] [stderr] Checking tempfile v3.12.0 [INFO] [stderr] Checking toml_datetime v0.6.8 [INFO] [stderr] Checking serde_spanned v0.6.7 [INFO] [stderr] Checking toml_edit v0.22.20 [INFO] [stderr] Checking toml v0.8.19 [INFO] [stderr] Checking cargo-manifest v0.15.1 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:1154:8 [INFO] [stdout] | [INFO] [stdout] 1149 | fn ok_or_default<'de, T, D>(deserializer: D) -> Result [INFO] [stdout] | --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 1154 | Ok(Deserialize::deserialize(deserializer).unwrap_or_default()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/afs.rs:32:12 [INFO] [stdout] | [INFO] [stdout] 31 | fn file_names_in>(&self, rel_path: T) -> io::Result>> { [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 32 | Ok(read_dir(self.path.join(rel_path))? [INFO] [stdout] | ____________^ [INFO] [stdout] 33 | | .filter_map(|entry| { [INFO] [stdout] 34 | | entry [INFO] [stdout] 35 | | .ok() [INFO] [stdout] 36 | | .map(|e| e.file_name().to_string_lossy().to_string().into_boxed_str()) [INFO] [stdout] 37 | | }) [INFO] [stdout] 38 | | .collect()) [INFO] [stdout] | |______________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/afs.rs:34:17 [INFO] [stdout] | [INFO] [stdout] 33 | .filter_map(|entry| { [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 34 | / entry [INFO] [stdout] 35 | | .ok() [INFO] [stdout] | |_________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 3 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `cargo-manifest` (lib) due to 4 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:1154:8 [INFO] [stdout] | [INFO] [stdout] 1149 | fn ok_or_default<'de, T, D>(deserializer: D) -> Result [INFO] [stdout] | --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 1154 | Ok(Deserialize::deserialize(deserializer).unwrap_or_default()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/afs.rs:32:12 [INFO] [stdout] | [INFO] [stdout] 31 | fn file_names_in>(&self, rel_path: T) -> io::Result>> { [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 32 | Ok(read_dir(self.path.join(rel_path))? [INFO] [stdout] | ____________^ [INFO] [stdout] 33 | | .filter_map(|entry| { [INFO] [stdout] 34 | | entry [INFO] [stdout] 35 | | .ok() [INFO] [stdout] 36 | | .map(|e| e.file_name().to_string_lossy().to_string().into_boxed_str()) [INFO] [stdout] 37 | | }) [INFO] [stdout] 38 | | .collect()) [INFO] [stdout] | |______________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/afs.rs:34:17 [INFO] [stdout] | [INFO] [stdout] 33 | .filter_map(|entry| { [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 34 | / entry [INFO] [stdout] 35 | | .ok() [INFO] [stdout] | |_________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 3 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `cargo-manifest` (lib test) due to 4 previous errors [INFO] running `Command { std: "docker" "inspect" "8a9d094a0161a0ac5642b8b7bbe0a9cc6f6625c3899d23c4469dbf73672499a9", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "8a9d094a0161a0ac5642b8b7bbe0a9cc6f6625c3899d23c4469dbf73672499a9", kill_on_drop: false }` [INFO] [stdout] 8a9d094a0161a0ac5642b8b7bbe0a9cc6f6625c3899d23c4469dbf73672499a9