[INFO] fetching crate cargo-hakari 0.9.30... [INFO] checking cargo-hakari-0.9.30 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate cargo-hakari 0.9.30 into /workspace/builds/worker-6-tc2/source [INFO] validating manifest of crates.io crate cargo-hakari 0.9.30 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate cargo-hakari 0.9.30 [INFO] finished tweaking crates.io crate cargo-hakari 0.9.30 [INFO] tweaked toml for crates.io crate cargo-hakari 0.9.30 written to /workspace/builds/worker-6-tc2/source/Cargo.toml [INFO] crate crates.io crate cargo-hakari 0.9.30 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 82d1f6d1be345656220abef00e21021e12399e601a87c17a6e94094e88141195 [INFO] running `Command { std: "docker" "start" "-a" "82d1f6d1be345656220abef00e21021e12399e601a87c17a6e94094e88141195", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "82d1f6d1be345656220abef00e21021e12399e601a87c17a6e94094e88141195", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "82d1f6d1be345656220abef00e21021e12399e601a87c17a6e94094e88141195", kill_on_drop: false }` [INFO] [stdout] 82d1f6d1be345656220abef00e21021e12399e601a87c17a6e94094e88141195 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] cbc3cf7dc9069d528152248fdc5c5d46c519aef67c58a28f6bcacecec1910127 [INFO] running `Command { std: "docker" "start" "-a" "cbc3cf7dc9069d528152248fdc5c5d46c519aef67c58a28f6bcacecec1910127", kill_on_drop: false }` [INFO] [stderr] Compiling proc-macro2 v1.0.78 [INFO] [stderr] Compiling serde v1.0.202 [INFO] [stderr] Compiling autocfg v1.1.0 [INFO] [stderr] Checking either v1.11.0 [INFO] [stderr] Compiling camino v1.1.7 [INFO] [stderr] Compiling semver v1.0.23 [INFO] [stderr] Compiling target-lexicon v0.12.15 [INFO] [stderr] Compiling guppy-workspace-hack v0.1.0 [INFO] [stderr] Compiling rustix v0.38.31 [INFO] [stderr] Checking itertools v0.10.5 [INFO] [stderr] Checking bitflags v2.6.0 [INFO] [stderr] Compiling serde_json v1.0.117 [INFO] [stderr] Compiling cc v1.0.83 [INFO] [stderr] Checking crossbeam-deque v0.8.5 [INFO] [stderr] Compiling indexmap v1.9.3 [INFO] [stderr] Checking atty v0.2.14 [INFO] [stderr] Checking anstyle-parse v0.2.3 [INFO] [stderr] Checking aho-corasick v1.1.2 [INFO] [stderr] Checking regex-syntax v0.8.2 [INFO] [stderr] Checking anstyle-query v1.0.2 [INFO] [stderr] Compiling quote v1.0.35 [INFO] [stderr] Checking arrayvec v0.5.2 [INFO] [stderr] Compiling syn v2.0.48 [INFO] [stderr] Checking anstyle v1.0.6 [INFO] [stderr] Compiling vte_generate_state_changes v0.1.1 [INFO] [stderr] Checking is_terminal_polyfill v1.70.1 [INFO] [stderr] Checking colorchoice v1.0.0 [INFO] [stderr] Checking is_ci v1.2.0 [INFO] [stderr] Checking ryu v1.0.16 [INFO] [stderr] Checking hashbrown v0.14.3 [INFO] [stderr] Checking itoa v1.0.10 [INFO] [stderr] Compiling target-spec v3.2.0 [INFO] [stderr] Checking diffus v0.10.0 [INFO] [stderr] Compiling backtrace v0.3.69 [INFO] [stderr] Checking supports-color v1.3.1 [INFO] [stderr] Checking cfg-expr v0.16.0 [INFO] [stderr] Checking anstream v0.6.15 [INFO] [stderr] Checking vte v0.10.1 [INFO] [stderr] Checking regex-automata v0.4.5 [INFO] [stderr] Checking rayon-core v1.12.1 [INFO] [stderr] Checking getrandom v0.2.12 [INFO] [stderr] Checking fixedbitset v0.4.2 [INFO] [stderr] Checking indexmap v2.2.6 [INFO] [stderr] Checking indenter v0.3.3 [INFO] [stderr] Checking zerocopy v0.7.32 [INFO] [stderr] Compiling eyre v0.6.12 [INFO] [stderr] Checking tempfile v3.10.1 [INFO] [stderr] Checking gimli v0.28.1 [INFO] [stderr] Checking unicode-ident v1.0.12 [INFO] [stderr] Checking rayon v1.10.0 [INFO] [stderr] Checking strip-ansi-escapes v0.1.1 [INFO] [stderr] Checking miniz_oxide v0.7.2 [INFO] [stderr] Checking owo-colors v3.5.0 [INFO] [stderr] Checking ahash v0.8.11 [INFO] [stderr] Compiling include_dir_macros v0.7.3 [INFO] [stderr] Checking petgraph v0.6.5 [INFO] [stderr] Checking itertools v0.12.1 [INFO] [stderr] Checking object v0.32.2 [INFO] [stderr] Checking nom8 v0.2.0 [INFO] [stderr] Checking regex v1.10.5 [INFO] [stderr] Checking clap_lex v0.7.2 [INFO] [stderr] Checking debug-ignore v1.0.5 [INFO] [stderr] Checking nested v0.1.1 [INFO] [stderr] Checking toml_datetime v0.5.1 [INFO] [stderr] Checking rustc-demangle v0.1.23 [INFO] [stderr] Checking clap_builder v4.5.11 [INFO] [stderr] Checking env_filter v0.1.0 [INFO] [stderr] Checking console v0.15.8 [INFO] [stderr] Checking include_dir v0.7.3 [INFO] [stderr] Checking tabular v0.2.0 [INFO] [stderr] Checking addr2line v0.21.0 [INFO] [stderr] Checking diffy v0.3.0 [INFO] [stderr] Checking atomicwrites v0.4.3 [INFO] [stderr] Checking twox-hash v1.6.3 [INFO] [stderr] Checking shared_child v1.0.0 [INFO] [stderr] Checking os_pipe v1.1.5 [INFO] [stderr] Checking shell-words v1.1.0 [INFO] [stderr] Checking bimap v0.6.3 [INFO] [stderr] Checking zeroize v1.7.0 [INFO] [stderr] Checking toml_edit v0.17.1 [INFO] [stderr] Checking duct v0.13.7 [INFO] [stderr] Checking env_logger v0.11.3 [INFO] [stderr] Checking enable-ansi-support v0.2.1 [INFO] [stderr] Compiling serde_derive v1.0.202 [INFO] [stderr] Compiling thiserror-impl v1.0.63 [INFO] [stderr] Compiling clap_derive v4.5.11 [INFO] [stderr] Checking color-eyre v0.6.3 [INFO] [stderr] Checking thiserror v1.0.63 [INFO] [stderr] Checking dialoguer v0.11.0 [INFO] [stderr] Checking clap v4.5.11 [INFO] [stderr] Checking toml v0.5.11 [INFO] [stderr] Checking cargo-platform v0.1.6 [INFO] [stderr] Checking pathdiff v0.2.1 [INFO] [stderr] Checking cargo_metadata v0.18.1 [INFO] [stderr] Checking guppy-summaries v0.7.1 [INFO] [stderr] Checking guppy v0.17.6 [INFO] [stderr] Checking hakari v0.17.3 [INFO] [stderr] Checking cargo-hakari v0.9.30 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/command.rs:489:8 [INFO] [stdout] | [INFO] [stdout] 479 | let config: HakariConfig = contents [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 483 | let builder = config [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 489 | Ok((builder, hakari_output)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/publish.rs:57:11 [INFO] [stdout] | [INFO] [stdout] 13 | builder: HakariBuilder<'_>, [INFO] [stdout] | -------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 14 | pass_through: &[String], [INFO] [stdout] 15 | output: OutputContext, [INFO] [stdout] | --------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 24 | let mut remove_dep = if hakari_package.publish().is_never() { [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 34 | let mut cargo_cli = CargoCli::new("publish", output.clone()); [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 55 | let expression = cargo_cli.to_expression().dir(abs_path); [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 56 | [INFO] [stdout] 57 | match expression.run() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/publish.rs:108:12 [INFO] [stdout] | [INFO] [stdout] 74 | builder: HakariBuilder<'g>, [INFO] [stdout] | -------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 75 | package: PackageMetadata<'g>, [INFO] [stdout] 76 | output: OutputContext, [INFO] [stdout] | --------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 85 | let inner = if remove_ops.is_empty() { [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 108 | Ok(Self { inner }) [INFO] [stdout] | ^^^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/command.rs:489:8 [INFO] [stdout] | [INFO] [stdout] 479 | let config: HakariConfig = contents [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 483 | let builder = config [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 489 | Ok((builder, hakari_output)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/publish.rs:57:11 [INFO] [stdout] | [INFO] [stdout] 13 | builder: HakariBuilder<'_>, [INFO] [stdout] | -------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 14 | pass_through: &[String], [INFO] [stdout] 15 | output: OutputContext, [INFO] [stdout] | --------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 24 | let mut remove_dep = if hakari_package.publish().is_never() { [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 34 | let mut cargo_cli = CargoCli::new("publish", output.clone()); [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 55 | let expression = cargo_cli.to_expression().dir(abs_path); [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 56 | [INFO] [stdout] 57 | match expression.run() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/publish.rs:108:12 [INFO] [stdout] | [INFO] [stdout] 74 | builder: HakariBuilder<'g>, [INFO] [stdout] | -------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 75 | package: PackageMetadata<'g>, [INFO] [stdout] 76 | output: OutputContext, [INFO] [stdout] | --------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 85 | let inner = if remove_ops.is_empty() { [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 108 | Ok(Self { inner }) [INFO] [stdout] | ^^^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 3 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 3 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `cargo-hakari` (lib test) due to 4 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] error: could not compile `cargo-hakari` (lib) due to 4 previous errors [INFO] running `Command { std: "docker" "inspect" "cbc3cf7dc9069d528152248fdc5c5d46c519aef67c58a28f6bcacecec1910127", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "cbc3cf7dc9069d528152248fdc5c5d46c519aef67c58a28f6bcacecec1910127", kill_on_drop: false }` [INFO] [stdout] cbc3cf7dc9069d528152248fdc5c5d46c519aef67c58a28f6bcacecec1910127