[INFO] fetching crate cargo-feature-aspect 0.1.10... [INFO] checking cargo-feature-aspect-0.1.10 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate cargo-feature-aspect 0.1.10 into /workspace/builds/worker-0-tc2/source [INFO] validating manifest of crates.io crate cargo-feature-aspect 0.1.10 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate cargo-feature-aspect 0.1.10 [INFO] finished tweaking crates.io crate cargo-feature-aspect 0.1.10 [INFO] tweaked toml for crates.io crate cargo-feature-aspect 0.1.10 written to /workspace/builds/worker-0-tc2/source/Cargo.toml [INFO] crate crates.io crate cargo-feature-aspect 0.1.10 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 124a4e9d22b72ffd03c9b6fb1f1e670afab56465cc213aa7c1561f84609b31b1 [INFO] running `Command { std: "docker" "start" "-a" "124a4e9d22b72ffd03c9b6fb1f1e670afab56465cc213aa7c1561f84609b31b1", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "124a4e9d22b72ffd03c9b6fb1f1e670afab56465cc213aa7c1561f84609b31b1", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "124a4e9d22b72ffd03c9b6fb1f1e670afab56465cc213aa7c1561f84609b31b1", kill_on_drop: false }` [INFO] [stdout] 124a4e9d22b72ffd03c9b6fb1f1e670afab56465cc213aa7c1561f84609b31b1 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] cb19b4edde31bf592a95aad3db215f4fa995297641036e0dd7c35f5c69a36241 [INFO] running `Command { std: "docker" "start" "-a" "cb19b4edde31bf592a95aad3db215f4fa995297641036e0dd7c35f5c69a36241", kill_on_drop: false }` [INFO] [stderr] Compiling serde v1.0.203 [INFO] [stderr] Compiling libc v0.2.155 [INFO] [stderr] Compiling cc v1.0.102 [INFO] [stderr] Compiling heck v0.5.0 [INFO] [stderr] Compiling semver v1.0.23 [INFO] [stderr] Checking strsim v0.11.1 [INFO] [stderr] Compiling camino v1.1.7 [INFO] [stderr] Checking gimli v0.29.0 [INFO] [stderr] Checking regex-syntax v0.8.4 [INFO] [stderr] Compiling serde_json v1.0.118 [INFO] [stderr] Compiling syn v2.0.68 [INFO] [stderr] Checking anstream v0.6.14 [INFO] [stderr] Checking clap_lex v0.7.1 [INFO] [stderr] Checking memchr v2.7.4 [INFO] [stderr] Checking indexmap v2.2.6 [INFO] [stderr] Checking miniz_oxide v0.7.4 [INFO] [stderr] Checking winnow v0.6.13 [INFO] [stderr] Checking rustc-demangle v0.1.24 [INFO] [stderr] Compiling anyhow v1.0.86 [INFO] [stderr] Checking tracing-log v0.2.0 [INFO] [stderr] Checking sharded-slab v0.1.7 [INFO] [stderr] Checking thread_local v1.1.8 [INFO] [stderr] Checking concolor-query v0.0.4 [INFO] [stderr] Checking smallvec v1.13.2 [INFO] [stderr] Checking topo_sort v0.4.0 [INFO] [stderr] Checking clap_builder v4.5.8 [INFO] [stderr] Checking object v0.36.1 [INFO] [stderr] Checking atty v0.2.14 [INFO] [stderr] Checking concolor-control v0.0.7 [INFO] [stderr] Compiling backtrace v0.3.73 [INFO] [stderr] Checking regex-automata v0.4.7 [INFO] [stderr] Checking regex v1.10.5 [INFO] [stderr] Checking addr2line v0.22.0 [INFO] [stderr] Compiling serde_derive v1.0.203 [INFO] [stderr] Compiling tracing-attributes v0.1.27 [INFO] [stderr] Compiling clap_derive v4.5.8 [INFO] [stderr] Compiling thiserror-impl v1.0.61 [INFO] [stderr] Checking thiserror v1.0.61 [INFO] [stderr] Checking tracing v0.1.40 [INFO] [stderr] Checking tracing-subscriber v0.3.18 [INFO] [stderr] Checking clap v4.5.8 [INFO] [stderr] Checking clap-cargo v0.14.0 [INFO] [stderr] Checking toml_datetime v0.6.6 [INFO] [stderr] Checking serde_spanned v0.6.6 [INFO] [stderr] Checking cargo-platform v0.1.8 [INFO] [stderr] Checking toml_edit v0.22.14 [INFO] [stderr] Checking cargo_metadata v0.18.1 [INFO] [stderr] Checking toml v0.8.14 [INFO] [stderr] Checking cargo-feature-aspect v0.1.10 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/main.rs:288:55 [INFO] [stdout] | [INFO] [stdout] 288 | .or_insert_with(|| toml_edit::Item::Table(toml_edit::Table::new())) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/main.rs:292:55 [INFO] [stdout] | [INFO] [stdout] 292 | .or_insert_with(|| toml_edit::Item::Value(toml_edit::Value::Array(toml_edit::Array::new()))) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/context.rs:57:12 [INFO] [stdout] | [INFO] [stdout] 28 | anyhow::bail!("Must specify specify --name or else specify exactly one --leaf-feature") [INFO] [stdout] | ---------------------------------------------------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 55 | let in_scope_packages = collections::HashSet::new(); [INFO] [stdout] | ----------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 56 | [INFO] [stdout] 57 | Ok(Self { [INFO] [stdout] | ____________^ [INFO] [stdout] 58 | | feature_name, [INFO] [stdout] 59 | | extra_feature_params, [INFO] [stdout] 60 | | dry_run, [INFO] [stdout] ... | [INFO] [stdout] 66 | | in_scope_packages, [INFO] [stdout] 67 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/metadata.rs:31:5 [INFO] [stdout] | [INFO] [stdout] 29 | pub fn find_ws_members(ws: cargo_metadata::Metadata) -> Vec { [INFO] [stdout] | ---------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 30 | let workspace_members: collections::HashSet<_> = ws.workspace_members.iter().collect(); [INFO] [stdout] | ----------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 31 | / ws.packages [INFO] [stdout] 32 | | .into_iter() [INFO] [stdout] 33 | | .filter(|p| workspace_members.contains(&p.id)) [INFO] [stdout] | |______________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/main.rs:288:55 [INFO] [stdout] | [INFO] [stdout] 288 | .or_insert_with(|| toml_edit::Item::Table(toml_edit::Table::new())) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/main.rs:292:55 [INFO] [stdout] | [INFO] [stdout] 292 | .or_insert_with(|| toml_edit::Item::Value(toml_edit::Value::Array(toml_edit::Array::new()))) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/context.rs:57:12 [INFO] [stdout] | [INFO] [stdout] 28 | anyhow::bail!("Must specify specify --name or else specify exactly one --leaf-feature") [INFO] [stdout] | ---------------------------------------------------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 55 | let in_scope_packages = collections::HashSet::new(); [INFO] [stdout] | ----------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 56 | [INFO] [stdout] 57 | Ok(Self { [INFO] [stdout] | ____________^ [INFO] [stdout] 58 | | feature_name, [INFO] [stdout] 59 | | extra_feature_params, [INFO] [stdout] 60 | | dry_run, [INFO] [stdout] ... | [INFO] [stdout] 66 | | in_scope_packages, [INFO] [stdout] 67 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/metadata.rs:31:5 [INFO] [stdout] | [INFO] [stdout] 29 | pub fn find_ws_members(ws: cargo_metadata::Metadata) -> Vec { [INFO] [stdout] | ---------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 30 | let workspace_members: collections::HashSet<_> = ws.workspace_members.iter().collect(); [INFO] [stdout] | ----------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 31 | / ws.packages [INFO] [stdout] 32 | | .into_iter() [INFO] [stdout] 33 | | .filter(|p| workspace_members.contains(&p.id)) [INFO] [stdout] | |______________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 4 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 4 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `cargo-feature-aspect` (bin "cargo-feature-aspect") due to 5 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] error: could not compile `cargo-feature-aspect` (bin "cargo-feature-aspect" test) due to 5 previous errors [INFO] running `Command { std: "docker" "inspect" "cb19b4edde31bf592a95aad3db215f4fa995297641036e0dd7c35f5c69a36241", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "cb19b4edde31bf592a95aad3db215f4fa995297641036e0dd7c35f5c69a36241", kill_on_drop: false }` [INFO] [stdout] cb19b4edde31bf592a95aad3db215f4fa995297641036e0dd7c35f5c69a36241