[INFO] fetching crate cargo-disasm 0.6.0... [INFO] checking cargo-disasm-0.6.0 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate cargo-disasm 0.6.0 into /workspace/builds/worker-1-tc2/source [INFO] validating manifest of crates.io crate cargo-disasm 0.6.0 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate cargo-disasm 0.6.0 [INFO] finished tweaking crates.io crate cargo-disasm 0.6.0 [INFO] tweaked toml for crates.io crate cargo-disasm 0.6.0 written to /workspace/builds/worker-1-tc2/source/Cargo.toml [INFO] crate crates.io crate cargo-disasm 0.6.0 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 21d5a04d429013fe4f4a68a7ce7b06546de75df6d5e5ea9beea02da09eb7f0a0 [INFO] running `Command { std: "docker" "start" "-a" "21d5a04d429013fe4f4a68a7ce7b06546de75df6d5e5ea9beea02da09eb7f0a0", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "21d5a04d429013fe4f4a68a7ce7b06546de75df6d5e5ea9beea02da09eb7f0a0", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "21d5a04d429013fe4f4a68a7ce7b06546de75df6d5e5ea9beea02da09eb7f0a0", kill_on_drop: false }` [INFO] [stdout] 21d5a04d429013fe4f4a68a7ce7b06546de75df6d5e5ea9beea02da09eb7f0a0 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] bc7c811cddb61bf0fab1c80d50309b8a38e47599dae18fae9537f701bd600567 [INFO] running `Command { std: "docker" "start" "-a" "bc7c811cddb61bf0fab1c80d50309b8a38e47599dae18fae9537f701bd600567", kill_on_drop: false }` [INFO] [stderr] Compiling proc-macro2 v1.0.60 [INFO] [stderr] Compiling quote v1.0.28 [INFO] [stderr] Compiling unicode-ident v1.0.9 [INFO] [stderr] Compiling libc v0.2.146 [INFO] [stderr] Compiling syn v1.0.109 [INFO] [stderr] Compiling version_check v0.9.4 [INFO] [stderr] Compiling crossbeam-utils v0.8.16 [INFO] [stderr] Compiling serde v1.0.164 [INFO] [stderr] Compiling thiserror v1.0.40 [INFO] [stderr] Checking scopeguard v1.1.0 [INFO] [stderr] Checking ucd-trie v0.1.5 [INFO] [stderr] Compiling cc v1.0.79 [INFO] [stderr] Checking hashbrown v0.12.3 [INFO] [stderr] Compiling rayon-core v1.11.0 [INFO] [stderr] Compiling memoffset v0.9.0 [INFO] [stderr] Compiling crossbeam-epoch v0.9.15 [INFO] [stderr] Compiling indexmap v1.9.3 [INFO] [stderr] Compiling serde_json v1.0.97 [INFO] [stderr] Checking os_str_bytes v6.5.1 [INFO] [stderr] Checking ryu v1.0.13 [INFO] [stderr] Checking fallible-iterator v0.2.0 [INFO] [stderr] Compiling heck v0.4.1 [INFO] [stderr] Compiling cpp_demangle v0.3.5 [INFO] [stderr] Compiling anyhow v1.0.71 [INFO] [stderr] Checking itoa v1.0.6 [INFO] [stderr] Checking strsim v0.10.0 [INFO] [stderr] Checking uuid v0.8.2 [INFO] [stderr] Checking textwrap v0.16.0 [INFO] [stderr] Checking either v1.8.1 [INFO] [stderr] Checking clap_lex v0.2.4 [INFO] [stderr] Checking plain v0.2.3 [INFO] [stderr] Checking stable_deref_trait v1.2.0 [INFO] [stderr] Compiling proc-macro-error-attr v1.0.4 [INFO] [stderr] Compiling proc-macro-error v1.0.4 [INFO] [stderr] Checking termcolor v1.2.0 [INFO] [stderr] Checking log v0.4.19 [INFO] [stderr] Checking rustc-demangle v0.1.23 [INFO] [stderr] Checking crossbeam-channel v0.5.8 [INFO] [stderr] Checking crossbeam-deque v0.8.3 [INFO] [stderr] Checking dirs-sys v0.3.7 [INFO] [stderr] Checking num_cpus v1.15.0 [INFO] [stderr] Checking atty v0.2.14 [INFO] [stderr] Checking memmap v0.7.0 [INFO] [stderr] Checking dirs v4.0.0 [INFO] [stderr] Compiling ep-capstone v0.2.0 [INFO] [stderr] Checking shellexpand v2.1.2 [INFO] [stderr] Checking gimli v0.23.0 [INFO] [stderr] Compiling syn v2.0.18 [INFO] [stderr] Checking rayon v1.7.0 [INFO] [stderr] Compiling serde_derive v1.0.164 [INFO] [stderr] Compiling thiserror-impl v1.0.40 [INFO] [stderr] Checking pest v2.6.1 [INFO] [stderr] Compiling scroll_derive v0.10.5 [INFO] [stderr] Compiling clap_derive v3.2.25 [INFO] [stderr] Checking scroll v0.10.2 [INFO] [stderr] Checking pdb v0.6.0 [INFO] [stderr] Checking goblin v0.2.3 [INFO] [stderr] Checking semver-parser v0.10.2 [INFO] [stderr] Checking clap v3.2.25 [INFO] [stderr] Checking semver v0.11.0 [INFO] [stderr] Checking cargo-platform v0.1.2 [INFO] [stderr] Checking cargo_metadata v0.12.3 [INFO] [stderr] Checking cargo-disasm v0.6.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: fields `dwarf_path`, `dsym_path`, and `pdb_path` are never read [INFO] [stdout] --> src/disasm/binary/mod.rs:694:9 [INFO] [stdout] | [INFO] [stdout] 689 | pub struct SearchOptions<'a> { [INFO] [stdout] | ------------- fields in this struct [INFO] [stdout] ... [INFO] [stdout] 694 | pub dwarf_path: Option<&'a Path>, [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 698 | pub dsym_path: Option<&'a Path>, [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 701 | pub pdb_path: Option<&'a Path>, [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `0` is never read [INFO] [stdout] --> src/disasm/anal/mod.rs:15:14 [INFO] [stdout] | [INFO] [stdout] 15 | Internal(usize), [INFO] [stdout] | -------- ^^^^^ [INFO] [stdout] | | [INFO] [stdout] | field in this variant [INFO] [stdout] | [INFO] [stdout] = note: `Jump` has derived impls for the traits `Clone` and `Debug`, but these are intentionally ignored during dead code analysis [INFO] [stdout] help: consider changing the field to be of unit type to suppress this warning while preserving the field numbering, or remove the field [INFO] [stdout] | [INFO] [stdout] 15 | Internal(()), [INFO] [stdout] | ~~ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/disasm/binary/mod.rs:58:9 [INFO] [stdout] | [INFO] [stdout] 45 | pub fn new(data: BinaryData, options: SearchOptions) -> anyhow::Result { [INFO] [stdout] | ---------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 46 | let mut binary = Binary { [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 58 | binary.parse_object(options).map(|_| { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/disasm/binary/mod.rs:58:42 [INFO] [stdout] | [INFO] [stdout] 45 | pub fn new(data: BinaryData, options: SearchOptions) -> anyhow::Result { [INFO] [stdout] | ---------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 46 | let mut binary = Binary { [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 58 | binary.parse_object(options).map(|_| { [INFO] [stdout] | __________________________________________^ [INFO] [stdout] 59 | | let symbol_sort_timer = std::time::Instant::now(); [INFO] [stdout] 60 | | binary.symbols.sort_unstable_by(|lhs, rhs| { [INFO] [stdout] 61 | | lhs.address() [INFO] [stdout] ... | [INFO] [stdout] 71 | | binary [INFO] [stdout] 72 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/disasm/binary/mod.rs:447:28 [INFO] [stdout] | [INFO] [stdout] 444 | .map(|mmap| BinaryData { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 447 | inner: Arc::new(BinaryDataInner { mmap, path }), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/disasm/binary/mod.rs:483:20 [INFO] [stdout] | [INFO] [stdout] 459 | pub fn slice(&self, range: R) -> BinaryData [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 483 | inner: self.inner.clone(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/disasm/binary/elf.rs:88:54 [INFO] [stdout] | [INFO] [stdout] 88 | let sup_loader = |_section: gimli::SectionId| Ok(EndianReader::new(data.slice(0..0), endian)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/disasm/binary/mach.rs:110:41 [INFO] [stdout] | [INFO] [stdout] 110 | |_section: gimli::SectionId| Ok(gimli::EndianReader::new(data.slice(0..0), endian)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/disasm/binary/mach.rs:173:8 [INFO] [stdout] | [INFO] [stdout] 148 | let data = BinaryData::from_path(&object_path).context("failed to load Mach-O DWARF binary")?; [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 171 | let dwarf = Box::new(DwarfInfo::new(loader, sup_loader)?); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 172 | [INFO] [stdout] 173 | Ok(Some(dwarf)) [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/disasm/binary/mach.rs:170:41 [INFO] [stdout] | [INFO] [stdout] 170 | |_section: gimli::SectionId| Ok(gimli::EndianReader::new(data.slice(0..0), endian)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/disasm/binary/mach.rs:212:5 [INFO] [stdout] | [INFO] [stdout] 207 | let entries = executable_dir.read_dir().ok().or_else(|| { [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 212 | / entries [INFO] [stdout] 213 | | .filter_map(|entry| entry.map(|e| e.path()).ok()) [INFO] [stdout] 214 | | .filter(|path| { [INFO] [stdout] 215 | | path.file_name() [INFO] [stdout] 216 | | .filter(|n| n.to_string_lossy().ends_with(".dSYM")) [INFO] [stdout] 217 | | .is_some() [INFO] [stdout] 218 | | }) [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |__________| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/disasm/binary/mach.rs:213:29 [INFO] [stdout] | [INFO] [stdout] 213 | .filter_map(|entry| entry.map(|e| e.path()).ok()) [INFO] [stdout] | ----- ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/disasm/binary/mach.rs:251:31 [INFO] [stdout] | [INFO] [stdout] 251 | .filter_map(|section| section.name().ok()) [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/disasm/binary/pe.rs:118:5 [INFO] [stdout] | [INFO] [stdout] 117 | pub fn load_pdb(pdb_data: BinaryData) -> anyhow::Result> { [INFO] [stdout] | -------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 118 | PDBInfo::new(pdb_data).map(Box::new) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/disasm/binary/pe.rs:135:41 [INFO] [stdout] | [INFO] [stdout] 135 | |_section: gimli::SectionId| Ok(gimli::EndianReader::new(data.slice(0..0), endian)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/disasm/binary/pe.rs:222:31 [INFO] [stdout] | [INFO] [stdout] 222 | .filter_map(|section| section.name().ok()) [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/disasm/symbol.rs:49:26 [INFO] [stdout] | [INFO] [stdout] 49 | .or_else(|_| CppSymbol::new(name.as_bytes()).map(|s| Cow::from(s.to_string()))) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/disasm/dwarf.rs:29:12 [INFO] [stdout] | [INFO] [stdout] 24 | pub fn new(loader: L, sup_loader: S) -> anyhow::Result [INFO] [stdout] | --------- ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 29 | Ok(DwarfInfo { [INFO] [stdout] | ____________^ [INFO] [stdout] 30 | | dwarf: gimli::Dwarf::load(loader, sup_loader)?, [INFO] [stdout] 31 | | [INFO] [stdout] 32 | | compilation_unit_ranges: Vec::new(), [INFO] [stdout] 33 | | compilation_units: Vec::new(), [INFO] [stdout] 34 | | compilation_units_initialized: false, [INFO] [stdout] 35 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: fields `dwarf_path`, `dsym_path`, and `pdb_path` are never read [INFO] [stdout] --> src/disasm/binary/mod.rs:694:9 [INFO] [stdout] | [INFO] [stdout] 689 | pub struct SearchOptions<'a> { [INFO] [stdout] | ------------- fields in this struct [INFO] [stdout] ... [INFO] [stdout] 694 | pub dwarf_path: Option<&'a Path>, [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 698 | pub dsym_path: Option<&'a Path>, [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 701 | pub pdb_path: Option<&'a Path>, [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `0` is never read [INFO] [stdout] --> src/disasm/anal/mod.rs:15:14 [INFO] [stdout] | [INFO] [stdout] 15 | Internal(usize), [INFO] [stdout] | -------- ^^^^^ [INFO] [stdout] | | [INFO] [stdout] | field in this variant [INFO] [stdout] | [INFO] [stdout] = note: `Jump` has derived impls for the traits `Clone` and `Debug`, but these are intentionally ignored during dead code analysis [INFO] [stdout] help: consider changing the field to be of unit type to suppress this warning while preserving the field numbering, or remove the field [INFO] [stdout] | [INFO] [stdout] 15 | Internal(()), [INFO] [stdout] | ~~ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/disasm/dwarf.rs:412:20 [INFO] [stdout] | [INFO] [stdout] 406 | unit: gimli::Unit, [INFO] [stdout] | ----------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 412 | lines: OnceCell::new(), [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/disasm/dwarf.rs:512:12 [INFO] [stdout] | [INFO] [stdout] 438 | let mut sequences = Vec::new(); [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 439 | let mut rows = inc_line_program.clone().rows(); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 512 | Ok(Lines { [INFO] [stdout] | ____________^ [INFO] [stdout] 513 | | sequences: sequences.into_boxed_slice(), [INFO] [stdout] 514 | | files: files.into_boxed_slice(), [INFO] [stdout] 515 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/disasm/pdb.rs:12:9 [INFO] [stdout] | [INFO] [stdout] 11 | pub fn new(data: BinaryData) -> anyhow::Result { [INFO] [stdout] | ---------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 12 | / PDB::open(data) [INFO] [stdout] 13 | | .map(PDBInfo::with_pdb) [INFO] [stdout] | |___________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/disasm/binary/mod.rs:58:9 [INFO] [stdout] | [INFO] [stdout] 45 | pub fn new(data: BinaryData, options: SearchOptions) -> anyhow::Result { [INFO] [stdout] | ---------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 46 | let mut binary = Binary { [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 58 | binary.parse_object(options).map(|_| { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/disasm/binary/mod.rs:58:42 [INFO] [stdout] | [INFO] [stdout] 45 | pub fn new(data: BinaryData, options: SearchOptions) -> anyhow::Result { [INFO] [stdout] | ---------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 46 | let mut binary = Binary { [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 58 | binary.parse_object(options).map(|_| { [INFO] [stdout] | __________________________________________^ [INFO] [stdout] 59 | | let symbol_sort_timer = std::time::Instant::now(); [INFO] [stdout] 60 | | binary.symbols.sort_unstable_by(|lhs, rhs| { [INFO] [stdout] 61 | | lhs.address() [INFO] [stdout] ... | [INFO] [stdout] 71 | | binary [INFO] [stdout] 72 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/disasm/binary/mod.rs:447:28 [INFO] [stdout] | [INFO] [stdout] 444 | .map(|mmap| BinaryData { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 447 | inner: Arc::new(BinaryDataInner { mmap, path }), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/disasm/binary/mod.rs:483:20 [INFO] [stdout] | [INFO] [stdout] 459 | pub fn slice(&self, range: R) -> BinaryData [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 483 | inner: self.inner.clone(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/disasm/binary/elf.rs:88:54 [INFO] [stdout] | [INFO] [stdout] 88 | let sup_loader = |_section: gimli::SectionId| Ok(EndianReader::new(data.slice(0..0), endian)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/disasm/binary/mach.rs:110:41 [INFO] [stdout] | [INFO] [stdout] 110 | |_section: gimli::SectionId| Ok(gimli::EndianReader::new(data.slice(0..0), endian)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/disasm/binary/mach.rs:173:8 [INFO] [stdout] | [INFO] [stdout] 148 | let data = BinaryData::from_path(&object_path).context("failed to load Mach-O DWARF binary")?; [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 171 | let dwarf = Box::new(DwarfInfo::new(loader, sup_loader)?); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 172 | [INFO] [stdout] 173 | Ok(Some(dwarf)) [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/disasm/binary/mach.rs:170:41 [INFO] [stdout] | [INFO] [stdout] 170 | |_section: gimli::SectionId| Ok(gimli::EndianReader::new(data.slice(0..0), endian)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/disasm/binary/mach.rs:212:5 [INFO] [stdout] | [INFO] [stdout] 207 | let entries = executable_dir.read_dir().ok().or_else(|| { [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 212 | / entries [INFO] [stdout] 213 | | .filter_map(|entry| entry.map(|e| e.path()).ok()) [INFO] [stdout] 214 | | .filter(|path| { [INFO] [stdout] 215 | | path.file_name() [INFO] [stdout] 216 | | .filter(|n| n.to_string_lossy().ends_with(".dSYM")) [INFO] [stdout] 217 | | .is_some() [INFO] [stdout] 218 | | }) [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |__________| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/disasm/binary/mach.rs:213:29 [INFO] [stdout] | [INFO] [stdout] 213 | .filter_map(|entry| entry.map(|e| e.path()).ok()) [INFO] [stdout] | ----- ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/disasm/binary/mach.rs:251:31 [INFO] [stdout] | [INFO] [stdout] 251 | .filter_map(|section| section.name().ok()) [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/disasm/binary/pe.rs:118:5 [INFO] [stdout] | [INFO] [stdout] 117 | pub fn load_pdb(pdb_data: BinaryData) -> anyhow::Result> { [INFO] [stdout] | -------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 118 | PDBInfo::new(pdb_data).map(Box::new) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/disasm/binary/pe.rs:135:41 [INFO] [stdout] | [INFO] [stdout] 135 | |_section: gimli::SectionId| Ok(gimli::EndianReader::new(data.slice(0..0), endian)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/disasm/binary/pe.rs:222:31 [INFO] [stdout] | [INFO] [stdout] 222 | .filter_map(|section| section.name().ok()) [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/disasm/symbol.rs:49:26 [INFO] [stdout] | [INFO] [stdout] 49 | .or_else(|_| CppSymbol::new(name.as_bytes()).map(|s| Cow::from(s.to_string()))) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/disasm/dwarf.rs:29:12 [INFO] [stdout] | [INFO] [stdout] 24 | pub fn new(loader: L, sup_loader: S) -> anyhow::Result [INFO] [stdout] | --------- ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 29 | Ok(DwarfInfo { [INFO] [stdout] | ____________^ [INFO] [stdout] 30 | | dwarf: gimli::Dwarf::load(loader, sup_loader)?, [INFO] [stdout] 31 | | [INFO] [stdout] 32 | | compilation_unit_ranges: Vec::new(), [INFO] [stdout] 33 | | compilation_units: Vec::new(), [INFO] [stdout] 34 | | compilation_units_initialized: false, [INFO] [stdout] 35 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/disasm/dwarf.rs:412:20 [INFO] [stdout] | [INFO] [stdout] 406 | unit: gimli::Unit, [INFO] [stdout] | ----------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 412 | lines: OnceCell::new(), [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/disasm/dwarf.rs:512:12 [INFO] [stdout] | [INFO] [stdout] 438 | let mut sequences = Vec::new(); [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 439 | let mut rows = inc_line_program.clone().rows(); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 512 | Ok(Lines { [INFO] [stdout] | ____________^ [INFO] [stdout] 513 | | sequences: sequences.into_boxed_slice(), [INFO] [stdout] 514 | | files: files.into_boxed_slice(), [INFO] [stdout] 515 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/disasm/pdb.rs:12:9 [INFO] [stdout] | [INFO] [stdout] 11 | pub fn new(data: BinaryData) -> anyhow::Result { [INFO] [stdout] | ---------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 12 | / PDB::open(data) [INFO] [stdout] 13 | | .map(PDBInfo::with_pdb) [INFO] [stdout] | |___________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 19 previous errors; 2 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `cargo-disasm` (bin "cargo-disasm") due to 20 previous errors; 2 warnings emitted [INFO] [stdout] error: aborting due to 19 previous errors; 2 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] error: could not compile `cargo-disasm` (bin "cargo-disasm" test) due to 20 previous errors; 2 warnings emitted [INFO] running `Command { std: "docker" "inspect" "bc7c811cddb61bf0fab1c80d50309b8a38e47599dae18fae9537f701bd600567", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "bc7c811cddb61bf0fab1c80d50309b8a38e47599dae18fae9537f701bd600567", kill_on_drop: false }` [INFO] [stdout] bc7c811cddb61bf0fab1c80d50309b8a38e47599dae18fae9537f701bd600567