[INFO] fetching crate cargo-clean-all 0.6.2... [INFO] checking cargo-clean-all-0.6.2 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate cargo-clean-all 0.6.2 into /workspace/builds/worker-2-tc2/source [INFO] validating manifest of crates.io crate cargo-clean-all 0.6.2 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate cargo-clean-all 0.6.2 [INFO] finished tweaking crates.io crate cargo-clean-all 0.6.2 [INFO] tweaked toml for crates.io crate cargo-clean-all 0.6.2 written to /workspace/builds/worker-2-tc2/source/Cargo.toml [INFO] crate crates.io crate cargo-clean-all 0.6.2 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 2e0e45e3aae894588610a195a5809eb5d3a6e366b01c4fc376dec7d06a366db0 [INFO] running `Command { std: "docker" "start" "-a" "2e0e45e3aae894588610a195a5809eb5d3a6e366b01c4fc376dec7d06a366db0", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "2e0e45e3aae894588610a195a5809eb5d3a6e366b01c4fc376dec7d06a366db0", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "2e0e45e3aae894588610a195a5809eb5d3a6e366b01c4fc376dec7d06a366db0", kill_on_drop: false }` [INFO] [stdout] 2e0e45e3aae894588610a195a5809eb5d3a6e366b01c4fc376dec7d06a366db0 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 2a7a900565304761b22e4c0666ca2c4d1d13947134ada9326880a2dc586ffb57 [INFO] running `Command { std: "docker" "start" "-a" "2a7a900565304761b22e4c0666ca2c4d1d13947134ada9326880a2dc586ffb57", kill_on_drop: false }` [INFO] [stderr] Compiling crossbeam-utils v0.8.12 [INFO] [stderr] Compiling unicode-ident v1.0.5 [INFO] [stderr] Compiling memoffset v0.6.5 [INFO] [stderr] Compiling crossbeam-epoch v0.9.11 [INFO] [stderr] Compiling rayon-core v1.9.3 [INFO] [stderr] Checking scopeguard v1.1.0 [INFO] [stderr] Compiling rustix v0.38.21 [INFO] [stderr] Compiling num-traits v0.2.15 [INFO] [stderr] Compiling rayon v1.5.3 [INFO] [stderr] Checking linux-raw-sys v0.4.10 [INFO] [stderr] Checking anstyle-parse v0.2.0 [INFO] [stderr] Checking terminal_size v0.1.17 [INFO] [stderr] Checking num_cpus v1.16.0 [INFO] [stderr] Compiling portable-atomic v1.3.2 [INFO] [stderr] Checking anstyle v1.0.0 [INFO] [stderr] Checking nix v0.26.2 [INFO] [stderr] Checking aho-corasick v0.7.19 [INFO] [stderr] Compiling proc-macro2 v1.0.69 [INFO] [stderr] Checking cvt v0.1.2 [INFO] [stderr] Checking console v0.15.2 [INFO] [stderr] Checking regex-syntax v0.6.28 [INFO] [stderr] Checking clap_lex v0.6.0 [INFO] [stderr] Checking either v1.8.0 [INFO] [stderr] Compiling heck v0.4.0 [INFO] [stderr] Checking remove_dir_all v0.5.3 [INFO] [stderr] Checking fastrand v1.8.0 [INFO] [stderr] Checking nix v0.27.1 [INFO] [stderr] Checking anstream v0.6.4 [INFO] [stderr] Checking iana-time-zone v0.1.53 [INFO] [stderr] Checking normpath v1.1.1 [INFO] [stderr] Checking zeroize v1.5.7 [INFO] [stderr] Checking shell-words v1.1.0 [INFO] [stderr] Checking is_executable v1.0.1 [INFO] [stderr] Checking tempfile v3.3.0 [INFO] [stderr] Checking clap_builder v4.4.7 [INFO] [stderr] Checking crossbeam-channel v0.5.8 [INFO] [stderr] Compiling quote v1.0.33 [INFO] [stderr] Checking fs_at v0.1.6 [INFO] [stderr] Compiling syn v2.0.38 [INFO] [stderr] Checking crossbeam-deque v0.8.2 [INFO] [stderr] Checking indicatif v0.17.7 [INFO] [stderr] Checking chrono v0.4.31 [INFO] [stderr] Checking is-terminal v0.4.9 [INFO] [stderr] Checking colored v2.0.4 [INFO] [stderr] Checking ctrlc v3.4.1 [INFO] [stderr] Checking regex v1.7.0 [INFO] [stderr] Checking bytefmt v0.1.7 [INFO] [stderr] Checking remove_dir_all v0.8.2 [INFO] [stderr] Compiling thiserror-impl v1.0.50 [INFO] [stderr] Compiling clap_derive v4.4.7 [INFO] [stderr] Checking thiserror v1.0.50 [INFO] [stderr] Checking dialoguer v0.11.0 [INFO] [stderr] Checking clap v4.4.7 [INFO] [stderr] Checking cargo-clean-all v0.6.2 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/main.rs:123:5 [INFO] [stdout] | [INFO] [stdout] 122 | fn canonicalize_or_not(p: impl AsRef) -> PathBuf { [INFO] [stdout] | ------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 123 | std::fs::canonicalize(p.as_ref()).unwrap_or_else(|_| p.as_ref().to_path_buf()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/main.rs:300:34 [INFO] [stdout] | [INFO] [stdout] 300 | .filter_map(|it| it.file_type().is_ok_and(|t| t.is_dir()).then(|| it.path())); [INFO] [stdout] | -- ^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/main.rs:315:38 [INFO] [stdout] | [INFO] [stdout] 315 | .filter_map(|it| it.file_type().is_ok_and(|t| t.is_file()).then(|| it.path())); [INFO] [stdout] | -- ^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/main.rs:434:27 [INFO] [stdout] | [INFO] [stdout] 434 | .map(|_| (job_rx.clone(), result_tx.clone())) [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/main.rs:434:43 [INFO] [stdout] | [INFO] [stdout] 434 | .map(|_| (job_rx.clone(), result_tx.clone())) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/main.rs:441:64 [INFO] [stdout] | [INFO] [stdout] 440 | job_rx.into_iter().for_each(|job| { [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 441 | find_cargo_projects_task(job, &pb, result_tx.clone(), &args) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/main.rs:489:25 [INFO] [stdout] | [INFO] [stdout] 489 | .partition(|it| it.file_type().is_ok_and(|t| t.is_dir())); [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/main.rs:555:15 [INFO] [stdout] | [INFO] [stdout] 546 | fn recursive_scan_target>(path: T) -> (u64, SystemTime) { [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 555 | match (path.is_file(), path.metadata()) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/main.rs:560:21 [INFO] [stdout] | [INFO] [stdout] 559 | .map(|rd| { [INFO] [stdout] | -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 560 | / rd.filter_map(|it| it.ok().map(|it| it.path())) [INFO] [stdout] 561 | | .map(Self::recursive_scan_target) [INFO] [stdout] | |_________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/main.rs:560:40 [INFO] [stdout] | [INFO] [stdout] 560 | rd.filter_map(|it| it.ok().map(|it| it.path())) [INFO] [stdout] | -- ^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 10 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `cargo-clean-all` (bin "cargo-clean-all") due to 11 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/main.rs:123:5 [INFO] [stdout] | [INFO] [stdout] 122 | fn canonicalize_or_not(p: impl AsRef) -> PathBuf { [INFO] [stdout] | ------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 123 | std::fs::canonicalize(p.as_ref()).unwrap_or_else(|_| p.as_ref().to_path_buf()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/main.rs:300:34 [INFO] [stdout] | [INFO] [stdout] 300 | .filter_map(|it| it.file_type().is_ok_and(|t| t.is_dir()).then(|| it.path())); [INFO] [stdout] | -- ^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/main.rs:315:38 [INFO] [stdout] | [INFO] [stdout] 315 | .filter_map(|it| it.file_type().is_ok_and(|t| t.is_file()).then(|| it.path())); [INFO] [stdout] | -- ^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/main.rs:434:27 [INFO] [stdout] | [INFO] [stdout] 434 | .map(|_| (job_rx.clone(), result_tx.clone())) [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/main.rs:434:43 [INFO] [stdout] | [INFO] [stdout] 434 | .map(|_| (job_rx.clone(), result_tx.clone())) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/main.rs:441:64 [INFO] [stdout] | [INFO] [stdout] 440 | job_rx.into_iter().for_each(|job| { [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 441 | find_cargo_projects_task(job, &pb, result_tx.clone(), &args) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/main.rs:489:25 [INFO] [stdout] | [INFO] [stdout] 489 | .partition(|it| it.file_type().is_ok_and(|t| t.is_dir())); [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/main.rs:555:15 [INFO] [stdout] | [INFO] [stdout] 546 | fn recursive_scan_target>(path: T) -> (u64, SystemTime) { [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 555 | match (path.is_file(), path.metadata()) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/main.rs:560:21 [INFO] [stdout] | [INFO] [stdout] 559 | .map(|rd| { [INFO] [stdout] | -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 560 | / rd.filter_map(|it| it.ok().map(|it| it.path())) [INFO] [stdout] 561 | | .map(Self::recursive_scan_target) [INFO] [stdout] | |_________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/main.rs:560:40 [INFO] [stdout] | [INFO] [stdout] 560 | rd.filter_map(|it| it.ok().map(|it| it.path())) [INFO] [stdout] | -- ^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 10 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `cargo-clean-all` (bin "cargo-clean-all" test) due to 11 previous errors [INFO] running `Command { std: "docker" "inspect" "2a7a900565304761b22e4c0666ca2c4d1d13947134ada9326880a2dc586ffb57", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "2a7a900565304761b22e4c0666ca2c4d1d13947134ada9326880a2dc586ffb57", kill_on_drop: false }` [INFO] [stdout] 2a7a900565304761b22e4c0666ca2c4d1d13947134ada9326880a2dc586ffb57