[INFO] fetching crate cargo-all-features 1.10.0... [INFO] checking cargo-all-features-1.10.0 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate cargo-all-features 1.10.0 into /workspace/builds/worker-0-tc2/source [INFO] validating manifest of crates.io crate cargo-all-features 1.10.0 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate cargo-all-features 1.10.0 [INFO] finished tweaking crates.io crate cargo-all-features 1.10.0 [INFO] tweaked toml for crates.io crate cargo-all-features 1.10.0 written to /workspace/builds/worker-0-tc2/source/Cargo.toml [INFO] crate crates.io crate cargo-all-features 1.10.0 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] a52379b766ca3f78c61822acd9d430473bec6e98e16a920a5f33e03864d6e126 [INFO] running `Command { std: "docker" "start" "-a" "a52379b766ca3f78c61822acd9d430473bec6e98e16a920a5f33e03864d6e126", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "a52379b766ca3f78c61822acd9d430473bec6e98e16a920a5f33e03864d6e126", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "a52379b766ca3f78c61822acd9d430473bec6e98e16a920a5f33e03864d6e126", kill_on_drop: false }` [INFO] [stdout] a52379b766ca3f78c61822acd9d430473bec6e98e16a920a5f33e03864d6e126 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] f19414073bd5f8e948520341d7ca9d7d25ecb9403f33ec0eaecbbd09995c244b [INFO] running `Command { std: "docker" "start" "-a" "f19414073bd5f8e948520341d7ca9d7d25ecb9403f33ec0eaecbbd09995c244b", kill_on_drop: false }` [INFO] [stderr] Compiling rustix v0.38.4 [INFO] [stderr] Compiling proc-macro2 v1.0.66 [INFO] [stderr] Checking linux-raw-sys v0.4.3 [INFO] [stderr] Compiling unicode-ident v1.0.11 [INFO] [stderr] Checking bitflags v2.3.3 [INFO] [stderr] Checking anstyle-parse v0.2.1 [INFO] [stderr] Checking anstyle v1.0.1 [INFO] [stderr] Checking either v1.6.1 [INFO] [stderr] Checking json v0.12.4 [INFO] [stderr] Checking termcolor v1.1.2 [INFO] [stderr] Checking itertools v0.10.1 [INFO] [stderr] Compiling quote v1.0.31 [INFO] [stderr] Compiling syn v2.0.27 [INFO] [stderr] Checking is-terminal v0.4.9 [INFO] [stderr] Checking anstream v0.3.2 [INFO] [stderr] Checking clap_builder v4.3.19 [INFO] [stderr] Compiling clap_derive v4.3.12 [INFO] [stderr] Checking clap v4.3.19 [INFO] [stderr] Checking cargo-all-features v1.10.0 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:138:8 [INFO] [stdout] | [INFO] [stdout] 136 | let metadata = cargo_metadata::fetch()?; [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 137 | [INFO] [stdout] 138 | Ok(if current_dir == metadata.workspace_root { [INFO] [stdout] | ________^ [INFO] [stdout] 139 | | metadata [INFO] [stdout] 140 | | .packages [INFO] [stdout] 141 | | .iter() [INFO] [stdout] ... | [INFO] [stdout] 151 | | .to_owned()] [INFO] [stdout] 152 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/cargo_metadata.rs:9:8 [INFO] [stdout] | [INFO] [stdout] 8 | let json = json::parse(&json)?; [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 9 | Ok(Metadata::try_from(json)?) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/cargo_metadata.rs:185:12 [INFO] [stdout] | [INFO] [stdout] 66 | fn try_from(json_value: json::JsonValue) -> Result { [INFO] [stdout] | --------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 116 | let denylist: HashSet<_> = json_value["metadata"]["cargo-all-features"]["denylist"] [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 185 | Ok(Package { [INFO] [stdout] | ____________^ [INFO] [stdout] 186 | | id, [INFO] [stdout] 187 | | name, [INFO] [stdout] 188 | | manifest_path, [INFO] [stdout] ... | [INFO] [stdout] 198 | | max_combination_size, [INFO] [stdout] 199 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/cargo_metadata.rs:73:44 [INFO] [stdout] | [INFO] [stdout] 73 | .map(|member| Dependency::from(member.to_owned())) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/cargo_metadata.rs:226:12 [INFO] [stdout] | [INFO] [stdout] 212 | fn try_from(json_value: json::JsonValue) -> Result { [INFO] [stdout] | --------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 221 | let packages = json_value["packages"] [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 226 | Ok(Metadata { [INFO] [stdout] | ____________^ [INFO] [stdout] 227 | | workspace_root, [INFO] [stdout] 228 | | workspace_members, [INFO] [stdout] 229 | | packages, [INFO] [stdout] 230 | | }) [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/cargo_metadata.rs:223:45 [INFO] [stdout] | [INFO] [stdout] 223 | .map(|member| Package::try_from(member.to_owned())) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/types.rs:19:21 [INFO] [stdout] | [INFO] [stdout] 18 | fn from_iter>(iter: T) -> Self { [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 19 | FeatureList(iter.into_iter().collect()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 7 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `cargo-all-features` (lib test) due to 8 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:138:8 [INFO] [stdout] | [INFO] [stdout] 136 | let metadata = cargo_metadata::fetch()?; [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 137 | [INFO] [stdout] 138 | Ok(if current_dir == metadata.workspace_root { [INFO] [stdout] | ________^ [INFO] [stdout] 139 | | metadata [INFO] [stdout] 140 | | .packages [INFO] [stdout] 141 | | .iter() [INFO] [stdout] ... | [INFO] [stdout] 151 | | .to_owned()] [INFO] [stdout] 152 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/cargo_metadata.rs:9:8 [INFO] [stdout] | [INFO] [stdout] 8 | let json = json::parse(&json)?; [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 9 | Ok(Metadata::try_from(json)?) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/cargo_metadata.rs:185:12 [INFO] [stdout] | [INFO] [stdout] 66 | fn try_from(json_value: json::JsonValue) -> Result { [INFO] [stdout] | --------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 116 | let denylist: HashSet<_> = json_value["metadata"]["cargo-all-features"]["denylist"] [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 185 | Ok(Package { [INFO] [stdout] | ____________^ [INFO] [stdout] 186 | | id, [INFO] [stdout] 187 | | name, [INFO] [stdout] 188 | | manifest_path, [INFO] [stdout] ... | [INFO] [stdout] 198 | | max_combination_size, [INFO] [stdout] 199 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/cargo_metadata.rs:73:44 [INFO] [stdout] | [INFO] [stdout] 73 | .map(|member| Dependency::from(member.to_owned())) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/cargo_metadata.rs:226:12 [INFO] [stdout] | [INFO] [stdout] 212 | fn try_from(json_value: json::JsonValue) -> Result { [INFO] [stdout] | --------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 221 | let packages = json_value["packages"] [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 226 | Ok(Metadata { [INFO] [stdout] | ____________^ [INFO] [stdout] 227 | | workspace_root, [INFO] [stdout] 228 | | workspace_members, [INFO] [stdout] 229 | | packages, [INFO] [stdout] 230 | | }) [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/cargo_metadata.rs:223:45 [INFO] [stdout] | [INFO] [stdout] 223 | .map(|member| Package::try_from(member.to_owned())) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/types.rs:19:21 [INFO] [stdout] | [INFO] [stdout] 18 | fn from_iter>(iter: T) -> Self { [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 19 | FeatureList(iter.into_iter().collect()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 7 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `cargo-all-features` (lib) due to 8 previous errors [INFO] running `Command { std: "docker" "inspect" "f19414073bd5f8e948520341d7ca9d7d25ecb9403f33ec0eaecbbd09995c244b", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "f19414073bd5f8e948520341d7ca9d7d25ecb9403f33ec0eaecbbd09995c244b", kill_on_drop: false }` [INFO] [stdout] f19414073bd5f8e948520341d7ca9d7d25ecb9403f33ec0eaecbbd09995c244b